From nobody Mon Dec 1 22:35:40 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4359B11CA0 for ; Wed, 26 Nov 2025 14:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764165715; cv=none; b=PjIXTl1fDK13eRJQvtFjZr/KsATH52K7Erqu5qLthcRDxWrZPLo2uvNId8s3I/ONniBTm6N5o0ZrlPrORVL9nCtPPRWRXPXEtEYYysSLtrC+2tPzeJefRFKEg9etCXlnX5aJkxQ8mE3+Q20+Q1AihuArsbQSb+SPxdU2CE8TF54= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764165715; c=relaxed/simple; bh=/N1yQaP0StdUG0iTdpvPhiNr39u+E8m0LrixdASsDiY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kEMCDqxa5B4Qql8sJDiPNCFboOmPBA6Q1kfz6K0p4OToIt3XVBlp7sKHTOdhnCe0uxgDvc1g6P8Hn31vgcTrOg+Cq5NJLxaMwGhiQCo8plKk9qj9215EkqySVkzK37Sb3XryVZlKWQdKjgl4lMX02UyQLGs85ABqXJY4FZJcLaY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VJOpe7nU; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VJOpe7nU" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4775ae5684fso32688555e9.1 for ; Wed, 26 Nov 2025 06:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764165713; x=1764770513; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BWI068vPYLSXZ5RCwTG2CH0PZ4pNstxIHxCa8vD/TIk=; b=VJOpe7nUeWHWEFRlhUfUJeDIV9ecyW/OJFr8plx5WnorA1Z+RJnETHNJMGnuTpfJLg Lm702rN8m13p8XZqMM/AypQ3P76o+tKCqpc8nWJYm1EgGutuNvWVk+uuPj+o6mQc9fPx GeC8VlwJoc5ieDZe2XRg38plou7KKTkBXv/j/NOPSorA1uO2qASm8jHbVyWl3b+l6KFm rKf6kgkjkfjOWFfiU3PTQDQad6ia7Aq1KQdPLJwWAisUhQ8No6k70UsKu+pt5RgsBOjY dIijn2CL1sKkLwVGYzG/zb5FDPgX53ORXVpvO8fCq/qdJ5QAVluqU5CYRbd4H8E5Uzq3 eurA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764165713; x=1764770513; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BWI068vPYLSXZ5RCwTG2CH0PZ4pNstxIHxCa8vD/TIk=; b=HvrxvRlHio7kFeSxyUs2KnwRXDa3UmXIzjWsvqkyOXTDKwZxs+diOsv3vvFlU7ivKn 1kRYdPPTq3ccXh0WRF8b648VD4DRV8eDou176CtN/BMmWavwg39+ioDfdi/wD3dnpXHD 04QQXamHQuHArmobfRiL7Y3tOnC1pCKKmY2OTC1t1Z4LmMHh+KQZbQSs3x1MX7if6gl7 I5hqzjUgcpojTKuQUAipdqw9Qog82wmQEnQ5rYqzo/bRqiRxxNb4VDvOyIMmWvMgzd63 m0zKHBqb14sLG9qERfAiSXcD6tJ6SsO3d19eDHMJZ+RnSHzz2wno3XkUmKRy/luEPH+O Q/LQ== X-Forwarded-Encrypted: i=1; AJvYcCU1IoVFQ/Eyii91QFVXBjJyLd95VcPReckBqDcfGZMkDyCYNMS0IJglkM3ejjAYGUzAGsSFUL78Cb5/eSA=@vger.kernel.org X-Gm-Message-State: AOJu0Yza5clR60GDnZqAP7hbpYcrhCBxHfhcIxzlKvTvrOXrl9zEUhKk B3P7DmDYIyXlASHMAXqS9bDkQtKcxUducgAB+HKgKFTtY2VLhvYW3F6T X-Gm-Gg: ASbGncvtRmoGk1UPm4otFpY7Gg5r0XEbeyBCcRk4fhyCrMsPT5l7L7TGLR4iJIrD9Aj NFzGde/LuAlds2llncXtzvpiStZVpqIyiszVkHnnJG4XgHS06/iVAbtPNBoN3+fAqLo3LlYxauy KrOIV0eVSer+2+BfLIEV0OCnfn4RbxWU8PCgXvsiylSuTFCEL0vxmA3q6wqtzB++XMrYPZSKSs8 RdrqhUxaPJL+wcLtmIbyAf5k6PPAW6pH9hPfVvmYFQCjBHWy00UhnNaQE4kRjX/pneBZWQnP/up cvTLVWeABF/cb/AYUFtoQhJSsEq5CcEdyeowMWgL7OZODqTg4eaPkRrKqSSwCV9bf5KJFKoRC+T M1NOPAKJuBvV6zuv4zjDUIyIOQ5r4Y5QZIAbL4OUuzNunf/6bJoNV7i2Ap2cIKs+9ILdedrFdd9 dcD2S6KhtUuZliQhLRQl5dT99nBt78ntf7JmVCRaTuSNFtnhusfYI0paynabXNtVhkoY02zT2d6 Lovz9XQuAdUhQ7+xOnGclo= X-Google-Smtp-Source: AGHT+IFzSn+vJCoVouAYGcpvzgFcmoMn1o28RCuRXQI35098v7LfOQ48EpWiC41admPbMKt9BZI5yQ== X-Received: by 2002:a05:600c:8b16:b0:475:dd8d:2f52 with SMTP id 5b1f17b1804b1-477c115dc85mr167384395e9.32.1764165712461; Wed, 26 Nov 2025 06:01:52 -0800 (PST) Received: from franzs-nb.corp.toradex.com (248.201.173.83.static.wline.lns.sme.cust.swisscom.ch. [83.173.201.248]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4790add608bsm46720265e9.5.2025.11.26.06.01.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 06:01:51 -0800 (PST) From: Franz Schnyder To: Vinod Koul , Kishon Vijay Abraham I , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: Franz Schnyder , linux-phy@lists.infradead.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Francesco Dolcini , Neil Armstrong , stable@vger.kernel.org, Xu Yang Subject: [PATCH v2] phy: fsl-imx8mq-usb: fix typec orientation switch when built as module Date: Wed, 26 Nov 2025 15:01:33 +0100 Message-ID: <20251126140136.1202241-1-fra.schnyder@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Franz Schnyder Currently, the PHY only registers the typec orientation switch when it is built in. If the typec driver is built as a module, the switch registration is skipped due to the preprocessor condition, causing orientation detection to fail. With commit 45fe729be9a6 ("usb: typec: Stub out typec_switch APIs when CONFIG_TYPEC=3Dn= ") the preprocessor condition is not needed anymore and the orientation switch is correctly registered for both built-in and module builds. Fixes: b58f0f86fd61 ("phy: fsl-imx8mq-usb: add tca function driver for imx9= 5") Cc: stable@vger.kernel.org Suggested-by: Xu Yang Signed-off-by: Franz Schnyder Reviewed-by: Frank Li Reviewed-by: Xu Yang --- v2: Drop the preprocessor condition after a better suggestion. Reviewed-by Neil tag not added as patch is different --- drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/frees= cale/phy-fsl-imx8mq-usb.c index b94f242420fc..72e8aff38b92 100644 --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c @@ -124,8 +124,6 @@ struct imx8mq_usb_phy { static void tca_blk_orientation_set(struct tca_blk *tca, enum typec_orientation orientation); =20 -#ifdef CONFIG_TYPEC - static int tca_blk_typec_switch_set(struct typec_switch_dev *sw, enum typec_orientation orientation) { @@ -173,18 +171,6 @@ static void tca_blk_put_typec_switch(struct typec_swit= ch_dev *sw) typec_switch_unregister(sw); } =20 -#else - -static struct typec_switch_dev *tca_blk_get_typec_switch(struct platform_d= evice *pdev, - struct imx8mq_usb_phy *imx_phy) -{ - return NULL; -} - -static void tca_blk_put_typec_switch(struct typec_switch_dev *sw) {} - -#endif /* CONFIG_TYPEC */ - static void tca_blk_orientation_set(struct tca_blk *tca, enum typec_orientation orientation) { --=20 2.43.0