From nobody Mon Dec 1 23:32:11 2025 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71A4C328B54 for ; Wed, 26 Nov 2025 12:43:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764160988; cv=none; b=NCvKpkAsYjhI3HeZzL4LCxUXT8lu6ujWY8VWMOlczeMkc1tfsE3BV2FvcsJx5cDS0r7Y3X4F67av+pskPwZig5o/3u3MY+rZJ7rlMnaKEUqVnUDSRF0OgXL9h9NR14xzy/lEsi7ZnRSHPOclWZUgBDjpHrqjYK5Ag5PyADH0xO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764160988; c=relaxed/simple; bh=x0VpZkifpmsZOeiUeKRVj5l01SHfLNEX+dBjXy+hSXo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qBpLuzp0mXjtrlJuBrP+XdncShooejlTTv2cTleXLhQ+kylEzMli8Moo4K88UuKlkqjOD9GnQt5ffDT1v2fBZwaZyfvx8nVmN5G7P+k5WW9ZLsQN9Xn6U/heVwKUHMMAgan7Of0yYGuz2a15MpmuAfFDAx6dN3UvDtm/C4NLk5c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hf4uB24V; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hf4uB24V" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b7355f6ef12so1377332866b.3 for ; Wed, 26 Nov 2025 04:43:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764160983; x=1764765783; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=URd/ONh2/S9cNJVZREq3Fly7rFEXScu5qM+CsEx4Im0=; b=hf4uB24VArUTx18oPYbedCvuxJBw5lkEjbAI81DZzOWrBeJU5NIdMVbNciXlyTFUZB XhrSl93nHa5yWnVt/edfNbG46Px6whbodEX54fz+dPywT5MJ33p9nKevCnzxrneWbqFL 6WfW/g85DiI1RZs6oB6ph63soGhjTeUO8ihxwiRt7Antq1MO+C5gKL7USqFvQuYO0CHZ 4r3Uyrv2zVVBh7vSkNfNtN9g82a/Ha4aF8855IP04kE7SLQphl2zV0FQitdvlU9FMm7V er8xnRWiIcqW/7Bc841g8j+HDS+ZGnIOrfhTwmGUfcWGebP7uz2Uogy2CSy6Mz3LORS4 +q/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764160983; x=1764765783; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=URd/ONh2/S9cNJVZREq3Fly7rFEXScu5qM+CsEx4Im0=; b=k6Ocs0wtvAjRmMgwUMyjhJx6I50uWqltZHSLD/7HNkRejqprVZo74BAVUJcrVyh8UF XQBzrQslBNHIkngUL8EAlObyaXQ2Esc7nPZSyVmOUScG5vCF8OBDIwo6GdH3NwGWFu3S t5hA6V/dI8+2q4fUl2n7sImDf0Kt8mhn3azxdRxc0Hw/UUyAwc9kpuY8NwPKKWKdnAEl fwq4025bLN2ei40RcB0N6PSU/iYHrQOIZATu7uYWAeoIBvAq3GVZ0POXPDX6gf7XEzwv zMAIXpm2NiQtyFWP6tl7mMXSPXJIJkxrGUZWgj1Z/EPNqV/BFvgSOlxeYqMxK6UNiYIw k5Eg== X-Forwarded-Encrypted: i=1; AJvYcCUgR2eUyl4/JOJBOvwWndpjUr8698DMUSGIEjaT8MnUFe4D3/5rXFAhytjz8j1DIgiVXz9DhOwlteQ4C5w=@vger.kernel.org X-Gm-Message-State: AOJu0YxOhTkVjlxaTogtvm34UzpIf06imVftI7QsLjO1xb6SdiyI6HnB Pi6TqXq6+s2qnA/DywbUkN6eZZCtx260riPw6LTKQgFNfrGjnSZcYn/m X-Gm-Gg: ASbGncujeMy0hWDPjK7KS1eWtVCxtOPutVLax/QEARvPdWu5dZRVhZ598ftiuzu0oQR EpS2YW1PsaIMUgEior05hJCAWja91U96zf7N9zOKjMkk0sguRdzuXM/pju7hw1jFEUFC+Ig5C/+ R2jtyzLc4Cna5jx7hYaCM10MKl1YmaUSnaAJYB6ujAj8nfMqQw6ZW23nbAKYSkugPCNbwovf+Ok D98Bk8pfCWedAit67whDf8BDFpIAGhfhVoTdTxl5X2U9ilBMLb93sznFoNWDQ9NFP1wc+SvVa6m w4+iXNtHmUDcKY7zIn2LNIw6YyOpQqe8MKyf++jxqR1VbWQyAnS0QhB2l/DTPGk8D03JJtAowxD uqRNtId82Sj5Xcr5DDlcMrdx1mP++BBZyhy/pU+mVtdMhun9CfGDXVUd3BF3cRm7oB9j/VubCoz Hze/jLouJYSajYt93MG+Jes4XNKvSsvGTVNsUY8fTTOAx5BhY= X-Google-Smtp-Source: AGHT+IFZ3jJn6ZtuPHP8d1zHAviRf2Hf5JxHWcSBJlcuwsyLTvUvL+Ag9uQmMJeg0bd+BjS0LWB2ew== X-Received: by 2002:a17:907:a893:b0:b76:3548:cdef with SMTP id a640c23a62f3a-b76715af3bbmr2271548866b.25.1764160982366; Wed, 26 Nov 2025 04:43:02 -0800 (PST) Received: from SMW024614.wbi.nxp.com ([128.77.115.157]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64536459d92sm17654824a12.31.2025.11.26.04.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 04:43:02 -0800 (PST) From: Laurentiu Mihalcea To: Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team Subject: [PATCH v6 1/5] reset: imx8mp-audiomix: Drop unneeded macros Date: Wed, 26 Nov 2025 04:42:14 -0800 Message-ID: <20251126124218.803-2-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251126124218.803-1-laurentiumihalcea111@gmail.com> References: <20251126124218.803-1-laurentiumihalcea111@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Laurentiu Mihalcea The macros defining the mask values for the EARC, EARC PHY resets, and the DSP RUN_STALL signal can be dropped as they are not and will not be used anywhere else except to set the value of the "mask" field from "struct imx8mp_reset_map". In this particular case, based on the name of the "mask" field, you can already deduce what these values are for, which is why defining macros for them doesn't offer any new information, nor does it help with the code readability. Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Reviewed-by: Philipp Zabel Signed-off-by: Laurentiu Mihalcea --- drivers/reset/reset-imx8mp-audiomix.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-im= x8mp-audiomix.c index eceb37ff5dc5..acfa92b15329 100644 --- a/drivers/reset/reset-imx8mp-audiomix.c +++ b/drivers/reset/reset-imx8mp-audiomix.c @@ -6,6 +6,7 @@ #include =20 #include +#include #include #include #include @@ -14,11 +15,7 @@ #include =20 #define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET 0x200 -#define IMX8MP_AUDIOMIX_EARC_RESET_MASK BIT(0) -#define IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK BIT(1) - #define IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET 0x108 -#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK BIT(5) =20 struct imx8mp_reset_map { unsigned int offset; @@ -29,17 +26,17 @@ struct imx8mp_reset_map { static const struct imx8mp_reset_map reset_map[] =3D { [IMX8MP_AUDIOMIX_EARC_RESET] =3D { .offset =3D IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, - .mask =3D IMX8MP_AUDIOMIX_EARC_RESET_MASK, + .mask =3D BIT(0), .active_low =3D true, }, [IMX8MP_AUDIOMIX_EARC_PHY_RESET] =3D { .offset =3D IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, - .mask =3D IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK, + .mask =3D BIT(1), .active_low =3D true, }, [IMX8MP_AUDIOMIX_DSP_RUNSTALL] =3D { .offset =3D IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET, - .mask =3D IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK, + .mask =3D BIT(5), .active_low =3D false, }, }; --=20 2.43.0