From nobody Mon Dec 1 23:33:22 2025 Received: from zg8tmja2lje4os4yms4ymjma.icoremail.net (zg8tmja2lje4os4yms4ymjma.icoremail.net [206.189.21.223]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1835B30DD3F for ; Wed, 26 Nov 2025 03:40:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.21.223 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764128432; cv=none; b=jDwg32L8Cxi/O0AHk1H45V0djLl+QG2liqyGFf5ISeB7qZukBOu50kCFt1dSnhRPAsY8ynPxSXsMQxvcseHay711xPaUNsyJsuSHnCwupbDQvnhXYjEWr+80ABkgHjpytlWpgUTRKSpEgOxEcDvu+tfcVVfN/rH97AG/w++zBAE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764128432; c=relaxed/simple; bh=eO+/pRsiIyMggKULQ3OLvRr6dXc2hBN8SftnMWhJLtY=; h=Date:From:To:Cc:Subject:Mime-Version:Message-ID:Content-Type; b=RVhYwR42rQcReDCrfJAacg5OkRsR30F6mPQKWqce4Bdd2KEuz7OC8zPfzxX510vPWtpts1rz7PI/72M5qBdyzk6pOTMFxy1/sCNGXWs3suBIJDHRYv+7bHx/G8zK1xR/ZudCvbJuq/816ai/H5aRfA/CQN4OLZT/wEIAhocp5c0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=eswincomputing.com; spf=pass smtp.mailfrom=eswincomputing.com; arc=none smtp.client-ip=206.189.21.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=eswincomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=eswincomputing.com Received: from E0001865LT (unknown [10.64.96.87]) by app2 (Coremail) with SMTP id TQJkCgB3u66gdiZpj3Z+AA--.7816S2; Wed, 26 Nov 2025 11:40:16 +0800 (CST) Date: Wed, 26 Nov 2025 11:40:16 +0800 From: "zhangdongchuan@eswincomputing.com" To: mst , jasowang , xuanzhuo , eperezma Cc: virtualization , linux-kernel , zhangdongchuan Subject: [PATCH] virtio_ring: code cleanup in detach_buf_split X-Priority: 3 X-GUID: DEF252B6-7D74-46CB-8B1F-A9A1F987F6AA X-Has-Attach: no X-Mailer: Foxmail 7.2.25.306[cn] Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Message-ID: <202511261140162936986@eswincomputing.com> Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: TQJkCgB3u66gdiZpj3Z+AA--.7816S2 X-Coremail-Antispam: 1UD129KBjvJXoWrKFWDGr4fAF4kKry5CFWUXFb_yoW8JF13pr 4jkry5Kw15C3srKa98CF4jqr1Y9a93K34I9Fy7W347Krn8ZF1UtFy8Cay8KF1UCry7Zr10 yF4Fqa43G34qvFJanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBv14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFcxC0VAYjxAxZF0E w4CEw7xC0wCY1x0262kKe7AKxVWUtVW8ZwCY02Avz4vE-syl42xK82IYc2Ij64vIr41l4I 8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AK xVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcV AFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8I cIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r 4j6r4UJwCE64xvF2IEb7IF0Fy7YxBIdaVFxhVjvjDU0xZFpf9x0JUAGYJUUUUU= X-CM-SenderInfo: x2kd0w5grqwuhkxd0qphvzx0xfrp13pwlqwhhfrp/ Content-Type: text/plain; charset="utf-8" Since the return value of vring_unmap_one_split() is exactly vq->split.desc_extra[i].next, 'i =3D vq->split.desc_extra[i].next' is redundant. Assign vring_unmap_one_split() to i instead. Since vq->split.desc_extra is assigned to extra, use extra[i].next instead of vq->split.desc_extra[i].next to improve readability. No change in functionality. Signed-off-by: zhangdongchuan Acked-by: Jason Wang --- drivers/virtio/virtio_ring.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 7b6205253b46..0cbf3419a645 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -764,13 +764,12 @@ static void detach_buf_split(struct vring_virtqueue *= vq, unsigned int head, i =3D head; =20 while (vq->split.vring.desc[i].flags & nextflag) { - vring_unmap_one_split(vq, &extra[i]); - i =3D vq->split.desc_extra[i].next; + i =3D vring_unmap_one_split(vq, &extra[i]); vq->vq.num_free++; } =20 vring_unmap_one_split(vq, &extra[i]); - vq->split.desc_extra[i].next =3D vq->free_head; + extra[i].next =3D vq->free_head; vq->free_head =3D head; =20 /* Plus final descriptor */ --=20 2.34.1