From nobody Tue Dec 2 00:01:06 2025 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADDB8322C99 for ; Wed, 26 Nov 2025 08:51:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764147064; cv=none; b=j7pxwbBr3J6RqK+ideCzIcLV8MTIbm/h/zCCjyQcfnrONz2mYuDw/ZBxdL+ekhfv5Nv7wk1bkIJ0HHQYFw5zFQ4iM7rGxK95Huu5k3rfmPwnkfjPAZ6hJC0b0/a+iuhY1tkGT3WXIK048e+MQDHGNHxEbNdHe4IGFe/I+OMjNOM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764147064; c=relaxed/simple; bh=n+zH9plFFMUYGIEcY3wzYO3Lyz+b74AkBCCdAEyYNdU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BXvW3bdC4dBOiGR81k2SR9KN/uxUnS+mbcxtt4vJIsagoN85k23euJxwEJXoAVpL7KxpMlSlU/hLP3QWS9ZVgvRTizHa3yexf1QLk3BWM4xXBc9JK5+2No4Wh1jHJ6186KvQLr5dli5/4so+7FOe6t1L/KpZj+qYv+zYk5OJX4o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W40X1mE1; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W40X1mE1" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7baf61be569so7853126b3a.3 for ; Wed, 26 Nov 2025 00:51:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764147062; x=1764751862; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FhW1CqQDAMm+jon2EpWEcUDvYwGJtYovETBfwMR4CKg=; b=W40X1mE1wHj00OK86wwq/JvcjMFvIb9GrNK94IItOm6DanbO/vl8X78KBNuGlgrkKv h2uGDVem9XuxbPtfuRY03Nsf08BLxdg/H+6CIIgNDLXSKW4aUGsKiXbwGJTPiPtj1KnU VfAZv6i2hECQTrPG8E/dY2Fi8mME1iFhIMWrQdV+lbEYYQQX/rtZKKW4whm2EYI7Pf3w 4PgICSJz0wbijVy9SNOBIaiJVjpc//7Dxqmfa/XSatWj8QSvUygUcd5NeECbgKmf/nic 7CAP+1ee+V0YiS4pKMFzztM+y02DK6XRV1K1NofzoGEZAVTBNHNZN7ldpBZgUIMgXNal TH4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764147062; x=1764751862; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FhW1CqQDAMm+jon2EpWEcUDvYwGJtYovETBfwMR4CKg=; b=T+3xGZV2Hsy5ac1R5M+Jjl5EGDPFrKZQIJYL60gjbAXgK14ffhw2gfDrGIgGx5COwi qzzQwqsgrLE3xs7hDUr1zS1deVxTiH4m91dAGwVd+LAY2wf/8lOUZKzAlT+3OoNSTnoh 9zC7JWpncFOleCG2a71HBvUqoTZ0xv+ooJHe9dnWp2ykjXRCglmXOWiJHoXsPR0U8yNi 1quSNpBH4iKnmi0frnMYyx0whRyRUlVd5kxXutaRivQWF7xUxBPsLMOIqavEiAlxAykG FVlZnFxAwnAu4bDDJ9GxG19F7ogx8NcDJ2wrEgOw8b+zoGaQZbWw0yz+T+9touftG+fN jZsQ== X-Forwarded-Encrypted: i=1; AJvYcCUYo3XFi4ZvuWCoevqiSAmCXRAM0GMx23LXbTvSpI1xuHYZzJt048ERmTInwhOPy5oFa9mc/7xUKYeCojg=@vger.kernel.org X-Gm-Message-State: AOJu0YxSWr4xnFwrSotOVsHMSKJdD5Hta0DxsPKtXw//s7spZw5UhTKj syDAlLPOJnFVH+USHwd258LW/z4WPIodSRM2qOv6XthcwBNhF29Cth4Vp/XCK5Sa0FA= X-Gm-Gg: ASbGnct8albME14UMmC/ZtWYhRYbhyTVByvSZ00bvrVN5mz0vR1ILGNHZvzPw/l8l5t 2IjaSq8wuM5LojL8jPzuvv7U7PH0dSsOa42RoBVVH0bhzSNY6VEHAHYICVWgdPSbNAizLwjELoe AmS9+yBj8gejKfr7GpXNn60T9ROQMe+gtaHxgYIUpHyYjcWako+kc+aRI+xR2ErsfMLYJZtUzXN z++X91//n8+vTljOuqP0Iyv7QpmbJZi9nmrqfKrCzTCD8rKXYhwCbzQ0gfzsuMnVLjEryvq6tW5 akVS1ekDdibSH0dAiAwMAxQqmKGOXM1B6yuQiIW+Q0bxiuDII60ZQICjTdN6tWQooADRBjPU2PL Q1+yryW2/6SBX0AnAP162gYgwvpU6gpy0MjYWHa5TsU+aXOnzaOZOMM4QzwV97GdnBbKq7yrZsb TV3nE0piN8RV0NhlrDTMFDilMzKI8= X-Google-Smtp-Source: AGHT+IEgDYcBhYjre0eraoB995A3V+FOhafJa61gSS23jqt0ReQdbQw0qAwBnAgVbqm2O94A3uyrCA== X-Received: by 2002:a05:6a00:1793:b0:7ab:78be:3212 with SMTP id d2e1a72fcca58-7c58e0170admr17529785b3a.19.1764147062054; Wed, 26 Nov 2025 00:51:02 -0800 (PST) Received: from pengdl-pc.mioffice.cn ([43.224.245.249]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f023fd82sm20885721b3a.42.2025.11.26.00.50.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 00:51:01 -0800 (PST) From: Donglin Peng To: ast@kernel.org, andrii.nakryiko@gmail.com Cc: eddyz87@gmail.com, zhangxiaoqin@xiaomi.com, ihor.solodrai@linux.dev, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, pengdonglin , Alan Maguire Subject: [RFC bpf-next v8 9/9] bpf: Optimize the performance of find_bpffs_btf_enums Date: Wed, 26 Nov 2025 16:50:25 +0800 Message-Id: <20251126085025.784288-10-dolinux.peng@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251126085025.784288-1-dolinux.peng@gmail.com> References: <20251126085025.784288-1-dolinux.peng@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: pengdonglin Currently, vmlinux BTF is unconditionally sorted during the build phase. The function btf_find_by_name_kind executes the binary search branch, so find_bpffs_btf_enums can be optimized by using btf_find_by_name_kind. Cc: Eduard Zingerman Cc: Alexei Starovoitov Cc: Andrii Nakryiko Cc: Alan Maguire Cc: Ihor Solodrai Cc: Xiaoqin Zhang Signed-off-by: pengdonglin --- kernel/bpf/inode.c | 42 +++++++++++++++++++----------------------- 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/kernel/bpf/inode.c b/kernel/bpf/inode.c index 81780bcf8d25..781c2c3181a4 100644 --- a/kernel/bpf/inode.c +++ b/kernel/bpf/inode.c @@ -605,10 +605,18 @@ struct bpffs_btf_enums { =20 static int find_bpffs_btf_enums(struct bpffs_btf_enums *info) { + struct { + const struct btf_type **type; + const char *name; + } btf_enums[] =3D { + {&info->cmd_t, "bpf_cmd"}, + {&info->map_t, "bpf_map_type"}, + {&info->prog_t, "bpf_prog_type"}, + {&info->attach_t, "bpf_attach_type"}, + }; const struct btf *btf; const struct btf_type *t; - const char *name; - int i, n; + int i, id; =20 memset(info, 0, sizeof(*info)); =20 @@ -620,30 +628,18 @@ static int find_bpffs_btf_enums(struct bpffs_btf_enum= s *info) =20 info->btf =3D btf; =20 - for (i =3D 1, n =3D btf_nr_types(btf); i < n; i++) { - t =3D btf_type_by_id(btf, i); - if (!btf_type_is_enum(t)) - continue; + for (i =3D 0; i < ARRAY_SIZE(btf_enums); i++) { + id =3D btf_find_by_name_kind(btf, btf_enums[i].name, + BTF_KIND_ENUM); + if (id < 0) + goto out; =20 - name =3D btf_name_by_offset(btf, t->name_off); - if (!name) - continue; - - if (strcmp(name, "bpf_cmd") =3D=3D 0) - info->cmd_t =3D t; - else if (strcmp(name, "bpf_map_type") =3D=3D 0) - info->map_t =3D t; - else if (strcmp(name, "bpf_prog_type") =3D=3D 0) - info->prog_t =3D t; - else if (strcmp(name, "bpf_attach_type") =3D=3D 0) - info->attach_t =3D t; - else - continue; - - if (info->cmd_t && info->map_t && info->prog_t && info->attach_t) - return 0; + t =3D btf_type_by_id(btf, id); + *btf_enums[i].type =3D t; } =20 + return 0; +out: return -ESRCH; } =20 --=20 2.34.1