From nobody Tue Dec 2 00:03:21 2025 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71A1731A555 for ; Wed, 26 Nov 2025 08:41:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764146487; cv=none; b=h8frDPL70Tg1hPkY4hOnEaBgMjqABNotVwgKavYoM9WkmbCUTd8IUBZt/Uxu2hBeFo6FIuv/YII+Lw0bCaG/yyALExUalAz+tnoxJh/zQiCblUw+vm87IN/JqYHnjDm8CjyjIXsPTIrI2jvJOwB4NCXX/L/KP9942qqBLyPgMhs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764146487; c=relaxed/simple; bh=GMqvMppgg9+kh8EZJaPvH4xH3QOVzWZS8jhDW4n9Qjk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RN9+ms0B7ZSibS8ocCrqsMwvlbkUsv222JEqH4WnHNoJasInPbEcHXDYfjQugvteoZ35ZlfegC533pBrBEXsO+u06ClzNZ7z7h7lf660h2nk1yac6cKIuPRaefq7rGM0o4EXKvNEa7gKJa+9aoCXehWxzghHT6xyYzBoZVnKPsQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f0QJgryF; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f0QJgryF" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7aa2170adf9so5574433b3a.0 for ; Wed, 26 Nov 2025 00:41:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764146486; x=1764751286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5jVEFoefhamhUSCRXilkvRs0+/dJxtk9IdYrSyATDdg=; b=f0QJgryF+Rv9OPfmWd64T+cwYvfWEHtDdrh92OQWhAQznc8884BKoE72xQyBTDdxrn b+jPh7drMYqSWUH2G759Y+cHEfBnw6R4MJ2QAnNuBLVwRyTxO9ycSle3UaVVNcGCcjZo lkD1iatAshnCcl740//M3scf4Aw8l7tfQARnuuELLirw89g//co1YoumUKRUQbLDql5l +CyhlnCuPY/BIFkKlSSDlmR70Of18hrROmX17mzcvRKQkOqOOxNodXzXQYYrgaZaEnCP GrVdq3+p7uD4XYs0svjpLiJmLMwqNuuDXLBIK9s0W5d6cI5EV4CZVof7HkrBmnTpz1A7 6j0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764146486; x=1764751286; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5jVEFoefhamhUSCRXilkvRs0+/dJxtk9IdYrSyATDdg=; b=Ge0R7WlUU2LIAHZzkInN81wZr1uDkSOsg0yMmIUM2TAAdMipcVa1VOEelgPCiOEtIV 2S6HZOQ1E1gmpkR5P6AYNB+qPmeAEgW6UUjltaIW+s+Ocuv5XNdbwNbPM8XVwNtXSXbE +/nsQIvjxlsOcVq8cGbRFzx96p11KdgFXwYrS4GoLm/2zcFjXha4O4UdJb6Zwb5ADibF ti0NT4fvpJD+O6qoMYur09hQpWBm9p4RgN7g+gT0HuuhVtU0QCq05o9c00PivYE9LVZZ aBUt8eT/yadfuPMEXdcrhHn0ZMSZDZk6BpGX7EcjTHCENxOfqn4DGfzbqB0Xuaurh8lY 2adQ== X-Forwarded-Encrypted: i=1; AJvYcCXpyxu/jFaJ4e3AjarUQFIO3XjHLwfVROGy/j0fjZXVlDaZy9CwWHDyLPTlVPm2h9brAYBgAzhLSea/Rl0=@vger.kernel.org X-Gm-Message-State: AOJu0Yyx3BhZZN/4GddQAj2uAY+DWL46RzwUHW1bSJSOY9B54zlX9evT 7YXMx96S8RKzHIcwzz3+198dnDI1jGSxqlLBEnEjAXxou99dbWdpYpC0 X-Gm-Gg: ASbGncvDg+Z3mnzWmhCRYtIsjSApHV617UljaArpcG1AaxGRvwFsmMQx2effIHWE2E8 +osPCC6pPtu89x7ayIQ+yb2c6z6rXBt4QPTqOeXUZFVcWYB1Iq6fUp0spH5v5p7B/8Sb98b3LCj X6vyeT+TfFcKAOY/X2q0zIZa3OikrjrZjRqaZX/SSIDS6HCduk70E1aU6W7YWQ3HzqRazTNG4cV O1hYjhpfB7/tZ8ycBFjPw79ACCL7WNkneKG+LkSbqlFbVsmkxmqKzIPHKaOihwNfjjUsBqUrXnd 1hpxRC3tfe7rylPbFCIFwJkFeRes04s2tJ2iat6G5lKBeMZwjfaYi1MyAJW+hSgsislEbwYlFvM UQaE0XAwE5qbatdUUWCVnvvyDEzL+gkgmgMHP/vSAjvTfEGSPfl2Vxrk/aYJPSCBXIdgtmIbNZz rCuYJ3V8OlNP1ptFXgpvqOsg== X-Google-Smtp-Source: AGHT+IH6MlF20aBw/ekPgNeSRKYo2VxiBjnu0MoQG1M0PA3MeCaWoqn4gRIyesjAQhNiYNPyQu2Z5g== X-Received: by 2002:a05:6a20:12cc:b0:34f:28f7:ed78 with SMTP id adf61e73a8af0-3637db6471dmr6746156637.25.1764146485644; Wed, 26 Nov 2025 00:41:25 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f024adcfsm20918248b3a.31.2025.11.26.00.41.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 00:41:25 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 1/2] net: dsa: yt921x: Fix parsing MIB attributes Date: Wed, 26 Nov 2025 16:40:19 +0800 Message-ID: <20251126084024.2843851-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251126084024.2843851-1-mmyangfl@gmail.com> References: <20251126084024.2843851-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are hard-to-find unused fields in the MIB table I didn't notice in the example driver code, causing wrong interpretation of the MIB data. For some 64-bit attributes, the current (wrong) implementation took the correct lower 32 bits, but messed up the upper 32 bits, so it would work accidentally until 32-bit overflows happen. Fix that too. Fixes: 186623f4aa72 ("net: dsa: yt921x: Add support for Motorcomm YT921x") Signed-off-by: David Yang --- drivers/net/dsa/yt921x.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c index 944988e29127..97fc6085f4d0 100644 --- a/drivers/net/dsa/yt921x.c +++ b/drivers/net/dsa/yt921x.c @@ -56,13 +56,13 @@ static const struct yt921x_mib_desc yt921x_mib_descs[] = =3D { =20 MIB_DESC(1, 0x30, NULL), /* RxPktSz1024To1518 */ MIB_DESC(1, 0x34, NULL), /* RxPktSz1519ToMax */ - MIB_DESC(2, 0x38, NULL), /* RxGoodBytes */ - /* 0x3c */ + /* 0x38 unused */ + MIB_DESC(2, 0x3c, NULL), /* RxGoodBytes */ =20 - MIB_DESC(2, 0x40, "RxBadBytes"), - /* 0x44 */ - MIB_DESC(2, 0x48, NULL), /* RxOverSzErr */ - /* 0x4c */ + /* 0x40 */ + MIB_DESC(2, 0x44, "RxBadBytes"), + /* 0x48 */ + MIB_DESC(1, 0x4c, NULL), /* RxOverSzErr */ =20 MIB_DESC(1, 0x50, NULL), /* RxDropped */ MIB_DESC(1, 0x54, NULL), /* TxBroadcast */ @@ -79,10 +79,10 @@ static const struct yt921x_mib_desc yt921x_mib_descs[] = =3D { MIB_DESC(1, 0x78, NULL), /* TxPktSz1024To1518 */ MIB_DESC(1, 0x7c, NULL), /* TxPktSz1519ToMax */ =20 - MIB_DESC(2, 0x80, NULL), /* TxGoodBytes */ - /* 0x84 */ - MIB_DESC(2, 0x88, NULL), /* TxCollision */ - /* 0x8c */ + /* 0x80 unused */ + MIB_DESC(2, 0x84, NULL), /* TxGoodBytes */ + /* 0x88 */ + MIB_DESC(1, 0x8c, NULL), /* TxCollision */ =20 MIB_DESC(1, 0x90, NULL), /* TxExcessiveCollistion */ MIB_DESC(1, 0x94, NULL), /* TxMultipleCollision */ @@ -705,7 +705,7 @@ static int yt921x_read_mib(struct yt921x_priv *priv, in= t port) res =3D yt921x_reg_read(priv, reg + 4, &val1); if (res) break; - val =3D ((u64)val0 << 32) | val1; + val =3D ((u64)val1 << 32) | val0; } =20 WRITE_ONCE(*valp, val); --=20 2.51.0