From nobody Mon Dec 1 23:36:43 2025 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71A1731A555 for ; Wed, 26 Nov 2025 08:41:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764146487; cv=none; b=h8frDPL70Tg1hPkY4hOnEaBgMjqABNotVwgKavYoM9WkmbCUTd8IUBZt/Uxu2hBeFo6FIuv/YII+Lw0bCaG/yyALExUalAz+tnoxJh/zQiCblUw+vm87IN/JqYHnjDm8CjyjIXsPTIrI2jvJOwB4NCXX/L/KP9942qqBLyPgMhs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764146487; c=relaxed/simple; bh=GMqvMppgg9+kh8EZJaPvH4xH3QOVzWZS8jhDW4n9Qjk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RN9+ms0B7ZSibS8ocCrqsMwvlbkUsv222JEqH4WnHNoJasInPbEcHXDYfjQugvteoZ35ZlfegC533pBrBEXsO+u06ClzNZ7z7h7lf660h2nk1yac6cKIuPRaefq7rGM0o4EXKvNEa7gKJa+9aoCXehWxzghHT6xyYzBoZVnKPsQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f0QJgryF; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f0QJgryF" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7aa2170adf9so5574433b3a.0 for ; Wed, 26 Nov 2025 00:41:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764146486; x=1764751286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5jVEFoefhamhUSCRXilkvRs0+/dJxtk9IdYrSyATDdg=; b=f0QJgryF+Rv9OPfmWd64T+cwYvfWEHtDdrh92OQWhAQznc8884BKoE72xQyBTDdxrn b+jPh7drMYqSWUH2G759Y+cHEfBnw6R4MJ2QAnNuBLVwRyTxO9ycSle3UaVVNcGCcjZo lkD1iatAshnCcl740//M3scf4Aw8l7tfQARnuuELLirw89g//co1YoumUKRUQbLDql5l +CyhlnCuPY/BIFkKlSSDlmR70Of18hrROmX17mzcvRKQkOqOOxNodXzXQYYrgaZaEnCP GrVdq3+p7uD4XYs0svjpLiJmLMwqNuuDXLBIK9s0W5d6cI5EV4CZVof7HkrBmnTpz1A7 6j0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764146486; x=1764751286; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5jVEFoefhamhUSCRXilkvRs0+/dJxtk9IdYrSyATDdg=; b=Ge0R7WlUU2LIAHZzkInN81wZr1uDkSOsg0yMmIUM2TAAdMipcVa1VOEelgPCiOEtIV 2S6HZOQ1E1gmpkR5P6AYNB+qPmeAEgW6UUjltaIW+s+Ocuv5XNdbwNbPM8XVwNtXSXbE +/nsQIvjxlsOcVq8cGbRFzx96p11KdgFXwYrS4GoLm/2zcFjXha4O4UdJb6Zwb5ADibF ti0NT4fvpJD+O6qoMYur09hQpWBm9p4RgN7g+gT0HuuhVtU0QCq05o9c00PivYE9LVZZ aBUt8eT/yadfuPMEXdcrhHn0ZMSZDZk6BpGX7EcjTHCENxOfqn4DGfzbqB0Xuaurh8lY 2adQ== X-Forwarded-Encrypted: i=1; AJvYcCXpyxu/jFaJ4e3AjarUQFIO3XjHLwfVROGy/j0fjZXVlDaZy9CwWHDyLPTlVPm2h9brAYBgAzhLSea/Rl0=@vger.kernel.org X-Gm-Message-State: AOJu0Yyx3BhZZN/4GddQAj2uAY+DWL46RzwUHW1bSJSOY9B54zlX9evT 7YXMx96S8RKzHIcwzz3+198dnDI1jGSxqlLBEnEjAXxou99dbWdpYpC0 X-Gm-Gg: ASbGncvDg+Z3mnzWmhCRYtIsjSApHV617UljaArpcG1AaxGRvwFsmMQx2effIHWE2E8 +osPCC6pPtu89x7ayIQ+yb2c6z6rXBt4QPTqOeXUZFVcWYB1Iq6fUp0spH5v5p7B/8Sb98b3LCj X6vyeT+TfFcKAOY/X2q0zIZa3OikrjrZjRqaZX/SSIDS6HCduk70E1aU6W7YWQ3HzqRazTNG4cV O1hYjhpfB7/tZ8ycBFjPw79ACCL7WNkneKG+LkSbqlFbVsmkxmqKzIPHKaOihwNfjjUsBqUrXnd 1hpxRC3tfe7rylPbFCIFwJkFeRes04s2tJ2iat6G5lKBeMZwjfaYi1MyAJW+hSgsislEbwYlFvM UQaE0XAwE5qbatdUUWCVnvvyDEzL+gkgmgMHP/vSAjvTfEGSPfl2Vxrk/aYJPSCBXIdgtmIbNZz rCuYJ3V8OlNP1ptFXgpvqOsg== X-Google-Smtp-Source: AGHT+IH6MlF20aBw/ekPgNeSRKYo2VxiBjnu0MoQG1M0PA3MeCaWoqn4gRIyesjAQhNiYNPyQu2Z5g== X-Received: by 2002:a05:6a20:12cc:b0:34f:28f7:ed78 with SMTP id adf61e73a8af0-3637db6471dmr6746156637.25.1764146485644; Wed, 26 Nov 2025 00:41:25 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f024adcfsm20918248b3a.31.2025.11.26.00.41.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 00:41:25 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 1/2] net: dsa: yt921x: Fix parsing MIB attributes Date: Wed, 26 Nov 2025 16:40:19 +0800 Message-ID: <20251126084024.2843851-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251126084024.2843851-1-mmyangfl@gmail.com> References: <20251126084024.2843851-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are hard-to-find unused fields in the MIB table I didn't notice in the example driver code, causing wrong interpretation of the MIB data. For some 64-bit attributes, the current (wrong) implementation took the correct lower 32 bits, but messed up the upper 32 bits, so it would work accidentally until 32-bit overflows happen. Fix that too. Fixes: 186623f4aa72 ("net: dsa: yt921x: Add support for Motorcomm YT921x") Signed-off-by: David Yang --- drivers/net/dsa/yt921x.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c index 944988e29127..97fc6085f4d0 100644 --- a/drivers/net/dsa/yt921x.c +++ b/drivers/net/dsa/yt921x.c @@ -56,13 +56,13 @@ static const struct yt921x_mib_desc yt921x_mib_descs[] = =3D { =20 MIB_DESC(1, 0x30, NULL), /* RxPktSz1024To1518 */ MIB_DESC(1, 0x34, NULL), /* RxPktSz1519ToMax */ - MIB_DESC(2, 0x38, NULL), /* RxGoodBytes */ - /* 0x3c */ + /* 0x38 unused */ + MIB_DESC(2, 0x3c, NULL), /* RxGoodBytes */ =20 - MIB_DESC(2, 0x40, "RxBadBytes"), - /* 0x44 */ - MIB_DESC(2, 0x48, NULL), /* RxOverSzErr */ - /* 0x4c */ + /* 0x40 */ + MIB_DESC(2, 0x44, "RxBadBytes"), + /* 0x48 */ + MIB_DESC(1, 0x4c, NULL), /* RxOverSzErr */ =20 MIB_DESC(1, 0x50, NULL), /* RxDropped */ MIB_DESC(1, 0x54, NULL), /* TxBroadcast */ @@ -79,10 +79,10 @@ static const struct yt921x_mib_desc yt921x_mib_descs[] = =3D { MIB_DESC(1, 0x78, NULL), /* TxPktSz1024To1518 */ MIB_DESC(1, 0x7c, NULL), /* TxPktSz1519ToMax */ =20 - MIB_DESC(2, 0x80, NULL), /* TxGoodBytes */ - /* 0x84 */ - MIB_DESC(2, 0x88, NULL), /* TxCollision */ - /* 0x8c */ + /* 0x80 unused */ + MIB_DESC(2, 0x84, NULL), /* TxGoodBytes */ + /* 0x88 */ + MIB_DESC(1, 0x8c, NULL), /* TxCollision */ =20 MIB_DESC(1, 0x90, NULL), /* TxExcessiveCollistion */ MIB_DESC(1, 0x94, NULL), /* TxMultipleCollision */ @@ -705,7 +705,7 @@ static int yt921x_read_mib(struct yt921x_priv *priv, in= t port) res =3D yt921x_reg_read(priv, reg + 4, &val1); if (res) break; - val =3D ((u64)val0 << 32) | val1; + val =3D ((u64)val1 << 32) | val0; } =20 WRITE_ONCE(*valp, val); --=20 2.51.0 From nobody Mon Dec 1 23:36:43 2025 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F40531A55A for ; Wed, 26 Nov 2025 08:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764146491; cv=none; b=tj7dr7QxiVC1hgqasIDuCyHOBGHYeMny/JVWMBSPT3JVnzQaAOWZL2pWQWgKradO+7Ou+W6cQ+nvGZMSecAGZesdboz4uWm3VLeng8BKzgbLH8hgj2fPLTkGTpgZ3aN/hJCKlZ1WEuCgkn2OVusM0tzjNUlikM32tGM0hly+pzs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764146491; c=relaxed/simple; bh=8q0JnY5DrrZ+PN2DSLXQVtqJLuqFnZlkdZoIWfZykH4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Sq01eUwnsHD0+uDjDWC+dhhCWry7QLzu44uD5D7FLOlVWLKCqpcTdV+8N/xvB58ry0qW6MVbWT4pLwJMt31wG8caaPiDwPZ52JhLbQOE+p/c59+IdMvIPwuo+OFHnns/OAVxQUQ4gdk/pO3xHtlTMXQiYwq4YbJftms9GBhblr8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i8k11jTB; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i8k11jTB" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7ba49f92362so412911b3a.1 for ; Wed, 26 Nov 2025 00:41:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764146489; x=1764751289; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YZ/O2Ko3hOv90LKroi8XCwo6K73vNvCcrb4vBmq+pd8=; b=i8k11jTB2YRvq13lAr08kiugg1VHRpAIuK4mQhMWBR8fiY8kcrWezYvzXS0MITGq9Y SnOad0nGmoSYPc4u6uizzly7mA8MW59npjK3C4wO0bCqBY58rErWNxqhrJtpFBaloBG4 zN0jsTKkPsLBmkmLMu4sRQk/Srf57/bSoA+lo7uzymyF0KJHyHDwdt2DNcwQCVjdK9U9 cr03Y/k+1q6C7X8u39FxCaHgwijahpWAOU5+jPtChlKOeAt0NAgkTTmxjpb4uFSh0c95 VFgbcGDtoPtpkmd1oKL+lW+Mh0oerhSZgH0nynAcP38pjUkViWja6QTHC25ziRXYRq1L +0Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764146489; x=1764751289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YZ/O2Ko3hOv90LKroi8XCwo6K73vNvCcrb4vBmq+pd8=; b=eDPWUOojRfIR8NblSg/runCWFa7qigcFjHcVTNM00jNVfC/tCsbreOSUAfmelVjKDy yLZ8obgVC42uHPs9gV4/Uxdqw4jOhYkrPljU74enr1nfvgD/pfywj1e+nET69YNuU3ZT +4U3G7u5lFcJxBDMhbIQLqN0anMOQy1erjgT1Y4V3Q8dXKVKtgD5l8EbtRTx4RgyGI7y bEceDAwor5hVCSoI7lse1DEXj1EOUkk2cibaGYzzuFCrDLPfG3UEyxA1IjQPsoehXQ+k v10OCTx+/miFuJMdMfBD/B3Pgyb++a3ASB5g/2V01IIJrx6ssBsRKFPkBdkNedXefmXZ bVkw== X-Forwarded-Encrypted: i=1; AJvYcCVua4vCsqY9XDHwfjU0YTC9n0DDvPfvuyQNvhJFd2h+ahSEkdFQpioS7JAxhxAZavIhOYTbaNEirSAAKWQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz24lI7ZIwgfV6i2H+c/zo1lN0AKCFnwrYud4WJgraPyu3Hlhis CpW6cFTnd5neSWH2VeQGhX65e58u2/0WZns9ooklZI6LirVQ7uswlN8a X-Gm-Gg: ASbGncuqbIy9Bm5OCE3Fb7Gjnq1gTnI4lj8Tu3LMgKNd2nN6AB98ZU9T3dDP5R1KiK5 oBdrbjgDJa5ufkS8khCTAfHhcgBEYFzOj4Ib+YNKH3CXuNYPGkLczfoKT5I1MCkTWVnkfWKOYQn r/GW0BWpvLX7IMKzl7W7RSgdboq+qOdmh7n082Cmo+tTDq3ONzZy9KjMEpzGIdo0k4e2duYkZ7a lpeweDsFz0fVN3PRxi248WK6li/uqruJMtMy0FwgVPSYJa4oRHliwIVWs/hBTkhuBzIXJ0N0l7r KNfzVFCcTe4eK6YBI2fgTca2n2GIvi3cAweOyF3UOMnueLchwm+rYc6sfjltSCH2N5zzZmVwKec oGYzbaLhmn2FBBpgpp4P7fveXTA4oPp26zW2t2pXwStW/O3yfVXTq6xo2y5GVYb+n1qRHy5nrxc hhcTLAuUMi34o5myCBlmC+pg== X-Google-Smtp-Source: AGHT+IEjsyvBfRts3y6K7+GKt69nymFayBLHmMH7D8x0mMtsZfiZYyaGDV/wMWKATGIe4TPDDuAAjw== X-Received: by 2002:a05:6a20:6a07:b0:35d:e4b2:b383 with SMTP id adf61e73a8af0-3614f5a21ecmr22112751637.31.1764146488787; Wed, 26 Nov 2025 00:41:28 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f024adcfsm20918248b3a.31.2025.11.26.00.41.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 00:41:28 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 2/2] net: dsa: yt921x: Use macros for MIB locations Date: Wed, 26 Nov 2025 16:40:20 +0800 Message-ID: <20251126084024.2843851-3-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251126084024.2843851-1-mmyangfl@gmail.com> References: <20251126084024.2843851-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Extract MIB constants into the header file to improve code style. This patch will not change the behavior of the function. Signed-off-by: David Yang --- drivers/net/dsa/yt921x.c | 103 +++++++++++++++++++-------------------- drivers/net/dsa/yt921x.h | 54 ++++++++++++++++++++ 2 files changed, 103 insertions(+), 54 deletions(-) diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c index 97fc6085f4d0..ebfd34f72314 100644 --- a/drivers/net/dsa/yt921x.c +++ b/drivers/net/dsa/yt921x.c @@ -39,60 +39,55 @@ struct yt921x_mib_desc { * to perform 32bit MIB overflow wraparound. */ static const struct yt921x_mib_desc yt921x_mib_descs[] =3D { - MIB_DESC(1, 0x00, NULL), /* RxBroadcast */ - MIB_DESC(1, 0x04, NULL), /* RxPause */ - MIB_DESC(1, 0x08, NULL), /* RxMulticast */ - MIB_DESC(1, 0x0c, NULL), /* RxCrcErr */ - - MIB_DESC(1, 0x10, NULL), /* RxAlignErr */ - MIB_DESC(1, 0x14, NULL), /* RxUnderSizeErr */ - MIB_DESC(1, 0x18, NULL), /* RxFragErr */ - MIB_DESC(1, 0x1c, NULL), /* RxPktSz64 */ - - MIB_DESC(1, 0x20, NULL), /* RxPktSz65To127 */ - MIB_DESC(1, 0x24, NULL), /* RxPktSz128To255 */ - MIB_DESC(1, 0x28, NULL), /* RxPktSz256To511 */ - MIB_DESC(1, 0x2c, NULL), /* RxPktSz512To1023 */ - - MIB_DESC(1, 0x30, NULL), /* RxPktSz1024To1518 */ - MIB_DESC(1, 0x34, NULL), /* RxPktSz1519ToMax */ - /* 0x38 unused */ - MIB_DESC(2, 0x3c, NULL), /* RxGoodBytes */ - - /* 0x40 */ - MIB_DESC(2, 0x44, "RxBadBytes"), - /* 0x48 */ - MIB_DESC(1, 0x4c, NULL), /* RxOverSzErr */ - - MIB_DESC(1, 0x50, NULL), /* RxDropped */ - MIB_DESC(1, 0x54, NULL), /* TxBroadcast */ - MIB_DESC(1, 0x58, NULL), /* TxPause */ - MIB_DESC(1, 0x5c, NULL), /* TxMulticast */ - - MIB_DESC(1, 0x60, NULL), /* TxUnderSizeErr */ - MIB_DESC(1, 0x64, NULL), /* TxPktSz64 */ - MIB_DESC(1, 0x68, NULL), /* TxPktSz65To127 */ - MIB_DESC(1, 0x6c, NULL), /* TxPktSz128To255 */ - - MIB_DESC(1, 0x70, NULL), /* TxPktSz256To511 */ - MIB_DESC(1, 0x74, NULL), /* TxPktSz512To1023 */ - MIB_DESC(1, 0x78, NULL), /* TxPktSz1024To1518 */ - MIB_DESC(1, 0x7c, NULL), /* TxPktSz1519ToMax */ - - /* 0x80 unused */ - MIB_DESC(2, 0x84, NULL), /* TxGoodBytes */ - /* 0x88 */ - MIB_DESC(1, 0x8c, NULL), /* TxCollision */ - - MIB_DESC(1, 0x90, NULL), /* TxExcessiveCollistion */ - MIB_DESC(1, 0x94, NULL), /* TxMultipleCollision */ - MIB_DESC(1, 0x98, NULL), /* TxSingleCollision */ - MIB_DESC(1, 0x9c, NULL), /* TxPkt */ - - MIB_DESC(1, 0xa0, NULL), /* TxDeferred */ - MIB_DESC(1, 0xa4, NULL), /* TxLateCollision */ - MIB_DESC(1, 0xa8, "RxOAM"), - MIB_DESC(1, 0xac, "TxOAM"), + MIB_DESC(1, YT921X_MIB_DATA_RX_BROADCAST, NULL), + MIB_DESC(1, YT921X_MIB_DATA_RX_PAUSE, NULL), + MIB_DESC(1, YT921X_MIB_DATA_RX_MULTICAST, NULL), + MIB_DESC(1, YT921X_MIB_DATA_RX_CRC_ERR, NULL), + + MIB_DESC(1, YT921X_MIB_DATA_RX_ALIGN_ERR, NULL), + MIB_DESC(1, YT921X_MIB_DATA_RX_UNDERSIZE_ERR, NULL), + MIB_DESC(1, YT921X_MIB_DATA_RX_FRAG_ERR, NULL), + MIB_DESC(1, YT921X_MIB_DATA_RX_PKT_SZ_64, NULL), + + MIB_DESC(1, YT921X_MIB_DATA_RX_PKT_SZ_65_TO_127, NULL), + MIB_DESC(1, YT921X_MIB_DATA_RX_PKT_SZ_128_TO_255, NULL), + MIB_DESC(1, YT921X_MIB_DATA_RX_PKT_SZ_256_TO_511, NULL), + MIB_DESC(1, YT921X_MIB_DATA_RX_PKT_SZ_512_TO_1023, NULL), + + MIB_DESC(1, YT921X_MIB_DATA_RX_PKT_SZ_1024_TO_1518, NULL), + MIB_DESC(1, YT921X_MIB_DATA_RX_PKT_SZ_1519_TO_MAX, NULL), + MIB_DESC(2, YT921X_MIB_DATA_RX_GOOD_BYTES, NULL), + + MIB_DESC(2, YT921X_MIB_DATA_RX_BAD_BYTES, "RxBadBytes"), + MIB_DESC(1, YT921X_MIB_DATA_RX_OVERSIZE_ERR, NULL), + + MIB_DESC(1, YT921X_MIB_DATA_RX_DROPPED, NULL), + MIB_DESC(1, YT921X_MIB_DATA_TX_BROADCAST, NULL), + MIB_DESC(1, YT921X_MIB_DATA_TX_PAUSE, NULL), + MIB_DESC(1, YT921X_MIB_DATA_TX_MULTICAST, NULL), + + MIB_DESC(1, YT921X_MIB_DATA_TX_UNDERSIZE_ERR, NULL), + MIB_DESC(1, YT921X_MIB_DATA_TX_PKT_SZ_64, NULL), + MIB_DESC(1, YT921X_MIB_DATA_TX_PKT_SZ_65_TO_127, NULL), + MIB_DESC(1, YT921X_MIB_DATA_TX_PKT_SZ_128_TO_255, NULL), + + MIB_DESC(1, YT921X_MIB_DATA_TX_PKT_SZ_256_TO_511, NULL), + MIB_DESC(1, YT921X_MIB_DATA_TX_PKT_SZ_512_TO_1023, NULL), + MIB_DESC(1, YT921X_MIB_DATA_TX_PKT_SZ_1024_TO_1518, NULL), + MIB_DESC(1, YT921X_MIB_DATA_TX_PKT_SZ_1519_TO_MAX, NULL), + + MIB_DESC(2, YT921X_MIB_DATA_TX_GOOD_BYTES, NULL), + MIB_DESC(1, YT921X_MIB_DATA_TX_COLLISION, NULL), + + MIB_DESC(1, YT921X_MIB_DATA_TX_EXCESSIVE_COLLISION, NULL), + MIB_DESC(1, YT921X_MIB_DATA_TX_MULTIPLE_COLLISION, NULL), + MIB_DESC(1, YT921X_MIB_DATA_TX_SINGLE_COLLISION, NULL), + MIB_DESC(1, YT921X_MIB_DATA_TX_PKT, NULL), + + MIB_DESC(1, YT921X_MIB_DATA_TX_DEFERRED, NULL), + MIB_DESC(1, YT921X_MIB_DATA_TX_LATE_COLLISION, NULL), + MIB_DESC(1, YT921X_MIB_DATA_RX_OAM, "RxOAM"), + MIB_DESC(1, YT921X_MIB_DATA_TX_OAM, "TxOAM"), }; =20 struct yt921x_info { diff --git a/drivers/net/dsa/yt921x.h b/drivers/net/dsa/yt921x.h index 3e85d90826fb..44719d841d40 100644 --- a/drivers/net/dsa/yt921x.h +++ b/drivers/net/dsa/yt921x.h @@ -173,6 +173,60 @@ #define YT921X_MIB_CTRL_ALL_PORT BIT(0) #define YT921X_MIBn_DATA0(port) (0xc0100 + 0x100 * (port)) #define YT921X_MIBn_DATAm(port, x) (YT921X_MIBn_DATA0(port) + 4 * (x)) +#define YT921X_MIB_DATA_RX_BROADCAST 0x00 +#define YT921X_MIB_DATA_RX_PAUSE 0x04 +#define YT921X_MIB_DATA_RX_MULTICAST 0x08 +#define YT921X_MIB_DATA_RX_CRC_ERR 0x0c + +#define YT921X_MIB_DATA_RX_ALIGN_ERR 0x10 +#define YT921X_MIB_DATA_RX_UNDERSIZE_ERR 0x14 +#define YT921X_MIB_DATA_RX_FRAG_ERR 0x18 +#define YT921X_MIB_DATA_RX_PKT_SZ_64 0x1c + +#define YT921X_MIB_DATA_RX_PKT_SZ_65_TO_127 0x20 +#define YT921X_MIB_DATA_RX_PKT_SZ_128_TO_255 0x24 +#define YT921X_MIB_DATA_RX_PKT_SZ_256_TO_511 0x28 +#define YT921X_MIB_DATA_RX_PKT_SZ_512_TO_1023 0x2c + +#define YT921X_MIB_DATA_RX_PKT_SZ_1024_TO_1518 0x30 +#define YT921X_MIB_DATA_RX_PKT_SZ_1519_TO_MAX 0x34 +/* 0x38: unused */ +#define YT921X_MIB_DATA_RX_GOOD_BYTES 0x3c + +/* 0x40: 64 bytes */ +#define YT921X_MIB_DATA_RX_BAD_BYTES 0x44 +/* 0x48: 64 bytes */ +#define YT921X_MIB_DATA_RX_OVERSIZE_ERR 0x4c + +#define YT921X_MIB_DATA_RX_DROPPED 0x50 +#define YT921X_MIB_DATA_TX_BROADCAST 0x54 +#define YT921X_MIB_DATA_TX_PAUSE 0x58 +#define YT921X_MIB_DATA_TX_MULTICAST 0x5c + +#define YT921X_MIB_DATA_TX_UNDERSIZE_ERR 0x60 +#define YT921X_MIB_DATA_TX_PKT_SZ_64 0x64 +#define YT921X_MIB_DATA_TX_PKT_SZ_65_TO_127 0x68 +#define YT921X_MIB_DATA_TX_PKT_SZ_128_TO_255 0x6c + +#define YT921X_MIB_DATA_TX_PKT_SZ_256_TO_511 0x70 +#define YT921X_MIB_DATA_TX_PKT_SZ_512_TO_1023 0x74 +#define YT921X_MIB_DATA_TX_PKT_SZ_1024_TO_1518 0x78 +#define YT921X_MIB_DATA_TX_PKT_SZ_1519_TO_MAX 0x7c + +/* 0x80: unused */ +#define YT921X_MIB_DATA_TX_GOOD_BYTES 0x84 +/* 0x88: 64 bytes */ +#define YT921X_MIB_DATA_TX_COLLISION 0x8c + +#define YT921X_MIB_DATA_TX_EXCESSIVE_COLLISION 0x90 +#define YT921X_MIB_DATA_TX_MULTIPLE_COLLISION 0x94 +#define YT921X_MIB_DATA_TX_SINGLE_COLLISION 0x98 +#define YT921X_MIB_DATA_TX_PKT 0x9c + +#define YT921X_MIB_DATA_TX_DEFERRED 0xa0 +#define YT921X_MIB_DATA_TX_LATE_COLLISION 0xa4 +#define YT921X_MIB_DATA_RX_OAM 0xa8 +#define YT921X_MIB_DATA_TX_OAM 0xac =20 #define YT921X_EDATA_CTRL 0xe0000 #define YT921X_EDATA_CTRL_ADDR_M GENMASK(15, 8) --=20 2.51.0