From nobody Mon Dec 1 23:33:17 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECCF92FF144 for ; Wed, 26 Nov 2025 08:17:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764145048; cv=none; b=StKSPwpf1T/Y8Hdop+U4XiHs9kpDEkqKlhCaoKR7eP3rtu9r+CL5wDwWVJ+3galdcvTHQX0eg2fxDrSQMccClR2wwyf//WjIE+eZ38mzFIiAv1pMv87iFNrqPyLHXnX4etogLkq3c9ebCX7skVqz+r7xvAVe5zVFBj9LZubEs08= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764145048; c=relaxed/simple; bh=26ewATnLhdKUDBijWBdOubXCn8dWfFQbYho+Ln2xqYk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AaqeBrvr33OmUK9K2f1WKQrE3/VhJfK1mu9sSYZKNUZoNXiCKLK8r55yhPFzdNZGDZdYDxxEQb57TlzKmWP6smIptVZ9O2S3+iHfbFhv7d+1Z1dGFd3D2omylCmZeNUZ+72JJKAiuCTVFXyoFi0xWxhik6owOByGvoQPvTFwAMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N3cTHsNV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iJ+PrVXg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N3cTHsNV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iJ+PrVXg" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5APLV7333666218 for ; Wed, 26 Nov 2025 08:17:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=qnD/1lKAxJmdDO+JtOoVFqrhZ2jHl2VA38L GsO7qpQY=; b=N3cTHsNV+yDowqoi08cRXlD6+419iQ/mOh6KxvVsUF1iviwfeNx MdvLz9b6s9ttJmqRGnTYvM+XJKHiw0MdMl0bpq7ea9m8cKxrEgwM6Iez2W/gtxcW UIpJYdSTKAso7t4cLbFvUvmq29czrURKlOnozQE6ZkEfJ9EyJPPpwKzULxLRw67+ k6LUsrb5QH1QvahiZkbhmaQ9P34fjO1to/eSyOs9L6zzh1vaF0GHNy3toXEKzRfs yPV4/Mh2ULL739qoYcQYJp5pCbOMhhQzx9fdcKrbjlf87MYG5u9r8PyjuT+yO1ht xbaZTvvwRKCIQJ4lfn6VYsE/waZdoys5xDw== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4anmemsc9h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Nov 2025 08:17:26 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7b9ef46df43so6310572b3a.1 for ; Wed, 26 Nov 2025 00:17:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764145045; x=1764749845; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qnD/1lKAxJmdDO+JtOoVFqrhZ2jHl2VA38LGsO7qpQY=; b=iJ+PrVXgtyPgN1oNjZuSYxjO6MFPWX3bvYZjROjw1CPD1wlwzuasC/vTvNLoMXCCjl +BXIJuqUIfM1j1V7mIFCEfeBc7dM+hJCEdxbdNxagol2JT1hed8WNGX5TnAq6ci/8MdS dRqyq3iH+XLVww2SpJdxcFVhV4toKAA9lDDOWaqcrkqC7cVzey/w67lAT2L2k+KESHeI xx21KMzr8sh87GkEdIyOTtq/wZyF3PiBG01WxQWW+wra+H/+vzqCA77JQMIeBL+LEJIg 2LmGtcCQN7rgfB+QQoWqXOqsgh5mnXiVNH6SbI7j1p8YMoG/kimCYA3xSPbYYFP8GvcH m+aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764145045; x=1764749845; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qnD/1lKAxJmdDO+JtOoVFqrhZ2jHl2VA38LGsO7qpQY=; b=dDt0E1ieEkNMu18t51VPBlBNuLE50sbX8FzDkqCJUG6VWVQcKb2HO4qBHPg6zEpjj5 JYqWpavSx9F/+tzGo6gw8ylkZWlhkPFbUEg/RkjOPelyeuceTgFxQesAH342TSLy0G+A JUdzBpjlhpzXIe8YyAScY4GK05se3ZYGX+7L/2r9rfq0kSznPP7HfK+zs7dkLgzFof69 OxN02Agf5B4hN9MovcZsBF4a3COJJtw28EHXVSJZ/WDirpU0Wt21HHhCMqb8BOuEzmjx 7seNhcyEsxDYKJYISKqF0lbpi03XfYPdWUpkcCLjbTVD8nm7YpIxP3gaKNBgVYK4EoDX k2EQ== X-Forwarded-Encrypted: i=1; AJvYcCWuzxg1MtJy0giSKzneqfbWq4kA61bxXku0S0exwkc4tCVABGCYbgmZuSC7Oeya/e4Y7hJDbiHtVX3Y/bM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2tkLpO3bty+7IM88pJiyAhw+lDw83nGb0Wg9Km45c0a4en9+e Wgvx+CJrrZrl1XI1MzGXj7t5ibqne7tua+qq+cW12PkoS503dhHZXSK3mz3A+7yiIdlJMHE5hpD Mc/m3Vt0Q/nTrqRKoCC22ID1Un2LFM43/AAdyR6+O0Fqf0mBoQ86bFGOcK94Jv91+Svc= X-Gm-Gg: ASbGncvTe5A5DnhNVV+9rD40T+NaD/qZ5q4T7Rhi7hsGkB2cd7EAsgwEL37ux0OGWft 3dE/1Mi7y4bdOqn3lw/+sqjImBqzJANdA++jRxJBL0DPT1xs8y9I2O8h8COaC5tHM6iEwH6wLD5 Q6HADIdTGVbGIF7mEE3EEDRpeLhoVRZEK7qR9mMEXSySkINvSGZY5zXGubtXLBHWZ8vz2mCR3LY JIUplH7o7uisu1m6zeEB2o61HPrXvFaATCCLxwZtI2zHzZnbcJKNQ/6I5etmd8cpnn8quRxYZ0a c5iuXV+oUiRRpscPYjfcjKtqTkG1GnhK0mmZE2YZkAY+eyjAcWhh+a9VOSR6JzA+xLeNTTn+A1T F X-Received: by 2002:a05:6a00:2d14:b0:772:4319:e7df with SMTP id d2e1a72fcca58-7ca89d594b4mr6020006b3a.30.1764145045388; Wed, 26 Nov 2025 00:17:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IFMnX3uutEhAxNfnRGDkCn54FdPUAUGPEjT1Hkxxud4okq3aFyy7ph/bAVkyK9nXbZ97Mmrgg== X-Received: by 2002:a05:6a00:2d14:b0:772:4319:e7df with SMTP id d2e1a72fcca58-7ca89d594b4mr6019976b3a.30.1764145044851; Wed, 26 Nov 2025 00:17:24 -0800 (PST) Received: from work.. ([2401:4900:88e8:55c:d927:2b8f:9059:4f8f]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c668138e7dsm14204371b3a.68.2025.11.26.00.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 00:17:24 -0800 (PST) From: Manivannan Sadhasivam X-Google-Original-From: Manivannan Sadhasivam To: mani@kernel.org, lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Dmitry Baryshkov Subject: [PATCH] PCI: qcom: Clear ASPM L0s CAP for MSM8996 SoC Date: Wed, 26 Nov 2025 13:47:18 +0530 Message-ID: <20251126081718.8239-1-mani@kernel.org> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: zXUtD66pf5taXRGazmmiD73yGTKs5I6n X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI2MDA2NiBTYWx0ZWRfX3NL0u8l03Dwk nQg2CPoL06qtr6y3ikpI4B7o5FuWvlGx53WTm6EvqP/Q1vQ8OtWx4DiLaJ8fzkqjk7SxBJXjOiV taWoC3FqRF6FmigHTByFoC6DDZdFFNNG7RqtVxzHvknfemfknzw3Rt/E0dfVodZ4or0Upwxfmlp Zm1cchy+irI8L8cLTqSxGy8+UiIkDzUaobEexLAGxjbNNPS0l4gBXyRIQqfLQhIzuCJOtJbw+1g a5X1XbmzJF2OyEDRDzFmLValc1+S/h0Eu8/MAc179H7o7U64gsFTrkg0+f/p3Kv3gCpPzhGFJv4 do7lR4mna3D71Z7ZWE3uTjiFZ/1NRCoFbwn0/GWYZ73jOyEOzPgGmNzCEhwqUPJaPbx+34UYCpE pHOdzgglhKA5IB3RfBly3bGToxviKQ== X-Proofpoint-GUID: zXUtD66pf5taXRGazmmiD73yGTKs5I6n X-Authority-Analysis: v=2.4 cv=bZBmkePB c=1 sm=1 tr=0 ts=6926b796 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=xqWC_Br6kY4A:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=iDgDmxrxDGO2Rnn2FVcA:9 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511260066 Content-Type: text/plain; charset="utf-8" From: Manivannan Sadhasivam Though I couldn't confirm the ASPM L0s support with the Qcom hardware team, bug report from Dmitry suggests that L0s is broken on this legacy SoC. Hence, clear the L0s CAP for the Root Ports in this SoC. Since qcom_pcie_clear_aspm_l0s() is now used by more than one SoC config, call it from qcom_pcie_host_init() instead. Reported-by: Dmitry Baryshkov Closes: https://lore.kernel.org/linux-pci/4cp5pzmlkkht2ni7us6p3edidnk25l45x= rp6w3fxguqcvhq2id@wjqqrdpkypkf Signed-off-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio Tested-by: Dmitry Baryshkov --- drivers/pci/controller/dwc/pcie-qcom.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controlle= r/dwc/pcie-qcom.c index 805edbbfe7eb..25399d47fc40 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1088,7 +1088,6 @@ static int qcom_pcie_post_init_2_7_0(struct qcom_pcie= *pcie) writel(WR_NO_SNOOP_OVERRIDE_EN | RD_NO_SNOOP_OVERRIDE_EN, pcie->parf + PARF_NO_SNOOP_OVERRIDE); =20 - qcom_pcie_clear_aspm_l0s(pcie->pci); qcom_pcie_clear_hpc(pcie->pci); =20 return 0; @@ -1350,6 +1349,8 @@ static int qcom_pcie_host_init(struct dw_pcie_rp *pp) goto err_disable_phy; } =20 + qcom_pcie_clear_aspm_l0s(pcie->pci); + qcom_ep_reset_deassert(pcie); =20 if (pcie->cfg->ops->config_sid) { @@ -1486,6 +1487,7 @@ static const struct qcom_pcie_cfg cfg_2_1_0 =3D { =20 static const struct qcom_pcie_cfg cfg_2_3_2 =3D { .ops =3D &ops_2_3_2, + .no_l0s =3D true, }; =20 static const struct qcom_pcie_cfg cfg_2_3_3 =3D { --=20 2.48.1