From nobody Mon Dec 1 23:33:42 2025 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56C4B20CCDC for ; Wed, 26 Nov 2025 06:30:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764138626; cv=none; b=B6ItyfrTluiW2vYBxqCwyqVppp0bePCjlA16v+9g510mYPdScgM9UU9giu4H4MXcPEMUToXQOa3DaXzsgih6SxDafeMeLjro1NP1dDt3AtH2ZqPsk4P/isjYrPrf1sedNxiVgb0ETDfc5c72PibkeUfpN8O2xjIx9ylbtaWSk/s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764138626; c=relaxed/simple; bh=U6bQmkUxd70UqE5e2zL7MVt9+dVE77Ehtb/US7OhAYg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Cwnd315LZZvFiqE6U26zRpDAHmzssKuGbfMbgRCfstsX+8VYPy7DTS72bi5SWhVlNQMDBcK5PUbEAiObf72qOaLmKnMgidq5BBbTJjiyNj0Osn77kd5MP6HQjzGmu0OtfVpPicU8QGO+aUN65SR4/EDtSfeKzhsD5oWgk6EUFv0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ee.vjti.ac.in; spf=none smtp.mailfrom=ee.vjti.ac.in; dkim=pass (1024-bit key) header.d=vjti.ac.in header.i=@vjti.ac.in header.b=JTppPQB+; arc=none smtp.client-ip=209.85.216.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ee.vjti.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ee.vjti.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=vjti.ac.in header.i=@vjti.ac.in header.b="JTppPQB+" Received: by mail-pj1-f65.google.com with SMTP id 98e67ed59e1d1-3437ea05540so5422372a91.0 for ; Tue, 25 Nov 2025 22:30:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vjti.ac.in; s=google; t=1764138623; x=1764743423; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IzRkGTCq3jZ+jOaGIzMctMlQ71AdgQEN3oB90COYnDU=; b=JTppPQB+1X7vktBDdv7BdsW1wouObmrt/ltyeVaeRbKpWb3ZCwWd5q2uyYPqOd8c5K ifMXX0zEowWEmm2U9WHPPCNRWmcmaS5E/zqAgO4VHK6tlAnMSL/fAAzqsFT8OqL3rsJv c1L+uKfD8ZH0G0M91dfM71ILEnzxLK4mDk8MY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764138623; x=1764743423; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IzRkGTCq3jZ+jOaGIzMctMlQ71AdgQEN3oB90COYnDU=; b=m+VC71DL6JG6souNy/YuQP+gd+Lq3bMky7/yrpInND85S0HObcolKRa/wg63HbrNQc LCqXn29Wwsu1mAw54CEd2qE7MxPDoD+S1IkNfdSCw/zikLqImkUG3AE+PKdMCg9jLiBB 0vX7YHvShUtVvQ0WpBQ10Ybi8y5lvPlEG5UT517uJywWP5y99TRSeyxZ6zmy399SFwks EURzdONczaTu95/M11mprHUQMuf/kcv4ZGpJLc2ZeVNHDxKjl0VhSW4sQ6W2+e3xNahx WAZLwtn6GeKdiStxA8rQdqf8B+bmOG52faMH9gg8rotu+IeBqWDtxiDxHQHfypQc+zHx /6sQ== X-Forwarded-Encrypted: i=1; AJvYcCWa763ilDsSUd0nK0z51xw4FLKrKdXR67258Cd//mK21nPByOXc9eaQQOIBCXplgImG1G8N2J1Jrhlw6E4=@vger.kernel.org X-Gm-Message-State: AOJu0Ywtyen7vDVDLOVOr2AO8vDD78L9GsZGaaNSeym2bXNovPKD91JS owrrC5nO3Ifmqxf0dGflGEz2Ru4fPY6pi0sf9DEiuYKkimZ9Twdi1zLKdsYNyczyeOs= X-Gm-Gg: ASbGncvRILQ1GmVuipZ1pmt0GJC/HPRtdIK+bO0bwJQlJInCEWMq5ENcbre27iX+WUe S7Y3TAVIZQx9GUSddCURjqIz9GfUMsb8TlaEHVetwnUIttJd44ZQ+tEhntW1SVgT3mgrM1vd0UF OptpVnxyVnXc3VbEigzZyaj3zO3W75PKqtSmiSczLxSxm17WiONlUKdqTO5Fu8zl9SY4H1GhTiM GBDjed8quGYQauwQRlFGIIpT7yL/4KZeLOxCk88KCnWaJ68Dh7bdwWKQcA6PE80OqI9JhCbwof1 xSnSOeJGV6L4gdlfqtrxI+g9JgzssMPnVfL6g7Azxv3EHqHpKrQkjrZ5E75FuvMvfqRF39Kx7+b vo8SfqqkCj4Glgsza+/c3OHASjltV8InBQsi9fL9L4GPL8RB8UzyDNq2o6+K6PlT7u80GDGK2q2 K0NCJ5YzwIdxjO7654Es/+QgN53Gj8W3ONteHDBlJ2Q1/FTUavOoxbjTVW X-Google-Smtp-Source: AGHT+IEuaHOrzBEFxv16/3EUkSrMUsaXs6T/9SLzDvNZQkcQxKIdKmZkZuFocPDxwf8ehClgPQYvyQ== X-Received: by 2002:a17:90b:4b8c:b0:340:d578:f2a2 with SMTP id 98e67ed59e1d1-34733e4cb74mr19340413a91.6.1764138622659; Tue, 25 Nov 2025 22:30:22 -0800 (PST) Received: from ranegod-HP-ENVY-x360-Convertible-13-bd0xxx.. ([2405:201:31:d869:7ab4:fdd5:842b:6bfe]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f0b63dbcsm20088553b3a.50.2025.11.25.22.30.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 22:30:22 -0800 (PST) From: ssrane_b23@ee.vjti.ac.in X-Google-Original-From: ssranevjti@gmail.com To: Hans Verkuil , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, david.hunter.linux@gmail.com, khalid@kernel.org, Shaurya Rane , syzbot+a41b73dce23962a74c72@syzkaller.appspotmail.com Subject: [PATCH v2] media: radio-keene: fix memory leak in error path Date: Wed, 26 Nov 2025 12:00:00 +0530 Message-Id: <20251126063000.28493-1-ssranevjti@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shaurya Rane Fix a memory leak in usb_keene_probe() when v4l2_device_register() fails. The v4l2 control handler was initialized and controls were added, but if v4l2_device_register() failed, the handler was never freed, leaking the allocated memory for the handler buckets and control structures. Consolidate the error handling by adding an err_hdl label that ensures v4l2_ctrl_handler_free() is called for all error paths after the handler is initialized. Reported-by: syzbot+a41b73dce23962a74c72@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3Da41b73dce23962a74c72 Fixes: 1bf20c3a0c61 ("[media] radio-keene: add a driver for the Keene FM Tr= ansmitter") Signed-off-by: Shaurya Rane --- v2: - Simplified fix: call v4l2_ctrl_handler_free() inline before goto instead of adding a new error label, avoiding unused label warning reported by Media CI. --- drivers/media/radio/radio-keene.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/radio/radio-keene.c b/drivers/media/radio/radio-= keene.c index f3b57f0cb1ec..4a203e958a4f 100644 --- a/drivers/media/radio/radio-keene.c +++ b/drivers/media/radio/radio-keene.c @@ -344,6 +344,7 @@ static int usb_keene_probe(struct usb_interface *intf, retval =3D v4l2_device_register(&intf->dev, &radio->v4l2_dev); if (retval < 0) { dev_err(&intf->dev, "couldn't register v4l2_device\n"); + v4l2_ctrl_handler_free(hdl); goto err_v4l2; } =20 --=20 2.34.1