From nobody Mon Dec 1 23:33:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B2CF314D0C for ; Wed, 26 Nov 2025 06:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764137692; cv=none; b=iWbG0sBeSnea9q0Lssp7Q/cZATig12UjvhNnH9GJggBxHMYXu6fiZqzJYHYR+ILlksPIlIp3nwx+c/jZr0p1f0adpMpKq+sLBRzYZGI/hqggQ8FBBOqL7HCBWKOps5enaC4SP/vLkUUkklZNOAT6dscKtaSHOEqvyE3TrTlTjBQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764137692; c=relaxed/simple; bh=xWH1HsevfA3c1s1qZoSEd9QG2VYtkDD8havo9G9tmwE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=STIlfMEQnOAxbmiuGo5uWQdRtEzlTA7jjSjW0fvlFnB0lj8P60Z2rArwMMpP8FSgZuWU2nKICDmZdsYqcYQQkoA3bmzfWxN3/1vNBjFOSaR0ZFheZgWV1F1fo7Ez8QTZJ0TsUpAUFsar5LW94SClEj3Bh9qD9JnDfmlIfSZsdKo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QQvNKHZy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QQvNKHZy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03023C113D0; Wed, 26 Nov 2025 06:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764137691; bh=xWH1HsevfA3c1s1qZoSEd9QG2VYtkDD8havo9G9tmwE=; h=From:To:Cc:Subject:Date:From; b=QQvNKHZyJ5piXVmK2DFKMaUXm1vc7MzZufot7TnlciRTbKuuKJDqXfbHiRQbwCq/G XbDxxNI2HHRTPBS3OLx0m9JxQOsNudp9r9RfBE0vJ2IzUaV6Y3KBC4wrz8lGHy8tvs tzHPQgQ3ZCRqo68omReACU+UpCGOd36Mu3FzY6FECxZW0FX4ntuxyISGPpwm+nLQz8 6RLfyuVUNOmViTVsDD95wqJ221i6M+nsahF5AyxK1msCF8kLrfUE+O5dDaO88zI1jk LLKsgCfj2J6282FrTrdIgAiXFRP3pr9I6S8QdcAJWmQk8y7QpPSdJ+TZwG/Xz277mg /+UtGYL+kEofg== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu , stable@kernel.org Subject: [PATCH] f2fs: fix to check bio after __blkdev_issue_discard() Date: Wed, 26 Nov 2025 14:14:37 +0800 Message-ID: <20251126061437.658896-1-chao@kernel.org> X-Mailer: git-send-email 2.52.0.487.g5c8c507ade-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Previously, __blkdev_issue_discard() will always returned valid bio, after commit e8b4869bc78d ("block: add a blk_alloc_discard_bio helper"), it can return bio w/ NULL value, which may trigger panic or warning in __submit_discard_cmd(), let's fix to check bio instread of return value after __blkdev_issue_discard(). Cc: stable@kernel.org Fixes: e8b4869bc78d ("block: add a blk_alloc_discard_bio helper") Signed-off-by: Chao Yu --- fs/f2fs/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 8375dca7ed9e..44c0cefbb5a9 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -1351,7 +1351,7 @@ static int __submit_discard_cmd(struct f2fs_sb_info *= sbi, SECTOR_FROM_BLOCK(len), GFP_NOFS, &bio); } - if (err) { + if (err || bio =3D=3D NULL) { spin_lock_irqsave(&dc->lock, flags); if (dc->state =3D=3D D_PARTIAL) dc->state =3D D_SUBMIT; --=20 2.49.0