From nobody Mon Dec 1 23:33:40 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D753D4C9D for ; Wed, 26 Nov 2025 05:41:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764135700; cv=none; b=XGs5J+6t1nuoNJRVCZFUrf8M8AQWls+W3BExujtitSLJvYm+h//uAYUZvAjWCqssfBsY0xzNqlrzbCt6OHxpd5GjzVfZS6SUJN+bpCAERC8P8CGVRg1lomm7M0DgwgLpJKjWL6V/IfLATkTq86Wz9d3fJPzX5yy4xqkYPEcYh2I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764135700; c=relaxed/simple; bh=kN8wNtyrFPMNkBMnseS+/dcIHc+YV5MfHN3kVM6Rs2k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iAAdAJv6/khCwKQOSTYuz6n5T+R3EH73gOEKnJXLG6AZvBKtqD3E8rr8oOtVteMruR3hJs0PzzhB/GlsF6u8lfzSMhTOHBmN2hFk4NoL5DdzaKtjlpN5b7j/P1gLSlzS4+vekh1biPu8Bqxw1PcxKy5hAhIl2yBNFKSnO96U28I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hMl8ZHZw; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hMl8ZHZw" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-429c82bf86bso3636300f8f.1 for ; Tue, 25 Nov 2025 21:41:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764135697; x=1764740497; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QW5cVIdovQWDv+bqBSbnBeQJjt2jpyUHW2uxiLg7ptY=; b=hMl8ZHZwS4caHB0Ci3qjK+NWP7BXgUlsP6OVAOyeGYnZokr6WnE1yppHgz2nlDwgOx Sp70VgzXXs6U0d8weRaO/BoyZ9TNBnwQ1RkBR4cZMbSkk+8BGB2nXCHKBdPL4qfZ3Qm5 E4jLBp5amIOR8v82YPXN4iRvOvEtRFL7AJehRVvqQifbPQnHpupzshtXch32JeErp00d 6xsShR2yp5CtfEF2uPCs9Lror+SLxjtelr36I7pPAxqKY5jao0vVoSiNGgk0XmLe5K9W wB4tF3lqHX3CDvBF4XZ3XRjG/fx+Ueun3awCFWxafqSHEQ1l57kf7bXsWt2zdOjKAAw5 trpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764135697; x=1764740497; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QW5cVIdovQWDv+bqBSbnBeQJjt2jpyUHW2uxiLg7ptY=; b=CW/Dvqh90AmMcRgmKUEP/elneKLXoQocfnykQzArJC/C2X2SY9xiG67Rj7O2qDtdRZ b3nW0sWN+vT7DvRBmuRpWYz/EaqfUJnCky1zmMWFy8mKPf6Ebg5ehoC6Ca2h1fAdBr4R CgVnggBw10PhiLPZgmARrWPMJPzCV/89Gpqdk5naKvKnIjtHQlW94/TOEnL3nGr4adFg hzT6zM2IU8SfEqZfWp1C8C0GafhRB41hYcIAGKBBth3NFTBLnb+LqiQwhjIMqeupNKah LzXtgvuVRXtHCK+lCRghMjMbjFuWu4yc/NTqVOakCEXylsTY16cTrQ6QyhqyoSBLWAU5 zl3g== X-Forwarded-Encrypted: i=1; AJvYcCX0DIsgLC3lZ6g2CCyNO+rokYKokhEEXXoZUTvTGO5U8NsFkDBvN3SD3X02a61uZs8w+H6MO0aaFqoYrsY=@vger.kernel.org X-Gm-Message-State: AOJu0YxTtUkKsh60J5FBxhmkGzT5GfkIMK/EKnzvbyDSmZxiP177/Goh Juxv6ABiMrEu9L1tOtfsmYa81bpyfgPRIcpwdCvSNP9IkcDAqd7eQlUa X-Gm-Gg: ASbGnctY44y27oziuLIZ87y/AwsmUBsa0M0wiRLLnzNxWis4E8SheZFqSsIXViEBJ8w 9a2dNu/bTGzc4Qty2Sc3iAQr6BL12lKpmHgvlnEvfDtIu6kkE5hv/XMQmbeKx98wDeVpWS7/ACk 056+LxMhv4Vir8KDysXgzau5CNhnQOJvrDTc0NQRulOMdFc0W1EXIHAnWm1e2EJVe6jNme5PJPg sf4RlXknMJk2y0vsUrvJAU0hue9DTAOCE32VpSEAeWohp6gqAZpBCbbpRyIkBkhg4gpClXYeIa1 Pb6kCsFRjhC/VU6w1bUz7j6MoVb3sOuk/W1PtmFZGvjlSoYth9voAtdbtBv7mBxa+pJdjaGKWu3 TFD7AUTQwQA4BQGs5PsRa+NfooHixw+hqpNOwjaMsrk8U8wsy2CZrVrOuuqqBGqZwoIYQcQE3GA DjXqNo3GtNog0U X-Google-Smtp-Source: AGHT+IF5V48oVy47DDAvZnj5lN2hPNi8IKQoV7v+luO0VgruXL17m6le0MnbAaH8JmcsbJdk8AXskQ== X-Received: by 2002:a05:6000:240b:b0:42b:3661:304a with SMTP id ffacd0b85a97d-42cc1d08715mr20198687f8f.38.1764135696988; Tue, 25 Nov 2025 21:41:36 -0800 (PST) Received: from gmail.com ([147.161.143.89]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f363b0sm38658536f8f.13.2025.11.25.21.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 21:41:36 -0800 (PST) From: hariconscious@gmail.com To: lgirdwood@gmail.com, broonie@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: perex@perex.cz, tiwai@suse.com, khalid@kernel.org, shuah@kernel.org, david.hunter.linux@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, HariKrishna Sagala Subject: [PATCH] ASoC: mediatek: mt8195: optimize property formatting error handling by using scnprintf() Date: Wed, 26 Nov 2025 11:05:02 +0530 Message-ID: <20251126053500.56353-3-hariconscious@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: HariKrishna Sagala Replace snprintf() with scnprintf() when constructing the property and remove negative return error handling as scnprintf() returns the actual number of bytes written to buffer. snprintf() as defined by the C99 standard,returns the number of=20 characters that *would have been* written if enough space were=20 available.Use scnprintf() that returns the actual number of=20 characters written. Link: https://github.com/KSPP/linux/issues/105 Signed-off-by: HariKrishna Sagala --- This patch optimizes the error handling part of property formatting using the scnrpintf(). Removed the error check ret < 0 as scnprintf() doesn't return the negative value as per contract. https://www.kernel.org/doc/html/latest/core-api/kernel-api.html#c.scnprintf Thank you. sound/soc/mediatek/mt8195/mt8195-dai-etdm.c | 44 ++++++--------------- 1 file changed, 12 insertions(+), 32 deletions(-) diff --git a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c b/sound/soc/mediat= ek/mt8195/mt8195-dai-etdm.c index fd4f9f8f032d..77c58c9ec3e2 100644 --- a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c +++ b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c @@ -2652,14 +2652,9 @@ static void mt8195_dai_etdm_parse_of(struct mtk_base= _afe *afe) =20 etdm_data =3D afe_priv->dai_priv[dai_id]; =20 - ret =3D snprintf(prop, sizeof(prop), - "mediatek,%s-mclk-always-on-rate", - of_afe_etdms[i].name); - if (ret < 0) { - dev_info(afe->dev, "%s snprintf err=3D%d\n", - __func__, ret); - return; - } + scnprintf(prop, sizeof(prop), + "mediatek,%s-mclk-always-on-rate", + of_afe_etdms[i].name); ret =3D of_property_read_u32(of_node, prop, &sel); if (ret =3D=3D 0) { etdm_data->mclk_dir =3D SND_SOC_CLOCK_OUT; @@ -2668,24 +2663,14 @@ static void mt8195_dai_etdm_parse_of(struct mtk_bas= e_afe *afe) __func__, sel); } =20 - ret =3D snprintf(prop, sizeof(prop), - "mediatek,%s-multi-pin-mode", - of_afe_etdms[i].name); - if (ret < 0) { - dev_info(afe->dev, "%s snprintf err=3D%d\n", - __func__, ret); - return; - } + scnprintf(prop, sizeof(prop), + "mediatek,%s-multi-pin-mode", + of_afe_etdms[i].name); etdm_data->data_mode =3D of_property_read_bool(of_node, prop); =20 - ret =3D snprintf(prop, sizeof(prop), - "mediatek,%s-cowork-source", - of_afe_etdms[i].name); - if (ret < 0) { - dev_info(afe->dev, "%s snprintf err=3D%d\n", - __func__, ret); - return; - } + scnprintf(prop, sizeof(prop), + "mediatek,%s-cowork-source", + of_afe_etdms[i].name); ret =3D of_property_read_u32(of_node, prop, &sel); if (ret =3D=3D 0) { if (sel >=3D MT8195_AFE_IO_ETDM_NUM) { @@ -2707,14 +2692,9 @@ static void mt8195_dai_etdm_parse_of(struct mtk_base= _afe *afe) dai_id =3D ETDM_TO_DAI_ID(i); etdm_data =3D afe_priv->dai_priv[dai_id]; =20 - ret =3D snprintf(prop, sizeof(prop), - "mediatek,%s-chn-disabled", - of_afe_etdms[i].name); - if (ret < 0) { - dev_info(afe->dev, "%s snprintf err=3D%d\n", - __func__, ret); - return; - } + scnprintf(prop, sizeof(prop), + "mediatek,%s-chn-disabled", + of_afe_etdms[i].name); ret =3D of_property_read_variable_u8_array(of_node, prop, disable_chn, 1, max_chn); base-commit: 30f09200cc4aefbd8385b01e41bde2e4565a6f0e --=20 2.43.0