From nobody Mon Dec 1 23:33:34 2025 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 800D030E0D2 for ; Wed, 26 Nov 2025 03:41:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764128479; cv=none; b=JcKwnQ7BxMIewxlCweGQQCnMh9rFvdN7J47y+p9CQ4pb1AB65mFl0AhgDfG9YwG4Vb1UOXlZsmYKRzduawDWab76RSR8W7vDUJXd6jHAAK8JJVgvaqKv6S6NgALEeBJA+BGP/v774dV/CCsyCV5l8LadfWQ7AO5WhnLnecPsf34= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764128479; c=relaxed/simple; bh=a9NYLup+GHVLFnigeOor2tUWrU5w0BB3Ez/xbw4Q8GI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=d5fNmYgIYgFqJ02YtXfGmvLc1FviebeoIsNvWk1UTWBrtrziL7ZaOVgCtD3wxv4uUV+hHBEa+4RQaTfzcHOlRof1sddax6nUO+Y4JGwki15k6GOnvk0W9uFNCyZK7ud58DBBm6sLjyKMCT99JzXh9Eu81GuMoG0nU+L/sfOjY+M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ee.vjti.ac.in; spf=none smtp.mailfrom=ee.vjti.ac.in; dkim=pass (1024-bit key) header.d=vjti.ac.in header.i=@vjti.ac.in header.b=O7SJwfV7; arc=none smtp.client-ip=209.85.210.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ee.vjti.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ee.vjti.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=vjti.ac.in header.i=@vjti.ac.in header.b="O7SJwfV7" Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-7b89c1ce9easo7350480b3a.2 for ; Tue, 25 Nov 2025 19:41:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vjti.ac.in; s=google; t=1764128476; x=1764733276; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=L06KdTNJX/VzLn2Sdswq1zSZJ8ncJFeN/TZrwKb7bDA=; b=O7SJwfV7NHffNdX8uhajXcYR4/8DHRrtdwjDckFFEOo6o09HSWUUb5wUl0CnxhVryc ZPkwvnE08Ef+70YQBvMs5C7I95muA0yU8HcMmy5oHvF66SdA1rGDeGTs2W+MboBa5L05 VoXO6zPj7k92UqC6cWcCk/kfA9Zl50Lc/ABXc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764128476; x=1764733276; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L06KdTNJX/VzLn2Sdswq1zSZJ8ncJFeN/TZrwKb7bDA=; b=rd+TSfFlSYXMDXsPojGk5FBHrjf0YlC5J7QYK+XFeww2ZbJxcvA0CtaeE0x2xUm3nn G4i98lwJDQ9Bf8P8Z6vdEmZ+jC7rQy9js6GwG6A/QAtp4IMM5zlrsOcGMHWGKuSxMUB7 nsezWLNZ0t71+Ik4gQWvNoeMs2uCZp3XvXt1E4Z+U29PyjkeGYCdkX2VRWHr+eSlVkou ktnhBWgeF5PF4C7dfTeJUjNo3FoEF3PC1IB+n7pf4ZKP6Wt7UFdWrHGh0VZRSaplb+LD InVF0D6dfzjc29aRGrWqk1GKnQYE1hMLhKLgc41kJmuFg1dLffmiBBWEHEVIVlZZeolr lOgA== X-Forwarded-Encrypted: i=1; AJvYcCWhyWfK2nVmrLMEWaNUpoiMTZdxvzflrigitOP7drrg+zDlkBGKk6ZprahKwwZ8Nt3lttpX3fRJSgUyh6M=@vger.kernel.org X-Gm-Message-State: AOJu0YzhoLmDMGq21PP4GkKZ4i5jloa+KL39wn1wqa000hhCAwrMzq1O 3CzV5Hk+bhJS8Hy7TxKwrZgUdD7xrUW71lBxIK/jo14xIG9ISZSisChvUWCJdXX7ajo= X-Gm-Gg: ASbGncs0G5ZhvQ+NrhDxXb6+nISXMpmMkXdBDDhggUygF91w+85LmC3tgF7sR4hIydF 1hvIkIPPFwhmseMbUMxwkTCEOq62eyoOT7/JTQrbdqIBltPOd9o22wI/P1Yu++eg4HpqSpZBrFP Nj114ORa5xbunFXU/DyUwR5p9ctuillD0qqM8tEw4hzgOj8ncG8pktXz139eVgWIMNTnbhcneGo v05gEsGB1WmzxtsoBdKQVnibaZgCuC4bfBWPO0PUYcOLts7/pgFV9atJq+APCezLFP7SxPAVENn YMFntrZVl6YhX9NLnLXuMBHWBqIUOGMdNnjcloGgpfvMoM86o0U1Zwk5rP6r6EO+rSg0YQqaMRz nSS4QfnG4MM6g/IpHeyt2FvIAl2SL1kj6OdrrdLSedOmEEk7GOdj3mqr4sBfCyGlvsCoFM/3L2P ktCx4PEgC1tWLxX76xrt/kOhNDrVGU8fiCOrQ8A7jEzEQ0x4uOwcy/L7Ku X-Google-Smtp-Source: AGHT+IFn0YyK8uoIBkvy3BywAsW6leMDGURDB5DGi/SakuSKZblQSgFbhnhe1dMYdgyoOjGxyQCmAg== X-Received: by 2002:a05:6a00:1890:b0:7a4:460e:f86a with SMTP id d2e1a72fcca58-7c58e6014e2mr15281081b3a.25.1764128475771; Tue, 25 Nov 2025 19:41:15 -0800 (PST) Received: from ranegod-HP-ENVY-x360-Convertible-13-bd0xxx.. ([2405:201:31:d869:f53f:2666:7529:e5cd]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f174ba7dsm19410224b3a.64.2025.11.25.19.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 19:41:15 -0800 (PST) From: ssrane_b23@ee.vjti.ac.in X-Google-Original-From: ssranevjti@gmail.com To: hverkuil@kernel.org Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, david.hunter.linux@gmail.com, khalid@kernel.org, Shaurya Rane , syzbot+a41b73dce23962a74c72@syzkaller.appspotmail.com Subject: [PATCH] media: radio-keene: fix memory leak in error path Date: Wed, 26 Nov 2025 09:11:05 +0530 Message-Id: <20251126034105.236131-1-ssranevjti@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shaurya Rane Fix a memory leak in usb_keene_probe() when v4l2_device_register() fails. The v4l2 control handler was initialized and controls were added, but if v4l2_device_register() failed, the handler was never freed, leaking the allocated memory for the handler buckets and control structures. Fixes the error handling by adding an err_hdl label that ensures v4l2_ctrl_handler_free() is called for all error paths after the handler is initialized. Reported-by: syzbot+a41b73dce23962a74c72@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3Da41b73dce23962a74c72 Fixes: 1bf20c3a0c61 ("[media] radio-keene: add a driver for the Keene FM Tr= ansmitter") Signed-off-by: Shaurya Rane --- drivers/media/radio/radio-keene.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/radio/radio-keene.c b/drivers/media/radio/radio-= keene.c index f3b57f0cb1ec..84916b5ebcb2 100644 --- a/drivers/media/radio/radio-keene.c +++ b/drivers/media/radio/radio-keene.c @@ -337,14 +337,12 @@ static int usb_keene_probe(struct usb_interface *intf, radio->stereo =3D true; if (hdl->error) { retval =3D hdl->error; - - v4l2_ctrl_handler_free(hdl); - goto err_v4l2; + goto err_hdl; } retval =3D v4l2_device_register(&intf->dev, &radio->v4l2_dev); if (retval < 0) { dev_err(&intf->dev, "couldn't register v4l2_device\n"); - goto err_v4l2; + goto err_hdl; } =20 mutex_init(&radio->lock); @@ -383,6 +381,8 @@ static int usb_keene_probe(struct usb_interface *intf, =20 err_vdev: v4l2_device_unregister(&radio->v4l2_dev); +err_hdl: + v4l2_ctrl_handler_free(&radio->hdl); err_v4l2: kfree(radio->buffer); kfree(radio); --=20 2.34.1