From nobody Tue Dec 2 00:05:28 2025 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C59AB30BF67 for ; Wed, 26 Nov 2025 02:13:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764123208; cv=none; b=EmwrEdur2moyqG7L4V9P+8kVuktTbbl9M5lvgBXiR4svSFg/15Veo0TPNP3gxRo/aaUJFSWvD73OipQDtm6/MQ7JUAlgOEXVg7plD2HlgSscrS4taziQCuPLsuXsMG/xRS1VBy4sYfZH6nqqZi5HyjlwYF+HNU0WQXSXo+cnD6A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764123208; c=relaxed/simple; bh=ObajzURZPpq5CwZKMTFWSecxl+UxPzyGjYPnyHSwBvE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XGcLFb1bqkO5oH7mc9uRXEbZ5joClOK3qSStUwKtttNLzFQszttmPNMcMZOw68S9++5+tkwhJhNqaRFL7dRet//e3hGj5gx5NFkB0kpti96TSn8Nd4LkoA83jaABhcsQsgtPVewsdPDzMi7JhjQrQaW2Iim/aj5qhWkmhiwHU3c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=NRHYdpE4; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="NRHYdpE4" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7aae5f2633dso7184683b3a.3 for ; Tue, 25 Nov 2025 18:13:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1764123206; x=1764728006; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8XbXxl9w54eoJ5bw9vwLfDrvdJe4OVmNRP09snH5Q98=; b=NRHYdpE4/vC9GuLUW9HmZeqInkDlkWSPKJbetAhT1/8s6lopKnOs8V0roJdiUIPPUQ +vDlrI0JyhrDv71dbGMKwK4lmOE2VH+Kd/00E4a9TMAlK0Xbii9kcI3FWFB3xy8f0+0u IkZYduBrzlnBxfd4keYhqoQuRhUqdcplf7H6ohtS+fFaeCgCJQqzPoPziBwyTJlhL5xZ 7DsAixzVDfTmSNSvMw2jfyHA2OrHbt+Q4D+kGn4VMzKSu3gAg2b4Xqbl3uobHOqpIBX4 Pd8B/ukoO449t2Yd6bdBTDzmHv7wbKH+JiLXlnxPZLualUtk/U1ibNGPYmirDxWCIjUV y8CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764123206; x=1764728006; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8XbXxl9w54eoJ5bw9vwLfDrvdJe4OVmNRP09snH5Q98=; b=MYHtUM9ckoMpvjHHqf7O8D9MUz+lBNK8Jg8FG5M2xYURV0tH8UMeKhjLSOVDBRCqQP 7do6j1TJoM03qamQOvZ9inKJ5DabJiRZti0/BdCEt8+Wd11daT5113OeGtK5MqKW6m2h +jN4s0cSvaALzTtl7+1D+P1uw4dAbQomCAg9mbyjUWtP7YXz5rZDNohj+Y6a85LoFDVQ hLbjmgSdjfztlmk+gJZFxtmbjpQMhZh5EuiJDM6JTvc+fQgoGJZoyWH/wUmErnlhUUMm kpbbCt7o4TtN9Vcbq3ww7HzeQWSMw0gVezMUppTw1WkSNi858x02F3Z2Hwkb026dJbBl tAjA== X-Forwarded-Encrypted: i=1; AJvYcCVWIM1OmqE4nsfhJm6jCFpW849MUvaI+Zw8ZLhkG38XA4IIsA1iJ/XKQJr+88ZGBVl6hm3cvLUYptLO5xM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywr0rAa0Vt+o8LaLx0vhT/uP25/Hpw6WuYbo6xvMphj0DxIh6gd qmi9zY/k6UlgOY4os+34ToNiXiM818BUKuH+RhAFT5errmSt1mdSGLJHYA4dmhNwfGA= X-Gm-Gg: ASbGnctNEkc1HdZH/pbIWRCm4E/cdxsABNJDk6fult4E6AKcXq/jy8UN0lIXrDFPW1w fnC5yJhIHvH/75iDOOG0/T9H+wna5JlnfQ39bOVNN26Nq3LGAWAXa416L+g0BJYRrt/zAN94Ld5 /ZjCE1eKerTz8UdJaAF5rK2y34XAc/PCMvEfihfhcdc4Jhm66X1mUSLiUiARTkHz78NIjRpIP9f E2o9IcseRKpXUUVHOTHteHDeBj6ILFFh6bi1In/8nYlklalgcvBBa0zqHqRIGL/o6wRr+5+4ZYb UyJb5cItGhMXJ6xnN5VcRDYd0Yq8z59zBX+BTRdkf8dNytHGOafWhBTKZCqGpRSOr0dPoPIOFny HdlMTHYJyRhFLN5Ls4f9XFG/vqtHjwYbJsvjhkZEE8+EIxxl6tUWgF1Kh0BuxseBiJl4EUeM4No 89HFAK+pyqNcqmJWK3qrTVx9uMp/+BljCjFHUhxLW6cm60 X-Google-Smtp-Source: AGHT+IHwR/uNyy4XREluHWJ5+ovrWb65gDmMgcIcohHXB6flzaenya5awGJFYvmrd36ufdEuxYrdaA== X-Received: by 2002:a05:7022:671f:b0:11a:436c:2d56 with SMTP id a92af1059eb24-11c9d7090ffmr11613972c88.2.1764123205776; Tue, 25 Nov 2025 18:13:25 -0800 (PST) Received: from apollo.purestorage.com ([208.88.152.253]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-11cc631c236sm17922979c88.7.2025.11.25.18.13.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 18:13:25 -0800 (PST) From: Mohamed Khalfella To: Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg Cc: Aaron Dailey , Randy Jennings , John Meneghini , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Mohamed Khalfella Subject: [RFC PATCH 05/14] nvmet: Send an AEN on CCR completion Date: Tue, 25 Nov 2025 18:11:52 -0800 Message-ID: <20251126021250.2583630-6-mkhalfella@purestorage.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251126021250.2583630-1-mkhalfella@purestorage.com> References: <20251126021250.2583630-1-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Send an AEN to initiator when impacted controller exists. The notification points to CCR log page that initiator can read to check which CCR operation completed. Signed-off-by: Mohamed Khalfella --- drivers/nvme/target/core.c | 27 +++++++++++++++++++++++---- drivers/nvme/target/nvmet.h | 3 ++- include/linux/nvme.h | 3 +++ 3 files changed, 28 insertions(+), 5 deletions(-) diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index 7dbe9255ff42..60173833c3eb 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -202,7 +202,7 @@ static void nvmet_async_event_work(struct work_struct *= work) nvmet_async_events_process(ctrl); } =20 -void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, +static void nvmet_add_async_event_locked(struct nvmet_ctrl *ctrl, u8 event= _type, u8 event_info, u8 log_page) { struct nvmet_async_event *aen; @@ -215,12 +215,17 @@ void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u= 8 event_type, aen->event_info =3D event_info; aen->log_page =3D log_page; =20 - mutex_lock(&ctrl->lock); list_add_tail(&aen->entry, &ctrl->async_events); - mutex_unlock(&ctrl->lock); =20 queue_work(nvmet_wq, &ctrl->async_event_work); } +void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, + u8 event_info, u8 log_page) +{ + mutex_lock(&ctrl->lock); + nvmet_add_async_event_locked(ctrl, event_type, event_info, log_page); + mutex_unlock(&ctrl->lock); +} =20 static void nvmet_add_to_changed_ns_log(struct nvmet_ctrl *ctrl, __le32 ns= id) { @@ -1788,6 +1793,18 @@ struct nvmet_ctrl *nvmet_alloc_ctrl(struct nvmet_all= oc_ctrl_args *args) } EXPORT_SYMBOL_GPL(nvmet_alloc_ctrl); =20 +static void nvmet_ctrl_notify_ccr(struct nvmet_ctrl *ctrl) +{ + lockdep_assert_held(&ctrl->lock); + + if (nvmet_aen_bit_disabled(ctrl, NVME_AEN_BIT_CCR_COMPLETE)) + return; + + nvmet_add_async_event_locked(ctrl, NVME_AER_NOTICE, + NVME_AER_NOTICE_CCR_COMPLETED, + NVME_LOG_CCR); +} + static void nvmet_ctrl_complete_pending_ccr(struct nvmet_ctrl *ctrl) { struct nvmet_subsys *subsys =3D ctrl->subsys; @@ -1801,8 +1818,10 @@ static void nvmet_ctrl_complete_pending_ccr(struct n= vmet_ctrl *ctrl) list_for_each_entry(sctrl, &subsys->ctrls, subsys_entry) { mutex_lock(&sctrl->lock); list_for_each_entry(ccr, &sctrl->ccrs, entry) { - if (ccr->ctrl =3D=3D ctrl) + if (ccr->ctrl =3D=3D ctrl) { + nvmet_ctrl_notify_ccr(sctrl); ccr->ctrl =3D NULL; + } } mutex_unlock(&sctrl->lock); } diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h index 6c0091b8af8b..7ebcef13be2b 100644 --- a/drivers/nvme/target/nvmet.h +++ b/drivers/nvme/target/nvmet.h @@ -44,7 +44,8 @@ * Supported optional AENs: */ #define NVMET_AEN_CFG_OPTIONAL \ - (NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_ANA_CHANGE) + (NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_ANA_CHANGE | \ + NVME_AEN_CFG_CCR_COMPLETE) #define NVMET_DISC_AEN_CFG_OPTIONAL \ (NVME_AEN_CFG_DISC_CHANGE) =20 diff --git a/include/linux/nvme.h b/include/linux/nvme.h index d51883122d65..a145417dccd3 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -863,12 +863,14 @@ enum { NVME_AER_NOTICE_FW_ACT_STARTING =3D 0x01, NVME_AER_NOTICE_ANA =3D 0x03, NVME_AER_NOTICE_DISC_CHANGED =3D 0xf0, + NVME_AER_NOTICE_CCR_COMPLETED =3D 0xf4, }; =20 enum { NVME_AEN_BIT_NS_ATTR =3D 8, NVME_AEN_BIT_FW_ACT =3D 9, NVME_AEN_BIT_ANA_CHANGE =3D 11, + NVME_AEN_BIT_CCR_COMPLETE =3D 20, NVME_AEN_BIT_DISC_CHANGE =3D 31, }; =20 @@ -876,6 +878,7 @@ enum { NVME_AEN_CFG_NS_ATTR =3D 1 << NVME_AEN_BIT_NS_ATTR, NVME_AEN_CFG_FW_ACT =3D 1 << NVME_AEN_BIT_FW_ACT, NVME_AEN_CFG_ANA_CHANGE =3D 1 << NVME_AEN_BIT_ANA_CHANGE, + NVME_AEN_CFG_CCR_COMPLETE =3D 1 << NVME_AEN_BIT_CCR_COMPLETE, NVME_AEN_CFG_DISC_CHANGE =3D 1 << NVME_AEN_BIT_DISC_CHANGE, }; =20 --=20 2.51.2