From nobody Tue Dec 2 00:02:41 2025 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 434E030BBAC for ; Wed, 26 Nov 2025 02:13:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764123207; cv=none; b=FVLt1om8UfnZ2IHQCb9AMdaB3NY2IcQpm5lN69/2pID/vgw4a/D1y9cliPBJuUKi9CVhhFUnUQTMtXRQDnBnW8lNg4r9Q/E7XAipsl7t9sqHjCR7VdslKW6yMSoiFx8+f2BMU2bIm/7s3KtmEhs42cC/iQaSR7dMRzwEwLL3xm0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764123207; c=relaxed/simple; bh=u7W20si0SUqps+5PlbgF3xoCTUVA5ja/Q7/V9V/8FlU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kaFrzQ8pB2U87UMFebF5UnSNJft4cQOO/CijztISHu3Iuai1+Kue9Gmie6stILnNhUDtoKGHE/G721AswFwNr+hL4SRy00CujiJCtcBl3T2tuIytDA35AwZOJJwrNAUhIUDmv59d0w86iJMPl9jzsIQxL1Y9zvGt2c3y8xu+TtU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=MsxM9byn; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="MsxM9byn" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-11b6bc976d6so555517c88.0 for ; Tue, 25 Nov 2025 18:13:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1764123205; x=1764728005; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=myVWmyIcrLWM/1NcPstHQcp5kFjs3Rj2+YxkwTil04s=; b=MsxM9bynFIWdF6K0CK2ZR7rsVwHfcbkRSCQlyDSGo/JLxnJ7PxSI5DaMC+j6kinQxT cLjfoN802V8GRvawpYFeP2IuudapDvK2xjVt8lLAZ/hZqXbw+F/Xv3+rhv3pSBi1Z+c/ 5LrsYh28bWfF+c4B24z2j1//J262ORpem89wQVa7hxG0Y0vTIl/s74+9KKY1D7WuNTI8 SlsNpU3+8c6P4q3BgVzhtuz8+GgKyIx60a/wKlM+jg4QGDA2etys36wD1hPr5aO3iqQb BtW/Hy9MFtNN8XqMJftmhlc+zDint8zbGC3IvGswD+cEWlPRAZnkWYcz6rEEqrRb7VlM O5oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764123205; x=1764728005; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=myVWmyIcrLWM/1NcPstHQcp5kFjs3Rj2+YxkwTil04s=; b=haQjtbKiGANAAsNiKSJLylCR0MnNjx6bn3yPbhZWnhmtdyHS+JDMjxrza9l0XZa9e/ 8cxSfiT2tOy5y0OOL9zBP6WG132MqxG0F7oAJLK3nNWyzhbJf6CizCYzi38uoaeqb+H+ S0lE0LSBHCQpg2/7hZWchqJ7Qn94qgDddRiQ3rznF1VLVb2WDz/D4tol8xW/dkUWmVqD OkEJ9ukjZyAjqbvdB8iEN5JAvSW58mUJ8AouiNbQJ6MXgQ6K13KZ4dGLfOzgUl2xjpKb kZQ54n/rMe+50b8ueRp1PKB1X5xZfN4+aYRuWwvUasJS+SKiyEirzr5lMiUXSY2M10oT CesQ== X-Forwarded-Encrypted: i=1; AJvYcCVKsDPZkFq4jzrtfk8dqYXQ6o5IxLDRR3Tr6tqVAEKh6Yc6a9483rS7Xm/VChelJXHyu1gI3X7F1H5TMvE=@vger.kernel.org X-Gm-Message-State: AOJu0YwJFHyZXk2Wtnz+tV3XUkxMKcU/w5yjeTvqISs68fEMqWb/iBvW 3rZWCFX0f7Jt/VnRmXOutkwhMWm9llOJsNPt3LTUUXvOGi88ArPhp5J6yVWyiUmEpza82Nnf9mG nMkte X-Gm-Gg: ASbGncvpfHa+ekU9RO82/SEd7Q2qrMepA4SxWFXtlcwamt7NOEF56wMQGu7azPX7qQs qD59JSxVUMMD39yYh4RAU+7Cm7BpSCl1UvfQZS21vPzRtsFsYK32m9SVV4dH915s2A+lDOlCEIy QxmwH+8Q0zaU3z+AJnDWi0rdJ9nKGimm5rfYPg5DKnBXU4bNlrhZBWt6vgSCXzr+slULzknQ6vq lQB5xSX1E0Nai7j5bAVg+dBe+RI1Y9Odu5FI2SDBlHoqfDqlJxelQPqQ/gilpyY/LE7JZv7MQI4 y4z7bEU0nVZ7vJibowrx9IaSNobwdKAhcr+9nxUKF0GGwskhs9S1QzwFgxu1fzaiG6tdj2zYHjR aQ6oST+1YQ/MDmkBezA6minGwFk/anY9uM8fQ5R9zC9hB6zKrepP/6LKBAMgt3nXjViX2L1PX/F 7wcFQZ4lnPbNYKYCIcmgj411dYJ/5Wy8RixA== X-Google-Smtp-Source: AGHT+IF762dvIfiy+MJfaaRdfezo6gJCeNNNIF95vwqjmCbVZcZEuTz+XQbUmdcGAbK33RotfljyPQ== X-Received: by 2002:a05:7022:ea53:b0:11b:7dcd:ca8d with SMTP id a92af1059eb24-11c9caaf0cfmr7562603c88.19.1764123204952; Tue, 25 Nov 2025 18:13:24 -0800 (PST) Received: from apollo.purestorage.com ([208.88.152.253]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-11cc631c236sm17922979c88.7.2025.11.25.18.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 18:13:24 -0800 (PST) From: Mohamed Khalfella To: Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg Cc: Aaron Dailey , Randy Jennings , John Meneghini , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Mohamed Khalfella Subject: [RFC PATCH 04/14] nvmet: Implement CCR logpage Date: Tue, 25 Nov 2025 18:11:51 -0800 Message-ID: <20251126021250.2583630-5-mkhalfella@purestorage.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251126021250.2583630-1-mkhalfella@purestorage.com> References: <20251126021250.2583630-1-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Defined by TP8028 Rapid Path Failure Recovery, CCR (Cross-Controller Reset) log page contains an entry for each CCR request submitted to source controller. Implement CCR logpage for nvme linux target. Signed-off-by: Mohamed Khalfella --- drivers/nvme/target/admin-cmd.c | 42 +++++++++++++++++++++++++++++++++ include/linux/nvme.h | 16 +++++++++++++ 2 files changed, 58 insertions(+) diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cm= d.c index a55ca010d34f..d2892354bf81 100644 --- a/drivers/nvme/target/admin-cmd.c +++ b/drivers/nvme/target/admin-cmd.c @@ -220,6 +220,7 @@ static void nvmet_execute_get_supported_log_pages(struc= t nvmet_req *req) logs->lids[NVME_LOG_FEATURES] =3D cpu_to_le32(NVME_LIDS_LSUPP); logs->lids[NVME_LOG_RMI] =3D cpu_to_le32(NVME_LIDS_LSUPP); logs->lids[NVME_LOG_RESERVATION] =3D cpu_to_le32(NVME_LIDS_LSUPP); + logs->lids[NVME_LOG_CCR] =3D cpu_to_le32(NVME_LIDS_LSUPP); =20 status =3D nvmet_copy_to_sgl(req, 0, logs, sizeof(*logs)); kfree(logs); @@ -608,6 +609,45 @@ static void nvmet_execute_get_log_page_features(struct= nvmet_req *req) nvmet_req_complete(req, status); } =20 +static void nvmet_execute_get_log_page_ccr(struct nvmet_req *req) +{ + struct nvmet_ctrl *ctrl =3D req->sq->ctrl; + struct nvmet_ccr *ccr; + struct nvme_ccr_log *log; + int index =3D 0; + u16 status; + + log =3D kzalloc(sizeof(*log), GFP_KERNEL); + if (!log) { + status =3D NVME_SC_INTERNAL; + goto out; + } + + mutex_lock(&ctrl->lock); + list_for_each_entry(ccr, &ctrl->ccrs, entry) { + log->entries[index].icid =3D cpu_to_le16(ccr->icid); + log->entries[index].ciu =3D ccr->ciu; + log->entries[index].acid =3D cpu_to_le16(0xffff); + + /* If ccr->ctrl is NULL then we know reset succeeded */ + log->entries[index].ccrs =3D ccr->ctrl ? 0x00 : 0x01; + log->entries[index].ccrf =3D 0x03; /* Validated and Initiated */ + index++; + } + + /* Cleanup completed CCRs if requested */ + if (req->cmd->get_log_page.lsp & 0x1) + nvmet_ctrl_cleanup_ccrs(ctrl, false); + mutex_unlock(&ctrl->lock); + + log->ne =3D cpu_to_le16(index); + nvmet_clear_aen_bit(req, NVME_AEN_BIT_CCR_COMPLETE); + status =3D nvmet_copy_to_sgl(req, 0, log, sizeof(*log)); + kfree(log); +out: + nvmet_req_complete(req, status); +} + static void nvmet_execute_get_log_page(struct nvmet_req *req) { if (!nvmet_check_transfer_len(req, nvmet_get_log_page_len(req->cmd))) @@ -641,6 +681,8 @@ static void nvmet_execute_get_log_page(struct nvmet_req= *req) return nvmet_execute_get_log_page_rmi(req); case NVME_LOG_RESERVATION: return nvmet_execute_get_log_page_resv(req); + case NVME_LOG_CCR: + return nvmet_execute_get_log_page_ccr(req); } pr_debug("unhandled lid %d on qid %d\n", req->cmd->get_log_page.lid, req->sq->qid); diff --git a/include/linux/nvme.h b/include/linux/nvme.h index 0f305b317aa3..d51883122d65 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -1435,6 +1435,7 @@ enum { NVME_LOG_FDP_CONFIGS =3D 0x20, NVME_LOG_DISC =3D 0x70, NVME_LOG_RESERVATION =3D 0x80, + NVME_LOG_CCR =3D 0x1E, NVME_FWACT_REPL =3D (0 << 3), NVME_FWACT_REPL_ACTV =3D (1 << 3), NVME_FWACT_ACTV =3D (2 << 3), @@ -1458,6 +1459,21 @@ enum { NVME_FIS_CSCPE =3D 1 << 21, }; =20 +struct nvme_ccr_log_entry { + __le16 icid; + __u8 ciu; + __u8 rsvd3; + __le16 acid; + __u8 ccrs; + __u8 ccrf; +}; + +struct nvme_ccr_log { + __le16 ne; + __u8 rsvd2[6]; + struct nvme_ccr_log_entry entries[NVMF_CCR_PER_PAGE]; +}; + /* NVMe Namespace Write Protect State */ enum { NVME_NS_NO_WRITE_PROTECT =3D 0, --=20 2.51.2