From nobody Tue Dec 2 00:02:41 2025 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 377833093DE for ; Wed, 26 Nov 2025 02:13:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764123206; cv=none; b=C/NKmkPpOmr+dxiyhZkdov/X1DkjrWtWfCLZxUXy2Pt+RGwRDKFy15RcF6LATHTnxf/79q1gcktxCuRtuZwkFdOONz39cFZMgDga+HqY0i09lwfo6Xx1woJ1Do+3WKXA8WOyp1pigDRuk4WBcFrN9GuY/LDYeCBpsccu/uPF5qg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764123206; c=relaxed/simple; bh=m7HncE7hjhDGiYwQsmDETG5E1qzwbIvyXgpxRikxB9I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dvr3fsvdgCZz0hoQM8HuqD0+aQgRPLUVuP3rA1s/OdfQL01PuOAkxuFNwBDCaxh5105ja+PFGQvNo+sGpZHU329Iyfn58xmQjXW4PyheFp9xoZ1GzUAcldHTskdxe57LISAdX92I8nC68HQ7s/+GfpqTfS425fDyckYsH7St9Zg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=IclFKiIb; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="IclFKiIb" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-298039e00c2so87146455ad.3 for ; Tue, 25 Nov 2025 18:13:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1764123204; x=1764728004; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/6Ktrx/UQXxQ+qDpf8ETJ4IOmhLU/ttIqJExJUB/Co0=; b=IclFKiIbV1n4bSAgFqnxxIkhToyHvq1F5ThAotsUsiS/CNTuPhVKEm64wOiY4WkvQ1 jikbbjf44Sp2pMnHU5DaYbaBaawo+LJ3oplyhW3IxesViKkrzJzSuufHWAGNsdqhFeDU e7eetfwBv+2cSIdPTBnSfyYMcXI9GLyQVRwNtPwHaoQx6m3A4ly6MkGH52Lj+k4pXQ4E mtDqzv5wGs9Uy5RpqvqQa1vV9Fxt12lIapZc2ogj113QzxeT9y6F7wc5uKGG9ZKEzPmV qcOWFJwyfUtWHgcDdF4zXBuQFv7DkiPlZCI0EQqaNTbR3kdI+urenyGvrlHNW7uQS8la atVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764123204; x=1764728004; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/6Ktrx/UQXxQ+qDpf8ETJ4IOmhLU/ttIqJExJUB/Co0=; b=kdEfCQ0QvlzMZbBnQypw5VFsxfvbdQQYa7zw2i/6zBbkrkw1BV+900+eKAT605kbs/ Y/5rm+6NfcI9r1AEKd5X6RbVFDO4eRedPZdou9CKITkAxAh7lEsqufymDVZ77KMN3pPY VTlPaO+4UlXtOlHsQtgE+inIwyqQrBOEqj3nWjZlo3UrMdiLOBdQIFE6JnkcBWQlSZ5H gdhSIdYwpUsUA/fvQXw1PmdHSuNtNnSkvF/c6OHKNVQH11u4dlU5KmJh3VZXf7JT0d0G yELL7mdippAO0OwNkuyJGcRi3nX8roEWBiKEz0WjgLTUwQ3n9hvc/dEy8dXAWFJKpGXo juUQ== X-Forwarded-Encrypted: i=1; AJvYcCU6YM6ZTQWxjgyN+DpOkgtAT5Cabjm7yRJWQPMa0MEZ/5pN8K7IrFN2HEKI45Al9eibUYYJ4XXCp4ZCVGU=@vger.kernel.org X-Gm-Message-State: AOJu0YzjCWwXMrzVnthHxGqwlulr/b7eyFubnPWBTG65wfLBf2BuOfQp hI5ydmgySOEMs6WQP4pQib1CHmAj411QBbDvu8c5Bw58CtZiPZKFTloxZj8YOJDVlC4= X-Gm-Gg: ASbGncuccwR0IsPefcQ5c4v6Pv2ZatTtoUotVMuJjYOjEmG/exKRZKZohkbkdLBzV/0 wHFDyAXHTNQ5lsohnp1iJmnu/bYnqvfvTi/lzwfxjCOPbZTPcCSPTpL+ceU8K9FDCxnlYchfGI6 DYkuqI2OQNdrGnY8y43si+Owvj9joamuB6RhxH7i6sirHcDkxhyzavUOGBFDKQqrwI7hlmhKACC Qe9lpcD19NJd3yLpL1+C/TBMN06F1Zcbulm6i+rTTv7qrTDkMWu0f/QODNztLtGENNEYdLrCk86 08Wy/1I40YOZd8o4B3T8iV13bm5Flik+OWvuC5zDS7khFvM3i7cSuhfP2lSUv5U1K6We+u8Wi4f V4+sQSJcl7S425mSJ0st1Q1W4g5UxDf9Vkx9LzodNAnxLiHQhBQ5SouMJagr+lf0ca3FSW0DfOM M/hIHH2W3BXRyHosyujbzXZkW6FVu+fj6UhA== X-Google-Smtp-Source: AGHT+IGhlGJPpQ3+vlhHqQlj5aqUn4UV+qpX9NaUrwXRBSwz4d1DrNZ/KHjJ/B/28fdUcg/Ys0VOZQ== X-Received: by 2002:a05:7022:4297:b0:11b:9386:a381 with SMTP id a92af1059eb24-11c9d871990mr13646494c88.48.1764123204091; Tue, 25 Nov 2025 18:13:24 -0800 (PST) Received: from apollo.purestorage.com ([208.88.152.253]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-11cc631c236sm17922979c88.7.2025.11.25.18.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 18:13:23 -0800 (PST) From: Mohamed Khalfella To: Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg Cc: Aaron Dailey , Randy Jennings , John Meneghini , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Mohamed Khalfella Subject: [RFC PATCH 03/14] nvmet: Implement CCR nvme command Date: Tue, 25 Nov 2025 18:11:50 -0800 Message-ID: <20251126021250.2583630-4-mkhalfella@purestorage.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251126021250.2583630-1-mkhalfella@purestorage.com> References: <20251126021250.2583630-1-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Defined by TP8028 Rapid Path Failure Recovery, CCR (Cross-Controller Reset) command is an nvme command the is issued to source controller by initiator to reset impacted controller. Implement CCR command for linux nvme target. Signed-off-by: Mohamed Khalfella --- drivers/nvme/target/admin-cmd.c | 79 +++++++++++++++++++++++++++++++++ drivers/nvme/target/core.c | 69 ++++++++++++++++++++++++++++ drivers/nvme/target/nvmet.h | 13 ++++++ include/linux/nvme.h | 23 ++++++++++ 4 files changed, 184 insertions(+) diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cm= d.c index aaceb697e4d2..a55ca010d34f 100644 --- a/drivers/nvme/target/admin-cmd.c +++ b/drivers/nvme/target/admin-cmd.c @@ -376,7 +376,9 @@ static void nvmet_get_cmd_effects_admin(struct nvmet_ct= rl *ctrl, log->acs[nvme_admin_get_features] =3D log->acs[nvme_admin_async_event] =3D log->acs[nvme_admin_keep_alive] =3D + log->acs[nvme_admin_cross_ctrl_reset] =3D cpu_to_le32(NVME_CMD_EFFECTS_CSUPP); + } =20 static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log) @@ -1615,6 +1617,80 @@ void nvmet_execute_keep_alive(struct nvmet_req *req) nvmet_req_complete(req, status); } =20 +void nvmet_execute_cross_ctrl_reset(struct nvmet_req *req) +{ + struct nvmet_ctrl *ictrl, *ctrl =3D req->sq->ctrl; + struct nvme_command *cmd =3D req->cmd; + struct nvmet_ccr *ccr, *new_ccr; + int ccr_active, ccr_total; + u16 cntlid, status =3D 0; + + cntlid =3D le16_to_cpu(cmd->ccr.icid); + if (ctrl->cntlid =3D=3D cntlid) { + req->error_loc =3D + offsetof(struct nvme_cross_ctrl_reset_cmd, icid); + status =3D NVME_SC_INVALID_FIELD | NVME_STATUS_DNR; + goto out; + } + + ictrl =3D nvmet_ctrl_find_get_ccr(ctrl->subsys, ctrl->hostnqn, + cmd->ccr.ciu, cntlid, + le64_to_cpu(cmd->ccr.cirn)); + if (!ictrl) { + /* Immediate Reset Successful */ + nvmet_set_result(req, 1); + status =3D NVME_SC_SUCCESS; + goto out; + } + + new_ccr =3D kmalloc(sizeof(*ccr), GFP_KERNEL); + if (!new_ccr) { + status =3D NVME_SC_INTERNAL; + goto out_put_ctrl; + } + + ccr_total =3D ccr_active =3D 0; + mutex_lock(&ctrl->lock); + list_for_each_entry(ccr, &ctrl->ccrs, entry) { + if (ccr->ctrl =3D=3D ictrl) { + status =3D NVME_SC_CCR_IN_PROGRESS | NVME_STATUS_DNR; + goto out_unlock; + } + + ccr_total++; + if (ccr->ctrl) + ccr_active++; + } + + if (ccr_active >=3D NVMF_CCR_LIMIT) { + status =3D NVME_SC_CCR_LIMIT_EXCEEDED; + goto out_unlock; + } + if (ccr_total >=3D NVMF_CCR_PER_PAGE) { + status =3D NVME_SC_CCR_LOGPAGE_FULL; + goto out_unlock; + } + + new_ccr->ciu =3D cmd->ccr.ciu; + new_ccr->icid =3D cntlid; + new_ccr->ctrl =3D ictrl; + list_add_tail(&new_ccr->entry, &ctrl->ccrs); + mutex_unlock(&ctrl->lock); + + nvmet_ctrl_fatal_error(ictrl); + nvmet_ctrl_put(ictrl); + nvmet_req_complete(req, 0); + return; + +out_unlock: + mutex_unlock(&ctrl->lock); + kfree(new_ccr); +out_put_ctrl: + nvmet_ctrl_put(ictrl); +out: + nvmet_req_complete(req, status); +} + u32 nvmet_admin_cmd_data_len(struct nvmet_req *req) { struct nvme_command *cmd =3D req->cmd; @@ -1692,6 +1768,9 @@ u16 nvmet_parse_admin_cmd(struct nvmet_req *req) case nvme_admin_keep_alive: req->execute =3D nvmet_execute_keep_alive; return 0; + case nvme_admin_cross_ctrl_reset: + req->execute =3D nvmet_execute_cross_ctrl_reset; + return 0; default: return nvmet_report_invalid_opcode(req); } diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index 409928202503..7dbe9255ff42 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -114,6 +114,20 @@ u16 nvmet_zero_sgl(struct nvmet_req *req, off_t off, s= ize_t len) return 0; } =20 +void nvmet_ctrl_cleanup_ccrs(struct nvmet_ctrl *ctrl, bool all) +{ + struct nvmet_ccr *ccr, *tmp; + + lockdep_assert_held(&ctrl->lock); + + list_for_each_entry_safe(ccr, tmp, &ctrl->ccrs, entry) { + if (all || ccr->ctrl =3D=3D NULL) { + list_del(&ccr->entry); + kfree(ccr); + } + } +} + static u32 nvmet_max_nsid(struct nvmet_subsys *subsys) { struct nvmet_ns *cur; @@ -1396,6 +1410,7 @@ static void nvmet_start_ctrl(struct nvmet_ctrl *ctrl) if (!nvmet_is_disc_subsys(ctrl->subsys)) { ctrl->uniquifier =3D ((u8)(ctrl->uniquifier + 1)) ? : 1; ctrl->random =3D get_random_u64(); + nvmet_ctrl_cleanup_ccrs(ctrl, false); } ctrl->csts =3D NVME_CSTS_RDY; =20 @@ -1501,6 +1516,38 @@ struct nvmet_ctrl *nvmet_ctrl_find_get(const char *s= ubsysnqn, return ctrl; } =20 +struct nvmet_ctrl *nvmet_ctrl_find_get_ccr(struct nvmet_subsys *subsys, + const char *hostnqn, u8 ciu, + u16 cntlid, u64 cirn) +{ + struct nvmet_ctrl *ctrl; + bool found =3D false; + + mutex_lock(&subsys->lock); + list_for_each_entry(ctrl, &subsys->ctrls, subsys_entry) { + if (ctrl->cntlid !=3D cntlid) + continue; + if (strncmp(ctrl->hostnqn, hostnqn, NVMF_NQN_SIZE)) + continue; + + /* Avoid racing with a controller that is becoming ready */ + mutex_lock(&ctrl->lock); + if (ctrl->uniquifier =3D=3D ciu && ctrl->random =3D=3D cirn) + found =3D true; + mutex_unlock(&ctrl->lock); + + if (found) { + if (kref_get_unless_zero(&ctrl->ref)) + goto out; + break; + } + }; + ctrl =3D NULL; +out: + mutex_unlock(&subsys->lock); + return ctrl; +} + u16 nvmet_check_ctrl_status(struct nvmet_req *req) { if (unlikely(!(req->sq->ctrl->cc & NVME_CC_ENABLE))) { @@ -1626,6 +1673,7 @@ struct nvmet_ctrl *nvmet_alloc_ctrl(struct nvmet_allo= c_ctrl_args *args) subsys->clear_ids =3D 1; #endif =20 + INIT_LIST_HEAD(&ctrl->ccrs); INIT_WORK(&ctrl->async_event_work, nvmet_async_event_work); INIT_LIST_HEAD(&ctrl->async_events); INIT_RADIX_TREE(&ctrl->p2p_ns_map, GFP_KERNEL); @@ -1740,12 +1788,33 @@ struct nvmet_ctrl *nvmet_alloc_ctrl(struct nvmet_al= loc_ctrl_args *args) } EXPORT_SYMBOL_GPL(nvmet_alloc_ctrl); =20 +static void nvmet_ctrl_complete_pending_ccr(struct nvmet_ctrl *ctrl) +{ + struct nvmet_subsys *subsys =3D ctrl->subsys; + struct nvmet_ctrl *sctrl; + struct nvmet_ccr *ccr; + + mutex_lock(&ctrl->lock); + nvmet_ctrl_cleanup_ccrs(ctrl, true); + mutex_unlock(&ctrl->lock); + + list_for_each_entry(sctrl, &subsys->ctrls, subsys_entry) { + mutex_lock(&sctrl->lock); + list_for_each_entry(ccr, &sctrl->ccrs, entry) { + if (ccr->ctrl =3D=3D ctrl) + ccr->ctrl =3D NULL; + } + mutex_unlock(&sctrl->lock); + } +} + static void nvmet_ctrl_free(struct kref *ref) { struct nvmet_ctrl *ctrl =3D container_of(ref, struct nvmet_ctrl, ref); struct nvmet_subsys *subsys =3D ctrl->subsys; =20 mutex_lock(&subsys->lock); + nvmet_ctrl_complete_pending_ccr(ctrl); nvmet_ctrl_destroy_pr(ctrl); nvmet_release_p2p_ns_map(ctrl); list_del(&ctrl->subsys_entry); diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h index 4195c9eff1da..6c0091b8af8b 100644 --- a/drivers/nvme/target/nvmet.h +++ b/drivers/nvme/target/nvmet.h @@ -267,6 +267,7 @@ struct nvmet_ctrl { u32 kato; u64 random; =20 + struct list_head ccrs; struct nvmet_port *port; =20 u32 aen_enabled; @@ -314,6 +315,13 @@ struct nvmet_ctrl { struct nvmet_pr_log_mgr pr_log_mgr; }; =20 +struct nvmet_ccr { + struct nvmet_ctrl *ctrl; + struct list_head entry; + u16 icid; + u8 ciu; +}; + struct nvmet_subsys { enum nvme_subsys_type type; =20 @@ -576,6 +584,7 @@ void nvmet_req_free_sgls(struct nvmet_req *req); void nvmet_execute_set_features(struct nvmet_req *req); void nvmet_execute_get_features(struct nvmet_req *req); void nvmet_execute_keep_alive(struct nvmet_req *req); +void nvmet_execute_cross_ctrl_reset(struct nvmet_req *req); =20 u16 nvmet_check_cqid(struct nvmet_ctrl *ctrl, u16 cqid, bool create); u16 nvmet_check_io_cqid(struct nvmet_ctrl *ctrl, u16 cqid, bool create); @@ -618,6 +627,10 @@ struct nvmet_ctrl *nvmet_alloc_ctrl(struct nvmet_alloc= _ctrl_args *args); struct nvmet_ctrl *nvmet_ctrl_find_get(const char *subsysnqn, const char *hostnqn, u16 cntlid, struct nvmet_req *req); +struct nvmet_ctrl *nvmet_ctrl_find_get_ccr(struct nvmet_subsys *subsys, + const char *hostnqn, u8 ciu, + u16 cntlid, u64 cirn); +void nvmet_ctrl_cleanup_ccrs(struct nvmet_ctrl *ctrl, bool all); void nvmet_ctrl_put(struct nvmet_ctrl *ctrl); u16 nvmet_check_ctrl_status(struct nvmet_req *req); ssize_t nvmet_ctrl_host_traddr(struct nvmet_ctrl *ctrl, diff --git a/include/linux/nvme.h b/include/linux/nvme.h index 5135cdc3c120..0f305b317aa3 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -23,6 +23,7 @@ =20 #define NVMF_CQT_MS 0 #define NVMF_CCR_LIMIT 4 +#define NVMF_CCR_PER_PAGE 511 =20 #define NVME_DISC_SUBSYS_NAME "nqn.2014-08.org.nvmexpress.discovery" =20 @@ -1225,6 +1226,22 @@ struct nvme_zone_mgmt_recv_cmd { __le32 cdw14[2]; }; =20 +struct nvme_cross_ctrl_reset_cmd { + __u8 opcode; + __u8 flags; + __u16 command_id; + __le32 nsid; + __le64 rsvd2[2]; + union nvme_data_ptr dptr; + __u8 rsvd10; + __u8 ciu; + __le16 icid; + __le32 cdw11; + __le64 cirn; + __le32 cdw14; + __le32 cdw15; +}; + struct nvme_io_mgmt_recv_cmd { __u8 opcode; __u8 flags; @@ -1323,6 +1340,7 @@ enum nvme_admin_opcode { nvme_admin_virtual_mgmt =3D 0x1c, nvme_admin_nvme_mi_send =3D 0x1d, nvme_admin_nvme_mi_recv =3D 0x1e, + nvme_admin_cross_ctrl_reset =3D 0x38, nvme_admin_dbbuf =3D 0x7C, nvme_admin_format_nvm =3D 0x80, nvme_admin_security_send =3D 0x81, @@ -1356,6 +1374,7 @@ enum nvme_admin_opcode { nvme_admin_opcode_name(nvme_admin_virtual_mgmt), \ nvme_admin_opcode_name(nvme_admin_nvme_mi_send), \ nvme_admin_opcode_name(nvme_admin_nvme_mi_recv), \ + nvme_admin_opcode_name(nvme_admin_cross_ctrl_reset), \ nvme_admin_opcode_name(nvme_admin_dbbuf), \ nvme_admin_opcode_name(nvme_admin_format_nvm), \ nvme_admin_opcode_name(nvme_admin_security_send), \ @@ -2009,6 +2028,7 @@ struct nvme_command { struct nvme_dbbuf dbbuf; struct nvme_directive_cmd directive; struct nvme_io_mgmt_recv_cmd imr; + struct nvme_cross_ctrl_reset_cmd ccr; }; }; =20 @@ -2173,6 +2193,9 @@ enum { NVME_SC_PMR_SAN_PROHIBITED =3D 0x123, NVME_SC_ANA_GROUP_ID_INVALID =3D 0x124, NVME_SC_ANA_ATTACH_FAILED =3D 0x125, + NVME_SC_CCR_IN_PROGRESS =3D 0x13f, + NVME_SC_CCR_LOGPAGE_FULL =3D 0x140, + NVME_SC_CCR_LIMIT_EXCEEDED =3D 0x141, =20 /* * I/O Command Set Specific - NVM commands: --=20 2.51.2