From nobody Mon Dec 1 23:06:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 038ED324B27 for ; Wed, 26 Nov 2025 11:37:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764157063; cv=none; b=F2Kt0RYwKXD0obbESM2WOVQy77xftg9sY7EnHPlS4IMLIXPjBl6wT/zgfyWi//mgBh93RjGSc/foN+wi9yR8AfurnPgSEiLM0Kt8MDNA1ywFGa25Yyy0Owqr1A+5XIM+nlDJqZ3mDKAvNb3alzL0t+SqeMyMTRosdEu1USE2QVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764157063; c=relaxed/simple; bh=jgD1fW2/HmiwQtjECStW5RTYnv3ytPfWP7KQC+fNINs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I4Wl7oVGMcy0FjUIxXzD7KelRgCUz3HoCbvktDuuWzgUx72ULabldYLp6xMBbxq2KOmfkAYJE94ycl4IwD70MBjpPuFxoIyrKpWJZ5iB6utxGJS2abCrIJCa4836FxiEwboIcWOIETqDEisi1Ia8GHI8lXx/n2E23ZNRj4BgmvY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=S5l1jj/b; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="S5l1jj/b" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764157062; x=1795693062; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=jgD1fW2/HmiwQtjECStW5RTYnv3ytPfWP7KQC+fNINs=; b=S5l1jj/bRB/InSbpNqzYvKiHl37gN8fhV1EJKKkwB7/y/WdJovO38x0K L3y/JClTOzYtDIROgdz4LjlOBjy+fR+fmdvvN8PoINOcxIEnMtUkZnyPC 7Ro2EFr62gyDIcmczS0aHSZJlUz6BxbTMd8ltewVslr6CUqpjtn3tnF3P v/NxIKfkdVp4SLdLOnanpK83I2sC1vUpa3o5yusqo5ZRqPYbrp/vAe3HC KJQpXCeZM/nL9fr9XyV+0Pk09SENNF/Ngx/ybTegysuMxH0Nu6UYmHFOt Mncv3aUIpFIZ7lvSVAQO2XdfOrPcMo8Pw0X8y0aSp5jPQl9Obs9glNBvj g==; X-CSE-ConnectionGUID: dQQbn3FJS/mmSZG+hfFOpA== X-CSE-MsgGUID: lUAhx9MmRnCqY7tQxInBuw== X-IronPort-AV: E=McAfee;i="6800,10657,11624"; a="66232862" X-IronPort-AV: E=Sophos;i="6.20,228,1758610800"; d="scan'208";a="66232862" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2025 03:37:41 -0800 X-CSE-ConnectionGUID: Wjwwe9UtSAuXoLbp68iXYA== X-CSE-MsgGUID: +97oJy7dTB6CO2q43/wzxA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,228,1758610800"; d="scan'208";a="192804460" Received: from lab-ah.igk.intel.com (HELO [127.0.1.1]) ([10.211.135.228]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2025 03:37:38 -0800 From: Andrzej Hajda Date: Wed, 26 Nov 2025 12:35:51 +0100 Subject: [PATCH 3/3] mm: use va_format_call helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251126-va_format_call-v1-3-8a604a331730@intel.com> References: <20251126-va_format_call-v1-0-8a604a331730@intel.com> In-Reply-To: <20251126-va_format_call-v1-0-8a604a331730@intel.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrzej Hajda X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2042; i=andrzej.hajda@intel.com; h=from:subject:message-id; bh=jgD1fW2/HmiwQtjECStW5RTYnv3ytPfWP7KQC+fNINs=; b=owEB7QES/pANAwAKASNispPeEP3XAcsmYgBpJuYy2Ei6pVpq+iRT+RUcGLhV1Bwx4jcAkAWTh a8DmOLnXkCJAbMEAAEKAB0WIQT8qEQxNN2/XeF/A00jYrKT3hD91wUCaSbmMgAKCRAjYrKT3hD9 1/1gDACkRt84YmIuBQkH5H9hpmGVce17KJ4r7+jlDuEjOzARqk/eHfLsHXLwKmuPtk1ghXZg4AH 2ZWATLpMWyV32IszDPayMMeaTzZe9ZfLE/LIIzIoAlq+MEJP0HXUr/gmtV9isvmPeoqGBXj6zGK 56JRKibprYT36I0g2TN/vrk9ot80JF0LHoEZs+33/eeH3hd5MSV1u7RwSWscWIRYOR6PIwvrt9F 9IiN8zSF2DGAU/mobMIqc7P+niqk4xghBSzrJqmpX9vhFFcY1e0v9fBX2gAjCmGD61wrlcjELta YFPFj8D4317nIgLMz61sJa80287j76pv0vBF/sukBVuz9KGXewTz0URKupUMKJ73Av1pHaOBxTp T/R+akb79tvC73Pi/x+Gky32njCrMz9+ZG+OMHEkpOPUDaw01XB0KggMkkrllbR1KNGGb9H9HGO l54XNmeEiFrsyXFLPisGOsIR4J+mENyvMGsSe2B+enswYyDhaJqdYSKTIO8/K+vkZt5C4= X-Developer-Key: i=andrzej.hajda@intel.com; a=openpgp; fpr=FCA8443134DDBF5DE17F034D2362B293DE10FDD7 It simplifies the code and makes it more clear. Signed-off-by: Andrzej Hajda --- mm/page_alloc.c | 14 ++++---------- mm/slub.c | 10 +--------- 2 files changed, 5 insertions(+), 19 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index ed82ee55e66afffafcf6360b13da410119f2898d..cd0b17ea4de0a3262fae117fac7= f427a7396978f 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3940,22 +3940,16 @@ static void warn_alloc_show_mem(gfp_t gfp_mask, nod= emask_t *nodemask) =20 void warn_alloc(gfp_t gfp_mask, nodemask_t *nodemask, const char *fmt, ...) { - struct va_format vaf; - va_list args; static DEFINE_RATELIMIT_STATE(nopage_rs, 10*HZ, 1); =20 if ((gfp_mask & __GFP_NOWARN) || !__ratelimit(&nopage_rs) || ((gfp_mask & __GFP_DMA) && !has_managed_dma())) return; - - va_start(args, fmt); - vaf.fmt =3D fmt; - vaf.va =3D &args; - pr_warn("%s: %pV, mode:%#x(%pGg), nodemask=3D%*pbl", - current->comm, &vaf, gfp_mask, &gfp_mask, - nodemask_pr_args(nodemask)); - va_end(args); + va_format_call(fmt, pr_warn, + "%s: %pV, mode:%#x(%pGg), nodemask=3D%*pbl", + current->comm, va_format_arg, gfp_mask, &gfp_mask, + nodemask_pr_args(nodemask)); =20 cpuset_print_current_mems_allowed(); pr_cont("\n"); diff --git a/mm/slub.c b/mm/slub.c index 1a5fc34290421ea32e6f5bba8acc87b53a9774b5..786c5a4195d44d5c40b3c9009ff= 52a3b836bfe23 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1161,17 +1161,9 @@ static void slab_bug(struct kmem_cache *s, const cha= r *fmt, ...) __printf(2, 3) static void slab_fix(struct kmem_cache *s, const char *fmt, ...) { - struct va_format vaf; - va_list args; - if (slab_add_kunit_errors()) return; - - va_start(args, fmt); - vaf.fmt =3D fmt; - vaf.va =3D &args; - pr_err("FIX %s: %pV\n", s->name, &vaf); - va_end(args); + va_format_call(fmt, pr_err, "FIX %s: %pV\n", s->name, va_format_arg); } =20 static void print_trailer(struct kmem_cache *s, struct slab *slab, u8 *p) --=20 2.43.0