From nobody Mon Dec 1 22:41:30 2025 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F5AE1E231E for ; Wed, 26 Nov 2025 17:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764176675; cv=none; b=p4iW/gPXx5on+W1cr2n6kUzKa8opjBeKiLj0QW7XFYrf5r3CxllL/EGINDV/qbsNVoEw951xY61gQ68HTaHGPOo5UccmDxG0IFcLZhfCt8xqb+hxDDAiapUIUTqsvvLtzpRDCjseF6fQlJNe+GCd4PnfY3Qg8FDIbZ7tYJmkVvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764176675; c=relaxed/simple; bh=SvHp0h8NsklocbzdYY7aO2MNGJqdaiMnGBPKE+inQoo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Bxwxlxz1Rfry1Xr00Ce8OpVKMKkQ5e5PkgHUVlYT6+hZUCXbY73Nf0yGBruNE6UcF4N+pfOiVX0O4YQ+wwzCq3dA1wiDMIGwXXSagKuEj2SZDberTkMGS8ET21pLk8M/OcwP3VClCg42ffbpgmLr8KVPO+mQP2JcQC6pQl8kjMY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i9Cobk35; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i9Cobk35" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-42b379cd896so25920f8f.3 for ; Wed, 26 Nov 2025 09:04:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764176672; x=1764781472; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=z0OD6Tul6N7Ac9c9vQK1/GWaIUr26ez2juaXAYXKN8s=; b=i9Cobk35VSAQcQDUMnk0d3azjKECnEC+lQ5ydt+7avRAxWEwW9AQgfbGKE6GaMIFQu hSb7sbeNsel4TnKXALOCb1QnALEU+ZIiEmHqtzhFNIQIPe9AEzZNYVZDYU6/wUE2IIEr eJ1UL9t5jPR1T4MBWzxsa9xnaM9lNFAsbNb/OH3aQF1ps9prR8EbGd/Z3woSJHkT+M4L nhXRFT+qpHIp3xZbHVmvQesOe60T1hYm+PQgnqweFMvwJxeCd3lnDWUFDTzyWhcZnBQC OHQt/PbiFd/HARAPvsL+hZEpiEV0Lel9C6mtllA02DXi3zzfG9tsbWZErvB3NmqskkTw 3TbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764176672; x=1764781472; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=z0OD6Tul6N7Ac9c9vQK1/GWaIUr26ez2juaXAYXKN8s=; b=XqKk9zYo1b3ARz4K9xTZsEw92fbsMihnxJvbMLy5s93XPGHU4RT8Zh5a4TeF88nFoZ 97JOxd/qSl45TOq8RjusGesCxktRjVM/kleqkcmRAmyc6/sGqQ2VvCuSdd0Z4Dp1oYQt IECUYVOMcMiNiVOnSmd12Viy3OG235kFcfLe77Zij5S8tG3CuAINNOiasyO8Cf1yOkLx 075TUSFtns6HPA8Ju1aQaYEqaR9tebREQct/K2A/LXdArWg8vhg+169BHCLpK7rhTP2M w92mJHSXiAo0oJE5XjiQTpfWZPG93HMYISg0bYcXgKEuPcKndXDWLReG988P9tx+tWri WYsg== X-Gm-Message-State: AOJu0YwnEbGLXl17mEyW3uKGGES/38C0gEB2BZ8YEtwwSesaDaTATXWL nKLEk9t8FuceLI/yRth6FntaJFUCJaW/IJ8feviL/X46FN5PKLbCqbQg X-Gm-Gg: ASbGncu2cQmZ3DJc62HNsa8RizQCQ29mKALgSiU93xEFlOzgx6XkERjMYCmp5JKF+ql /Ahag/kJAzr5jg1R8nO0U6YY/N9k6GDrsv+ytYXc4yiblSu24xwIqVIukrKeZlVcvVULd+/5pUh Fgk73chW8GzSp2VIp4l6+AbcwOOPs/lcriT3m+WFme537K54jhAloaYixK/M0WPFWVwWvgK3L7+ Om75pvomuwtOvnPXC8wiBABBI9wP6Za18n5+aqqgj2Qx6QeiJqDx/E0LV2cAgCMQkR9xNGOgFB6 MqQg/i2Y+61BBLSiECIyGRDP0P3q0/94mNopZtxksofqg3jRomc3KTukF7U2oTDj56muGLflNkt unLrEIKJNDikfBqfukNucU9KfXWKgv4I+ug1Px7TIFKi+3/fkoo9bQanRVJQv0oZ08VffJQqzVw 1BaQs+TV3eIra90qSlCcEO/POBqqadZZ6fH4rgcE/81Es3eZ4KaSbP X-Google-Smtp-Source: AGHT+IGuGmBOIwj1mx/KDvXaUjKyWYx4qrXMEWM/RRovenW6LKvpiCaIe8KXa+I1aqRc59MHCZfA+Q== X-Received: by 2002:a5d:5888:0:b0:42b:3b55:8908 with SMTP id ffacd0b85a97d-42cc1d22c70mr20850453f8f.51.1764176671730; Wed, 26 Nov 2025 09:04:31 -0800 (PST) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([5.225.141.247]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f2e574sm41252799f8f.3.2025.11.26.09.04.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 09:04:31 -0800 (PST) From: Iker Pedrosa Date: Wed, 26 Nov 2025 18:03:49 +0100 Subject: [PATCH v5 1/3] dt-bindings: display: sitronix,st7920: Add DT schema Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251126-st7920-v5-1-64eda5267d35@gmail.com> References: <20251126-st7920-v5-0-64eda5267d35@gmail.com> In-Reply-To: <20251126-st7920-v5-0-64eda5267d35@gmail.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Javier Martinez Canillas , Iker Pedrosa Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 Add binding for Sitronix ST7920 display. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Iker Pedrosa --- .../bindings/display/sitronix,st7920.yaml | 58 ++++++++++++++++++= ++++ 1 file changed, 58 insertions(+) diff --git a/Documentation/devicetree/bindings/display/sitronix,st7920.yaml= b/Documentation/devicetree/bindings/display/sitronix,st7920.yaml new file mode 100644 index 0000000000000000000000000000000000000000..c4f006fc41e1f472939725bd82b= 86a649f9b3f56 --- /dev/null +++ b/Documentation/devicetree/bindings/display/sitronix,st7920.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/sitronix,st7920.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sitronix ST7920 LCD Display Controllers + +maintainers: + - Iker Pedrosa + +description: + The Sitronix ST7920 is a controller for monochrome dot-matrix graphical = LCDs, + most commonly used for 128x64 pixel displays. + +properties: + compatible: + const: sitronix,st7920 + + reg: + maxItems: 1 + + vdd-supply: + description: Regulator that provides 5V Vdd power supply + + reset-gpios: + maxItems: 1 + + spi-max-frequency: + maximum: 600000 + +required: + - compatible + - reg + - spi-max-frequency + +allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +unevaluatedProperties: false + +examples: + - | + #include + + spi { + #address-cells =3D <1>; + #size-cells =3D <0>; + + display@0 { + compatible =3D "sitronix,st7920"; + reg =3D <0>; + vdd-supply =3D <®_5v>; + reset-gpios =3D <&gpio 25 GPIO_ACTIVE_LOW>; + spi-max-frequency =3D <600000>; + spi-cs-high; + }; + }; --=20 2.52.0 From nobody Mon Dec 1 22:41:30 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15C8133DEFD for ; Wed, 26 Nov 2025 17:04:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764176678; cv=none; b=PaHFZHpMgyZ5Zv/PHz42+AqRuESzsTbPZ13fbQgcBAOb9YxMMXaUGJOX4+PlxqDmOubOuR+0Z7mnIJxioMOHX7+nqsBI1pIYq5/v+InkW9bbKr0Me4T4o4yyCtxXpmAybSoc96eJe3Kw3IzD6Ocep1ocvgHIOcS5/hTQZJbT2+k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764176678; c=relaxed/simple; bh=ydoz8UnbFW6GoMi6Ii5X3wE2LrRLHkV3a8TebygqBCg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QbIR+yE7rkO2eND/k4AIPZNMgpIPlu9gznV36kP0Qxwgk7F1cqo0jEhxAnbgQQs6fpvpWm9e3YH7spjMJQVMMGEKt45GfXYOGUpU7E3zILKQCCOZoJ7gPLoizxM9yOs70YX0UY8h3EuzzW/ZOcnasZ4OoHGZaGIoM9BYaYzdXoQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DNCOz28R; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DNCOz28R" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-42b47f662a0so601691f8f.0 for ; Wed, 26 Nov 2025 09:04:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764176673; x=1764781473; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7njXWkNiQMXNgzwMMr2wixORggvT5ewyZiYKwdan8DI=; b=DNCOz28RNf7RN1CX/mSMYa6hVlJoGjfqGYCDqxhoHxeWbZf091cCrwMsHVt7XPOhQB 5tbel4SkRQOjWh5N5WhkC4PdrlUzKYtqpS4H09qWd0O3dWgBp48R0QRC/OqcZmNf+CrT 6r710V0oOUMRUJ3z2nvXa+BFgyaFABBJij6TuLtArc/32OLMJxlp+y03XVoZWILgm3DC TWphCzM5bwK4c9iqGvRfceWvzuC9wFaYwUY/YQHKw29flDeqwXYHRxYrYTwW+fZ6GhhO 0DSkZBMeiDGuzihAFe4gT0XFHz4CGVQeScWcLCwTbvyggTzk0xWDFSKHtuEIlDCFvpF8 wryg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764176673; x=1764781473; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7njXWkNiQMXNgzwMMr2wixORggvT5ewyZiYKwdan8DI=; b=c01+2RK9MAxLqWbhi896hTm7BuQe3F2fe5rKMfAYngGYrx2KYRmDwKVTFtn6hSoVV8 x9m1DcdntTxwcvzC4UqElqKQYmjNKnquslUePmqWmDXn5lpvDWQboE0TnY60Ut0r3TW+ feNAoSQPO6P2XiwT3U50A0aHFGZM2lx9t1MuyjAIe/eQ3oCDSbjXC9fxop7+cCujWmoO oJflf+bCna0Y81qXapOZDMqFmilUGx5C2Mum6vuOihQ0Bm/XsXd0AqiEhq0nZJf9Xbcv xNfE/A64OTt9+ju6xE8hlK9KGqquM4GMQHjM5Iq6VFfhO9ecXMT6BlyFCcEWYhBOGe5J js6Q== X-Gm-Message-State: AOJu0Yz0sbnOyWmEpJHJ/srQHjti8sFi1Vhr26L/Uf0VIr7ZoI/n02Vv UgzfB+If8rGpkJiyu15omp4w44IuTpvxLzaIdiVeoQDjSUIrTLRJEBvx X-Gm-Gg: ASbGncuCB3LJweSyS984KvDa2qO574q1SOPeZC7tJiTqOqU2jsIEyMFWdRUVBamKgtE 4g2vKtXJrGwTtOuAS3Wk1PzhbJ87U05QnFGBQkwD1p3uk5hngbVz6DRRFMn66RQ50kZpnSJWlHn tz7xCtyfEaVf15OqfX1w39gYMNGb9UlcQYgw6Im8Rv0DFrzfyp6Ier76vpBWjgG1XxJtmKOGcjL n68BXtP8LuE7gdn4I8Nkg4Kfhs4IveRPILTCgvGGR8lmyC4wXN7YDiO9TZ6fjOfclr92IUgyTWa lBmo+wtHj8kfc9SYleRYox0450ZIrhoIqISIwZPXSaiJMfjdnWnJ9891A7o/xc7UuN+bh2AAG5D xE3/igsMMqe1rFN1c2J+96ECysakG/j4allnrMVq6fjgRTgFjN4y106MVMZMnVIUIv42QdwlQp8 KQVqQgXH1Cng9VFVF/CJ6jld61399tnM/UMrgI/43ir8FHpEWNwtJ5 X-Google-Smtp-Source: AGHT+IHgur49RVBrk1Kx4FGjswY5KgJw3E1REp/s36+FqDL5ZRMWA6UpgXiFYReZRBquXrUmgeGxmQ== X-Received: by 2002:a05:6000:1844:b0:429:d4e1:cb9f with SMTP id ffacd0b85a97d-42cc137bd1bmr24213210f8f.22.1764176673126; Wed, 26 Nov 2025 09:04:33 -0800 (PST) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([5.225.141.247]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f2e574sm41252799f8f.3.2025.11.26.09.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 09:04:32 -0800 (PST) From: Iker Pedrosa Date: Wed, 26 Nov 2025 18:03:50 +0100 Subject: [PATCH v5 2/3] drm: Add driver for Sitronix ST7920 LCD displays Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251126-st7920-v5-2-64eda5267d35@gmail.com> References: <20251126-st7920-v5-0-64eda5267d35@gmail.com> In-Reply-To: <20251126-st7920-v5-0-64eda5267d35@gmail.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Javier Martinez Canillas , Iker Pedrosa Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.2 Add a new DRM/KMS driver for displays using the Sitronix ST7920 controller connected via the SPI bus. This provides a standard framebuffer interface for these common monochrome LCDs. Signed-off-by: Iker Pedrosa --- drivers/gpu/drm/sitronix/Kconfig | 10 + drivers/gpu/drm/sitronix/Makefile | 1 + drivers/gpu/drm/sitronix/st7920.c | 866 ++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 877 insertions(+) diff --git a/drivers/gpu/drm/sitronix/Kconfig b/drivers/gpu/drm/sitronix/Kc= onfig index 6de7d92d9b74c72746915b945869dba91f161d2b..f14115350069849b668d75188f6= d504d56fa3dda 100644 --- a/drivers/gpu/drm/sitronix/Kconfig +++ b/drivers/gpu/drm/sitronix/Kconfig @@ -40,3 +40,13 @@ config DRM_ST7735R =20 If M is selected the module will be called st7735r. =20 +config DRM_ST7920 + tristate "DRM support for Sitronix ST7920 LCD displays" + depends on DRM && SPI && MMU + select DRM_GEM_SHMEM_HELPER + select DRM_KMS_HELPER + select REGMAP_SPI + help + DRM driver for the ST7920 Sitronix LCD controllers. + + If M is selected the module will be called st7920. diff --git a/drivers/gpu/drm/sitronix/Makefile b/drivers/gpu/drm/sitronix/M= akefile index bd139e5a6995fa026cc635b3c29782473d1efad7..2f064a518121bfee3cca73acd42= 589e8c54cd4d7 100644 --- a/drivers/gpu/drm/sitronix/Makefile +++ b/drivers/gpu/drm/sitronix/Makefile @@ -1,3 +1,4 @@ obj-$(CONFIG_DRM_ST7571_I2C) +=3D st7571-i2c.o obj-$(CONFIG_DRM_ST7586) +=3D st7586.o obj-$(CONFIG_DRM_ST7735R) +=3D st7735r.o +obj-$(CONFIG_DRM_ST7920)) +=3D st7920.o diff --git a/drivers/gpu/drm/sitronix/st7920.c b/drivers/gpu/drm/sitronix/s= t7920.c new file mode 100644 index 0000000000000000000000000000000000000000..afa266b666f860494ba9dc55646= ee783f036e076 --- /dev/null +++ b/drivers/gpu/drm/sitronix/st7920.c @@ -0,0 +1,866 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * DRM driver for Sitronix ST7920 LCD displays + * + * Copyright 2025 Iker Pedrosa + * + */ + +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define DRIVER_NAME "sitronix_st7920" +#define DRIVER_DESC "DRM driver for Sitronix ST7920 LCD displays" +#define DRIVER_DATE "20250723" +#define DRIVER_MAJOR 1 +#define DRIVER_MINOR 0 + +/* Display organization */ +#define ST7920_PITCH 16 +#define ST7920_SCANLINES 64 +#define BYTES_IN_DISPLAY (ST7920_PITCH * ST7920_SCANLINES) +#define BYTES_IN_SEGMENT 2 +#define PIXELS_PER_SEGMENT (BYTES_IN_SEGMENT * 8) +#define ST7920_DEFAULT_WIDTH 128 +#define ST7920_DEFAULT_HEIGHT 64 + +/* Sync sequence */ +#define SYNC_BITS 0xF8 +#define RW_HIGH 0x04 +#define RS_HIGH 0x02 + +/* Commands */ +#define SET_DISPLAY_ON 0x0C +#define SET_DISPLAY_OFF 0x08 +#define SET_DISPLAY_CLEAR 0x01 +#define SET_BASIC_INSTRUCTION_SET 0x30 +#define SET_EXT_INSTRUCTION_SET 0x34 +#define SET_GRAPHICS_DISPLAY 0x36 +#define SET_GDRAM_ADDRESS 0x80 +#define SET_GDRAM_DATA 0xFF /* Driver internal command */ + +/* Masks */ +#define HIGH_DATA_MASK 0xF0 +#define LOW_DATA_MASK 0x0F +#define TOP_VERTICAL_ADDRESS 0x80 +#define BOTTOM_VERTICAL_ADDRESS 0x60 +#define TOP_HORIZONTAL_ADDRESS 0x00 +#define BOTTOM_HORIZONTAL_ADDRESS 0x80 + +#define CMD_SIZE 35 + +struct spi7920_error { + int errno; +}; + +struct st7920_device { + struct drm_device drm; + struct drm_display_mode mode; + struct drm_plane primary_plane; + struct drm_crtc crtc; + struct drm_encoder encoder; + struct drm_connector connector; + struct spi_device *spi; + + struct regmap *regmap; + + struct gpio_desc *reset_gpio; + + u32 height; + u32 width; +}; + +struct st7920_plane_state { + struct drm_shadow_plane_state base; + /* Intermediate buffer to convert pixels from XRGB8888 to HW format */ + u8 *buffer; +}; + +struct st7920_crtc_state { + struct drm_crtc_state base; + /* Buffer to store pixels in HW format and written to the panel */ + u8 *data_array; +}; + +static inline struct st7920_plane_state *to_st7920_plane_state(struct drm_= plane_state *state) +{ + return container_of(state, struct st7920_plane_state, base.base); +} + +static inline struct st7920_crtc_state *to_st7920_crtc_state(struct drm_cr= tc_state *state) +{ + return container_of(state, struct st7920_crtc_state, base); +} + +static inline struct st7920_device *drm_to_st7920(struct drm_device *drm) +{ + return container_of(drm, struct st7920_device, drm); +} + +static int st7920_store_gdram_address(const void *data, u8 *reg) +{ + const u8 y_addr =3D *(const u8 *)data; + bool bottom_screen =3D (y_addr >=3D 32); + int i =3D 0; + + reg[i++] =3D SYNC_BITS; + /* Set vertical address */ + if (!bottom_screen) + reg[i++] =3D TOP_VERTICAL_ADDRESS + (*(uint8_t *)data & HIGH_DATA_MASK); + else + reg[i++] =3D BOTTOM_VERTICAL_ADDRESS + (*(uint8_t *)data & HIGH_DATA_MAS= K); + + reg[i++] =3D *(uint8_t *)data << 4; + /* Set horizontal address */ + reg[i++] =3D SET_GDRAM_ADDRESS; + if (!bottom_screen) + reg[i++] =3D TOP_HORIZONTAL_ADDRESS; + else + reg[i++] =3D BOTTOM_HORIZONTAL_ADDRESS; + + return i; +} + +static int st7920_store_gdram_data(const void *data, u8 *reg) +{ + const u8 *line_data =3D data; + int i =3D 0, j =3D 0; + + reg[i++] =3D SYNC_BITS | RS_HIGH; + + for (j =3D 0; j < 16; j++) { + reg[i++] =3D line_data[j] & 0xF0; + reg[i++] =3D (line_data[j] << 4) & 0xF0; + } + + return i; +} + +static int st7920_store_others(int cmd, const void *data, u8 *reg) +{ + int i =3D 0; + + reg[i++] =3D SYNC_BITS; + reg[i++] =3D cmd & HIGH_DATA_MASK; + reg[i++] =3D (cmd & LOW_DATA_MASK) << 4; + + return i; +} + +static void st7920_spi_write(struct spi_device *spi, int cmd, const void *= data, + int delay_us, struct spi7920_error *err) +{ + u8 reg[CMD_SIZE] =3D {0}; + int size =3D 0; + int ret; + + if (err->errno) + return; + + /* + * First the sync bits are sent: 11111WS0. + * Where W is the read/write (RW) bit and S is the register/data (RS) bit. + * Then, every 8 bits instruction/data will be separated into 2 groups. + * Higher 4 bits (DB7~DB4) will be placed in the first section followed by + * 4 '0's. And lower 4 bits (DB3~DB0) will be placed in the second section + * followed by 4 '0's. + */ + if (cmd =3D=3D SET_GDRAM_ADDRESS) + size =3D st7920_store_gdram_address(data, reg); + else if (cmd =3D=3D SET_GDRAM_DATA) + size =3D st7920_store_gdram_data(data, reg); + else + size =3D st7920_store_others(cmd, data, reg); + + ret =3D spi_write(spi, reg, size); + if (ret) { + err->errno =3D ret; + return; + } + + if (delay_us) + udelay(delay_us); +} + +static const struct regmap_config st7920_spi_regmap_config =3D { + .reg_bits =3D 8, + .val_bits =3D 8, +}; + +static const struct of_device_id st7920_of_match[] =3D { + /* st7920 family */ + { + .compatible =3D "sitronix,st7920", + }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, st7920_of_match); + +/* + * The SPI core always reports a MODALIAS uevent of the form "spi:", = even + * if the device was registered via OF. This means that the module will no= t be + * auto loaded, unless it contains an alias that matches the MODALIAS repo= rted. + * + * To workaround this issue, add a SPI device ID table. Even when this sho= uld + * not be needed for this driver to match the registered SPI devices. + */ +static const struct spi_device_id st7920_spi_id[] =3D { + /* st7920 family */ + { "st7920", 0 }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(spi, st7920_spi_id); + +static void st7920_power_on(struct st7920_device *st7920, + struct spi7920_error *err) +{ + st7920_spi_write(st7920->spi, SET_DISPLAY_ON, NULL, 72, err); +} + +static void st7920_power_off(struct st7920_device *st7920, + struct spi7920_error *err) +{ + st7920_spi_write(st7920->spi, SET_DISPLAY_CLEAR, NULL, 1600, err); + st7920_spi_write(st7920->spi, SET_DISPLAY_OFF, NULL, 72, err); +} + +static void st7920_hw_reset(struct st7920_device *st7920) +{ + if (!st7920->reset_gpio) + return; + + gpiod_set_value_cansleep(st7920->reset_gpio, 1); + usleep_range(15, 20); + gpiod_set_value_cansleep(st7920->reset_gpio, 0); + msleep(40); +} + +static int st7920_init(struct st7920_device *st7920) +{ + struct spi7920_error err =3D {0}; + + st7920_spi_write(st7920->spi, SET_BASIC_INSTRUCTION_SET, NULL, 72, &err); + st7920_power_on(st7920, &err); + st7920_spi_write(st7920->spi, SET_GRAPHICS_DISPLAY, NULL, 72, &err); + st7920_spi_write(st7920->spi, SET_DISPLAY_CLEAR, NULL, 1600, &err); + + return err.errno; +} + +static int st7920_update_rect(struct st7920_device *st7920, + struct drm_rect *rect, u8 *buf, + u8 *data_array) +{ + struct spi7920_error err; + u32 array_idx =3D 0; + int i, j; + + /* + * The screen is divided in 64(Y)x8(X) segments and each segment is + * further divided in 2 bytes (D15~D0). + * + * Segment 0x0 is in the top-right corner, while segment 63x15 is in the + * bottom-left. They would be displayed in the screen in the following wa= y: + * 0x0 0x1 0x2 ... 0x15 + * 1x0 1x1 1x2 ... 1x15 + * ... + * 63x0 63x1 63x2 ... 63x15 + * + * The data in each byte is big endian. + */ + + for (i =3D 0; i < ST7920_SCANLINES; i++) { + u8 *line_start =3D buf + (i * ST7920_PITCH); + u8 line_buffer[ST7920_PITCH]; + + for (j =3D 0; j < ST7920_PITCH; j++) { + line_buffer[j] =3D bitrev8(line_start[j]); + data_array[array_idx++] =3D line_buffer[j]; + } + + st7920_spi_write(st7920->spi, SET_GDRAM_ADDRESS, &i, 72, &err); + st7920_spi_write(st7920->spi, SET_GDRAM_DATA, line_buffer, 72, &err); + } + + return err.errno; +} + +static void st7920_clear_screen(struct st7920_device *st7920, u8 *data_arr= ay) +{ + struct spi7920_error err; + + memset(data_array, 0, BYTES_IN_DISPLAY); + + st7920_spi_write(st7920->spi, SET_DISPLAY_CLEAR, NULL, 1600, &err); +} + +static int st7920_fb_blit_rect(struct drm_framebuffer *fb, + const struct iosys_map *vmap, + struct drm_rect *rect, + u8 *buf, u8 *data_array, + struct drm_format_conv_state *fmtcnv_state) +{ + struct st7920_device *st7920 =3D drm_to_st7920(fb->dev); + struct iosys_map dst; + unsigned int dst_pitch; + int ret; + + /* Align y to display page boundaries */ + rect->y1 =3D round_down(rect->y1, PIXELS_PER_SEGMENT); + rect->y2 =3D min_t(unsigned int, round_up(rect->y2, PIXELS_PER_SEGMENT), = st7920->height); + + dst_pitch =3D DIV_ROUND_UP(drm_rect_width(rect), 8); + + iosys_map_set_vaddr(&dst, buf); + drm_fb_xrgb8888_to_mono(&dst, &dst_pitch, vmap, fb, rect, fmtcnv_state); + + ret =3D st7920_update_rect(st7920, rect, buf, data_array); + + return ret; +} + +static int st7920_primary_plane_atomic_check(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_device *drm =3D plane->dev; + struct st7920_device *st7920 =3D drm_to_st7920(drm); + struct drm_plane_state *plane_state =3D drm_atomic_get_new_plane_state(st= ate, plane); + struct st7920_plane_state *st7920_state =3D to_st7920_plane_state(plane_s= tate); + struct drm_shadow_plane_state *shadow_plane_state =3D &st7920_state->base; + struct drm_crtc *crtc =3D plane_state->crtc; + struct drm_crtc_state *crtc_state =3D NULL; + const struct drm_format_info *fi; + unsigned int pitch; + int ret; + + if (crtc) + crtc_state =3D drm_atomic_get_new_crtc_state(state, crtc); + + ret =3D drm_atomic_helper_check_plane_state(plane_state, crtc_state, + DRM_PLANE_NO_SCALING, + DRM_PLANE_NO_SCALING, + false, false); + if (ret) + return ret; + else if (!plane_state->visible) + return 0; + + fi =3D drm_format_info(DRM_FORMAT_R1); + if (!fi) + return -EINVAL; + + pitch =3D drm_format_info_min_pitch(fi, 0, st7920->width); + + if (plane_state->fb->format !=3D fi) { + void *buf; + + /* format conversion necessary; reserve buffer */ + buf =3D drm_format_conv_state_reserve(&shadow_plane_state->fmtcnv_state, + pitch, GFP_KERNEL); + if (!buf) + return -ENOMEM; + } + + st7920_state->buffer =3D kcalloc(pitch, st7920->height, GFP_KERNEL); + if (!st7920_state->buffer) + return -ENOMEM; + + return 0; +} + +static void st7920_primary_plane_atomic_update(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_plane_state *plane_state =3D drm_atomic_get_new_plane_state(st= ate, plane); + struct drm_plane_state *old_plane_state =3D drm_atomic_get_old_plane_stat= e(state, plane); + struct drm_shadow_plane_state *shadow_plane_state =3D to_drm_shadow_plane= _state(plane_state); + struct drm_crtc_state *crtc_state =3D drm_atomic_get_new_crtc_state(state= , plane_state->crtc); + struct st7920_crtc_state *st7920_crtc_state =3D to_st7920_crtc_state(crt= c_state); + struct st7920_plane_state *st7920_plane_state =3D to_st7920_plane_state(p= lane_state); + struct drm_framebuffer *fb =3D plane_state->fb; + struct drm_atomic_helper_damage_iter iter; + struct drm_device *drm =3D plane->dev; + struct drm_rect dst_clip; + struct drm_rect damage; + int idx; + int ret; + + if (!drm_dev_enter(drm, &idx)) + return; + + if (drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE) =3D=3D 0) { + drm_atomic_helper_damage_iter_init(&iter, old_plane_state, plane_state); + drm_atomic_for_each_plane_damage(&iter, &damage) { + dst_clip =3D plane_state->dst; + + if (!drm_rect_intersect(&dst_clip, &damage)) + continue; + + ret =3D st7920_fb_blit_rect(fb, &shadow_plane_state->data[0], &dst_clip, + st7920_plane_state->buffer, + st7920_crtc_state->data_array, + &shadow_plane_state->fmtcnv_state); + if (ret) + drm_err_once(plane->dev, "Failed to write to device: %d.\n", ret); + } + + drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE); + } +} + +static void st7920_primary_plane_atomic_disable(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_device *drm =3D plane->dev; + struct st7920_device *st7920 =3D drm_to_st7920(drm); + struct drm_plane_state *plane_state =3D drm_atomic_get_new_plane_state(st= ate, plane); + struct drm_crtc_state *crtc_state; + struct st7920_crtc_state *st7920_crtc_state; + int idx; + + if (!plane_state->crtc) + return; + + crtc_state =3D drm_atomic_get_new_crtc_state(state, plane_state->crtc); + st7920_crtc_state =3D to_st7920_crtc_state(crtc_state); + + if (!drm_dev_enter(drm, &idx)) + return; + + st7920_clear_screen(st7920, st7920_crtc_state->data_array); + + drm_dev_exit(idx); +} + +/* Called during init to allocate the plane's atomic state. */ +static void st7920_primary_plane_reset(struct drm_plane *plane) +{ + struct st7920_plane_state *st7920_state; + + drm_WARN_ON_ONCE(plane->dev, plane->state); + + st7920_state =3D kzalloc(sizeof(*st7920_state), GFP_KERNEL); + if (!st7920_state) + return; + + __drm_gem_reset_shadow_plane(plane, &st7920_state->base); +} + +static struct drm_plane_state *st7920_primary_plane_duplicate_state(struct= drm_plane *plane) +{ + struct drm_shadow_plane_state *new_shadow_plane_state; + struct st7920_plane_state *st7920_state; + + if (drm_WARN_ON_ONCE(plane->dev, !plane->state)) + return NULL; + + st7920_state =3D kzalloc(sizeof(*st7920_state), GFP_KERNEL); + if (!st7920_state) + return NULL; + + new_shadow_plane_state =3D &st7920_state->base; + + __drm_gem_duplicate_shadow_plane_state(plane, new_shadow_plane_state); + + return &new_shadow_plane_state->base; +} + +static void st7920_primary_plane_destroy_state(struct drm_plane *plane, + struct drm_plane_state *state) +{ + struct st7920_plane_state *st7920_state =3D to_st7920_plane_state(state); + + kfree(st7920_state->buffer); + + __drm_gem_destroy_shadow_plane_state(&st7920_state->base); + + kfree(st7920_state); +} + +static const struct drm_plane_helper_funcs st7920_primary_plane_helper_fun= cs =3D { + DRM_GEM_SHADOW_PLANE_HELPER_FUNCS, + .atomic_check =3D st7920_primary_plane_atomic_check, + .atomic_update =3D st7920_primary_plane_atomic_update, + .atomic_disable =3D st7920_primary_plane_atomic_disable, +}; + +static const struct drm_plane_funcs st7920_primary_plane_funcs =3D { + .update_plane =3D drm_atomic_helper_update_plane, + .disable_plane =3D drm_atomic_helper_disable_plane, + .reset =3D st7920_primary_plane_reset, + .atomic_duplicate_state =3D st7920_primary_plane_duplicate_state, + .atomic_destroy_state =3D st7920_primary_plane_destroy_state, + .destroy =3D drm_plane_cleanup, +}; + +static enum drm_mode_status st7920_crtc_mode_valid(struct drm_crtc *crtc, + const struct drm_display_mode *mode) +{ + struct st7920_device *st7920 =3D drm_to_st7920(crtc->dev); + + return drm_crtc_helper_mode_valid_fixed(crtc, mode, &st7920->mode); +} + +static int st7920_crtc_atomic_check(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + struct drm_crtc_state *crtc_state =3D drm_atomic_get_new_crtc_state(state= , crtc); + struct st7920_crtc_state *st7920_state =3D to_st7920_crtc_state(crtc_stat= e); + int ret; + + ret =3D drm_crtc_helper_atomic_check(crtc, state); + if (ret) + return ret; + + st7920_state->data_array =3D kmalloc(BYTES_IN_DISPLAY, GFP_KERNEL); + if (!st7920_state->data_array) + return -ENOMEM; + + return 0; +} + +static void st7920_crtc_atomic_enable(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + struct drm_device *drm =3D crtc->dev; + struct st7920_device *st7920 =3D drm_to_st7920(drm); + int idx; + int ret; + + if (!drm_dev_enter(drm, &idx)) + return; + + st7920_hw_reset(st7920); + + ret =3D st7920_init(st7920); + if (ret) + drm_err(drm, "Failed to init hardware: %d\n", ret); + + drm_dev_exit(idx); +} + +static void st7920_crtc_atomic_disable(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + struct spi7920_error err =3D {0}; + struct drm_device *drm =3D crtc->dev; + struct st7920_device *st7920 =3D drm_to_st7920(drm); + int idx; + + drm_dev_enter(drm, &idx); + + st7920_power_off(st7920, &err); + + drm_dev_exit(idx); +} + +/* Called during init to allocate the CRTC's atomic state. */ +static void st7920_crtc_reset(struct drm_crtc *crtc) +{ + struct st7920_crtc_state *st7920_state; + + drm_WARN_ON_ONCE(crtc->dev, crtc->state); + + st7920_state =3D kzalloc(sizeof(*st7920_state), GFP_KERNEL); + if (!st7920_state) + return; + + __drm_atomic_helper_crtc_reset(crtc, &st7920_state->base); +} + +static struct drm_crtc_state *st7920_crtc_duplicate_state(struct drm_crtc = *crtc) +{ + struct st7920_crtc_state *st7920_state; + + if (drm_WARN_ON_ONCE(crtc->dev, !crtc->state)) + return NULL; + + st7920_state =3D kzalloc(sizeof(*st7920_state), GFP_KERNEL); + if (!st7920_state) + return NULL; + + __drm_atomic_helper_crtc_duplicate_state(crtc, &st7920_state->base); + + return &st7920_state->base; +} + +static void st7920_crtc_destroy_state(struct drm_crtc *crtc, + struct drm_crtc_state *state) +{ + struct st7920_crtc_state *st7920_state =3D to_st7920_crtc_state(state); + + kfree(st7920_state->data_array); + + __drm_atomic_helper_crtc_destroy_state(state); + + kfree(st7920_state); +} + +/* + * The CRTC is always enabled. Screen updates are performed by + * the primary plane's atomic_update function. Disabling clears + * the screen in the primary plane's atomic_disable function. + */ +static const struct drm_crtc_helper_funcs st7920_crtc_helper_funcs =3D { + .mode_valid =3D st7920_crtc_mode_valid, + .atomic_check =3D st7920_crtc_atomic_check, + .atomic_enable =3D st7920_crtc_atomic_enable, + .atomic_disable =3D st7920_crtc_atomic_disable, +}; + +static const struct drm_crtc_funcs st7920_crtc_funcs =3D { + .reset =3D st7920_crtc_reset, + .destroy =3D drm_crtc_cleanup, + .set_config =3D drm_atomic_helper_set_config, + .page_flip =3D drm_atomic_helper_page_flip, + .atomic_duplicate_state =3D st7920_crtc_duplicate_state, + .atomic_destroy_state =3D st7920_crtc_destroy_state, +}; + +static const struct drm_encoder_funcs st7920_encoder_funcs =3D { + .destroy =3D drm_encoder_cleanup, +}; + +static int st7920_connector_get_modes(struct drm_connector *connector) +{ + struct st7920_device *st7920 =3D drm_to_st7920(connector->dev); + + return drm_connector_helper_get_modes_fixed(connector, &st7920->mode); +} + +static const struct drm_connector_helper_funcs st7920_connector_helper_fun= cs =3D { + .get_modes =3D st7920_connector_get_modes, +}; + +static const struct drm_connector_funcs st7920_connector_funcs =3D { + .reset =3D drm_atomic_helper_connector_reset, + .fill_modes =3D drm_helper_probe_single_connector_modes, + .destroy =3D drm_connector_cleanup, + .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, + .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, +}; + +static const struct drm_mode_config_funcs st7920_mode_config_funcs =3D { + .fb_create =3D drm_gem_fb_create_with_dirty, + .atomic_check =3D drm_atomic_helper_check, + .atomic_commit =3D drm_atomic_helper_commit, +}; + +static const uint32_t st7920_formats[] =3D { + DRM_FORMAT_XRGB8888, +}; + +DEFINE_DRM_GEM_FOPS(st7920_fops); + +static const struct drm_driver st7920_drm_driver =3D { + DRM_GEM_SHMEM_DRIVER_OPS, + DRM_FBDEV_SHMEM_DRIVER_OPS, + .name =3D DRIVER_NAME, + .desc =3D DRIVER_DESC, + .date =3D DRIVER_DATE, + .major =3D DRIVER_MAJOR, + .minor =3D DRIVER_MINOR, + .driver_features =3D DRIVER_ATOMIC | DRIVER_GEM | DRIVER_MODESET, + .fops =3D &st7920_fops, +}; + +static int st7920_init_modeset(struct st7920_device *st7920) +{ + struct drm_display_mode *mode =3D &st7920->mode; + struct drm_device *drm =3D &st7920->drm; + unsigned long max_width, max_height; + struct drm_plane *primary_plane; + struct drm_crtc *crtc; + struct drm_encoder *encoder; + struct drm_connector *connector; + int ret; + + /* + * Modesetting + */ + + ret =3D drmm_mode_config_init(drm); + if (ret) { + drm_err(drm, "DRM mode config init failed: %d\n", ret); + return ret; + } + + mode->type =3D DRM_MODE_TYPE_DRIVER; + mode->clock =3D 30; + mode->hdisplay =3D st7920->width; + mode->htotal =3D st7920->width; + mode->hsync_start =3D st7920->width; + mode->hsync_end =3D st7920->width; + mode->vdisplay =3D st7920->height; + mode->vtotal =3D st7920->height; + mode->vsync_start =3D st7920->height; + mode->vsync_end =3D st7920->height; + mode->width_mm =3D 27; + mode->height_mm =3D 27; + + max_width =3D max_t(unsigned long, mode->hdisplay, DRM_SHADOW_PLANE_MAX_W= IDTH); + max_height =3D max_t(unsigned long, mode->vdisplay, DRM_SHADOW_PLANE_MAX_= HEIGHT); + + drm->mode_config.min_width =3D mode->hdisplay; + drm->mode_config.max_width =3D max_width; + drm->mode_config.min_height =3D mode->vdisplay; + drm->mode_config.max_height =3D max_height; + drm->mode_config.preferred_depth =3D 24; + drm->mode_config.funcs =3D &st7920_mode_config_funcs; + + /* Primary plane */ + + primary_plane =3D &st7920->primary_plane; + ret =3D drm_universal_plane_init(drm, primary_plane, 0, &st7920_primary_p= lane_funcs, + st7920_formats, ARRAY_SIZE(st7920_formats), + NULL, DRM_PLANE_TYPE_PRIMARY, NULL); + if (ret) { + drm_err(drm, "DRM primary plane init failed: %d\n", ret); + return ret; + } + + drm_plane_helper_add(primary_plane, &st7920_primary_plane_helper_funcs); + + drm_plane_enable_fb_damage_clips(primary_plane); + + /* CRTC */ + + crtc =3D &st7920->crtc; + ret =3D drm_crtc_init_with_planes(drm, crtc, primary_plane, NULL, + &st7920_crtc_funcs, NULL); + if (ret) { + drm_err(drm, "DRM crtc init failed: %d\n", ret); + return ret; + } + + drm_crtc_helper_add(crtc, &st7920_crtc_helper_funcs); + + /* Encoder */ + + encoder =3D &st7920->encoder; + ret =3D drm_encoder_init(drm, encoder, &st7920_encoder_funcs, + DRM_MODE_ENCODER_NONE, NULL); + if (ret) { + drm_err(drm, "DRM encoder init failed: %d\n", ret); + return ret; + } + + encoder->possible_crtcs =3D drm_crtc_mask(crtc); + + /* Connector */ + + connector =3D &st7920->connector; + ret =3D drm_connector_init(drm, connector, &st7920_connector_funcs, + DRM_MODE_CONNECTOR_Unknown); + if (ret) { + drm_err(drm, "DRM connector init failed: %d\n", ret); + return ret; + } + + drm_connector_helper_add(connector, &st7920_connector_helper_funcs); + + ret =3D drm_connector_attach_encoder(connector, encoder); + if (ret) { + drm_err(drm, "DRM attach connector to encoder failed: %d\n", ret); + return ret; + } + + drm_mode_config_reset(drm); + + return 0; +} + +static int st7920_probe(struct spi_device *spi) +{ + struct st7920_device *st7920; + struct regmap *regmap; + struct device *dev =3D &spi->dev; + struct drm_device *drm; + int ret; + + regmap =3D devm_regmap_init_spi(spi, &st7920_spi_regmap_config); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); + + st7920 =3D devm_drm_dev_alloc(dev, &st7920_drm_driver, + struct st7920_device, drm); + if (IS_ERR(st7920)) + return PTR_ERR(st7920); + + drm =3D &st7920->drm; + + st7920->drm.dev =3D dev; + st7920->regmap =3D regmap; + st7920->spi =3D spi; + st7920->width =3D ST7920_DEFAULT_WIDTH; + st7920->height =3D ST7920_DEFAULT_HEIGHT; + + st7920->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LO= W); + if (IS_ERR(st7920->reset_gpio)) { + ret =3D PTR_ERR(st7920->reset_gpio); + return dev_err_probe(dev, ret, "Unable to retrieve reset GPIO\n"); + } + + spi_set_drvdata(spi, st7920); + + ret =3D st7920_init_modeset(st7920); + if (ret) + return ret; + + ret =3D drm_dev_register(drm, 0); + if (ret) + return dev_err_probe(dev, ret, "DRM device register failed\n"); + + drm_client_setup(drm, NULL); + + return 0; +} + +static void st7920_remove(struct spi_device *spi) +{ + struct st7920_device *st7920 =3D spi_get_drvdata(spi); + + drm_dev_unplug(&st7920->drm); + drm_atomic_helper_shutdown(&st7920->drm); +} + +static void st7920_shutdown(struct spi_device *spi) +{ + struct st7920_device *st7920 =3D spi_get_drvdata(spi); + + drm_atomic_helper_shutdown(&st7920->drm); +} + +static struct spi_driver st7920_spi_driver =3D { + .driver =3D { + .name =3D DRIVER_NAME, + .of_match_table =3D st7920_of_match, + }, + .id_table =3D st7920_spi_id, + .probe =3D st7920_probe, + .remove =3D st7920_remove, + .shutdown =3D st7920_shutdown, +}; +module_spi_driver(st7920_spi_driver); + +MODULE_DESCRIPTION(DRIVER_DESC); +MODULE_AUTHOR("Iker Pedrosa "); +MODULE_LICENSE("GPL v2"); --=20 2.52.0 From nobody Mon Dec 1 22:41:30 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3421233F8A7 for ; Wed, 26 Nov 2025 17:04:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764176678; cv=none; b=F1SgrAegtRvLzEfsZYl45vUVczwbmWI7fqxr2qF5hcgVAo/Uqp+rG6rZ4Pp61T0tycNcPy3gAvTfri4niB5w96YnAhicV8rUd/LU921ZJLuYzsvXm7gwgK/NhZ+b0S5bkOwTJscuAJYrOSekKDnAGxuCv8yh0A3V3vCVXL58w2w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764176678; c=relaxed/simple; bh=SXNHwmt4IY8mD5pE4WSrMi6z+GqRjpGucvBnGaDk3bU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jt4kim7+KyEQCXLXQn65fl1n2G7ChXYO+IavNWfD00j1d0o7ugdfOu5533DJawx8yr2NSQ47yLipCpJ2QV1h0p+TLzmi4Yu3NZAZnhiThIULg0azBr+DUzw6e+M2CGFBkzWZDlR7nqq+Q3eXKOmIWkk2U/R49PRlLSkl96SP+20= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O+Y9avAG; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O+Y9avAG" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-42b32a3e78bso68027f8f.0 for ; Wed, 26 Nov 2025 09:04:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764176674; x=1764781474; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j5xnr554TtYoRpbiQVpIVqZ94ylKVMynqnLIjhVFhbc=; b=O+Y9avAGwPb9mg4uYXviMV4GOgyuktYi+L3eTUNDArvymJFHEyi3wCmbmkS9DpGEbk JQfu0xU+ciFqrspuukZuDiQLVaK10qS1YlMTTryIeSr2CZVWVUAxqPR/j/cnEIeuJAmk Wazr2AzLTRCQz0mZyoGaSBrgnz8ECqAkv1nG3KyPjUiuqGQrOIiam0aiwvymSxlF2PW0 qG5E5rvHVPje3p9Fc30K1E+jAUqlYjFvva6NJKRtQSBI/02LZBx1xh5lUcldC37CF99j sBYoflYoBWmwBzq1ijkH3krpQQquYKguo99+Y/odYf08cZIisdkfxT8+cpprtuuDsGol l31Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764176674; x=1764781474; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j5xnr554TtYoRpbiQVpIVqZ94ylKVMynqnLIjhVFhbc=; b=CcaYJok08uSRgHeu7R6d6ivgRoTM+yS86NU/8rikAqdDytmjokTEbNO4IwfPMXM+Ll Mhumn08ZJEbVln7Ya7TijWMYVnhoUwM7+WVyg6Htr/o5GKqt8R5Axv9JMqrIcBkEGTfG cF8trrOaG6n2mXedWIE6Eqg9jGqTPDH1SYEMcSpgfkJwkrUcz4UfNyW/u2ApBW1ClSLG d+JenMhuGXMoNBSBTlg1skZ7wsVuDlQUGvar+b99z0QEf6bk4h+eAdG8+z9/frDLoJFo lJWZIqNV0icZK5cRCiNh4214UkkxYkG2+VVsKGcJnPthO767yhLwK3qrVRx2b4BkqH2L gEaw== X-Gm-Message-State: AOJu0Ywy9mWQB/uTRsHO/h27zN+7YCSWje4WDhQiExIw8HEI1g5blaGr juzNxkSzDTvL4SDcLXMsyY3GtCMrE5pCtnttnxzl4USQB2ZcZw5PoWwI X-Gm-Gg: ASbGncsTFh1OWq47/3amTGLlc54VzBDQ8vk/Hw8qzpQi/0jenHs4n9AX5iVxlhdRRkF jnz/YY4ft+0WjXmdz6wMJ97sbbL3Nwwnu1tyVxcyFFASktKKNiVoqmlU5qgSB2iuz4jQN1EYWwT aBBLuShM2kbsw3h9oD8uxX2T6MNYEm+/Hqt7r5zFHb4G9albtbt3tt9eGGibi3Xcy+IWM1IbFuf iTPMp5/1MhxHB17ODtB/aEqfSQDOtkC/CcC2zKdpY1nMXVP1H1cq6Gh5RThZKoYDkPO2V/IhDPn wfKp9fkkyI0k/g3w7Rv7Jmyi1dcJOi0FmveuovqzCcvcKO7VD9FZ5LCMnmOgPeY6r0ivgrJYUWZ A83KbheeQo6ZyF14jDbjIk1bXiKWG4pRWNYhnSzlGpEWX7NE0VigOMLfYNAJ/10LXPzQvg9itzB B5mu+PQThq6vkolbC+uAzzBvBuFt9Gifl1TbQuF1pLmGHR3i1gSlGQ X-Google-Smtp-Source: AGHT+IFqhKM2PJT48YuPA9rXKH7Jp8+lFruZ6GLD8AePWoqqJeh2VVlVCxFXl1S1iXjh3vRhps00Xg== X-Received: by 2002:a05:6000:230f:b0:42b:4223:e62a with SMTP id ffacd0b85a97d-42cc1cbe219mr20121309f8f.23.1764176674356; Wed, 26 Nov 2025 09:04:34 -0800 (PST) Received: from ipedrosa-thinkpadx1carbongen12.rmtes.csb ([5.225.141.247]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f2e574sm41252799f8f.3.2025.11.26.09.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 09:04:33 -0800 (PST) From: Iker Pedrosa Date: Wed, 26 Nov 2025 18:03:51 +0100 Subject: [PATCH v5 3/3] MAINTAINERS: Add entry for Sitronix ST7920 driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251126-st7920-v5-3-64eda5267d35@gmail.com> References: <20251126-st7920-v5-0-64eda5267d35@gmail.com> In-Reply-To: <20251126-st7920-v5-0-64eda5267d35@gmail.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Javier Martinez Canillas , Iker Pedrosa Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org X-Mailer: b4 0.14.2 Add Iker as ST7920 driver maintainer. Reviewed-by: Thomas Zimmermann Signed-off-by: Iker Pedrosa --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5ddf37f0acc960039422ef988cadfa7176972fc5..79b8a277e38b55ebcff05450d6c= 565c0d87c6b51 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7861,6 +7861,13 @@ T: git https://gitlab.freedesktop.org/drm/misc/kerne= l.git F: Documentation/devicetree/bindings/display/sitronix,st7735r.yaml F: drivers/gpu/drm/sitronix/st7735r.c =20 +DRM DRIVER FOR SITRONIX ST7920 LCD DISPLAYS +M: Iker Pedrosa +S: Maintained +T: git https://gitlab.freedesktop.org/drm/misc/kernel.git +F: Documentation/devicetree/bindings/display/sitronix,st7920.yaml +F: drivers/gpu/drm/sitronix/st7920.c + DRM DRIVER FOR SOLOMON SSD130X OLED DISPLAYS M: Javier Martinez Canillas S: Maintained --=20 2.52.0