From nobody Mon Dec 1 23:09:23 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49BA234402C for ; Wed, 26 Nov 2025 20:23:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764188607; cv=none; b=ft/VMmYnutXo0V9ME+qCAcIMz45eOTGOkML8Ecd2RHbrI1TpxkAyyIIIcazbT1x2dWAo99e1c558llCXaZToKzYo3mVmT1sZuHUgpM5RlAm4gaM4e0MrgQCcYYCphJejCwXHrjG5eJwm8oMHarSWJW2RMIttslWijWmRlVwxmVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764188607; c=relaxed/simple; bh=oZlSrKc5HSf8OTgk8Y9zCO1ND/6B7m7anVTBiZTQDCE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NP/+3Q8bb6vFQF4QSa5XdmOYxlw3WwPpxjcopKPnI29nlk7XH/Z9AO4m63kdNs8R8dqoWXTN8wxGLE//ex531xqOIjpfCfL3yJk0kNl0JdDN0wt8RzYRYRKw+khxFOImEZDOi7noOz25QR0h4guOnEcB0lBqnVYKw02wJQy8yso= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QbbaRCMu; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QbbaRCMu" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-298039e00c2so2180165ad.3 for ; Wed, 26 Nov 2025 12:23:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764188605; x=1764793405; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J4d7URFdeCPYu3U6zdfTOnUzmMHd/kT6rS033v+6Sa8=; b=QbbaRCMutWdy8VBU7QOm/Di7vDec7kR4wXzLpS8nM0UC3D8a+RcUqBiR9h0BvSl7l7 A8bd3OaQ4dAUDCSwBqtERrTu4gQFp0/8EsDNYlZ+HKED1Vbe+bo0RpjIjTWDqKk2KQ3m m8/ftGRHIcEsUtRpjYCEp7t4x7AsftRSiff8yV8bYoxeDDS5teJdx4jb8+fIu0WkPxfj Rb6iGVa5B8slO3/208HljEZwFkLWBTrJ6mbFLmDERPijz9sesU+sFdn0ltx1EBdXgbMa xMx5iolKt19G0fAvb5mTk2Lul1BXEHIifXbph1VXthv/FutpLrg7g/PRqobJ3DEK1WV7 KEEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764188605; x=1764793405; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=J4d7URFdeCPYu3U6zdfTOnUzmMHd/kT6rS033v+6Sa8=; b=LUPa6SCMU6kS9OyAscdvg6udxqgpkDHXkzYe+pVedTvRaLLd1C3MjNXjIgCLiLii+w q8aX1UYl4wfZp+HXw2V5QI5aJI4B+/AOIrePewhv9531SPQDtHxdebkaUWO51lFTNq2u bqAo725jxhAY/iXPHEWSxUr5VOR+k4C7258VA6KteEOU6SdWWONpFgqrlsE5MCjLEOrQ IlFTGfh+/mokFLLQ6w7I0yrpHgGg+a+gmMEs59XMpv2EFKcDyYSggardHpHhyxPFxUpf Bv3PjexD1sO/KflPHaB92eLXvWUnDiUOTtplCrNDImM4z9ainiyUHzmsip/qjyZZ9wPE TW1A== X-Forwarded-Encrypted: i=1; AJvYcCVVWD5OSbmsCqHVOiLe7TRPCCfnbWH6W38Bc2GRXp2ht4HUAsd/2BGyyalriB5h2vrtLTzg4NbMFxZw2xY=@vger.kernel.org X-Gm-Message-State: AOJu0YyCWqm3a+fJQS6bwQTEf1tlkx0a++c5+LadFzakKPoHURFsd0bl m5pIO6mEOzP56wBw0bdrhhNwGqI5Ui0wRYibCr0l7zpIBZDnvVpJGcgD X-Gm-Gg: ASbGncuKn1oR8WshFEVeVkGIWA2pfId8AQ+QBEF4Rf/oJ8KbZqSVLFru53B7iv7Qcuo ksLyvHSaiDtMCrW67gh4Q0snkTOgtEH+R1rrZaDAmJHdaGdkShfOgehvmjCuMTs6SkGcUKQV13Q jXuDzJjWive8/sDm15vSnb9SICj2xbaGs9rNEzKuaE6+pM9I/apVaoj3PN2UxDrRjqbNlsoNMmY ksTR0b64qp0jVAiveiVS812am0lkVEY7SDaC0izfesNCHsyWEWvH0Me3NIgr7Mrcs9B4OVmeOEl KRrhbIDEPcPc4GHeph95mc0kmfhC1fDkTak9vfmtieN/AAq/Zsl8bYcbubeS2kZ+MtqXA9yXp/Q ysMcgZxP3R/Qjv8Iav0sMBMbPEeG1T19GDeEuCHs9bPHc3ITmcZWw67iZACb1+aCFEJFY/Dpaop 5N5BtCDDXaNtJjN8WbRr54hAIrTC7e X-Google-Smtp-Source: AGHT+IHGB5xyi1FRDO7qHEuNyrSdPuJIf66uTvcetBn/DBSU9Vii6oLU5Y+uncUTdE5yg8blVoT9WQ== X-Received: by 2002:a17:903:2acc:b0:298:603b:dc46 with SMTP id d9443c01a7336-29b6bf37df2mr258195425ad.39.1764188604441; Wed, 26 Nov 2025 12:23:24 -0800 (PST) Received: from [192.168.15.94] ([2804:7f1:ebc3:752f:12e1:8eff:fe46:88b8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b13a80csm207100475ad.35.2025.11.26.12.23.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 12:23:23 -0800 (PST) From: Andre Carvalho Date: Wed, 26 Nov 2025 20:22:55 +0000 Subject: [PATCH net-next v7 3/5] netconsole: add STATE_DEACTIVATED to track targets disabled by low level Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251126-netcons-retrigger-v7-3-1d86dba83b1c@gmail.com> References: <20251126-netcons-retrigger-v7-0-1d86dba83b1c@gmail.com> In-Reply-To: <20251126-netcons-retrigger-v7-0-1d86dba83b1c@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Andre Carvalho X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764188576; l=2409; i=asantostc@gmail.com; s=20250807; h=from:subject:message-id; bh=Bc0ee9DYK1oiSRrahxYGeDv2Y4gYudwUsG3FQq7nt2Y=; b=SAJQL5ZINCumtqkECOtyodcazmBLEaPG4kqXo8BJJNM+nb4uiY0spJyYDIMSkqHNOUpxUNvLP Js7kLRT7E39BoVXz89doaMvxrg303N9bDKMIWgzdmXTns8Is+sOzLHo X-Developer-Key: i=asantostc@gmail.com; a=ed25519; pk=eWre+RwFHCxkiaQrZLsjC67mZ/pZnzSM/f7/+yFXY4Q= From: Breno Leitao When the low level interface brings a netconsole target down, record this using a new STATE_DEACTIVATED state. This allows netconsole to distinguish between targets explicitly disabled by users and those deactivated due to interface state changes. It also enables automatic recovery and re-enabling of targets if the underlying low-level interfaces come back online. From a code perspective, anything that is not STATE_ENABLED is disabled. Devices (de)enslaving are marked STATE_DISABLED to prevent automatically resuming as enslaved interfaces cannot have netconsole enabled. Signed-off-by: Breno Leitao Signed-off-by: Andre Carvalho --- drivers/net/netconsole.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index b21ecea60d52..7a1e5559fc0d 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -122,6 +122,7 @@ enum sysdata_feature { enum target_state { STATE_DISABLED, STATE_ENABLED, + STATE_DEACTIVATED, }; =20 /** @@ -580,6 +581,14 @@ static ssize_t enabled_store(struct config_item *item, if (ret) goto out_unlock; =20 + /* When the user explicitly enables or disables a target that is + * currently deactivated, reset its state to disabled. The DEACTIVATED + * state only tracks interface-driven deactivation and should _not_ + * persist when the user manually changes the target's enabled state. + */ + if (nt->state =3D=3D STATE_DEACTIVATED) + nt->state =3D STATE_DISABLED; + ret =3D -EINVAL; current_enabled =3D nt->state =3D=3D STATE_ENABLED; if (enabled =3D=3D current_enabled) { @@ -1445,10 +1454,19 @@ static int netconsole_netdev_event(struct notifier_= block *this, break; case NETDEV_RELEASE: case NETDEV_JOIN: - case NETDEV_UNREGISTER: + /* transition target to DISABLED instead of + * DEACTIVATED when (de)enslaving devices as + * their targets should not be automatically + * resumed when the interface is brought up. + */ nt->state =3D STATE_DISABLED; list_move(&nt->list, &target_cleanup_list); stopped =3D true; + break; + case NETDEV_UNREGISTER: + nt->state =3D STATE_DEACTIVATED; + list_move(&nt->list, &target_cleanup_list); + stopped =3D true; } } netconsole_target_put(nt); --=20 2.52.0