From nobody Mon Dec 1 23:03:14 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8C2E3009DE for ; Wed, 26 Nov 2025 10:17:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764152227; cv=none; b=gQPqYjf9UvDzKCueQTVzrIp006Su1WFMlM6AbrDw/H13INZwq90tmYnS8eyXFMeGrj20LJpBZJJPm1rqru4yXYiO8/mQZUsS9cepEbHxVghrKPdPQpx5GiOyVS13bEG0EGprjYs0MKtaKvcnfzLIxamjyb/Y3MOuVp8CJbYB2eY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764152227; c=relaxed/simple; bh=XbwD81IF2hWlAqj8+XiP5Jch3xUbg5Ot/2nn03qkwCs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Yrk5mmTqMxjDHyUMa5rcw78qmAgTtSHV/3LjzRRqeSV9OyPFQZHiiYFfGGuCo953SZFxJxbxWSSr7CwgsRreg8i447MfGeCR90+SBTjqRiNzLvAzdKEVzublA26epqgudPB6DX7j7NUN4jfC85WgC18DCGe4ODcXAiLG8Ts+4zM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vOCZv-0000Qh-7Z; Wed, 26 Nov 2025 11:16:51 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vOCZu-002aSb-2v; Wed, 26 Nov 2025 11:16:50 +0100 Received: from hardanger.blackshift.org (p54b152ce.dip0.t-ipconnect.de [84.177.82.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id A45904A88D3; Wed, 26 Nov 2025 10:16:50 +0000 (UTC) From: Marc Kleine-Budde Date: Wed, 26 Nov 2025 11:16:03 +0100 Subject: [PATCH can-next v8 02/17] can: bittiming: apply NL_SET_ERR_MSG() to can_calc_bittiming() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251126-canxl-v8-2-e7e3eb74f889@pengutronix.de> References: <20251126-canxl-v8-0-e7e3eb74f889@pengutronix.de> In-Reply-To: <20251126-canxl-v8-0-e7e3eb74f889@pengutronix.de> To: Marc Kleine-Budde , Vincent Mailhol , Oliver Hartkopp Cc: kernel@pengutronix.de, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?St=C3=A9phane_Grosjean?= X-Mailer: b4 0.15-dev-a6db3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1193; i=mkl@pengutronix.de; h=from:subject:message-id; bh=v8m7nKBeI46RR6uNXm/Tz3YaMp4YiXOun4vKbbogbgs=; b=owEBbQGS/pANAwAKAQx0Zd/5kJGcAcsmYgBpJtN1rO+4rE424E9mGwz6GVizQHeA8QyjObr5F dC1IHgLL8WJATMEAAEKAB0WIQSf+wzYr2eoX/wVbPMMdGXf+ZCRnAUCaSbTdQAKCRAMdGXf+ZCR nIpdB/9N3sYGeTP/fPZ6UmcnqgjFU4Xsa+gMx+08FgPAEi+NXjw1WLTWM9cBBVBovKFUAR6003j vGHDmIut+FMTS06I/LVoGWnKv0dv+oEZo99IA9a2UDWOtmbMaQEHlkyIbQ0qNxP1KgID02qk9pU ZdzW2h8irgPB+v8hUxQJeuJeZH6wY4sVc61mRWwtCOmrPJDv0ZsEMQegEqoVxnN8qa6ZNlbdGuZ V+kC4HkWtIzCUkfKwYlk6hDJ+7Yw949faiEcnvdVeLgYeJBfipUYu9M0+Z/kFERESbcVlYgBlkQ IA903wwq1Rc6HoF2kNjeTz+KDd+gjj8+Jb7ewp65J4hquyV2 X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org From: Vincent Mailhol When CONFIG_CAN_CALC_BITTIMING is disabled, the can_calc_bittiming() functions can not be used and the user needs to provide all the bittiming parameters. Currently, can_calc_bittiming() prints an error message to the kernel log. Instead use NL_SET_ERR_MSG() to make it return the error message through the netlink interface so that the user can directly see it. Signed-off-by: Vincent Mailhol Signed-off-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde --- include/linux/can/bittiming.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/can/bittiming.h b/include/linux/can/bittiming.h index d30816dd93c7..3926c78b2222 100644 --- a/include/linux/can/bittiming.h +++ b/include/linux/can/bittiming.h @@ -141,7 +141,7 @@ static inline int can_calc_bittiming(const struct net_device *dev, struct can_bittiming *bt, const struct can_bittiming_const *btc, struct netlink_ext_ack *extack) { - netdev_err(dev, "bit-timing calculation not available\n"); + NL_SET_ERR_MSG(extack, "bit-timing calculation not available\n"); return -EINVAL; } =20 --=20 2.51.0