From nobody Mon Dec 1 23:03:13 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF34F3016EC for ; Wed, 26 Nov 2025 10:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764152228; cv=none; b=WWMBuWADSlQGoDPp6E5nAhXOtxr9mNFFwzZyn8tNH8C5vOb03MquRfhHUNsaZ/51pC1Wjr78SHXPWeOK61uk3tQGvjip6TVVjqPWuEBXMd1Zfuy3SWSqxjcAFfWUXw96RL/8aMW/PPV/z2o6KrZGERZU1FC2epixqgY8ODRqf2E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764152228; c=relaxed/simple; bh=nphzJBCUTQlxJNEIZoAIIkAZNQvpkKrkgQSxr+QxPII=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=a7GEL7XiKMiawV6nz6E5rSjAbUwqceBsxg7IfrntpKqaoGr9PRf207jHWIEb320FbQe6gWvpibhXS5edQEp8Sy7uIo8ASIS0rqL1q8FnCAHtYLUppXH3YyustEciyNjVB5IsdjVGID86ii1slfcehvCPZJ6uLdL/WJhY7LCy7ao= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vOCZw-0000SH-8u; Wed, 26 Nov 2025 11:16:52 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vOCZv-002aTR-2E; Wed, 26 Nov 2025 11:16:51 +0100 Received: from hardanger.blackshift.org (p54b152ce.dip0.t-ipconnect.de [84.177.82.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 76FD04A88E2; Wed, 26 Nov 2025 10:16:51 +0000 (UTC) From: Marc Kleine-Budde Date: Wed, 26 Nov 2025 11:16:18 +0100 Subject: [PATCH can-next v8 17/17] can: dev: print bitrate error with two decimal digits Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251126-canxl-v8-17-e7e3eb74f889@pengutronix.de> References: <20251126-canxl-v8-0-e7e3eb74f889@pengutronix.de> In-Reply-To: <20251126-canxl-v8-0-e7e3eb74f889@pengutronix.de> To: Marc Kleine-Budde , Vincent Mailhol , Oliver Hartkopp Cc: kernel@pengutronix.de, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?St=C3=A9phane_Grosjean?= X-Mailer: b4 0.15-dev-a6db3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1711; i=mkl@pengutronix.de; h=from:subject:message-id; bh=7kyl7e7nsbgVHh+uNt5JmfhY7X+/ImB4fbvttTL6e1Q=; b=owEBbQGS/pANAwAKAQx0Zd/5kJGcAcsmYgBpJtOQ3mXo6FkpURAlFDmmlsklyxJUQ0hnbCxld kdn8cuZhwuJATMEAAEKAB0WIQSf+wzYr2eoX/wVbPMMdGXf+ZCRnAUCaSbTkAAKCRAMdGXf+ZCR nIpcCACP7FaFZd4U6vLne9a5LeZRoW5eNRLPZbBXZ42T5I8l1YPUwO8kP8sgdUsX+E0cYydTvTB WJVyFOGO2iraX7xPoG547XAYYMBNWbsBE79F3VEZUJ+xN/RVSC7Zoq+4sUWGuutgvRdw2yb8tsf BLBti/6qDwT+ntEQEGl8Sh1K/8PxWqztXlSwPpKASnlVltB7CNN2Yqnx5/0q8+/gcACK+Tds3oT bfoGHpPWaUHGU/7xhfjHUyOzeOa0a9VkupjNOYwE8RmUoQyJ7YSjQOhvqlrxY3Lzq6/7LhZV+Pz eNrOcAw3JkL4VCoYZ4GmcCtfGfNDNxNsUYhXgCxM4twXMc/1 X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org From: Oliver Hartkopp Increase the resolution when printing the bitrate error and round-up the value to 0.01% in the case the resolution would still provide values which would lead to 0.00%. Suggested-by: Vincent Mailhol Signed-off-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev/calc_bittiming.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/can/dev/calc_bittiming.c b/drivers/net/can/dev/cal= c_bittiming.c index 60a505ce69de..cc4022241553 100644 --- a/drivers/net/can/dev/calc_bittiming.c +++ b/drivers/net/can/dev/calc_bittiming.c @@ -153,19 +153,22 @@ int can_calc_bittiming(const struct net_device *dev, = struct can_bittiming *bt, } =20 if (best_bitrate_error) { - /* Error in one-tenth of a percent */ - v64 =3D (u64)best_bitrate_error * 1000; + /* Error in one-hundredth of a percent */ + v64 =3D (u64)best_bitrate_error * 10000; do_div(v64, bt->bitrate); bitrate_error =3D (u32)v64; + /* print at least 0.01% if the error is smaller */ + bitrate_error =3D max(bitrate_error, 1U); if (bitrate_error > CAN_CALC_MAX_ERROR) { NL_SET_ERR_MSG_FMT(extack, - "bitrate error: %u.%u%% too high", - bitrate_error / 10, bitrate_error % 10); + "bitrate error: %u.%02u%% too high", + bitrate_error / 100, + bitrate_error % 100); return -EINVAL; } NL_SET_ERR_MSG_FMT(extack, - "bitrate error: %u.%u%%", - bitrate_error / 10, bitrate_error % 10); + "bitrate error: %u.%02u%%", + bitrate_error / 100, bitrate_error % 100); } =20 /* real sample point */ --=20 2.51.0