From nobody Sun Feb 8 11:25:54 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A2292EA173 for ; Tue, 25 Nov 2025 22:56:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764111392; cv=none; b=FbmBpn5mpQki2bbkRF3zaupiiNOk544++8QqJYw3/6xbGKzI6w5YIQHi7dU0W6874EOQGTTC94txDPJbJguQLrJOLW9IJ5SlahLqFzLgxh4ZVq28Wba4hbsW3JiAbDTBJDKdNicZvXB00XLkrTAXgohnmrWZDHXJcOqHImxsYVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764111392; c=relaxed/simple; bh=nHdXGb2AdP2DgjNFeV3zcq8k0NdmnFBHBirPKHWn4Lk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=geNJsb5KvMVQywdUJRtWtwtM9YBniDK0glhYxDK8y9Woqsyw6X4u532EkIeKGoR4Q6EZYAmGPURk3XU02y1jlqpoFiPjmkD2OABw6zAW+0xP3ttjyHk26/5OnHJiR1ZMFTx1/9mLgBvSFGjhh5wBNaO+E1ehDlNJ7OfQxf1GSjU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HvlHhRCp; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HvlHhRCp" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-3437af8444cso6849658a91.2 for ; Tue, 25 Nov 2025 14:56:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764111390; x=1764716190; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zz05WzE00CjGABLWbGj8jFZgzfZ/0bbpM+rkTuSaLU8=; b=HvlHhRCpA0CK0FlEs55WwDBeuvIjc3ejaibjVuagXaA1QBMc/N1x5iaBoeiFoWar17 GmQ1HA8GGeMshNheAyI8n/5KYn9+qEBsLY1i0L2ug6GTAgp1TpHX4KSHOit/+LfdtVIx rBqHUF3S+JX23ApU56H0eLnlg+Jwer+TeKHnNC/+U1MX4ZU/m9PJAHLgLLTlx/OB2DAp AiTomerstfkx/yvZ6d5FRjVzvULuYgdnvZtE8ZPQxzNlu3qW822gj57dysvD6tp6FzZf cUKwlNSPeZhBnj947lE/NedyueI/83sYZq85bIoZCo86hsQadJekzBonK3Kg8oIhI9F4 MUCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764111390; x=1764716190; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Zz05WzE00CjGABLWbGj8jFZgzfZ/0bbpM+rkTuSaLU8=; b=DljoWVdGJTSSsImO2PN5LxZNvwwPurRMLKvXPUb9ftxOjaPB+sjiIqeF5dxihmU4Tp 3foqPDhyvltnQ2eCmhVnBzignBo7+Lv+Zrs4x6zW9we/gQpWGjSd1bCHug4BlpwFEO/g GsnCftvmynQeE27qKXDxHtQlK4eAkzWmndDdZj20YK2T+SjRCGBERo0rokeo0/SXP/kR gpZEAayvTA9ar/5hMEBIHP1JTHf80kLidM4/bQL23zXl5sCkJUtDs8c9Rwf3oReIiNuZ qx8hXroug+dea1z5V0XIyDj35DPMGpx2bMcQYFPzPTZX0snTV21DTUn2KRXLN6DNyuso gmWw== X-Forwarded-Encrypted: i=1; AJvYcCUCzznydt4S8FcX7jmZdj2u2Bwhg1fxxzRH4ZYjT98Nh+7n3SvjhjaVgxsFhGuHgpJs/BrLe3fLiFN5UxM=@vger.kernel.org X-Gm-Message-State: AOJu0YwQ2+WKJNoVaoSUY9yxR5Nhc6TJF+nZHyeBSUo0/juz8CuyRs5i obKYDmO8oju484G39E3aV3LzwZQ0Lrhjm47AP/HJcVWLn/AAvNMcmQfs X-Gm-Gg: ASbGnct1LmAZQjY8nN2N5DZ3K5k/lEIiRIuos2wMMVAbhSquFkzY2II+0+9huWrN6TA wcfGb6FVx5ygdaF5oo0+pN3V0AjEJRYIRrQF+xhi3pXDsa4XDwbKKsvP/z+MLm6g17njXGxepkG MR2iqgwlzPtWiqyI2qFTkpMKcWN0vvF1/SnwB2ft2kbQdK+fJfo+tG6LHY5qVxJjkqceJIJbtpN pa3BFuibRk7Ha2tLZZHkEJl+tmpGZEydEhAayjY7GcYA/npTeNj8xGQkl5zm6ANRwa+mYimWMWl 4K/vKZRxUhilxDcRugE5ZScNesUi6Vy2NqGhvIyojyHDT/KowPyB21RQyjGTeX7CIOfooTd87mJ oHf7nJr4PR5iZFqGojs4NX0tDO3rnXZkOY+Sdnulv2h8neOSdxORbunh+sFxR5Er2z6zbbUHhQ2 133EdLAJWbvIIdNUjcmWPYJQtP8zzEccSGUO8Awc4d5gehcm+hyvDWTfTai0nLkUSl9YuTmU6D2 Ozw1P+KNWiKwi5m02Spgk+sPLhP404l5yB6/v+R5s4/QqQXrZOtMm4//yslc3wRh3zR+ckQhrdQ ZEhIirQ7mRKLk+Ix3+yP+A52n4y7r8qe4Q== X-Google-Smtp-Source: AGHT+IHSAMT3z9iKxxRaqeZuqJy1nJTpeo3FuYnyVBT41pXi2yGCB/dHlw7gvfrBZM9/hCr7qkg3UQ== X-Received: by 2002:a17:90b:5183:b0:32e:9f1e:4ee4 with SMTP id 98e67ed59e1d1-34733f2278bmr18436896a91.17.1764111390426; Tue, 25 Nov 2025 14:56:30 -0800 (PST) Received: from cyberkunju.asia-south1-c.c.gen-lang-client-0196962068.internal (125.31.93.34.bc.googleusercontent.com. [34.93.31.125]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3476a546ed0sm471842a91.3.2025.11.25.14.56.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 14:56:29 -0800 (PST) From: Navaneeth K To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Navaneeth K Subject: [PATCH v2 1/2] most: core: fix resource leak in most_register_interface error paths Date: Tue, 25 Nov 2025 22:56:05 +0000 Message-ID: <20251125225606.70719-2-knavaneeth786@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251125225606.70719-1-knavaneeth786@gmail.com> References: <20251125225606.70719-1-knavaneeth786@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function most_register_interface() did not correctly release resources if it failed early (before device_register). In these cases, it returned an error code immediately, leaking the memory allocated for the interface. Fix this by initializing the device early via device_initialize() and calling put_device() on all error paths. This ensures the release callback is triggered to free memory. Switch to using device_add() instead of device_register() to handle the split initialization. Signed-off-by: Navaneeth K Acked-by: Abdun Nihaal Reported-by: Abdun Nihaal --- drivers/most/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/most/core.c b/drivers/most/core.c index da319d108ea1d..8635fd08035e9 100644 --- a/drivers/most/core.c +++ b/drivers/most/core.c @@ -1283,18 +1283,23 @@ int most_register_interface(struct most_interface *= iface) struct most_channel *c; =20 if (!iface || !iface->enqueue || !iface->configure || - !iface->poison_channel || (iface->num_channels > MAX_CHANNELS)) + !iface->poison_channel || (iface->num_channels > MAX_CHANNELS) || + !iface->dev) return -EINVAL; =20 + device_initialize(iface->dev); + id =3D ida_alloc(&mdev_id, GFP_KERNEL); if (id < 0) { dev_err(iface->dev, "Failed to allocate device ID\n"); + put_device(iface->dev); return id; } =20 iface->p =3D kzalloc(sizeof(*iface->p), GFP_KERNEL); if (!iface->p) { ida_free(&mdev_id, id); + put_device(iface->dev); return -ENOMEM; } =20 @@ -1304,7 +1309,7 @@ int most_register_interface(struct most_interface *if= ace) iface->dev->bus =3D &mostbus; iface->dev->groups =3D interface_attr_groups; dev_set_drvdata(iface->dev, iface); - if (device_register(iface->dev)) { + if (device_add(iface->dev)) { dev_err(iface->dev, "Failed to register interface device\n"); kfree(iface->p); put_device(iface->dev); --=20 2.43.0 From nobody Sun Feb 8 11:25:54 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AA352F12AD for ; Tue, 25 Nov 2025 22:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764111395; cv=none; b=UZicWcpJfIjqjApS7h7gNK4/1Ucy3AX+AhDuyz2GK7YKSvfUU1bU3t2tV8HiNMW/V4Ankp/HFwFSkqq5u8FJZ19LYPZ6V5+cLyhRcr7pkPuOhcJxG9eGb68oFFsYA5RL7RJQTRD5pI7gqsOUkaVTWQcINbHmV9ryHMtRn91Uhgg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764111395; c=relaxed/simple; bh=UpVyaBs8eAOQi08DfycyxuWW04wnSjnuFTX2AkrDpkA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FFkw6tV7BM95r9H8yuIGd6nFVZKYatmOHbAXEaMHPFkaG6LBj0vpzBhuxvvL6orx82tGUTLtczCw//u65yt0zb3X/9R8XabKkOnZCzeyiiJkL0+X/W2RxkNevKz5BJXu/ue2wfoNl4vMrKhMGYpW7mtdqSBqdgwFmNzic1JM3jw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h6LXT6QI; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h6LXT6QI" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-34372216275so6150857a91.2 for ; Tue, 25 Nov 2025 14:56:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764111393; x=1764716193; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v8infRYS555HXMSuFzeioCvs9HbNCrDo+QxiT/yj2jU=; b=h6LXT6QIdbF2R5DJqiJK6f2IdWDjVwALrnNDjoVGoJCSTHUaI+Ysf+MuupdsJNIJ7K NXzFJZItT0oS3kZQDYsjYhuCzgjrolk1wzduL/kbEQlHkDUAwYXu7CRLx1oDsaiF+Fsx ZN9NZO+yYYM9AkTzq3rW3Ujc9GP7gk6LEnjT9QJwTzSzPFhR2iliDpykmBvLfpoCQNNi Hrb53VVkieco8TiVdrS0RHcVgSZRSr+p4E029/SVeK+F5HlvaLVH2/KpxUP16ANcAH2p Tl4vrmwz2FK0B/N+fmvU529ZHzgHWAqOcurMkybw5aBR7NGdY13ctGlYsy/moG5F2DTq bGoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764111393; x=1764716193; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=v8infRYS555HXMSuFzeioCvs9HbNCrDo+QxiT/yj2jU=; b=FacBAUumnkBqlMDSdd3+337n7t+n5TEgfmiITyf2KnXUsdIKRvIwVx2bfcwRvPJhUt 5tqDmkLzcvOCDqBo7B6z+rb9h7FlG436L2SHmbTisetx0B+ESrrbzWzU2aTqyWZMAbEY 95zJdOz1rhn8ROumVv2+YhdX/HGEIzq137XdAmKVGYx6vpfWxRpn7eoaJZD1kZtUEbR+ Ze1Bkxlzu5o22U2+F+lxBJyCmfinqRITWRsT3MJB6e6M3GuSXuit/CVhcHD4zgnu/WHP eaz5HNkijxJ8zjr3R2F+4FVDhXvcDEvb+YXotSwBMLO+XOfD28WVYFjLlsA210K5jvW1 co1Q== X-Forwarded-Encrypted: i=1; AJvYcCUrt2Bmr6U5mX3+POlg1Q/m17tNds+4bg3LbuknQecrsa5N4owUtsoifDgfwAsalL4G6oaNao3ZLh8QQxo=@vger.kernel.org X-Gm-Message-State: AOJu0YwaTg/NHiGxFn07WLW3RKc4evqy73cSO10bTv6ZjfWJ2AdChJmp K1w8XItLbVnEnZw3ktEAHrIYv4GtMhRrMHyXuFsyDiCEEzFaw3CRJT0X X-Gm-Gg: ASbGnctfufrn5YOGwQsFpodWbcNSS0uRvdh3XDhcH+yX1tCSmKogmax8nUUsTNjb7mx BCGdpdGLulCnf/t+yMzhdiC3oF+ahwkb+WR4H5j5SaZhMQ8wrNKhpHZa63buG61y9W3NbBS0QNh NQQr4Hjjc8h2IzDDP/F2Zdb38CdYGFiFcWLCgQe515FyAXK/Bi2BS+DfeLmBqv23WogzjWJ7KHK ZEFV2yVy6n0rym31zhAhHysplU9IIcBf0yrTamEEvV3o+TcvztgJMAE7kILt5RBLEUWyEC5lOO7 XSBJE5IQjNtlRqQlZ0t3Z4kfc0JhRd6rQhLCXSgjqsb4JppEmq30MQt80UcjW2r0cANxzxz8X8J cPg8dQjOQcj/0poCjvmoDydHCPBL2OYLX/PKyaeugL10JhK01YskAwuCDVR+5SLGbtChp1bsp7Z oxlUNC/1yl2lpQ5IX8aUnV5oKeT++onw0oi1qU2Nnr5sOlEdcYKzZ96bZUMJkv7rphVRDXAdzXv 8VPpGzIhoaNu4upp6P3cLuW860KvdXCBAzeaGerMbwo5h+0pXmkJzrMWwjnu+40dbDKrd0Ah/Dh SKqbr4OZrcb4vWpz+VBpwH6eaSP7EaAqkA== X-Google-Smtp-Source: AGHT+IESYLJoTPg6cuS+nu96MVtqOjXbB1YQv3xzSC+BtOZqok/UZvc//J7EfkYrIt5EuDPpA/ldfQ== X-Received: by 2002:a17:90b:4f4c:b0:340:be40:fe0c with SMTP id 98e67ed59e1d1-34733f5c930mr15298749a91.36.1764111393291; Tue, 25 Nov 2025 14:56:33 -0800 (PST) Received: from cyberkunju.asia-south1-c.c.gen-lang-client-0196962068.internal (125.31.93.34.bc.googleusercontent.com. [34.93.31.125]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3476a546ed0sm471842a91.3.2025.11.25.14.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 14:56:32 -0800 (PST) From: Navaneeth K To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Navaneeth K Subject: [PATCH v2 2/2] most: usb: remove double cleanup of interface on registration failure Date: Tue, 25 Nov 2025 22:56:06 +0000 Message-ID: <20251125225606.70719-3-knavaneeth786@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251125225606.70719-1-knavaneeth786@gmail.com> References: <20251125225606.70719-1-knavaneeth786@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since most_register_interface() now correctly handles cleanup (calling put_device on failure), the manual cleanup in hdm_probe() would cause a double-free. Remove the manual cleanup labels and return the error code directly. Signed-off-by: Navaneeth K --- drivers/most/most_usb.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/most/most_usb.c b/drivers/most/most_usb.c index 10064d7b72498..597cf7f4e6b90 100644 --- a/drivers/most/most_usb.c +++ b/drivers/most/most_usb.c @@ -1058,7 +1058,7 @@ hdm_probe(struct usb_interface *interface, const stru= ct usb_device_id *id) =20 ret =3D most_register_interface(&mdev->iface); if (ret) - goto err_free_busy_urbs; + return ret; =20 mutex_lock(&mdev->io_mutex); if (le16_to_cpu(usb_dev->descriptor.idProduct) =3D=3D USB_DEV_ID_OS81118 = || @@ -1068,8 +1068,7 @@ hdm_probe(struct usb_interface *interface, const stru= ct usb_device_id *id) if (!mdev->dci) { mutex_unlock(&mdev->io_mutex); most_deregister_interface(&mdev->iface); - ret =3D -ENOMEM; - goto err_free_busy_urbs; + return -ENOMEM; } =20 mdev->dci->dev.init_name =3D "dci"; @@ -1077,19 +1076,15 @@ hdm_probe(struct usb_interface *interface, const st= ruct usb_device_id *id) mdev->dci->dev.groups =3D dci_groups; mdev->dci->dev.release =3D release_dci; if (device_register(&mdev->dci->dev)) { + put_device(&mdev->dci->dev); mutex_unlock(&mdev->io_mutex); most_deregister_interface(&mdev->iface); - ret =3D -ENOMEM; - goto err_free_dci; + return -ENOMEM; } mdev->dci->usb_device =3D mdev->usb_device; } mutex_unlock(&mdev->io_mutex); return 0; -err_free_dci: - put_device(&mdev->dci->dev); -err_free_busy_urbs: - kfree(mdev->busy_urbs); err_free_ep_address: kfree(mdev->ep_address); err_free_cap: --=20 2.43.0