From nobody Tue Dec 2 00:45:20 2025 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 822C033D6F7 for ; Tue, 25 Nov 2025 20:23:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764102201; cv=none; b=jfSLyl2PinJ2Gzl3jc0/73BJbEkYJobqseTqxvJt4LN0c7tiZW/bf3+L4AdJvBxaKrfJ4vmwkeTwXBRyje8ULiTdwOBgfU4M5kbacU9V/HxsgvURX5SUSkf9wRWxH6+8lLzobt11NjjnmKYTuUB63VrsHLeeFnHW5Nckxi1wjiQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764102201; c=relaxed/simple; bh=gHSJ2ACpil3oUoOrN4nqa6atJKyrIL8QdwCNvpfI3Qk=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dc42v3qoe5/UjnjiVZ22/5y+iNX1RYSLolsai6wZcHy+QsxNlqrwreu2YUwpgSugteq+6MBX4zS2xYLvifjYAkyWHXBWHEEUjR9c79hUw5jbMlPnYHY3sQZ+4DR1XddtmR4RPOzojwSt2DHC1TeYN7A/8YyyhRy81RdFWvRv1z0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=gXqzApp3; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="gXqzApp3" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-b725ead5800so762508766b.1 for ; Tue, 25 Nov 2025 12:23:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764102198; x=1764706998; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=vZ3KjII7xZFDbQeKyBo731P+isw4m0FcuZQDXssMMvU=; b=gXqzApp3jhpRnUzLKBd+c+xg81L3u+GHUPfVZRwpibLT2CfJPzHo6RlWEifdL9Zg4y RcDIqIGRCp+G26Nk4nT87yQDBsaRLF0bt2LfwnVLCusyjnSyP8vqv8UWmLIcDSLTlIUo bZVZmHvMSoXDb66ffWPXieRPdcoYknTh/YyMDyMRqB7TXTFOQ+9N3StYxeKBqTjeF3T8 zAnUgqUYm0+WjznUn+gnqfTOVYzpR0NlCkmvYxvvcM9KqkwlBp7BeX1qdXEFH4nkAlU8 OM15Yxxxmijp8RumPniKQe4cYOeiF4/JBTjJtE4s+Jx6CV9leling45Rm9t68FCnIIFW yndw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764102198; x=1764706998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vZ3KjII7xZFDbQeKyBo731P+isw4m0FcuZQDXssMMvU=; b=OhWW31DiIyF0ojylPubfbRf6ZpgC1m1NUfa8jpNzfqnJVlwLSh6GmFu54DPPGR7itr Z1ASNfRPLUEHxmMYHSsAHKaGkgrl//6Rlks0yMLfbedeGuS4FhFOdtPr+sjz0bgkbeKL TlzooH4buXk5XRloi4ZG3nUSuoUkvUk9xGYxNTIwuvmmss8g/v5lZQucPN00XYpdkR9d aQ49/U7BGyQiqOBxiYSN2Ln+sENHN076bhGFYQ8G/8ndGJs3i/FrK8zDmphc4O8a5tYJ QueJvRgSk2+QdvZOGVsYJsfi6dm/ZNmIuUDSOtx+/5z5fXnrXN7GqfYMpCPN0YsAsStc LGvw== X-Forwarded-Encrypted: i=1; AJvYcCUjCYqlUSy8Nii6mNgxo/z8+TvcSS7nFXKu+ZIjKjUDvTZoqfg29n0ozZenHOGnYO9NnmG93BQCKWRkU2k=@vger.kernel.org X-Gm-Message-State: AOJu0YyB4bNCsArdaZ/g+c4XA7JlZbL1kdg+8rgw2B2rKG3o0J8tBDQt 31AIVWbvWVz2INaI0t30Sy254kcyOuzmfMJ8/bqc2SJqe8+CAwylfKBtWUst92Oh9uE= X-Gm-Gg: ASbGncsgWP9Y0bUkMIHha/UpeLL83IrwyqHv2LuXk4fs5Fc6tw3/ScxyKaP0mHLs/zq 1O5xD5OLGkfYWczEECzyaU4z3ytRsr6E5+BkveaX7u/GYdbgVGEa2DvhiIf8uTntnIE9nhDOtWs ljtvtpSVU9YO+8/K+Spt1XlMlhpNRawkQ9dM7QhLqTOVQjszbLcbO8H98ngSvfy8qw6gU3AWKgs XNqLUeR0mAKpFn1oSTPoTNKfz6BBVX+n0cGVO1jUMibxVYjW5oL9+7XPRsUCtsjotILm4Wv3FGS 2wAcZsY7fJ2GOLsHKA6CcjZ8n3Vo8c7Y2s0Fe1H20QIZ9aBpMu3mLh85zOrPL/7c1GquzRm/rzR VUQqT2hCHniqU88Hya1HumFplJqXPeqwZ0anEcRspSF1wQ4WaX7o8mP8iPQ== X-Google-Smtp-Source: AGHT+IFlmccSpoREOSIViih01/Pl1YGQquFBeoydLee+4dk/jLLZRnkDI96o5RM1J6u6zey3yzyV/g== X-Received: by 2002:a17:907:7ba1:b0:b73:870f:fa37 with SMTP id a640c23a62f3a-b76c53c0113mr482544466b.17.1764102197785; Tue, 25 Nov 2025 12:23:17 -0800 (PST) Received: from localhost ([151.35.128.119]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654fd43a6sm1637193266b.32.2025.11.25.12.23.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 12:23:17 -0800 (PST) From: Francesco Lavra To: Lorenzo Bianconi , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 7/9] iio: imu: st_lsm6dsx: add event configurability on a per axis basis Date: Tue, 25 Nov 2025 21:23:05 +0100 Message-Id: <20251125202307.4033346-8-flavra@baylibre.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20251125202307.4033346-1-flavra@baylibre.com> References: <20251125202307.4033346-1-flavra@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=5627; i=flavra@baylibre.com; h=from:subject; bh=gHSJ2ACpil3oUoOrN4nqa6atJKyrIL8QdwCNvpfI3Qk=; b=owEB7QES/pANAwAKAe3xO3POlDZfAcsmYgBpJhAEB75tQqC/WkBF5miDejQQrZ2AjaoCKO7aX bDty5S4JpmJAbMEAAEKAB0WIQSGV4VPlTvcox7DFObt8TtzzpQ2XwUCaSYQBAAKCRDt8TtzzpQ2 X1B4C/4spJl2I7rRU/UjeSAH7mntFxJiXC3jnYIopFbUoyKqnszNdeygqXsHN2hO98hjlXZGIeA jv1L7bhwhu1KFCC9sUKe2wjjYdxdwIniC+Lg+WxDxQgbmm/YAsdL/PCVRkY5jzh+jC28XyTwZtR itT05l8EFZgK2zHH9cCDCeSWzCZxe4psvFnURrwqcRj+TpweIhlljUYcNEdtmjw3aBFxfceEnIX 5+Kmpr155YddDOSBFjwnqHXytO07O2OpGP/25mgZvFt3CeVaChV0iTqMRZCEGNn0gTyLlDQbJb1 N7aVlmJKW5e0sMa/X3xtGZp2S92ccNeJ8H/HD9vGFxNWgKxcgfJ6PuwkA5e8OX5QVztoaDwpF3m yeJqsYEROgi9oqQGB+eK6uoY3004dYSCNA+NrgQZpgj3zX8roeHlyq1+t8Iv9K6mXbT36EvnqWS UtQqqMqs9iosMPZTVJXvHMsA+M/pjUVSrAatQGk0A/nGBKDmNBqSKh52036Kzmmqg+AeA= X-Developer-Key: i=flavra@baylibre.com; a=openpgp; fpr=8657854F953BDCA31EC314E6EDF13B73CE94365F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In order to be able to configure event detection on a per axis basis (for either setting an event threshold/sensitivity value, or enabling/disabling event detection), add new axis-specific fields to struct st_lsm6dsx_event_src, and modify the logic that handles event configuration to properly handle axis-specific settings when supported by a given event source. A future commit will add actual event sources with per-axis configurability. Signed-off-by: Francesco Lavra --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 7 ++ drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 95 +++++++++++++++++--- 2 files changed, 88 insertions(+), 14 deletions(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_l= sm6dsx/st_lsm6dsx.h index 2aae56b7db0b..515aadbee3a4 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h @@ -250,7 +250,14 @@ enum st_lsm6dsx_event_id { =20 struct st_lsm6dsx_event_src { struct st_lsm6dsx_reg value; + struct st_lsm6dsx_reg x_value; + struct st_lsm6dsx_reg y_value; + struct st_lsm6dsx_reg z_value; u8 enable_mask; + u8 enable_axis_reg; + u8 enable_x_mask; + u8 enable_y_mask; + u8 enable_z_mask; struct st_lsm6dsx_reg status; u8 status_x_mask; u8 status_y_mask; diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu= /st_lsm6dsx/st_lsm6dsx_core.c index 6dc6cda54d05..50c00dd38c63 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c @@ -1888,12 +1888,50 @@ static int st_lsm6dsx_event_setup(struct st_lsm6dsx= _hw *hw, const struct st_lsm6dsx_event_src *src; unsigned int data; int err; + u8 old_enable, new_enable; =20 if (!hw->irq_routing) return -ENOTSUPP; =20 /* Enable/disable event interrupt */ src =3D &hw->settings->event_settings.sources[event]; + if (src->enable_axis_reg) { + u8 enable_mask; + + switch (axis) { + case IIO_MOD_X: + enable_mask =3D src->enable_x_mask; + break; + case IIO_MOD_Y: + enable_mask =3D src->enable_y_mask; + break; + case IIO_MOD_Z: + enable_mask =3D src->enable_z_mask; + break; + default: + enable_mask =3D 0; + } + if (enable_mask) { + data =3D ST_LSM6DSX_SHIFT_VAL(state, enable_mask); + err =3D st_lsm6dsx_update_bits_locked(hw, + src->enable_axis_reg, + enable_mask, data); + if (err < 0) + return err; + } + } + + /* + * If the set of axes for which the event source is enabled does not + * change from empty to non-empty or vice versa, there is nothing else + * to do. + */ + old_enable =3D hw->enable_event[event]; + new_enable =3D state ? (old_enable | BIT(axis)) : + (old_enable & ~BIT(axis)); + if (!!old_enable =3D=3D !!new_enable) + return 0; + data =3D ST_LSM6DSX_SHIFT_VAL(state, src->enable_mask); return st_lsm6dsx_update_bits_locked(hw, hw->irq_routing, src->enable_mask, data); @@ -1910,6 +1948,39 @@ st_lsm6dsx_get_event_id(enum iio_event_type type) } } =20 +static const struct st_lsm6dsx_reg * +st_lsm6dsx_get_event_reg(struct st_lsm6dsx_hw *hw, + enum st_lsm6dsx_event_id event, + const struct iio_chan_spec *chan) +{ + const struct st_lsm6dsx_event_src *src; + const struct st_lsm6dsx_reg *reg; + + src =3D &hw->settings->event_settings.sources[event]; + switch (chan->channel2) { + case IIO_MOD_X: + reg =3D &src->x_value; + break; + case IIO_MOD_Y: + reg =3D &src->y_value; + break; + case IIO_MOD_Z: + reg =3D &src->z_value; + break; + default: + return NULL; + } + if (reg->addr) + return reg; + + /* + * The sensor does not support configuring this event source on a per + * axis basis: return the register to configure the event source for all + * axes. + */ + return &src->value; +} + static int st_lsm6dsx_read_event(struct iio_dev *iio_dev, const struct iio_chan_spec *chan, enum iio_event_type type, @@ -1927,7 +1998,10 @@ static int st_lsm6dsx_read_event(struct iio_dev *iio= _dev, if (event =3D=3D ST_LSM6DSX_EVENT_MAX) return -EINVAL; =20 - reg =3D &hw->settings->event_settings.sources[event].value; + reg =3D st_lsm6dsx_get_event_reg(hw, event, chan); + if (!reg) + return -EINVAL; + err =3D st_lsm6dsx_read_locked(hw, reg->addr, &data, sizeof(data)); if (err < 0) return err; @@ -1959,7 +2033,10 @@ st_lsm6dsx_write_event(struct iio_dev *iio_dev, if (val < 0 || val > 31) return -EINVAL; =20 - reg =3D &hw->settings->event_settings.sources[event].value; + reg =3D st_lsm6dsx_get_event_reg(hw, event, chan); + if (!reg) + return -EINVAL; + data =3D ST_LSM6DSX_SHIFT_VAL(val, reg->mask); err =3D st_lsm6dsx_update_bits_locked(hw, reg->addr, reg->mask, data); @@ -2042,20 +2119,11 @@ st_lsm6dsx_write_event_config(struct iio_dev *iio_d= ev, if (event =3D=3D ST_LSM6DSX_EVENT_MAX) return -EINVAL; =20 - if (state) { + if (state) enable_event =3D hw->enable_event[event] | BIT(chan->channel2); - - /* do not enable events if they are already enabled */ - if (hw->enable_event[event]) - goto out; - } else { + else enable_event =3D hw->enable_event[event] & ~BIT(chan->channel2); =20 - /* only turn off sensor if no events is enabled */ - if (enable_event) - goto out; - } - /* stop here if no changes have been made */ if (hw->enable_event[event] =3D=3D enable_event) return 0; @@ -2073,7 +2141,6 @@ st_lsm6dsx_write_event_config(struct iio_dev *iio_dev, if (err < 0) return err; =20 -out: hw->enable_event[event] =3D enable_event; =20 return 0; --=20 2.39.5