From nobody Tue Dec 2 00:45:20 2025 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EA5B33C19B for ; Tue, 25 Nov 2025 20:23:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764102198; cv=none; b=AWafn5rvTGSJgfBUG5qT1L5h8ak9e6vj1/CZ15AKPvscIMWlQ82WJoQTV+8KQkSvYGMwd0qXKYC8ITjoLlJaJYqk/38JJm1IfRNbqwdFmDXefitmlPvkddLD3SiuSzFzsmr4Lhh3Vy4Dm5fLJh2yBTN3j01ZIP9uj6cpd+7ZiBI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764102198; c=relaxed/simple; bh=DqJyjrJckqTFCFbsp+ufeGsL49os8RH1HQOvg32AKQk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=b+2kCjWPeboUiets08ngXvGhiZ3na9N7LGhPbIQBmxuOr4k5o5WYLn7U8zazIR8WKRo/FfA4XglhKDZyXDR0LPdtaYBGcd8e4/muknA80EB6Z5ZhY6DGYFLCQyunN9ZjzRaIHTSyz3CYJ1H3GjPaC9sklZ5cws2yV0p3wbQnRrI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=n95Kmad8; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="n95Kmad8" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-640a3317b89so8751338a12.0 for ; Tue, 25 Nov 2025 12:23:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764102194; x=1764706994; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T/17Tgx9epkg1KaWaLaodjBbzP+GCzteuD35HmwuiLE=; b=n95Kmad8cOie22eHyiMhmiBGYDkAtsdMWXBOJqz721WW3WTNt24bBn4gHy3lNwiQH1 Pya+ByHGQkteqZ4X7MNB3UVCx6g3NQtqaRHLE3Y9Jhl/6ImoeR/ujFdm7bF70InkzNMg 5NFJ0m5MxBpj/X9ufSeVI5SZGM3Re4r6cFMDZWwRXs6+D1La2/kg4TVZMJTruMS3PEkE EyMmc3CUSn4IJ8DN3ej5Ei8xsvwlhtuHjfZ+ERk9Aa2bUZbbAZ2eRVeWL0YFtcqxCG3m 5H+pSMxCbudy4TC3DIfE6ujFbGWKl3Z6ULHVYQlLE2HqCpD9CAnW/ZGtd77iOqqqiAC5 aY7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764102194; x=1764706994; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T/17Tgx9epkg1KaWaLaodjBbzP+GCzteuD35HmwuiLE=; b=Xv+Gy6hHyLzzhU6aHcGDDg5QH+i62/OF+HERwmTDfj1h8iMLsliIZVz77v6MDWP596 iaZNNE1qpejBSMx3DPtK7G5quc2c7+Pe01AQHlI7fE1ngliJbvLTx0nL4G0kFJ4OMiuK 7XjkWXE1QeSOiVRQBMOiaULhAXb/EyUco+F+7JxpgK7vUqGXsfYrKqzp2gLseGCJMyP1 G3Kv8qprpfqzMDeWvDmA4IL2v47baBcBlameUngYJKafj5BhPTshp1yQUmF0cXDBxjIV D/dEUNgdYykQtoWIlrgX8LBHtkB0euUSDkUK01EaxGca8YNbvUccZGyYa4wk1qfqYgwG NNXg== X-Forwarded-Encrypted: i=1; AJvYcCXe2sYl6L3XsD8poavx1EDb7VSdK789nURyVGuKfYlVJrr8JOQhn2om6z0vxKz3hi6PLJjKFwYQ+96YDP0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9UXiiXYIih/ndKZN1RbZo6wjne8926mHjP0BylAtOPwc63fhi aWMWHKBpRVK8QVHex0K7kHb8AQf3kOHLcWwJKv8vW0OV40HMglS7Zji7f4JF+WKOWdU= X-Gm-Gg: ASbGncuWZHNuQNx+x53PLXjfkUIjyYn/iWDnr+H5f0Olqlq0iXsC13N0Whyn3rMJehw FfmU+CUgkMLbu1JA8/viCiVlsYJe8KmNCNVfrxvQzIPnUC9jOigyfXZoNVVTbkwjADgmKl3gHqD c32D7rvq2cu9bYDNskjpFYAG6C74dm/dXFIST1b3OoK245iHG+qrvOiPi1e/jr/z7CgDzWyKwY3 U007PFJKR7P7YXVgEbwOtiJNU6bh6gie5XOghItmMTUNr2C+xQb5olbdr9OaaTjMYJRc8Z4s9Xn rKfHA+4Vnz1HrqWxlvvZaEe8ynNGAxzZBEGWZzSQwABt1lwF9D91pUKjOSrQNzZrYEI8xm0Tlk0 KmsKBbrOdOxK+WACqfzB2M/wZ58H1NiXwDFm7b83kqTy/6AVLW7Nq8lOd7a5uPsW08/FO X-Google-Smtp-Source: AGHT+IF1jEzi0tnblxW4NUau8G4FOxDCk+CR1sk5/D9G7iXCJNbzlCtwMboP/Ymqc97J2f4E7Aqqag== X-Received: by 2002:a17:906:f5aa:b0:b3e:e16a:8cdb with SMTP id a640c23a62f3a-b76c5352f46mr447862366b.12.1764102194273; Tue, 25 Nov 2025 12:23:14 -0800 (PST) Received: from localhost ([151.35.128.119]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654ff3bbesm1674127166b.51.2025.11.25.12.23.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 12:23:14 -0800 (PST) From: Francesco Lavra To: Lorenzo Bianconi , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v3 4/9] iio: imu: st_lsm6dsx: rework code to check for enabled events Date: Tue, 25 Nov 2025 21:23:02 +0100 Message-Id: <20251125202307.4033346-5-flavra@baylibre.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20251125202307.4033346-1-flavra@baylibre.com> References: <20251125202307.4033346-1-flavra@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2722; i=flavra@baylibre.com; h=from:subject; bh=DqJyjrJckqTFCFbsp+ufeGsL49os8RH1HQOvg32AKQk=; b=owEB7QES/pANAwAKAe3xO3POlDZfAcsmYgBpJhADMQVpJcwRohUAGn+A7Rc5GiIcg+Cr4E5+E EzqWf8+OkWJAbMEAAEKAB0WIQSGV4VPlTvcox7DFObt8TtzzpQ2XwUCaSYQAwAKCRDt8TtzzpQ2 X+MyC/wMDPp1XD/LQyq5jGU+UkDGYKK9/xkEjzCySgK4pBi083KT2QpF33bhob6gdTg7PTMHec2 IVDXVKvKBgGBtpgkioBtErY8Gii1R60Xf/BQRaHZcz+DHG102PgGWo0NV+Ijc83QKXTUSClaEE2 wAjb1O3BWzx8t1j0wvh1t10Gp82IBa/D1Vf5D0gCwUufP9FplacQGKaie9iP1zLYNdFydLVr4MU G33oJ2JUBAjOMaQJ8zgjWe1AL3NAsAP7L/869/q1mhiPaO1eGuk2iDb039fQocuHUmRrpAR8jqK 8KHmFSFHDxbyRfdqxrtWVMvwpFBX3So0wTCE33IfPPVcEWHX4Vco5lPDiMevHuSPLsVMwHWVrwc +jeoowGnf5nfINARwB7glrzQ9u3bWNHeTDg59jpooYIxUqH29c7vh44gpnxl12iosfkBC2y+OGF KLBBxcxeL7RDd2HCJFh+mERUIVKPgJF8j96p65INJFc2sDCngIwhnrlk9g6rOTjs1tx1c= X-Developer-Key: i=flavra@baylibre.com; a=openpgp; fpr=8657854F953BDCA31EC314E6EDF13B73CE94365F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The enable_event field in struct st_lsm6dsx_hw does not lend itself well to handling multiple event sources, so it will have to be modified to add support for more event sources. As a preparatory step, remove references to this field from code that does not deal with event management; rework the st_lsm6dsx_check_events() function so that it returns whether any events are currently enabled on a given sensor. Signed-off-by: Francesco Lavra Reviewed-by: Andy Shevchenko --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu= /st_lsm6dsx/st_lsm6dsx_core.c index ba163dd2ab82..828e495c870c 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c @@ -1756,11 +1756,11 @@ __st_lsm6dsx_sensor_set_enable(struct st_lsm6dsx_se= nsor *sensor, } =20 static int -st_lsm6dsx_check_events(struct st_lsm6dsx_sensor *sensor, bool enable) +st_lsm6dsx_check_events(struct st_lsm6dsx_sensor *sensor) { struct st_lsm6dsx_hw *hw =3D sensor->hw; =20 - if (sensor->id =3D=3D ST_LSM6DSX_ID_GYRO || enable) + if (sensor->id !=3D ST_LSM6DSX_ID_ACC) return 0; =20 return hw->enable_event; @@ -1769,7 +1769,7 @@ st_lsm6dsx_check_events(struct st_lsm6dsx_sensor *sen= sor, bool enable) int st_lsm6dsx_sensor_set_enable(struct st_lsm6dsx_sensor *sensor, bool enable) { - if (st_lsm6dsx_check_events(sensor, enable)) + if (st_lsm6dsx_check_events(sensor)) return 0; =20 return __st_lsm6dsx_sensor_set_enable(sensor, enable); @@ -1797,11 +1797,9 @@ static int st_lsm6dsx_read_oneshot(struct st_lsm6dsx= _sensor *sensor, if (err < 0) return err; =20 - if (!hw->enable_event) { - err =3D st_lsm6dsx_sensor_set_enable(sensor, false); - if (err < 0) - return err; - } + err =3D st_lsm6dsx_sensor_set_enable(sensor, false); + if (err < 0) + return err; =20 *val =3D (s16)le16_to_cpu(data); =20 @@ -2762,7 +2760,7 @@ static int st_lsm6dsx_suspend(struct device *dev) continue; =20 if (device_may_wakeup(dev) && - sensor->id =3D=3D ST_LSM6DSX_ID_ACC && hw->enable_event) { + st_lsm6dsx_check_events(sensor)) { /* Enable wake from IRQ */ enable_irq_wake(hw->irq); continue; @@ -2793,7 +2791,7 @@ static int st_lsm6dsx_resume(struct device *dev) =20 sensor =3D iio_priv(hw->iio_devs[i]); if (device_may_wakeup(dev) && - sensor->id =3D=3D ST_LSM6DSX_ID_ACC && hw->enable_event) + st_lsm6dsx_check_events(sensor)) disable_irq_wake(hw->irq); =20 if (!(hw->suspend_mask & BIT(sensor->id))) --=20 2.39.5