From nobody Tue Dec 2 00:44:56 2025 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA9122D060E for ; Tue, 25 Nov 2025 20:23:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764102193; cv=none; b=OxlvMHFJgQbTpKdCuigbuSjgqt7qwrPrpP6c8xbXLxt42C4W/xiA4FMBaaVSIxAXF/YSHO4paCGbGpgXSKPAjy5xknmu8fIogOQbz5uVyN2L8u9OzCb76oKWKU7oxVVzN15iiRKHx9qGyZbKs3/VDwnPq40ExuE3yuNx9JgwnHk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764102193; c=relaxed/simple; bh=Xb/mqp4+YwITWlbn8v8dEwFHqYPu9zYkndT2tCfzi90=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PrwSetSVfFEzh17hLWIP6fFwZVGCioFFDHLWw8kli41RRphJFgGIir7Uq14SR7xlq95mQADKjPO2Rs0ymc/PurvXg8LcSoDX2kcCRplHbrfNuJYo326bJQsgCwPAa9O82z7HLzsb/G08bY22cNrxC0DXKPvJMno9D4hL7N6wsaQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=MgiM+INT; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="MgiM+INT" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b735e278fa1so592722766b.0 for ; Tue, 25 Nov 2025 12:23:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764102190; x=1764706990; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8Ib0drqFrjnDrbAYTSSfxv4es9CvzBMVOslQd6EXaRk=; b=MgiM+INTWMEjj5TL/Y6K42VIPQ35oJPQNO8uOTrmiWCitqdiSbhLZFdB7PBoU/qCd6 mEZq4flDo8PfbdvCNvKVehtSOnJVlrb+UrGmhHsuL8KBANNwabegvfc2BWWV+f5cz0Vh rzPkuJ7kdAwKH/+ouJzJTf82TieEDZqJmIJSDJwDGW8BA+s7wTsVUg47jhpmogsSFaUF MP+p/9hXOevJd11fLiWW7+IiWBPFLwSN0L2Hh4X1W/4ajx19wpBegOKdRR5FMtBiXeMp d3eX/EyooK8lVhOLdjo++k33CeCYdGoni152nb1FGX+XXbaZQvT+RtAFsHeA8IQWRxT8 +CzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764102190; x=1764706990; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8Ib0drqFrjnDrbAYTSSfxv4es9CvzBMVOslQd6EXaRk=; b=CmmiwjPcg3l701fgb9ag7Et8jfwSQTj9RW3T/ajddfbj2jFWThfLDylCd1Jq31Hqvx 82+xL9AZCK2kl/KRQueQ2ZicOc2VxrtN1GLT0q/YtQtIwB14MK0aDpkJgvt2xlUD3CMX svBmxeY88S4zNmOpC4G/8Pp82X1d3ljSl0YHOCAecAEdTxWS89IaT8ESFJb5B3uSxvpU JggRXBdG0sk2vTx9/FNWuVCE430YGAn8cZqwmx6cIDFlOeSKCZfl2YBdBd7+BrOErhu5 vj7XmeDL6FHQDWl+OmqAWW03rawjSKStrHI32Z6dv7CiAU/nNwtYqxYR09iDYrln8Es3 KQ5g== X-Forwarded-Encrypted: i=1; AJvYcCXsLzSdweKbn3+P54pxZrHY3y2xWKNDmI1nKuXMeJ/5LZfW1B0U18/f5oin1+OQmRaX/F4YMjHq4sLIaLs=@vger.kernel.org X-Gm-Message-State: AOJu0YzGpJC/mdnxXk2g3cainlubNDD0xabtwU+fDP7dElY61kJaKT7Y xnmUiaSFcsdrUCBejuBMfYQWKzgWUOii7hDEJRHPohXbPvsMOqALlupQ1ypTmbXcWG8= X-Gm-Gg: ASbGnctHCKz62EZ4akpUpya40Mui1h3y+aLzfeP/EKuhHlIj/0u3tOHnyNJmRg6zfM9 lrtXJboDtNE0RYV/NFjyxF2ivPOqFuu+3Cux4+raYldGCjyIvqXL9AgK/a59rdqpVfWqlMuUV54 QwkOWcvS8dXZcVoA0Jc5H4wOoIpAdjv3GTHVF0zy5qawMh3oSc0ZCdE0r59GAich0BSIMD3KKgA GN2jmYDFQlUpgTHIbYsUmlaf/ir/ZnYq9WVOqf2iSNETIOcich8NH0HkNaKxKMzfvpE+/5MUsW6 5aA82hCiJnqeGQf/NA7g+61GQgTMvaH2X5XWLOHTmOO7huzIkDoCtyOQz/oSM7/CqhL7sM6HRZU rmIyq8g+8LYqTCVuPL7hyMcCIxz+dx6uzxY98ZnoGf6r7lggWr2H/9TVRizt316CYUN4sc4oeEp ns7A== X-Google-Smtp-Source: AGHT+IGmtQaLA/Uc4OF4O4nDM/5+lEJ34paMjp1QNcJa/UK+uZ+msJKQDzBQKODh/ewuat38K/Z4PA== X-Received: by 2002:a17:907:744:b0:b73:b0eb:16f5 with SMTP id a640c23a62f3a-b76c55f4037mr512604466b.31.1764102190146; Tue, 25 Nov 2025 12:23:10 -0800 (PST) Received: from localhost ([151.35.128.119]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b765c1379ddsm1583680466b.0.2025.11.25.12.23.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 12:23:09 -0800 (PST) From: Francesco Lavra To: Lorenzo Bianconi , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v3 1/9] iio: imu: st_lsm6dsx: fix iio_chan_spec for sensors without event detection Date: Tue, 25 Nov 2025 21:22:59 +0100 Message-Id: <20251125202307.4033346-2-flavra@baylibre.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20251125202307.4033346-1-flavra@baylibre.com> References: <20251125202307.4033346-1-flavra@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2615; i=flavra@baylibre.com; h=from:subject; bh=Xb/mqp4+YwITWlbn8v8dEwFHqYPu9zYkndT2tCfzi90=; b=owEB7QES/pANAwAKAe3xO3POlDZfAcsmYgBpJhACb7PSvMCE4FL2AoX2G7rJWV6MWZPzu6uCj zuR4kzIvpiJAbMEAAEKAB0WIQSGV4VPlTvcox7DFObt8TtzzpQ2XwUCaSYQAgAKCRDt8TtzzpQ2 X032C/4nr+nfvc3LvitKlpUfYNuGChz6j9VHNrts/2ML7zBvEZbr2bf+mgUJM3NRJu439PRLxm5 TR6jyO8W809+M8QORepMjECfKhVAprfkRUa+QZMkn6gvyyQ3f70Rn8tN5LXFpV3WdSyUcxU4U3I o4UOGkdA9nYRGB5x0f8iX5X9T4FHGf2UUv8XVX0v84kty3LtqPoQM78oOa0edMM8SuKXlCvQ9ao YTHri8qWoNV/ov2hlMJgrsxjDKTJ4cYg5r0/A8RfUqlzxoa+eQcl9X3QBlK+668855qRRDsAzRe dXQQ8znDKyjcdre090FAc5JyWl70bl9GfM57zYpsLIYyt+F+gsEsLqi3fcQlu2vfdJx+ZTFVg3T d6SqVFXiBEaGenHn2fSIJL5rIqXRu99+dQUWif+SJkveP3Ra9dCu/M7URSfghJ0LlXSQ0H6qSz7 QEB5QJvpvef5o6QBwHWcWUkm/vQaYHT8nAxsIJ7fJYfMWYKXexBY2yy2bviRt/1i78aq0= X-Developer-Key: i=flavra@baylibre.com; a=openpgp; fpr=8657854F953BDCA31EC314E6EDF13B73CE94365F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The st_lsm6dsx_acc_channels array of struct iio_chan_spec has a non-NULL event_spec field, indicating support for IIO events. However, event detection is not supported for all sensors, and if userspace tries to configure accelerometer wakeup events on a sensor device that does not support them (e.g. LSM6DS0), st_lsm6dsx_write_event() dereferences a NULL pointer when trying to write to the wakeup register. Define an additional struct iio_chan_spec array whose members have a NULL event_spec field, and use this array instead of st_lsm6dsx_acc_channels for sensors without event detection capability. Fixes: b5969abfa8b8 ("iio: imu: st_lsm6dsx: add motion events") Signed-off-by: Francesco Lavra Reviewed-by: Andy Shevchenko Acked-by: Lorenzo Bianconi --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu= /st_lsm6dsx/st_lsm6dsx_core.c index 216160549b5a..a09df9d772dd 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c @@ -103,6 +103,13 @@ static const struct iio_chan_spec st_lsm6dsx_acc_chann= els[] =3D { IIO_CHAN_SOFT_TIMESTAMP(3), }; =20 +static const struct iio_chan_spec st_lsm6ds0_acc_channels[] =3D { + ST_LSM6DSX_CHANNEL(IIO_ACCEL, 0x28, IIO_MOD_X, 0), + ST_LSM6DSX_CHANNEL(IIO_ACCEL, 0x2a, IIO_MOD_Y, 1), + ST_LSM6DSX_CHANNEL(IIO_ACCEL, 0x2c, IIO_MOD_Z, 2), + IIO_CHAN_SOFT_TIMESTAMP(3), +}; + static const struct iio_chan_spec st_lsm6dsx_gyro_channels[] =3D { ST_LSM6DSX_CHANNEL(IIO_ANGL_VEL, 0x22, IIO_MOD_X, 0), ST_LSM6DSX_CHANNEL(IIO_ANGL_VEL, 0x24, IIO_MOD_Y, 1), @@ -144,8 +151,8 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sens= or_settings[] =3D { }, .channels =3D { [ST_LSM6DSX_ID_ACC] =3D { - .chan =3D st_lsm6dsx_acc_channels, - .len =3D ARRAY_SIZE(st_lsm6dsx_acc_channels), + .chan =3D st_lsm6ds0_acc_channels, + .len =3D ARRAY_SIZE(st_lsm6ds0_acc_channels), }, [ST_LSM6DSX_ID_GYRO] =3D { .chan =3D st_lsm6ds0_gyro_channels, @@ -1445,8 +1452,8 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_se= nsor_settings[] =3D { }, .channels =3D { [ST_LSM6DSX_ID_ACC] =3D { - .chan =3D st_lsm6dsx_acc_channels, - .len =3D ARRAY_SIZE(st_lsm6dsx_acc_channels), + .chan =3D st_lsm6ds0_acc_channels, + .len =3D ARRAY_SIZE(st_lsm6ds0_acc_channels), }, [ST_LSM6DSX_ID_GYRO] =3D { .chan =3D st_lsm6dsx_gyro_channels, --=20 2.39.5