From nobody Tue Dec 2 00:45:21 2025 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D92533EAFC for ; Tue, 25 Nov 2025 20:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764102204; cv=none; b=BtvY3w+Hx+l8rduXzO9rKaTyUngXMb99MTZ8VRJSV3v8KYnlgxEjWQZcj5Pc10aWfWC/2mJWn0xf5EhG75kAJs7kV+nmQOIZmaeWjBOagGmC3aHfv/t1z6hbzQc5FP8NTHe5q0B163JpC9bLfID2P4VmcpY/3FQnjLV5V8hsuuM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764102204; c=relaxed/simple; bh=fPKQq9VW/0IRfnIwOJhKfq8568r/UARLM1IVoAPX3D0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Qk6hlRy/NQGg8mGh6MGk80M/Xe0cOBR2LZws4BTFLM5j+QPc70OJaJQQ8Z7WjVU30w4cLRgmDADDxvecdd2tEsTk8eC78ISBhiNF43ZMN0I6F8z6BuzGgSDCgyIgVHlPEqYYvIyVE0zP5kwSlgx/GG0+gVHRJnApra+FUkvR91s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=klVG/I8J; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="klVG/I8J" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-641977dc00fso8553499a12.1 for ; Tue, 25 Nov 2025 12:23:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764102201; x=1764707001; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Lu3VlZP+h+37IpIE5wmYW7UTzGfSy7LB4iu6rGw2cJQ=; b=klVG/I8J48rmDVma7mgOYkNsiq85wqSx9V1Uf0GPpvl/fkbpA0jvll0y5V52lT/E5A Q8PQS9CjVM14viE+sgJiIklKmNkiVOMkKrJachUWP5fHNumEP90P9vOQk5nlWf/FUArE /V2WAIDykOhUWmTrFqrNZJyod22f9NNHU7gthpdLnWb1jVzgEsWBCnjDdEx1UlS9NRq6 xXh7xo1zYFNQFs7tKC28tYFWixoaa0GjHepSfvZ2lqewJ3BODkEeL6RzOJeuTgNJ8m3J WRyL3YzlT6lSUBJs9/8YthLb0j+IEc/n2ApDH62mVE2hkvPYSpI9m5+8vY+z6AbnhYZ5 agTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764102201; x=1764707001; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Lu3VlZP+h+37IpIE5wmYW7UTzGfSy7LB4iu6rGw2cJQ=; b=i5uLzI1lWOu+oMSg+NVoV0JmLaXwaK+JuII4BeDKCy7w76LrcoZUz3HUx5Eq3l96RD wMwN+Zg5yS/wzfKUdzuvpxZFCh3cwX+LJoXwMdYnA/w+7PB9D+QLqGwzcjeEYajh/G+j YZcPVMedmK8mAam3etLRsC6J0EMwMHbcewe2DkNxy+eIqbH2DPl098JK6GzMRFCN9LQp ynknbS4eKKO3JtaXEtW3V7EpFYWWjhO1qngcfdBL5Z5tx2X7dI/eirTQzJLd6yfkFNua 95rH4DnILwTMJ2PIowSpPZy3LtKMZlm97rxGn1h3R1r654Ng5Y1njkjkG/is9XyvKjhT F00Q== X-Forwarded-Encrypted: i=1; AJvYcCUWzJYW/Cx9K5QBrNYhIgzAruF+/Gs9ZvvEXfDyJ0fvv5yR70q3ateoOssac8Tn/fBGe9It09JO6jDLilo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0RF5Zv9MGIRixnUuhREJjjXhsMdP7IOgJeGBLTU7Lc9krG8p+ YRxfb1qmIhpHRTrI5pHajek7QA7X6G3KccAZeOzMM9V1Vyr+lC6ejf+Nwa+8dKz7S+k= X-Gm-Gg: ASbGncskRb3DSoM5MTOoTVRmntrV+y1+v7V/2Btd/kCim3FbjmIlwYqnVYEEQLL6YOM /CmYU6IA4LKXWZi9Nq3OlvxT7Lzn7RKDYHunZaT78DRRbp7omiw5+i3WtSf6gV2Lyo+GOpve9c9 F0/AXYe2fVVT1sd5cDb61Cgpz6Fb62vDO0xhI2rlxhVVL27J6bvWfu3iI8O/+xPpjYv7IeZeEbv b8IEq1QLsWRWW3374FWpuMu+DQLuosEp0sirtOMdUfrSXvtSi+i4E1t6Wu2Oxg56fBqp5R3GyDi VRkdljhyjOQtPD8hQIB78LZDWHjcMKeUILYy914pe4MzdeTT8PoRrHiY+D3N/9Ca4/lJuS0v7Ep UudXQinZfV60Yu2LLUk3JDUk7M7jB0QRXy9aez5agqyk4e/DjshazHZUOAkvSnFO/iiGJhLWmRK 8F3A== X-Google-Smtp-Source: AGHT+IFFxu6lRPjOwtB3ddihvruy9A2yx5MCC3G4mEdVQ/CR9Ep4cTGk5NZUtjWETohOzfRwr+REtg== X-Received: by 2002:a05:6402:1ed2:b0:643:83f3:1b9f with SMTP id 4fb4d7f45d1cf-64554691819mr14495817a12.31.1764102200752; Tue, 25 Nov 2025 12:23:20 -0800 (PST) Received: from localhost ([151.35.128.119]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6453645f2easm15731147a12.33.2025.11.25.12.23.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 12:23:20 -0800 (PST) From: Francesco Lavra To: Lorenzo Bianconi , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v3 9/9] iio: imu: st_lsm6dsx: add tap event detection Date: Tue, 25 Nov 2025 21:23:07 +0100 Message-Id: <20251125202307.4033346-10-flavra@baylibre.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20251125202307.4033346-1-flavra@baylibre.com> References: <20251125202307.4033346-1-flavra@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4582; i=flavra@baylibre.com; h=from:subject; bh=fPKQq9VW/0IRfnIwOJhKfq8568r/UARLM1IVoAPX3D0=; b=owEB7QES/pANAwAKAe3xO3POlDZfAcsmYgBpJhAFZUzSspl8rRCYGkd5xsAkHOgNqFIknAJX5 kQzb/3nSQKJAbMEAAEKAB0WIQSGV4VPlTvcox7DFObt8TtzzpQ2XwUCaSYQBQAKCRDt8TtzzpQ2 X8t/C/4+/yYGE6L2EJTqkqd4ZyypsfHo7VvWgFUuRkdZza9w4bvvl3uILk/YLonmqEFjOzeZiLg 2SJuhH0a4qnupHzwbb+kRDb6s/ANpZsnIryv0hlDIg4gXDY/NwG/VOcVsTVHRNDO+DasHBsEes4 KE6G1SjeV4GWedbvHvR1Nx3rrrnYZJgtyw0WPHwNsSzt9ACzAKatxjn7JA0Jzdgrb7jIT13jJW4 UNsTI6QuX8V4LMohiJq5ic3Z0XetjWZbq+AgYqm4qRbHZg6wGkDQm1MdlkdbaZ9qvpai9w6Z0vN LavEZLH0s8Mg+Q0AAswiVOt4s37J5UzzlDhTPFj3gSPp+uZqGhC6mFoAlo/ppy1AvMuSxJaJjrR Hzf2JgW/8kinPTNMFpo+I8hLU4pyZha1cajGqlbi7jsxSRTfL0MMlDiBkoFl5qNRgwBomyWReof aY42YJXGyaLkSl+r0ChKm2IhLUp8QXdqURB9tYslmuAIscaro3ShrOAM09m1LfGxKMzpg= X-Developer-Key: i=flavra@baylibre.com; a=openpgp; fpr=8657854F953BDCA31EC314E6EDF13B73CE94365F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In order to allow sensors to advertise tap event capability and report tap events, define a new struct iio_event_spec array that includes a tap event spec, and a new struct iio_chan_spec array that references the new iio_event_spec array; for the LSM6DSV chip family, use the new iio_chan_spec array and define an event source for tap events. Tested on LSMDSV16X. Signed-off-by: Francesco Lavra Reviewed-by: Andy Shevchenko Acked-by: Lorenzo Bianconi --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 1 + drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 57 +++++++++++++++++++- 2 files changed, 56 insertions(+), 2 deletions(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_l= sm6dsx/st_lsm6dsx.h index 3edff8456a8f..957dae73e13d 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h @@ -245,6 +245,7 @@ struct st_lsm6dsx_shub_settings { =20 enum st_lsm6dsx_event_id { ST_LSM6DSX_EVENT_WAKEUP, + ST_LSM6DSX_EVENT_TAP, ST_LSM6DSX_EVENT_MAX }; =20 diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu= /st_lsm6dsx/st_lsm6dsx_core.c index e1eb64a5b10d..1c70d8d80541 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c @@ -105,6 +105,21 @@ static const struct iio_event_spec st_lsm6dsx_ev_motio= n[] =3D { }, }; =20 +static const struct iio_event_spec st_lsm6dsx_ev_motion_tap[] =3D { + { + .type =3D IIO_EV_TYPE_THRESH, + .dir =3D IIO_EV_DIR_EITHER, + .mask_separate =3D BIT(IIO_EV_INFO_VALUE) | + BIT(IIO_EV_INFO_ENABLE), + }, + { + .type =3D IIO_EV_TYPE_GESTURE, + .dir =3D IIO_EV_DIR_SINGLETAP, + .mask_separate =3D BIT(IIO_EV_INFO_VALUE) | + BIT(IIO_EV_INFO_ENABLE), + }, +}; + static const struct iio_chan_spec st_lsm6dsx_acc_channels[] =3D { ST_LSM6DSX_CHANNEL_ACC(0x28, IIO_MOD_X, 0, st_lsm6dsx_ev_motion), ST_LSM6DSX_CHANNEL_ACC(0x2a, IIO_MOD_Y, 1, st_lsm6dsx_ev_motion), @@ -119,6 +134,13 @@ static const struct iio_chan_spec st_lsm6ds0_acc_chann= els[] =3D { IIO_CHAN_SOFT_TIMESTAMP(3), }; =20 +static const struct iio_chan_spec st_lsm6dsx_acc_tap_channels[] =3D { + ST_LSM6DSX_CHANNEL_ACC(0x28, IIO_MOD_X, 0, st_lsm6dsx_ev_motion_tap), + ST_LSM6DSX_CHANNEL_ACC(0x2a, IIO_MOD_Y, 1, st_lsm6dsx_ev_motion_tap), + ST_LSM6DSX_CHANNEL_ACC(0x2c, IIO_MOD_Z, 2, st_lsm6dsx_ev_motion_tap), + IIO_CHAN_SOFT_TIMESTAMP(3), +}; + static const struct iio_chan_spec st_lsm6dsx_gyro_channels[] =3D { ST_LSM6DSX_CHANNEL(IIO_ANGL_VEL, 0x22, IIO_MOD_X, 0), ST_LSM6DSX_CHANNEL(IIO_ANGL_VEL, 0x24, IIO_MOD_Y, 1), @@ -1260,8 +1282,8 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_se= nsor_settings[] =3D { }, .channels =3D { [ST_LSM6DSX_ID_ACC] =3D { - .chan =3D st_lsm6dsx_acc_channels, - .len =3D ARRAY_SIZE(st_lsm6dsx_acc_channels), + .chan =3D st_lsm6dsx_acc_tap_channels, + .len =3D ARRAY_SIZE(st_lsm6dsx_acc_tap_channels), }, [ST_LSM6DSX_ID_GYRO] =3D { .chan =3D st_lsm6dsx_gyro_channels, @@ -1438,6 +1460,32 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_s= ensor_settings[] =3D { .status_y_mask =3D BIT(1), .status_x_mask =3D BIT(2), }, + [ST_LSM6DSX_EVENT_TAP] =3D { + .x_value =3D { + .addr =3D 0x57, + .mask =3D GENMASK(4, 0), + }, + .y_value =3D { + .addr =3D 0x58, + .mask =3D GENMASK(4, 0), + }, + .z_value =3D { + .addr =3D 0x59, + .mask =3D GENMASK(4, 0), + }, + .enable_mask =3D BIT(6), + .enable_axis_reg =3D 0x56, + .enable_x_mask =3D BIT(3), + .enable_y_mask =3D BIT(2), + .enable_z_mask =3D BIT(1), + .status =3D { + .addr =3D 0x46, + .mask =3D BIT(5), + }, + .status_x_mask =3D BIT(2), + .status_y_mask =3D BIT(1), + .status_z_mask =3D BIT(0), + }, }, }, }, @@ -1952,6 +2000,8 @@ st_lsm6dsx_get_event_id(enum iio_event_type type) switch (type) { case IIO_EV_TYPE_THRESH: return ST_LSM6DSX_EVENT_WAKEUP; + case IIO_EV_TYPE_GESTURE: + return ST_LSM6DSX_EVENT_TAP; default: return ST_LSM6DSX_EVENT_MAX; } @@ -2620,6 +2670,9 @@ static bool st_lsm6dsx_report_motion_event(struct st_= lsm6dsx_hw *hw) events_found =3D st_lsm6dsx_report_events(hw, ST_LSM6DSX_EVENT_WAKEUP, IIO_EV_TYPE_THRESH, IIO_EV_DIR_EITHER); + events_found |=3D st_lsm6dsx_report_events(hw, ST_LSM6DSX_EVENT_TAP, + IIO_EV_TYPE_GESTURE, + IIO_EV_DIR_SINGLETAP); =20 return events_found; } --=20 2.39.5