From nobody Tue Dec 2 00:04:08 2025 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E19D621D5B3 for ; Tue, 25 Nov 2025 17:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764091204; cv=none; b=js7W/O2/JFvtXXx9vX8rDKeOFHqhlSlFBdArB7MlyKvIAgWTjO9F37hEh0J0P+hn6GJ1fn8SgubwmQ/nS0aXLmMlc2B6e0yXGI4AqkU4mSoDRg8GZMAtytDBRl/cL7KEGVtgLaQ+wcmTsR8KZVcGnrDERj5euhZgC9WKZrur5M8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764091204; c=relaxed/simple; bh=u+QW4wE0E+GuOWOEoMtw2A/DLU27AmIjNtqsJd4+/WI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ExZ7ZxXR3pmSGny806h/qUo+Nolh9v9r4BtKPeJo/+SbYJJzjdt+4E/05dNlNb4pAzQL7hOkcFm58cVlVTWBcWRRCn9dqcppj812gGM8HPOlf6THhAqBwa3bAWryO4JUJPJSqKxGclS/9AekvPNIAwk27PK+RdTlutml+dR0fBk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b=rFYvaTDp; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b="rFYvaTDp" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-343dfb673a8so5684166a91.0 for ; Tue, 25 Nov 2025 09:20:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20230601.gappssmtp.com; s=20230601; t=1764091200; x=1764696000; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=x8/SvNkDdVJgOARiH50aGa0Poz0t6L0iCgXicUtRbus=; b=rFYvaTDpQZ7aqSIAfY/WF47rJIZO+pK8DYwKCinqiEsvNhURSVH+ngr/qX0paWNldZ J8MGyKo+tGvV0m8WjmKvHdCgCqz6pRaoFZfsAo3YhUN43dHhgkC6LZk7dsBnT8hEUAVt ePs7/xauwWKHvJZc1pIR33N8hbAEbp+oZzvSHq0xD4t01gUx7DUJeHYnxSM94URmW1Yt VlijIc4SP/3GPGS2X+HU/C2izaQghEn+CvG/Qa+2vDGRvEYsVhru6fqIq+gm5RxJF7qQ OUDCkSUrQvz9EQE4hIhUrLBagKvNSssIa8uvGJU+IiR8cvkm/up8zzQoW03K+lBBnOlS r0Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764091200; x=1764696000; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x8/SvNkDdVJgOARiH50aGa0Poz0t6L0iCgXicUtRbus=; b=ickFanGjV4+NeBoAgZSZDTJ+UkPLnMmnO0Abc0LBD6zOlH7gc1zLzK9UMpaLiDytwv OCL1MjCu1Qh8Jb8lVgHtZECej1W/CSM1HIx9s/uyXXir1jxaSxhGIAi8dCCKPpPlvnTA tjPFCdtQKVhSx4PIsEqE4pJfcPKnZd94SCXuautaIbSK7J5DOZhUQyzv/gaXrPczO4FM E1rBJ6kpgq9Idsh+Tx8VJMSi5q2Nldd2UXubwYhvQaBbOMqsva9g3t2d5KipBJtQdmKc dxLYa8xJk8PhTBVfnj5LLwoIPVUmJ01wfLRs1mHhzybp+/T25estU3sBIM+3nrbZv/Sv 3yRw== X-Forwarded-Encrypted: i=1; AJvYcCXyiNhjxbZGikgtXzYyTWv5GCNFp+EyUIdbfHyVbNBoxikLHUrM3IMpl26RD4X69hDWEQUF4Gc1kHpCdT0=@vger.kernel.org X-Gm-Message-State: AOJu0YwsMoDTUnXH+UO5vlrNN/Oj7EA+P6Hts3A09+VtjDbZLIbnIy+a FF99MUtUWerQhGqSmRQ74bsjQT7TesQ7uMCu+B1nGiJmmvjLYxMWzhE4MmH2mE+bonY= X-Gm-Gg: ASbGncuEM+jgyjwKo0hNKhuHmMbhJ9CTiLxea9UvI/viJMvTS4MczwkyJAAropW8IdT crPpE7aQGViCwMDQE5YoumdrgK8TPnq/PRKgDlsJpT76ojdb46pUZcTEg1SpctItZ6uqS8OqITX TVbKIka9hUexDjISDFX4gemtzJfpQ5YgdJnk2/uJHz1r0nLuKIIef18aMaL1YezyW+3pMsfX8Bj ex6YXjx6VDiKUotzZSn5DcpyzoI0EaSEpfG1YYLCdas6F7rEkApo6T9DEPfkj4qEGh99u7QQhN9 bXoMfjpN/f3KPGkV7Cj8qFvvgrZbeuJYdGqXQoqq5Yt7E60EOnw3ybNpd/Z+zD14oPFj3Tr3L4l eh3jipjvlFzmuinLmViCDu+u/qpMSlLDdUO+HD1uXIl0CBWRvmh9wohzIDdsovsvyoTbCLzs+0b 3QB8UVmQFgGg== X-Google-Smtp-Source: AGHT+IFBCZHdOpAji2y54FQe0Qb0B7+K0VaS8ZtngzaGnCLTiNLOmI9AdpxFEoiSFQaEzFmpPmAChQ== X-Received: by 2002:a17:90b:180e:b0:340:bfcd:6af3 with SMTP id 98e67ed59e1d1-34733f546aamr15376598a91.33.1764091200071; Tue, 25 Nov 2025 09:20:00 -0800 (PST) Received: from localhost.localdomain ([49.37.219.248]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-3475e980f41sm1618722a91.2.2025.11.25.09.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 09:19:59 -0800 (PST) From: Abdun Nihaal To: lee@kernel.org Cc: Abdun Nihaal , linux-kernel@vger.kernel.org Subject: [PATCH] mfd: mc13xxx-core: Fix memory leak in mc13xxx_add_subdevice_pdata() Date: Tue, 25 Nov 2025 22:49:33 +0530 Message-ID: <20251125171936.98101-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for cell.name using kmemdup() is not freed when mfd_add_devices() fails. Fix that by checking return code and freeing. Fixes: 8e00593557c3 ("mfd: Add mc13892 support to mc13xxx") Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/mfd/mc13xxx-core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c index 920797b806ce..1ebf849d80fe 100644 --- a/drivers/mfd/mc13xxx-core.c +++ b/drivers/mfd/mc13xxx-core.c @@ -365,6 +365,7 @@ EXPORT_SYMBOL_GPL(mc13xxx_adc_do_conversion); static int mc13xxx_add_subdevice_pdata(struct mc13xxx *mc13xxx, const char *format, void *pdata, size_t pdata_size) { + int ret; char buf[30]; const char *name =3D mc13xxx_get_chipname(mc13xxx); =20 @@ -381,8 +382,11 @@ static int mc13xxx_add_subdevice_pdata(struct mc13xxx = *mc13xxx, if (!cell.name) return -ENOMEM; =20 - return mfd_add_devices(mc13xxx->dev, -1, &cell, 1, NULL, 0, + ret =3D mfd_add_devices(mc13xxx->dev, -1, &cell, 1, NULL, 0, regmap_irq_get_domain(mc13xxx->irq_data)); + if (ret) + kfree(cell.name); + return ret; } =20 static int mc13xxx_add_subdevice(struct mc13xxx *mc13xxx, const char *form= at) --=20 2.43.0