From nobody Tue Dec 2 00:25:51 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2D02326D4A for ; Tue, 25 Nov 2025 15:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764083200; cv=none; b=DpXdHn3hmYhCP9qP0gBpq9Qt0mlFrlRBFVrLbcms4JaBF7iaqIrqpJoSurGI8xHm3hSOkx96i4bF1JngDervocJ1bgqJqJCa47X5b22CvC570+grj84Rady+i/NjS4HQe8Qwo1MzlLdR6wIkTAsc/A+ySCIMEsop6V2xqHwl8JI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764083200; c=relaxed/simple; bh=Nh3Ty6TiX7FCEIz6ikF19spmIxiE8SBKU0CTyBwe/s4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R992hKyXxfPtJ96VZoDRPaZimD3dQlEa2W6V/8K3O0IVlTjAR2Zk1QVUd4CWe4+HXPpb24L7ANJi69y+WjxUPUQdMQDVpa72sENnY+vzWgqENo5xp5Y+tFdfdSApxjUqkoVV4YtkN8XYn9bGLZ6QB0ki3lGhGdX7rn1tx7vbL8o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KITUXPaA; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KITUXPaA" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-429c48e05aeso3470049f8f.1 for ; Tue, 25 Nov 2025 07:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764083197; x=1764687997; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LsvzpDdHuaCCHjJpYBsgV96uU86b6iPp7/i436ekO/M=; b=KITUXPaAPaNEjZuoZ9vUCvYuqHolUJJqjZI/47FnxXC+Ecl/tBc/RPSMEzm4eAVHKq jSWTfQ6kt8kMYIByk96Fb6b04yJsd3jvOq4aCCJnUMW/t2owUa3ubP4zcZMAtzS6l0pW ET9fvxoB6E+Jx4btB/otiTfhm9Q2TLK4gk7x/iZBv+yqXyquH+64H6uicpC8M9j6kYPA LmKlPdJXZXfT23ktaUtLtTqmC/Uq0zQg7sC+5XopPU1s4Y8WB9dX0aqeDJTxDzca7Qxj SuTAOHNkFx7L/dyxAB4sRx20a+xBE7bN7+o7z8uF5D7vUArfQQTNdcukuycMTq7s8vbE 1F2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764083197; x=1764687997; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LsvzpDdHuaCCHjJpYBsgV96uU86b6iPp7/i436ekO/M=; b=uhxg+JI0+vF3OA8Z1l17C18TJLgvB/byLH8+IIa+7MV8HFbu/dY4UWDk4+oIYQtTmY 8ki8gY2/SOa2mULUWHR0alWfW2i6eXZiepIy/CsGAVkrWP/0UZ09TNDyWbzwzIz+n3/D mPXwvNKUm3YMjCTW2ZWyV1+C7Ly46jFipQ8QHya1saKtQjXTULj989RZB0PItYG3vejp a5v/wB5XKkvmIL0iODxJ7aOrCaAcEHXX2kvE9oFqAJDb1bYgbU+nUhbtlbTRNfLcdkyE o0YD5z01oi1ZRclJIkGdCFenSrMN8PycX+PpxO2HxggU++7rYWOhCfwomv911QM3+2bi V9Wg== X-Forwarded-Encrypted: i=1; AJvYcCVUR47Ci+wkiS8RL2zx5GZahjk/NNoDmVAPgaAPlepKTFwhR3h1ovU29MV1Xn3aStfdxpE0Pc05aqFURn0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzlxxooa8mhsuDJ00qYv3LxgxjI20t0+sdUpgEC6hakYMnLaST6 yZ/Dj+FZz5Fpzta9AD0FQApVEo4VFRaIcwCUX79v96tiZ62VsKJZI2RS X-Gm-Gg: ASbGnctwqx81PMDW/xgGQAvCynt69BXweZLnT/tfp9+9oHkz1/+PP9hE6qiXRB2F+Ly Z5mR6CBgKCISWvTms2ciJlV40ZxwUC4FvmgoZFzdKNxUp/C23Y4oVAlutQg+JVQ+E4GYjHOsup5 G4x66KtRyI71vS4QyH4aqsT2cWH/n/pMebPzmke4peltHvXuLtsQoV9dFImeBy4X12HhKPRNUxV qH4Cl6ZWz9oTN6/SdWa9tUVRGHXTgF9L59vMeCBHHbs407SLvNZdpaLj7R7UAidcw59U0H8rYLQ wESEF7k40gzr0f8NxMrVJ+eda727Fuc9LxVJ0Ub7p+ENQLF28eQuv7oGDhiw5B6UYpCoZAru036 +vfIHrLMrEaAY6KgM0YuT2o9a2hLRsyUlcZpjl/9OILoPlJNmjydZUFw3wmjssU+vy7FkoHniT5 YzlrOximEwIY8hrJvTvdUyvC4pyxhK7GXAW4Mqj/H6cr/97a8hk0GdPsNwyccXtgitSyyIdY9Yb A== X-Google-Smtp-Source: AGHT+IGQ2lrJjpd5A0Bi98GjwpO8U0bS/285r/RkgU2XPW9IQYDqpZ5dHzIRnpjdKjTjaKMviAxfTA== X-Received: by 2002:a05:6000:2508:b0:42b:39ee:2855 with SMTP id ffacd0b85a97d-42cba6528a2mr21269154f8f.8.1764083196944; Tue, 25 Nov 2025 07:06:36 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fba201sm34797809f8f.32.2025.11.25.07.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 07:06:36 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm Cc: Biju Das , Wolfram Sang , Lad Prabhakar , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das Subject: [PATCH v4 02/16] serial: sh-sci: Add sci_is_fifo_type() Date: Tue, 25 Nov 2025 15:06:04 +0000 Message-ID: <20251125150632.299890-3-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251125150632.299890-1-biju.das.jz@bp.renesas.com> References: <20251125150632.299890-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Add sci_is_fifo_type() helper for SCI operates in FIFO mode to simplify the code in probe() and remove(). Signed-off-by: Biju Das --- v4: * New patch. --- drivers/tty/serial/sh-sci.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 53edbf1d8963..56d6489b2a7c 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -3546,6 +3546,12 @@ static struct uart_driver sci_uart_driver =3D { .cons =3D SCI_CONSOLE, }; =20 +static bool sci_is_fifo_type(u8 type) +{ + return (type =3D=3D PORT_SCIFA || type =3D=3D PORT_SCIFB || + type =3D=3D PORT_HSCIF || type =3D=3D SCI_PORT_RSCI); +} + static void sci_remove(struct platform_device *dev) { struct sci_port *s =3D platform_get_drvdata(dev); @@ -3556,8 +3562,7 @@ static void sci_remove(struct platform_device *dev) =20 if (s->port.fifosize > 1) device_remove_file(&dev->dev, &dev_attr_rx_fifo_trigger); - if (type =3D=3D PORT_SCIFA || type =3D=3D PORT_SCIFB || type =3D=3D PORT_= HSCIF || - type =3D=3D SCI_PORT_RSCI) + if (sci_is_fifo_type(type)) device_remove_file(&dev->dev, &dev_attr_rx_fifo_timeout); } =20 @@ -3918,8 +3923,7 @@ static int sci_probe(struct platform_device *dev) if (ret) return ret; } - if (sp->type =3D=3D PORT_SCIFA || sp->type =3D=3D PORT_SCIFB || - sp->type =3D=3D PORT_HSCIF || sp->type =3D=3D SCI_PORT_RSCI) { + if (sci_is_fifo_type(sp->type)) { ret =3D device_create_file(&dev->dev, &dev_attr_rx_fifo_timeout); if (ret) { if (sp->port.fifosize > 1) { --=20 2.43.0