From nobody Tue Dec 2 00:25:51 2025 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3DCC328B69 for ; Tue, 25 Nov 2025 15:06:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764083207; cv=none; b=X9NleKL4c0YHyMvHxwlHQykp7ZoeP30PGEv37VpJZudgVhvxDtLw6nsUw32bSd7ynQLkV4ApopZdfhZHrEkL3YD8aPtFXVi9wH0nJuTAMpR0UMeWstg+jrDej3bObPfeQSPkJD5IAqYq/VIV5cZLXfuGHV3G+B4IA+Xl8mJLUtg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764083207; c=relaxed/simple; bh=RqWNr+J2yXgOsuO0923Xd+N0rvDeRRxq1yU1YzPrTew=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SmdEUIBsoXu/jqVbjcI3sGCWtvT2Ke8YEXog/AqyqbwAhOLXlJ6GpFPeCGL3MmsCm7XSHXS3oiyroHsyr4FyGEkqflZkEPiaJOPeE5jw1eYbCI9cVCcQ566Rgpffa7wTEdHa+qfAduZqavmnY5L9j/guXX1uu+c+XiMZCIhMz5c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NyiXADg1; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NyiXADg1" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-429c82bf86bso3305602f8f.1 for ; Tue, 25 Nov 2025 07:06:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764083202; x=1764688002; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6jX3LIbgY2Qs2rnCAEJyiR5LJ9WWfAcTghJovwqWhk0=; b=NyiXADg1wq59/Lan29YX1N8/NiYv3ArDTmDW/KlGMkWdJ823QpatOmkCrifAUpZUNv RrLjXJeWRiQAQRmvN9dbkE3jJTuqp8IxxmGQXgaDRxEodApiUNfwCKF0jHtPI4X5kMWG ejTG9/Ufl6zNYw4LluBWjmj86nJaQvqXoWszyJmMQmpEK9P77n5CHazyO0OBAUspGdlX 1SdwmXcxybU5hBMjS96XhSXHWiqqHfuuTsMGHVGYrXOpbNkJ8rFzbS38hjco7GhY3tfs W85keXXDRKB2EGTZa3ulvg99GnZOwI8UkkgIYP38SIibhracFA7eNaYWLueRLVEMR6CK +Euw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764083202; x=1764688002; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6jX3LIbgY2Qs2rnCAEJyiR5LJ9WWfAcTghJovwqWhk0=; b=KjTJJmmuM2NpYkTo1jfGiAjk7aQ325v78fsvnAEXdk86qE3IsEKBv9sHEvYxuG6Q0+ 4VIC1qzOOEG5AI9ZZVrHsJ72SssQdzklKowX21hGhT49uKwmChao4yCFKzWDe9JpuN3m JBNmcMZN9kduwwaQyZoVGgM66f+MasQFiFNY1J7F5qCeAzEURuhS6kWl9Glig59PM6ql ChmRtCxT59M8uoyJiN3w4+qLKiIkdSuyL5SPhXfn8Z2TdQJ0E13qZTjmHww0iqRg7Ud9 3G3YNKjkExUk9dm/Rem2X+nu8QVqanLe6TyXR8DZ5KXd0mmEsBx1lZ8E6bMO62jT/0Yu Be7g== X-Forwarded-Encrypted: i=1; AJvYcCVy0ArxZ4cFa/xP3l2IXBO7+uxhy4nGOoEt75fizvmaFLdvf6nGHpyAHXpu2B6e2WxVNB/VG1Dj1PtZymY=@vger.kernel.org X-Gm-Message-State: AOJu0YwcrDdjD83q+EINZOXYM8c/J9UNkjRr/J4b648VPu1qU6hEke8K PfSw84iDWbUo6FrLnj54upXHgXeTplVFbE43BXdjiucGCMaqTGvdfPJg X-Gm-Gg: ASbGncsXXQW2P2aricAIVZO0/KnHFOdDX28NGw4IZURHLdIClN/SK033yQf1XJ94H5c c7pNGhUDdWBFwlFp7uoYnKziUnq3LAeMDA2RZn2cu0AdC+/5TS1Xb4nsaO72PWaqySO7pQOo191 9zCm8fe+R+dbpUA2393Y1/I+7mWd8/sok63QreuDP7fzUMrjMkuhrWgMGVnYchCJNwVUXrbCrPF Alq9dTcIvntC5Bwt1QznwHT71hhHQgMdsNyuq01bQJch5KaKRI5js/Ep9D6JMLsrVglZ2BrSPKp vYlP1BALMd8SbhBQIpLmTYkHd7VDZ9NYjjed6DYWMRD0Q5uw0/fL88UsP8T+eWdmmseyHPTROWf 5Oqmqb/NCR30DCsbSLPrFwtJfZ0tM5p601XPRLw0qUnhwvUgwAcsTZ4sOWcgCDmes0xwQnxJE8m h7P7tbU18eeX8oRqxRICDDA6nPbRCzV+rYSh4Iy++vvZyJQdQgpF1ymSWrTt1fY43IIg6IYxQVe g== X-Google-Smtp-Source: AGHT+IHJ3f6R4O0T6ProSqd6CgB0eBY01jmedSgsJF/qjxeGwfodfwrWbqyZIRq1uJuQdty6QtAvRg== X-Received: by 2002:a5d:64c9:0:b0:42b:47da:c313 with SMTP id ffacd0b85a97d-42cc1abdefdmr18028213f8f.3.1764083202442; Tue, 25 Nov 2025 07:06:42 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fba201sm34797809f8f.32.2025.11.25.07.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 07:06:42 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm Cc: Biju Das , Wolfram Sang , Lad Prabhakar , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das Subject: [PATCH v4 09/16] serial: sh-sci: Add sci_is_rsci_type() Date: Tue, 25 Nov 2025 15:06:11 +0000 Message-ID: <20251125150632.299890-10-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251125150632.299890-1-biju.das.jz@bp.renesas.com> References: <20251125150632.299890-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Add sci_is_rsci_type() for RSCI port type. This will simplify the code when the support added for RSCI_PORT_SCIF32 private PORT type. Reviewed-by: Geert Uytterhoeven Signed-off-by: Biju Das --- v3->v4: * Collected tag. * Updated commit description. v2->v3: * No change. v1->v2: * No change. --- drivers/tty/serial/sh-sci.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index ae76705baba9..914bdb41ccc6 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -1182,6 +1182,11 @@ static int sci_handle_errors(struct uart_port *port) return copied; } =20 +static bool sci_is_rsci_type(u8 type) +{ + return (type =3D=3D SCI_PORT_RSCI); +} + static int sci_handle_fifo_overrun(struct uart_port *port) { struct tty_port *tport =3D &port->state->port; @@ -1190,7 +1195,7 @@ static int sci_handle_fifo_overrun(struct uart_port *= port) int copied =3D 0; u32 status; =20 - if (s->type !=3D SCI_PORT_RSCI) { + if (!sci_is_rsci_type(s->type)) { reg =3D sci_getreg(port, s->params->overrun_reg); if (!reg->size) return 0; @@ -1198,7 +1203,7 @@ static int sci_handle_fifo_overrun(struct uart_port *= port) =20 status =3D s->ops->read_reg(port, s->params->overrun_reg); if (status & s->params->overrun_mask) { - if (s->type =3D=3D SCI_PORT_RSCI) { + if (sci_is_rsci_type(s->type)) { /* * All of the CFCLR_*C clearing bits match the corresponding * CSR_*status bits. So, reuse the overrun mask for clearing. @@ -2015,7 +2020,7 @@ static irqreturn_t sci_tx_end_interrupt(int irq, void= *ptr) unsigned long flags; u32 ctrl; =20 - if (s->type !=3D PORT_SCI && s->type !=3D SCI_PORT_RSCI) + if (s->type !=3D PORT_SCI && !sci_is_rsci_type(s->type)) return sci_tx_interrupt(irq, ptr); =20 uart_port_lock_irqsave(port, &flags); @@ -3289,7 +3294,7 @@ static int sci_init_single(struct platform_device *de= v, * The fourth interrupt on SCI and RSCI port is transmit end interrupt, so * shuffle the interrupts. */ - if (p->type =3D=3D PORT_SCI || p->type =3D=3D SCI_PORT_RSCI) + if (p->type =3D=3D PORT_SCI || sci_is_rsci_type(p->type)) swap(sci_port->irqs[SCIx_BRI_IRQ], sci_port->irqs[SCIx_TEI_IRQ]); =20 /* The SCI generates several interrupts. They can be muxed together or --=20 2.43.0