From nobody Tue Dec 2 00:25:39 2025 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48975315D24 for ; Tue, 25 Nov 2025 11:27:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764070022; cv=none; b=c5KLFfvqvk2HTiZ7F1BgcwsEcXOF98qnpFikHUdJ0x2UoDFrTLZIROLZbM61n5JTj67gLSZHfHt5bMhfuna7sEZy3hl2YMVZ6rFz/D7rWpd4T/goFcJKGXyp2ssrYYK5UHRNtF4yfFskSL2ZE8wWb5aWNVpr0/PvmoAdQHlybH0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764070022; c=relaxed/simple; bh=qWZZt0EJ5EGhQp+jROsS7jIaWHMmW8TPlU611Gbd3ug=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j3ndlIRDx3OqTTeqGWOP1SzQ4WAgYKS/gqIXZhodGFQFl+VFrZbhtg8ehYrvziLsPrGqTAgkNlxk3soKfORlbEt1Lk88TvUd+2CDt0UZUG6zHvZaqMn0tbbxdlQ/NflGfuiL+E+NLuBLy8UmQi1K+4FzLNIzns9D1ByKefAIoUA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GURsFWKs; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GURsFWKs" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5959105629bso5188044e87.2 for ; Tue, 25 Nov 2025 03:26:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764070018; x=1764674818; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YkBdbnO/aTuh3Uyl4FaE6iA6IZG4p2hYiXFE9xVcIHM=; b=GURsFWKs2o/H6SYDHodny8XQ0QX+t5IW/HwszqcHo6e3VchnKaKAmmBJgL82du085z e6SuFq2kpHJZvZqgbJAYFGXROF9zSCeGTnwFd7nSQIIcqYBIMEUq55196MobW09eIRx4 pnbAgHCqc+y2r3IkbKK/73pI8lJn4PZjN5ClsgcPX1ZEHxpV1PB9aSIpM+RheKvC1i5V 69NaNpKZc8LUmeHLi4IceUV1nd0KOwrr3cUzj4NMhGQ9kZlbmDOVEAjRGL6qSYgk7Yw8 T8y8ZsBs8jqA6oqEwUVUfiLPuxsN7Ii8UPeoZ9nHE7XfHboQKAoSwRL6WV8Q0q9O3ztM hpBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764070018; x=1764674818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YkBdbnO/aTuh3Uyl4FaE6iA6IZG4p2hYiXFE9xVcIHM=; b=xC+zu8fclUxujfn2fDo52UxwyFMTzGQPb37jWShNyKW2AwSOiEpbx3r1butdqnKyhp 7FD2tSW2VfFKeOqIDN0wJqR0Up57+Gh7B92P/hric51AlqfONUD9/cKR66KQW3nimLAP UAfCp9qbOoAdpZZkmmDAnGHSxU9+RSAJr2pZ595IdYdMD2lfJih1nH7v/gHiVYibHymX FNxYqaFDbC3TVz2ypjmDz2V6hRPNV08/czfQpEAJXs3ERqz5U8aMfSRxKbbNifqj/3Q0 VfXMTfBb+wyvQOk9Ho3fJ1raxONXRoeAU3D2lZdC63ViJjmSA2amExJ7Ror19Im87hw4 lUlQ== X-Forwarded-Encrypted: i=1; AJvYcCXC1XGq2NTJ9qIYL1oBAaiBGppLdE5tec/mH+5etiKYJIfTWhiBMCdqQFRvLfIJpr3aCX04z0q2f6WGcy0=@vger.kernel.org X-Gm-Message-State: AOJu0YxRmh0sAhXdh4qaaTd8qmqwtqw8/NI4WiuZ86xnvim0MJBrjwy1 DZuafaNeXJVyCT4ryAorW1VkX5UfQgVbT7ML0YJTLbgR2AHaeyrEaZCVzLgqPSxe7/c= X-Gm-Gg: ASbGnct8jaBFPXiYBwoDkE5yZ+kZCjyuWEkkMfKjAQ5OztSXG4XJtle/XXTV8b8Hl08 dDxQOtlXTtP7bMEvllsqAFGz/ox2nJEblDx9heRueXpPFrNwC0lk3zwCYDvNLvmlE8Hw/DBXqLK Gy2FRKNK5guRiHOc3pcF5UR++bSkgxSJwZomuciQMh4Cp4G0m/jajYICt8vONByj0wAQChWYKq+ ZJJObRhih6Mbi/2m8mMx9eTiULaxzNm1WebZQMqS/eotf6Aeorzf74AhcX+6LpncqwZZTWj6v+X myjD/7lR11AyOTWC6CEo4+hlMiCKXT+0pvYzWL3uA4XCuRR7wspXD6IHPSvK5X3axY/nbNtoYef wL1st+dUVK/yQ8hqZjRq2W06sGmwgSSY+7KwVNqLmVCU1tIMeE+Ryeh3EYniPtqxGmSO5F6aOym aSBqKegsA+nTY7EZjoHvlqdDwW1Kx/eVihAPRA4DtOW+5/9XHXah0JX9qts0hU X-Google-Smtp-Source: AGHT+IF5/zPRqq5Gc8LX/DzP5wRoX37ptDORDPlLBcwihZhjQ8Hod/OKSQTB4ujkPlnaRcuFpIKOGw== X-Received: by 2002:a05:6512:3a82:b0:594:27dd:2701 with SMTP id 2adb3069b0e04-596b529d662mr891658e87.49.1764070018227; Tue, 25 Nov 2025 03:26:58 -0800 (PST) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5969db7563fsm4993526e87.2.2025.11.25.03.26.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 03:26:56 -0800 (PST) From: Ulf Hansson To: "Rafael J . Wysocki" , linux-pm@vger.kernel.org Cc: Vincent Guittot , Peter Zijlstra , Kevin Hilman , Pavel Machek , Len Brown , Daniel Lezcano , Maulik Shah , Prasad Sodagudi , Dhruva Gole , Deepti Jaggi , Ulf Hansson , linux-kernel@vger.kernel.org Subject: [PATCH v4 2/6] pmdomain: Respect the CPU system wakeup QoS limit for s2idle Date: Tue, 25 Nov 2025 12:26:43 +0100 Message-ID: <20251125112650.329269-3-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251125112650.329269-1-ulf.hansson@linaro.org> References: <20251125112650.329269-1-ulf.hansson@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A CPU system wakeup QoS limit may have been requested by user space. To avoid breaking this constraint when entering a low power state during s2idle through genpd, let's extend the corresponding genpd governor for CPUs. More precisely, during s2idle let the genpd governor select a suitable domain idle state, by taking into account the QoS limit. Reviewed-by: Dhruva Gole Reviewed-by: Kevin Hilman (TI) Tested-by: Kevin Hilman (TI) Signed-off-by: Ulf Hansson --- Changes in v4: - Added tags. Changes in v3: - Updated the commit message. Changes in v2: - Limite the change to the genpd governor for CPUs. --- drivers/pmdomain/core.c | 10 ++++++++-- drivers/pmdomain/governor.c | 27 +++++++++++++++++++++++++++ include/linux/pm_domain.h | 1 + 3 files changed, 36 insertions(+), 2 deletions(-) diff --git a/drivers/pmdomain/core.c b/drivers/pmdomain/core.c index 61c2277c9ce3..4fd546ef0448 100644 --- a/drivers/pmdomain/core.c +++ b/drivers/pmdomain/core.c @@ -1425,8 +1425,14 @@ static void genpd_sync_power_off(struct generic_pm_d= omain *genpd, bool use_lock, return; } =20 - /* Choose the deepest state when suspending */ - genpd->state_idx =3D genpd->state_count - 1; + if (genpd->gov && genpd->gov->system_power_down_ok) { + if (!genpd->gov->system_power_down_ok(&genpd->domain)) + return; + } else { + /* Default to the deepest state. */ + genpd->state_idx =3D genpd->state_count - 1; + } + if (_genpd_power_off(genpd, false)) { genpd->states[genpd->state_idx].rejected++; return; diff --git a/drivers/pmdomain/governor.c b/drivers/pmdomain/governor.c index 39359811a930..bd1b9d66d4a5 100644 --- a/drivers/pmdomain/governor.c +++ b/drivers/pmdomain/governor.c @@ -415,9 +415,36 @@ static bool cpu_power_down_ok(struct dev_pm_domain *pd) return false; } =20 +static bool cpu_system_power_down_ok(struct dev_pm_domain *pd) +{ + s64 constraint_ns =3D cpu_wakeup_latency_qos_limit() * NSEC_PER_USEC; + struct generic_pm_domain *genpd =3D pd_to_genpd(pd); + int state_idx =3D genpd->state_count - 1; + + if (!(genpd->flags & GENPD_FLAG_CPU_DOMAIN)) { + genpd->state_idx =3D state_idx; + return true; + } + + /* Find the deepest state for the latency constraint. */ + while (state_idx >=3D 0) { + s64 latency_ns =3D genpd->states[state_idx].power_off_latency_ns + + genpd->states[state_idx].power_on_latency_ns; + + if (latency_ns <=3D constraint_ns) { + genpd->state_idx =3D state_idx; + return true; + } + state_idx--; + } + + return false; +} + struct dev_power_governor pm_domain_cpu_gov =3D { .suspend_ok =3D default_suspend_ok, .power_down_ok =3D cpu_power_down_ok, + .system_power_down_ok =3D cpu_system_power_down_ok, }; #endif =20 diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index f67a2cb7d781..93ba0143ca47 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -153,6 +153,7 @@ enum genpd_sync_state { }; =20 struct dev_power_governor { + bool (*system_power_down_ok)(struct dev_pm_domain *domain); bool (*power_down_ok)(struct dev_pm_domain *domain); bool (*suspend_ok)(struct device *dev); }; --=20 2.43.0