From nobody Tue Dec 2 00:24:06 2025 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5D3B317702 for ; Tue, 25 Nov 2025 11:21:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069681; cv=none; b=U0k7nBuvDuqYOBOftzv8vo8v1KM1sOvpHkzXjVoPcMtXLvEX1SrXTshGyKgEQ5kMA2InrwkUsk/FOgVl2drXZxh+Uk6hC/Bk5lkUPmh2IyjcKycbRBlKLhm3jwXyPrdMSsqVViU8e67x+XQrQPTrn8ekEf7l2RmYbW44TXrf9XY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069681; c=relaxed/simple; bh=YBtaO/eBYbzQQWoYMOteVAhhJ+DKjGwoQ/N2zOVhKW0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VIH6/PbNcv5URwmGu9QLpFkExvRdBOi9k/TvDOOiHYRXDUVyjz3337EH3d6gvwBJEbM69onAuRsONTmz62k2uQ3LFTVSAtuaTVc0MkVpAQngzvJCAS2MbInTb0IdmWHY0moca9nV7VC+IXRNztHwBVA9KtAxrniKyIOCWumc1Gc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lUzKUicj; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lUzKUicj" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3438d4ae152so5917169a91.1 for ; Tue, 25 Nov 2025 03:21:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764069679; x=1764674479; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ol6FJ1vrGQKaUJffz/esQb5b2URIUDMsH3CGBHb/slA=; b=lUzKUicjHLub4/WoEzMHSCfNrS/TeBBQRyescftaaI1n5A9ElYJUBDGKBph5l+rqbV uWTpvHYgcegi09An8uNrayhWWP3acrAd/fahON8rxhTlpWGXrh4KUSFkKr4WvM/cMw+D d6LurxZsB5Dh2ieU2RqlPlStuRK/b+cDjOHKCyCKnhLwtDMvZQFBqeStA8Z02juo0KT4 DPkoRnlvd8xBrzP/r8LiA/lvE4T54QzxhjJjAsu8oRt62TCOK56/RyHBhZbIx5r3zqup +eLRZ6dI4Mcb4E/mXBl5LN1iBOnOeEA+6HdgveTznz4rvIxUR8OSxd5J0H04VHnbFgLS YHUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764069679; x=1764674479; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ol6FJ1vrGQKaUJffz/esQb5b2URIUDMsH3CGBHb/slA=; b=Csan1q+Me0xAuHT4AVq4fHqsbluqemCxmc9yAD8CSNqwPo04QWBeH+eHmv5zdezMo9 xRRdWxtjTFVM/AL+ASmWV/kZ3Z8aj4lqM3YLO65n17/jzCFtlF5WuumoYb1Hi4ETFWCb Nrf8buUgNnohBQd582F39qt3laAMyikGQjyx0ceadmuSWHOHpg2eFpycdRVsI8fTmDSC YH1lGB4Epk/9loMo1aBwXOekqB45EuGRn29gwYOANWCra3xSdUTKnRI9cJPK/h4qi3KY tKPpyxBaFDpNRXD+9lDojH/mHztlfI1jYatqAPZ4iHxl4vjQTGO24uCYq178D/2lFbjf 8nTA== X-Forwarded-Encrypted: i=1; AJvYcCWFW19Td8ETN0ac2STDZLXJwaEL2OK/gt68FVlfTAXWjX6UuBpXy69HyEVXHLAypAJ/68NTkFbV9NXlYPE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxr+IMWQtILYnnwt0cLAiaP21v8QCzOFeGfjoQwcO9algY/UOz1 wyhpr3oMIO7ioSiuJRVfewO3xoVYg22mAy8pfg7OFgoVGvZQN17NG9CF X-Gm-Gg: ASbGncvDQ2E99fi820u46WgpWZ7R0VkohjMDgQdmerB3JGFiZU5lxhE0jj2YqGEjkWm 2Y0ZmZZEETzDxYopJGyIyIh04BNzBS5WxWtHfhRnAeeVs6G9JgMkCWr5XIA8SLXq7DBPXHFu7v0 +ixRbtE3FvUqGrKA1jKUc3FB4Amb2lBIu4gg/9Ulot3LfpUxpiyAenASQ1+O8kSLenARC1TX0kB 9GuGelf3cdO+ldYZb6Oczfi9Yk5OTrwtcsCxMUIX9hHn6LW+Xslt4rlKBpgCJ1xpdFZkRWaPPvY Yo42POjKarytDvU+egnhzCW3GN9gxHC0iq3asIbcvwcndlLxcsa1GxBXwdqXNdReQz3nHwtP+Mz LKzppQ9fefdC0amiAmiHZuL28nxQE17X1n9N2Mp0zTuSdJ9cZ8VCi1Y3FhPYjrpQf4uiVCuG38M iK+3QT0eXjM0+W8MbUr5zj2/8S+bHNySIWZdu0p3WkCA8xBwy6PZOXM2mgTmt8pJcIb6YgQjpN4 pY+kC++myNepMKIhnBvfPMCp4q1YFat3dAv1N90kbGVIy12aU7lVUd3v64CkuOJ07zt7d5ojjHw 2v4JyMxUJHAajlDbj8N77Oa+QCz1oKn2eg== X-Google-Smtp-Source: AGHT+IEznkxcTSR7i/lIJr2+8XsplWKM45jT6llpuiaa5oIQh+yi25Xglc4E8X8i2VZvEBaHegRsFQ== X-Received: by 2002:a17:90b:48c6:b0:340:5c38:3a56 with SMTP id 98e67ed59e1d1-34733f5cef1mr14909715a91.37.1764069678967; Tue, 25 Nov 2025 03:21:18 -0800 (PST) Received: from cyberkunju.asia-south1-c.c.gen-lang-client-0196962068.internal (125.31.93.34.bc.googleusercontent.com. [34.93.31.125]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34727bcaf13sm16296250a91.1.2025.11.25.03.21.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 03:21:18 -0800 (PST) From: Navaneeth K To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, david.laight@runbox.com, Navaneeth K Subject: [PATCH v2 3/5] staging: rtl8723bs: remove dead commented code from odm.c Date: Tue, 25 Nov 2025 11:20:57 +0000 Message-ID: <20251125112059.16913-4-knavaneeth786@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251125112059.16913-1-knavaneeth786@gmail.com> References: <20251125112059.16913-1-knavaneeth786@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove obsolete commented-out code that references unsupported chip variants (ODM_RTL8723A, ODM_RTL8188E). This code has been dead since the driver was added to staging. Also fix the resulting formatting by removing the unnecessary outer parentheses and moving the inline comment to its own line. Signed-off-by: Navaneeth K --- drivers/staging/rtl8723bs/hal/odm.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723b= s/hal/odm.c index 4b36af47f680..639b6da2302b 100644 --- a/drivers/staging/rtl8723bs/hal/odm.c +++ b/drivers/staging/rtl8723bs/hal/odm.c @@ -609,15 +609,12 @@ void ODM_DMWatchdog(struct dm_odm_t *pDM_Odm) /* 8723A or 8189ES platform */ /* NeilChen--2012--08--24-- */ /* Fix Leave LPS issue */ - if ((adapter_to_pwrctl(pDM_Odm->Adapter)->pwr_mode !=3D PS_MODE_ACTIVE) /= * in LPS mode */ - /* */ - /* (pDM_Odm->SupportICType & (ODM_RTL8723A))|| */ - /* (pDM_Odm->SupportICType & (ODM_RTL8188E) &&(&&(((pDM_Odm->SupportInte= rface =3D=3D ODM_ITRF_SDIO))) */ - /* */ - ) { - odm_DIGbyRSSI_LPS(pDM_Odm); - } else + if (adapter_to_pwrctl(pDM_Odm->Adapter)->pwr_mode !=3D PS_MODE_ACTIVE) { + /* in LPS mode */ + odm_DIGbyRSSI_LPS(pDM_Odm); + } else { odm_DIG(pDM_Odm); + } =20 { struct dig_t *pDM_DigTable =3D &pDM_Odm->DM_DigTable; --=20 2.43.0