From nobody Tue Dec 2 00:02:18 2025 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09A883164D7 for ; Tue, 25 Nov 2025 11:21:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069675; cv=none; b=hShWHgsRN+3ccen0bJ5HJvqmK2lv7IYYOM8wat81jLvunAEkBQ9Ut0NVmC/DX9VDHkVbwqjSf+JGUMwwro76viG5gC99z0XMlK/wlrrfloRV3v78EOzZS6LoKba/W8c1v5hn7rfs4D7/l4W07CrX5Ik3n8fL4AjgoMTOwc/SeHM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069675; c=relaxed/simple; bh=ovkN/QtqiTh6IBjF4Ai13OqOr346zlINWglhpIlW60o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=spPAilGZeRrepnnTklityHGuJx7HbBC/MEbpi/WAT7txI1Km7Ix24xD5b94bw7jOSwd4Q6lNfF0ifWqyh09+4w0wrDUZEkzKgFssqNat1vW7Ps9liSItROanWMLSrzqLM0xqpWB8qaisNkb2Wieqybm1I+LTQay5gz9ikBI3+Pk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nD90XwBj; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nD90XwBj" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-3434700be69so7739297a91.1 for ; Tue, 25 Nov 2025 03:21:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764069673; x=1764674473; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eC66Ck7qicXDGH3O+D4ASvf7yKcAVNQleViJcYPhp7E=; b=nD90XwBjItk9U5Ii3xRX46M6a8poIokhgGSagdphYYj/ByRikY4QLVLxIZ6aXdVmx7 JlC0DbvN55n0Vbn2tF9k3p/9i9dcMiWUoQI1HdeGhgrlythQLpy+7Cgbh2mqeF6GZJ7Z zbIJdDPcnaL181/MAo1DOTEWuUbya6dawoMTpQm2gHzu4OkTtGBQixbTIHN22coyUHRO MfjNB22ffwtd/viaH6XKVnFQdTse4zwBsWlGPub6WUS3Z59J0bvaDhod70l+S8CeLMhc 5P64vZQkn2ARJODomhVppWfbEu1/vWDCu2ue8jtrOFhmkhULG1GUDJgER6pVUzVlLd0F Lcpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764069673; x=1764674473; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eC66Ck7qicXDGH3O+D4ASvf7yKcAVNQleViJcYPhp7E=; b=gBWS0CCyZ7IzU6r9tY66n3nLIq5S+U4WqRFhvg8stn0m/KSjZbGGWi6zKcArE0idf0 vak6xaMOw5iZwVebQf7sbfDmqBREsgr6OacCro3oznDyptPWWudl1Bxcqhd5X2IN7M0P m/pN8s8ReP4WDKMvHceN6L20/2rMJVVxa9J6NjDQyIhMANJ4gTxPFbnVEYIuf0qer+UN NAG9WsIBa73Rmdf/kFCAX8f4y2GoivbxRCud4aM3bKXuzOoH7pHHS7S7/G/0+U58JoqN GDsezDPwYMHVgeF5UTQ/ii0T5HCuojamA890GpwP7mkvmBLZzfS++YJLS2pXNyiU3erY csFA== X-Forwarded-Encrypted: i=1; AJvYcCVGpidvf56rIhytwXrXAAz8gZVFVbJWMlQM9mvofDqE5WAZ1F0FJ2y1/9zt4Jy+rPmIPcIdS+PqVjPaCSw=@vger.kernel.org X-Gm-Message-State: AOJu0YzF2xrGqsz5u7JXazOlx1mddy4ZkGiSBvsQ0KSG17sacN0LjA+x tV1mdUnXIt/pFgl3F2lTcJHgdC0/eY37ir5mDOrY8zDoWTTWN+1OsaN0 X-Gm-Gg: ASbGncu2cRhZ9eZgqa1MHdm8ztOb+vYTJWIxXPyPHEemWNZzX6ANBEPlNkIAsIuyNwg 6auXfv0XVGsTqyQHD0gHJKGpSfdkSjXD8KIstU9EKMl4WwyIj3wJhlVn3rTwQGFBjKJveN3nVS1 hvTrDOL26KKtocfA84A00sEwMD6V7+7cFfBXgEATxhNgQs1EL+QafMqEzl9GPpeSKkpogHv+7Mi U6prf+1Wc8pSW4tP0ZTSJrhD3+7Qu1TJLm2nYhhK+2zGcQ3h73WpfF9ghpWeGE6uaDDQS/gWNkL vBYs4Z9rrMay74nkHi1/kNG3Macy2xZ7FcMR/QO05JXBURErptFeR7sauE5SRvpvv5tN/ME8NyK +dCV8fMc0pWeJWSM9bVRbmx7mvNmvPr8k6d0/CJiu8NhBSFHkV+okAIW+1ozs6Go3KnNwCm8Nm4 fXDTPHrTnsE482N452MJfV9WazFGVu4frp6sbGsQb1G70Y92z16nvBRDojBTkTDnwC7safGOWR0 Ap1+XSTiNF/LhlwfPjXT8/+twLmtWNs8jlRTFzqBnmY3j9oNcldB8M5x4XnN5s55mrI0AkXaJwE DbStReW9SvdQM5O200mXdXXPJaYkv8x+Kw== X-Google-Smtp-Source: AGHT+IEIbYqDNK2u9wkDTzUkrjISce7uRIaTbwYioXyCxP5QC2SyCRcZstR7F+Ns6yReS0XL9hz0IQ== X-Received: by 2002:a17:90b:4f84:b0:32b:c9c0:2a11 with SMTP id 98e67ed59e1d1-3475ebd2f0fmr2526178a91.4.1764069673199; Tue, 25 Nov 2025 03:21:13 -0800 (PST) Received: from cyberkunju.asia-south1-c.c.gen-lang-client-0196962068.internal (125.31.93.34.bc.googleusercontent.com. [34.93.31.125]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34727bcaf13sm16296250a91.1.2025.11.25.03.21.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 03:21:12 -0800 (PST) From: Navaneeth K To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, david.laight@runbox.com, Navaneeth K Subject: [PATCH v2 1/5] staging: rtl8723bs: remove unused registry and BSSID offset macros Date: Tue, 25 Nov 2025 11:20:55 +0000 Message-ID: <20251125112059.16913-2-knavaneeth786@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251125112059.16913-1-knavaneeth786@gmail.com> References: <20251125112059.16913-1-knavaneeth786@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The RGTRY_OFT, RGTRY_SZ, BSSID_OFT, and BSSID_SZ macros are defined but never used anywhere in the driver. Remove these dead macro definitions to clean up the code. Signed-off-by: Navaneeth K Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/include/drv_types.h | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/stagin= g/rtl8723bs/include/drv_types.h index dd9018aa4ee5..f86180dc350c 100644 --- a/drivers/staging/rtl8723bs/include/drv_types.h +++ b/drivers/staging/rtl8723bs/include/drv_types.h @@ -171,13 +171,6 @@ struct registry_priv { u8 hiq_filter; }; =20 - -/* For registry parameters */ -#define RGTRY_OFT(field) ((u32)FIELD_OFFSET(struct registry_priv, field)) -#define RGTRY_SZ(field) sizeof(((struct registry_priv *)0)->field) -#define BSSID_OFT(field) ((u32)FIELD_OFFSET(struct wlan_bssid_ex, field)) -#define BSSID_SZ(field) sizeof(((struct wlan_bssid_ex *) 0)->field) - #include =20 #define GET_PRIMARY_ADAPTER(padapter) (((struct adapter *)padapter)->dvobj= ->if1) --=20 2.43.0 From nobody Tue Dec 2 00:02:18 2025 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03D36319618 for ; Tue, 25 Nov 2025 11:21:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069678; cv=none; b=NSfBkcnCWTXMUSPgq63jn6HFU7v9jUT4EHYKzlBg7NvdepsiNA4Sbk8pdXXVvWZ7seF46ekZjZd1rfOB2WHfeORMvcPofMn0OZhIVdWFNDWSEb3LfY8scmDW1WZo67zQsVBltR3ofLS7LmAy2J0gKKo7O4UNSB5NC3AKHUgDYqY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069678; c=relaxed/simple; bh=5A2pDKNhbF0/77JU3bsQaFVBTUYS4izX+U7cPkgVXAw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IQI9KU7OtBYY18z23IiKa9xAunSmew1m5r3aaifV4kYWnOY6jsiVNR8DIfjM3Ztvv7yYCfBag0w2oYAJiYQS4YA/KFgnr/oi3hVStcFuJp0/++rLJyofyDFjeDNIt4cPpHcRucPhzz5BnmycysA6Nw62ujPnPDUD6y83NiU8Pqw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mnsEEZjM; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mnsEEZjM" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-343dfb673a8so5293676a91.0 for ; Tue, 25 Nov 2025 03:21:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764069676; x=1764674476; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nYCzOSmeD3AlFpQHOBdKOssS9JyrnynNQJZhTfGWgls=; b=mnsEEZjM+euB3/JaTwBkMP++itMWV6sbddrXm7fP40JjhDq4HxEbF421WrjJTqpf3L F9lqKyJesaw5UYzBXMnGg6MFWnQb/1DkXwWApfvbiOiN5V8jDnDAoQrs+DtQuvgKvZ1j zU8m6BxrgkVvt8v5zxfbpZJvcPTM8wxMh2WBpTSVdn217cStenTDG9KF8fiLFZD+H7lw 4w0XIQDjDnweY8nqkjLDxS4rh08eQgggVvO0XMeLQIK6dXjCFrAQeTo8LT89QYFrOh+d QDeWKtnDmH3zBlQ1RGUvRquKir7oC3ONix53T28ijAUE/lr9bPVS+QcMAQFA11BVJ0ez Lptw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764069676; x=1764674476; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nYCzOSmeD3AlFpQHOBdKOssS9JyrnynNQJZhTfGWgls=; b=Xx+YHQEbKPKoN/uX+4dlhXoIx51C83T1QmvrM9B7Xzq9kyklSKUM+woK7npOoRu3Ik 6tpM1IyaRqwCUiCkuWKzsfhumQFEjC57TxaWjqLD8PQX0PCj1Sn9xZC+Yo/O8BOY+APJ ZkZ+Q4kIUwv9bZsZ6HoZLFJhXTFWT7b8ZzPRswLuligDm2Zb3vaDs/Cy8auS3JmkLkY3 7463Pl7j3EuQnkOwDoq8e+oaw8rYYoHJU+OgkRP+WQ7xBltWixTGb8+QWkT52BbqZy/G TQ2HIbjwj532jyYxshiW5VcTr3Ogp+q6Mk70vrnwkC83GIqrqu5fbiri7e4HK9y1UfyQ 0vPg== X-Forwarded-Encrypted: i=1; AJvYcCV6zIu17CCLTGt/BqinxsjeD2nmNnNJfHrQ96Mec4YRmL24Ano5JDtK0p9/bNoWbzWgZ0Fa+qfOnQAwLjo=@vger.kernel.org X-Gm-Message-State: AOJu0YydmScdqCG4HG5Aymqv29CzHaryCUfvRcpCBW4LI/myhxL3rKRE Tqt5TY7lK+pJI0mesm1sUT7NQea2V+1iqhIgP1UnkHkTFyRMHzs4rqQH77+qVPzjEV7CHQ== X-Gm-Gg: ASbGncvqzlAvJPHmfRCxdAyQ6/FxMF9MEKLbwsWl2eRsDBrZB/ZW/JHXsYiw7TDgNPE 2Lnt3c/Zs9X0ajawhrNXgMJB5FdaBCv6bPJiXal9gb92wmkdZyBbYNOv95qVxIRor9UwQCHdIPs boRBeQi0aiNJKl7mhJICRbeVCT2R5/6vg5Z8gbTQwjrbKgUA+DFo4U/4vRgBhZs/CScRP6uY7GN DlibRHyR1Nj8GZhuv1rNLwzAFNVGLQxE0NTKav6T78t5GQguJj/++zixjmVlfy+HWKwj8J/iw69 g9Qg8cnWsDg/O4HzJFBe/ha1pGnN3s6lE8zCeAZ4PCF7t8c85bzow9Lo5dw2jlC9sWncGpRZyK0 Dny3CSX19arDpTlDaEMJRqNZGaoJkeH9R4cJRnyvcPTsZf0WTVyxhUz0MUcXYfbihCfABe9bVjL xTSbXI0j6clzqBVRHVuHyimeaTrSrY4qtX3cu8EqsZmWDJsODdn8VqbR0F1ojnEkOqNebB/sblZ QL8G0sTFXXtin6C6YrUvkn/agX78xLspcIQOnq48umZbz36Chw0RlhDfiSoDBuxGWuxb4enp+Dn iBtqeTflJTAdJcA3Tjs= X-Google-Smtp-Source: AGHT+IH5lMArkNfhsGEGK/fgLgKF5OQcQdSf/g81Ys6AxJe2WVkBUoOLKtd7yNl3CKRxVTK3S/lf+g== X-Received: by 2002:a17:90b:1fc5:b0:32b:9750:10e4 with SMTP id 98e67ed59e1d1-34733f3eb71mr15682419a91.27.1764069676199; Tue, 25 Nov 2025 03:21:16 -0800 (PST) Received: from cyberkunju.asia-south1-c.c.gen-lang-client-0196962068.internal (125.31.93.34.bc.googleusercontent.com. [34.93.31.125]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34727bcaf13sm16296250a91.1.2025.11.25.03.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 03:21:15 -0800 (PST) From: Navaneeth K To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, david.laight@runbox.com, Navaneeth K Subject: [PATCH v2 2/5] staging: rtl8723bs: use standard offsetof in cfg80211 operations Date: Tue, 25 Nov 2025 11:20:56 +0000 Message-ID: <20251125112059.16913-3-knavaneeth786@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251125112059.16913-1-knavaneeth786@gmail.com> References: <20251125112059.16913-1-knavaneeth786@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace usage of the custom FIELD_OFFSET macro with the standard offsetof() macro in ioctl_cfg80211.c. This improves code readability and uses the kernel's standard mechanism. Also include in basic_types.h to ensure offsetof() is available for this and future conversions. Signed-off-by: Navaneeth K Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/include/basic_types.h | 1 + drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/include/basic_types.h b/drivers/stag= ing/rtl8723bs/include/basic_types.h index 1c2da18e6210..16b270fe0203 100644 --- a/drivers/staging/rtl8723bs/include/basic_types.h +++ b/drivers/staging/rtl8723bs/include/basic_types.h @@ -12,6 +12,7 @@ #define FAIL (-1) =20 #include +#include =20 #define FIELD_OFFSET(s, field) ((__kernel_ssize_t)&((s *)(0))->field) =20 diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 315bab373729..60edeae1cffe 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -1712,7 +1712,8 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, = struct net_device *ndev, =20 if (wep_key_len > 0) { wep_key_len =3D wep_key_len <=3D 5 ? 5 : 13; - wep_total_len =3D wep_key_len + FIELD_OFFSET(struct ndis_802_11_wep, ke= y_material); + wep_total_len =3D wep_key_len + + offsetof(struct ndis_802_11_wep, key_material); pwep =3D rtw_malloc(wep_total_len); if (!pwep) { ret =3D -ENOMEM; --=20 2.43.0 From nobody Tue Dec 2 00:02:18 2025 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5D3B317702 for ; Tue, 25 Nov 2025 11:21:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069681; cv=none; b=U0k7nBuvDuqYOBOftzv8vo8v1KM1sOvpHkzXjVoPcMtXLvEX1SrXTshGyKgEQ5kMA2InrwkUsk/FOgVl2drXZxh+Uk6hC/Bk5lkUPmh2IyjcKycbRBlKLhm3jwXyPrdMSsqVViU8e67x+XQrQPTrn8ekEf7l2RmYbW44TXrf9XY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069681; c=relaxed/simple; bh=YBtaO/eBYbzQQWoYMOteVAhhJ+DKjGwoQ/N2zOVhKW0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VIH6/PbNcv5URwmGu9QLpFkExvRdBOi9k/TvDOOiHYRXDUVyjz3337EH3d6gvwBJEbM69onAuRsONTmz62k2uQ3LFTVSAtuaTVc0MkVpAQngzvJCAS2MbInTb0IdmWHY0moca9nV7VC+IXRNztHwBVA9KtAxrniKyIOCWumc1Gc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lUzKUicj; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lUzKUicj" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3438d4ae152so5917169a91.1 for ; Tue, 25 Nov 2025 03:21:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764069679; x=1764674479; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ol6FJ1vrGQKaUJffz/esQb5b2URIUDMsH3CGBHb/slA=; b=lUzKUicjHLub4/WoEzMHSCfNrS/TeBBQRyescftaaI1n5A9ElYJUBDGKBph5l+rqbV uWTpvHYgcegi09An8uNrayhWWP3acrAd/fahON8rxhTlpWGXrh4KUSFkKr4WvM/cMw+D d6LurxZsB5Dh2ieU2RqlPlStuRK/b+cDjOHKCyCKnhLwtDMvZQFBqeStA8Z02juo0KT4 DPkoRnlvd8xBrzP/r8LiA/lvE4T54QzxhjJjAsu8oRt62TCOK56/RyHBhZbIx5r3zqup +eLRZ6dI4Mcb4E/mXBl5LN1iBOnOeEA+6HdgveTznz4rvIxUR8OSxd5J0H04VHnbFgLS YHUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764069679; x=1764674479; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ol6FJ1vrGQKaUJffz/esQb5b2URIUDMsH3CGBHb/slA=; b=Csan1q+Me0xAuHT4AVq4fHqsbluqemCxmc9yAD8CSNqwPo04QWBeH+eHmv5zdezMo9 xRRdWxtjTFVM/AL+ASmWV/kZ3Z8aj4lqM3YLO65n17/jzCFtlF5WuumoYb1Hi4ETFWCb Nrf8buUgNnohBQd582F39qt3laAMyikGQjyx0ceadmuSWHOHpg2eFpycdRVsI8fTmDSC YH1lGB4Epk/9loMo1aBwXOekqB45EuGRn29gwYOANWCra3xSdUTKnRI9cJPK/h4qi3KY tKPpyxBaFDpNRXD+9lDojH/mHztlfI1jYatqAPZ4iHxl4vjQTGO24uCYq178D/2lFbjf 8nTA== X-Forwarded-Encrypted: i=1; AJvYcCWFW19Td8ETN0ac2STDZLXJwaEL2OK/gt68FVlfTAXWjX6UuBpXy69HyEVXHLAypAJ/68NTkFbV9NXlYPE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxr+IMWQtILYnnwt0cLAiaP21v8QCzOFeGfjoQwcO9algY/UOz1 wyhpr3oMIO7ioSiuJRVfewO3xoVYg22mAy8pfg7OFgoVGvZQN17NG9CF X-Gm-Gg: ASbGncvDQ2E99fi820u46WgpWZ7R0VkohjMDgQdmerB3JGFiZU5lxhE0jj2YqGEjkWm 2Y0ZmZZEETzDxYopJGyIyIh04BNzBS5WxWtHfhRnAeeVs6G9JgMkCWr5XIA8SLXq7DBPXHFu7v0 +ixRbtE3FvUqGrKA1jKUc3FB4Amb2lBIu4gg/9Ulot3LfpUxpiyAenASQ1+O8kSLenARC1TX0kB 9GuGelf3cdO+ldYZb6Oczfi9Yk5OTrwtcsCxMUIX9hHn6LW+Xslt4rlKBpgCJ1xpdFZkRWaPPvY Yo42POjKarytDvU+egnhzCW3GN9gxHC0iq3asIbcvwcndlLxcsa1GxBXwdqXNdReQz3nHwtP+Mz LKzppQ9fefdC0amiAmiHZuL28nxQE17X1n9N2Mp0zTuSdJ9cZ8VCi1Y3FhPYjrpQf4uiVCuG38M iK+3QT0eXjM0+W8MbUr5zj2/8S+bHNySIWZdu0p3WkCA8xBwy6PZOXM2mgTmt8pJcIb6YgQjpN4 pY+kC++myNepMKIhnBvfPMCp4q1YFat3dAv1N90kbGVIy12aU7lVUd3v64CkuOJ07zt7d5ojjHw 2v4JyMxUJHAajlDbj8N77Oa+QCz1oKn2eg== X-Google-Smtp-Source: AGHT+IEznkxcTSR7i/lIJr2+8XsplWKM45jT6llpuiaa5oIQh+yi25Xglc4E8X8i2VZvEBaHegRsFQ== X-Received: by 2002:a17:90b:48c6:b0:340:5c38:3a56 with SMTP id 98e67ed59e1d1-34733f5cef1mr14909715a91.37.1764069678967; Tue, 25 Nov 2025 03:21:18 -0800 (PST) Received: from cyberkunju.asia-south1-c.c.gen-lang-client-0196962068.internal (125.31.93.34.bc.googleusercontent.com. [34.93.31.125]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34727bcaf13sm16296250a91.1.2025.11.25.03.21.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 03:21:18 -0800 (PST) From: Navaneeth K To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, david.laight@runbox.com, Navaneeth K Subject: [PATCH v2 3/5] staging: rtl8723bs: remove dead commented code from odm.c Date: Tue, 25 Nov 2025 11:20:57 +0000 Message-ID: <20251125112059.16913-4-knavaneeth786@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251125112059.16913-1-knavaneeth786@gmail.com> References: <20251125112059.16913-1-knavaneeth786@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove obsolete commented-out code that references unsupported chip variants (ODM_RTL8723A, ODM_RTL8188E). This code has been dead since the driver was added to staging. Also fix the resulting formatting by removing the unnecessary outer parentheses and moving the inline comment to its own line. Signed-off-by: Navaneeth K Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/hal/odm.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723b= s/hal/odm.c index 4b36af47f680..639b6da2302b 100644 --- a/drivers/staging/rtl8723bs/hal/odm.c +++ b/drivers/staging/rtl8723bs/hal/odm.c @@ -609,15 +609,12 @@ void ODM_DMWatchdog(struct dm_odm_t *pDM_Odm) /* 8723A or 8189ES platform */ /* NeilChen--2012--08--24-- */ /* Fix Leave LPS issue */ - if ((adapter_to_pwrctl(pDM_Odm->Adapter)->pwr_mode !=3D PS_MODE_ACTIVE) /= * in LPS mode */ - /* */ - /* (pDM_Odm->SupportICType & (ODM_RTL8723A))|| */ - /* (pDM_Odm->SupportICType & (ODM_RTL8188E) &&(&&(((pDM_Odm->SupportInte= rface =3D=3D ODM_ITRF_SDIO))) */ - /* */ - ) { - odm_DIGbyRSSI_LPS(pDM_Odm); - } else + if (adapter_to_pwrctl(pDM_Odm->Adapter)->pwr_mode !=3D PS_MODE_ACTIVE) { + /* in LPS mode */ + odm_DIGbyRSSI_LPS(pDM_Odm); + } else { odm_DIG(pDM_Odm); + } =20 { struct dig_t *pDM_DigTable =3D &pDM_Odm->DM_DigTable; --=20 2.43.0 From nobody Tue Dec 2 00:02:18 2025 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87E9E31A810 for ; Tue, 25 Nov 2025 11:21:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069684; cv=none; b=QeyIMXjKPng6fld2QRd6zova7ULWFJ/U39R3dRGyYv7eaZIUJB8NFKes3xGVlhPfw1GGfB7cX1Z2henXq6H5lxdn7BV/+xkiovxOGh5FTmaRFDazovM3SOezGp2o1YAwVYVNxQ2rG/ubezZCqds8etih55grm6eFXFwa0FfdO9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069684; c=relaxed/simple; bh=I3GZ8XwBioEHKmiD5OVtWbKJ8W0S2ADG7BUv6vj/H8E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NPjvewkafB2Vnh9aVoAZ+aaswyBDBR0t65SKCRIEWx3HzXF4VSWCdnbOXwCROsJ4o3SN268/q20kzzUTK3GdWPuj3BBPgw0X/LE8DXAEWChB7vx/GbQIPS6PASxwVC3XFWV6MwZVQdSodRdu7Pd5oqHYMeJNCf4Xcu7KZ/IqDVE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CDNpvSjk; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CDNpvSjk" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-3436d6ca17bso5358263a91.3 for ; Tue, 25 Nov 2025 03:21:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764069682; x=1764674482; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T5Ist/iGDJwJAI85WLcHXvNoHsSh8TLeoUx3PCoW6I4=; b=CDNpvSjk9DHNLNdfJAck4/sbTj7YxgGZdo3C5SqKa6emQTlIGK2lCGFs5OmbFobMiK mnWHOaKGWmzdqOlCInk1TePGTBKpG/66TwsAQO3vKYpu17o/E9aQ/GK6rmXZNYCJrO/T g/bU1xEVOyo+h0l9g0bJ5DlsHqNWrLINqXFBSpQ1UhcUisdNwPUdgrzUes3v+8ZJEVXf o8bRMDxbSGjpozSaWNG3StknQq7k/tYY5PCMehc3EHEa8E0S+oI3saLfCLddLpy10YzQ hWs3CftTH/ufbF1eMjU+UHaniKbQySr0TNPtRJDCxKkZmkiS1oUTEXC914oOAhn73vF7 VrKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764069682; x=1764674482; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T5Ist/iGDJwJAI85WLcHXvNoHsSh8TLeoUx3PCoW6I4=; b=ciByX3lY+4OdCPN9oL224utX1XKrt6DhoU3YSp5eA0R7dlB6ZiC2zngZ6sAUjTD4y6 1AALQoc+KstBo/Wfkz2J9vF1FQjIO7qWQldGPrLnWHVzlMGkRiVc46bvKyyJYPqIXAdF UrPLHMff77r219iK7CUfiK+mgAIMj5oCg+iJhmb5He03rWfmDQZU3RZR8ULO3DRPcNA8 21goFIhVeRBwEgP1r7kC0aKR5LREhKUeABwb5fYshv7OR4VhV5lml4Q1IOSsl8eqCq/r DQfyMVpN70eBYcDtXzSFAJXvXaQMrYWSheC08VrEbSCdvXNjLfl3NBeS3kM3h8GU2xCs /V+A== X-Forwarded-Encrypted: i=1; AJvYcCXVobbUg6p9xzSOWfwGI1vtQfJTariwDTYg3JQSGgw2K81XB1apmmrFTseqKcPHd1C3aEkTbsazwwY21H0=@vger.kernel.org X-Gm-Message-State: AOJu0YzlMAz2IO7Wvwajq+fbom5AHFwCCSApPBIdu2c2PEIaXnT5HJrM RgkxvA0VS1bDi2CDlQ740HYjpEJZhHX+sp215Dp6T5qzYzgH1msOeOXogyovUd6P3+d3YQ== X-Gm-Gg: ASbGnctRpNf6Otw+divBOJ+0PZ7U60epXaPunZY20nWWTCTDndaTGHqLFrRfx3pAT++ VwZoe/5di1vUTugHEZTV9snYNYCYHz/Iq+x7JpRiL6b1TMFf28e9e4+nyCOp/7uSlBYfQDCF6Ey BBUXCZq3NGpjvH5AmVRuun1gV1o1ftyBBACAv3IMdkdt7plCW6b8cvZqbQ+Z4OXm68mTqohgKbH 0jxZljlETAkWIw7Ztha6Lf6o7VJnyKociObucPCuENxo5zYfaVLwOL/hIT/+Tn62deElgfPxUXf SPhim2dQkfeE997/kBqRPFUglDrnvem+EwUK8E1V7anQBXjKn44z+Vdnj0WLa5WWaPJEp0AyGit W96QwAI7s8csETkXjps4luad1byqlfoKE+GF6CLsz829gHMXpCa6W9/mKUjifleR0fFQsOyGF3/ IgpDf9n0NJPNh9wx1HUUPALZikgpplqqR4VTrUb5xzUO+dtfXJFLYLP1+trFhKkCz3PUhWn1ysA sRwGsj6EPkYxNkj8QXdLaErCWLejaMxRW0CUs8zWV1DQKfYcJvvnqJr0SX5GGX7y2L90IJWh7eg xk8DmdYq9X8v+K6LC16iphiNs6I9IBuGKQ== X-Google-Smtp-Source: AGHT+IFA9nFLT0pvtshZXrcVVlI0mAQS56rjPa1/up1ipD7A8IkqAHLbi0Fq05Exmt0aQJYAWLTO+A== X-Received: by 2002:a17:90b:2587:b0:32d:db5b:7636 with SMTP id 98e67ed59e1d1-34733f34e52mr15923438a91.27.1764069681717; Tue, 25 Nov 2025 03:21:21 -0800 (PST) Received: from cyberkunju.asia-south1-c.c.gen-lang-client-0196962068.internal (125.31.93.34.bc.googleusercontent.com. [34.93.31.125]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34727bcaf13sm16296250a91.1.2025.11.25.03.21.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 03:21:21 -0800 (PST) From: Navaneeth K To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, david.laight@runbox.com, Navaneeth K Subject: [PATCH v2 4/5] staging: rtl8723bs: replace FIELD_OFFSET usage with offsetof in rtw_mlme_ext.c Date: Tue, 25 Nov 2025 11:20:58 +0000 Message-ID: <20251125112059.16913-5-knavaneeth786@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251125112059.16913-1-knavaneeth786@gmail.com> References: <20251125112059.16913-1-knavaneeth786@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace usage of the custom FIELD_OFFSET macro with the standard offsetof() macro in rtw_mlme_ext.c. This improves code readability and uses the kernel's standard mechanism. Signed-off-by: Navaneeth K Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index a897c433d2b0..9372b997fc23 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -5275,7 +5275,7 @@ u8 createbss_hdl(struct adapter *padapter, u8 *pbuf) /* clear CAM */ flush_all_cam_entry(padapter); =20 - memcpy(pnetwork, pbuf, FIELD_OFFSET(struct wlan_bssid_ex, ie_length)); + memcpy(pnetwork, pbuf, offsetof(struct wlan_bssid_ex, ie_length)); pnetwork->ie_length =3D ((struct wlan_bssid_ex *)pbuf)->ie_length; =20 if (pnetwork->ie_length > MAX_IE_SZ)/* Check pbuf->ie_length */ @@ -5339,7 +5339,7 @@ u8 join_cmd_hdl(struct adapter *padapter, u8 *pbuf) /* pmlmeinfo->assoc_AP_vendor =3D HT_IOT_PEER_MAX; */ pmlmeinfo->VHT_enable =3D 0; =20 - memcpy(pnetwork, pbuf, FIELD_OFFSET(struct wlan_bssid_ex, ie_length)); + memcpy(pnetwork, pbuf, offsetof(struct wlan_bssid_ex, ie_length)); pnetwork->ie_length =3D ((struct wlan_bssid_ex *)pbuf)->ie_length; =20 if (pnetwork->ie_length > MAX_IE_SZ)/* Check pbuf->ie_length */ --=20 2.43.0 From nobody Tue Dec 2 00:02:18 2025 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8698A26CE3B for ; Tue, 25 Nov 2025 11:21:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069686; cv=none; b=CDYyAbu4HXtS9cHU5zBdu9YEOAJ6wKeVjJw2ziiroc52b4IIyB/86RpDzR130uucBmFXvO1maeZ9X799EBUhVVpKgeihF+ce7/7HdpUtneTUg6LBFdLNaxVP+2prLqDZsdvID4PTAlD2a/MMqYhy4+GjDHdzp63me5oUTbOhkfg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764069686; c=relaxed/simple; bh=d7ggIp9WmDKUq0Bx88AaHSWp7QdXZBaFiW91NBQPfXc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o/wZDsF81Yo4Xn30zpHHBNJHizP3o9ptVZwl0PHiZ0QELUj0DE5Q5xkEG5MUkYSaPJ2s8oPZGUsHkya6ttZvV7kv2mof+uZaEPhywQRtwYYX2LQTAZJPNV9jcOCW/GegpSrm0mZerrltrtbicgz7pobENXNIIHcXzvmVlhdCKvk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CVpgOjIV; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CVpgOjIV" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3436a97f092so6699805a91.3 for ; Tue, 25 Nov 2025 03:21:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764069685; x=1764674485; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zIKvcPrVHRY60iEnnzdnX3swFhRRplLLW+yCKl5Bl8Y=; b=CVpgOjIVxpXRMd1qKUfoxzhiwUtzly1bBN6VdywDbI4KOpex+wo49i/2KgNAwJ071a q53k758+QeUOxFzuPmNDfRQYauqzRW6e7xhBITGF94uUdhqbuk/qnwo/ETMOag5iDiPJ C8hffYKxKg/WMRZNTIjRUnJbVszAF7CiBHyRyop9vhE8S4t9bXYRRzlj0EFEknRIjLtU Moe1Qy0o0xA2C487cDrpYSf6tSia/LyAxJXSOQgoegH+aEFWpUkLMu2TbDtpJb/7eDMo M6cmZY4zaRwDNUQ/OfDs9nEEk1gMmcIz9hmEBKdlRDUhTOG6SsKWzGSaZaWze1OZD66x v8Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764069685; x=1764674485; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zIKvcPrVHRY60iEnnzdnX3swFhRRplLLW+yCKl5Bl8Y=; b=eKO7BDncBcIRCt0QEazx82Pzb7HaQpN4R3ughUhf+k8Exc16MLdvmSr38AbeYEDqdH qxogk4P9nJFH+/q0FILZZ6bjjcWnVs4v7ebidoP3a1+atfuH8SdHtZoyW0xr0gmPzEBb HU0XtGDYdWG+w/XWa72pKYg0hCk2f421mHo81yZPuwO8lhDruY86DK2X6Onc8s43oCVW a6GofU3j5PR65j4XZ/YQhzP+Bqpuy/a6tXH0jYbUufBdR11e/11YgvW/NI8m+IbRBkGJ VjE3HJkeUbBkOkHp9A+/Fgf6Y+1PuFK31PQckmVC4uBmfSkC6D/BNe2dGghJmPn35t1o QWqg== X-Forwarded-Encrypted: i=1; AJvYcCX9JWA1bzm6yTsXxJKV99734dychdb6sldBgIP7Mw/+j+2tZqpV8g13RHmVZUAxCrW4zoyoKVEiil4p0fE=@vger.kernel.org X-Gm-Message-State: AOJu0YwKt0RKwnfX8Hxrc7M2OyssQpiTVw7I2MaCZZksKIN36G/ILl5+ vT6ovWwNZhDJrq+FkFw2irpFTDpQEPDJlplgKw1Re12WGgrcJUCE8cgz X-Gm-Gg: ASbGnctIG9fK1xVCWNFiV/rNXlLimrx7fUXF2NrJ529QQI8zwfyKUHbncC8V1ykIjZk 7FlZEFWr2YAsawW6/ia/6l5OijqUGtsoNEhPUTDUkAkFgGWu+WbjTeDWKphsbsk+1HYAhvaQsWU VeULtEmg73T0JSd2204/F25ZXvvqLFU2Y1TP/bZ/Pl4gV7lKNtlZpBdbRD8LO6G6GbxnIDq0xvi 5Q2M3hEgcnFzkFp34kOalJsRIQWU47G/lqB10KNlXhaCHXnHe0JArlsUI9Z32aQiIt+C0SYwWCR 5M1Idhx+xbR2OMhh6R+mdaYLigEM211pEmXZRPCvngwnOZ5tqlL8Pb/uSah3uKACM2KeWnpDntB snK4OrM6mPSe8GYsCNDq1/wcXYMjvP3jUn/mOiwpTkQBCaRIQJSERpLjWTLB1yhNx1OLENL9J30 508OH+iU5cua4NEhfzvqORpQy4tIguuSngGLqTxUVhGZFLoyp2ha9gw78sgV95SAL9Xwop0HY6B tTvAI4eTxJxt+u+khu2zcWAn75jPcfaTTBlGiLB9gv0k5JxgyG9fjq45EdlGBxoJ4eX8s85xAht fbtPQmCVqbJdRwDCzXzSOWrHNS0RJZ+/qg== X-Google-Smtp-Source: AGHT+IHx2836kz7Rowql9JbmvNi3nb0WpYKlYcG4iZVPEFRYlU/Xp84X8ugu16J73E5AMPBFzdKvXA== X-Received: by 2002:a17:90b:388a:b0:340:cb18:922 with SMTP id 98e67ed59e1d1-3475ebe8306mr3115661a91.14.1764069684698; Tue, 25 Nov 2025 03:21:24 -0800 (PST) Received: from cyberkunju.asia-south1-c.c.gen-lang-client-0196962068.internal (125.31.93.34.bc.googleusercontent.com. [34.93.31.125]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34727bcaf13sm16296250a91.1.2025.11.25.03.21.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 03:21:24 -0800 (PST) From: Navaneeth K To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, david.laight@runbox.com, Navaneeth K Subject: [PATCH v2 5/5] staging: rtl8723bs: remove custom FIELD_OFFSET macro Date: Tue, 25 Nov 2025 11:20:59 +0000 Message-ID: <20251125112059.16913-6-knavaneeth786@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251125112059.16913-1-knavaneeth786@gmail.com> References: <20251125112059.16913-1-knavaneeth786@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The custom FIELD_OFFSET macro is no longer used in the driver (replaced by standard offsetof). Remove the definition. Signed-off-by: Navaneeth K Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/include/basic_types.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/basic_types.h b/drivers/stag= ing/rtl8723bs/include/basic_types.h index 16b270fe0203..8adb95f9f1e5 100644 --- a/drivers/staging/rtl8723bs/include/basic_types.h +++ b/drivers/staging/rtl8723bs/include/basic_types.h @@ -14,8 +14,6 @@ #include #include =20 -#define FIELD_OFFSET(s, field) ((__kernel_ssize_t)&((s *)(0))->field) - #define SIZE_PTR __kernel_size_t #define SSIZE_PTR __kernel_ssize_t =20 --=20 2.43.0