From nobody Tue Dec 2 00:25:42 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68F55314D2A for ; Tue, 25 Nov 2025 11:09:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764068966; cv=none; b=t1PSpQC/YVZoQGK0oUISdrRtVKPrhdWKIk1PLGZ5BDAwPJVV/Kco7vSrz5WP8L71wENSL7wk8lSHJNUsUF3jlw2E0QMIgj9JeLwzcHmSEgVLtUHddwlIG+dNvHejJlgCBBmuSIDktKboBeF+/49mXHUGVboT5bkhlwDuQfluh2w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764068966; c=relaxed/simple; bh=tl0WK0vKXJu7BGS4fSCa6MdaVgIDRX4gqgHFUZ7FCvE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e08H5nrW50jzLWlJ3F1HlY0vOQpCrRuU3uMa2GIExVdN8F0JhU20fevByxuqnb+3eD1DVD37g+4HTEposKbcu74Fju2twzSdOyziGMXca9hJ0TaorIXO0+tLPUB2Ee4jrWjlyLyCo7sppDaQ/oLs+Tik+qWVIUxcNCxii2hg1+w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VbnlXt4v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VbnlXt4v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB5D3C116B1; Tue, 25 Nov 2025 11:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764068965; bh=tl0WK0vKXJu7BGS4fSCa6MdaVgIDRX4gqgHFUZ7FCvE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VbnlXt4vHwhp3etx/I2CyBGBAEisjkzEBHPcohG60xGiIC2LCcCaadt9eBE5cTRuQ IH8TsX9arsUjYD7UGW81qx/k5gn+ElbZ2oOta0wgR7UasVfPoXTs4M+2IbevAwTGL2 vD6tuNrdOEWObS30ep/vIBJSSZtytYYFm4poTr71FvNMwxHJr8vk1m7AQxpzda4eIX 1zQBl3vcEjdiqCjairTRFNGZXKNel9ojJ7dDIelhQ37jOwDq916GlbdDc35oUbppWx e6EzScsu+5yFNTNhF/1M0CpKcUa9XG7P1PvND4uQtVtWo1hs0jXm50lrFblQKlUOod h9TFZXswX5hWg== From: Mike Rapoport To: Andrew Morton Cc: Alexander Graf , Mike Rapoport , Pasha Tatashin , Pratyush Yadav , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] kho: kho_restore_vmalloc: fix initialization of pages array Date: Tue, 25 Nov 2025 13:09:16 +0200 Message-ID: <20251125110917.843744-2-rppt@kernel.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251125110917.843744-1-rppt@kernel.org> References: <20251125110917.843744-1-rppt@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Mike Rapoport (Microsoft)" In case a preserved vmalloc allocation was using huge pages, all pages in the array of pages added to vm_struct during kho_restore_vmalloc() are wrongly set to the same page. Fix the indexing when assigning pages to that array. Fixes: a667300bd53f ("kho: add support for preserving vmalloc allocations") Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Pratyush Yadav --- kernel/liveupdate/kexec_handover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_h= andover.c index 5809c6fe331c..e64ee87fa62a 100644 --- a/kernel/liveupdate/kexec_handover.c +++ b/kernel/liveupdate/kexec_handover.c @@ -1096,7 +1096,7 @@ void *kho_restore_vmalloc(const struct kho_vmalloc *p= reservation) goto err_free_pages_array; =20 for (int j =3D 0; j < contig_pages; j++) - pages[idx++] =3D page; + pages[idx++] =3D page + j; =20 phys +=3D contig_pages * PAGE_SIZE; } --=20 2.50.1