From nobody Tue Dec 2 00:03:24 2025 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011007.outbound.protection.outlook.com [40.107.130.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 109702DAFDA; Tue, 25 Nov 2025 08:51:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.7 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764060695; cv=fail; b=iGJ7ndEYB2x0BUcB9IBHOk3kmdPKE8ojtikRVhyjL2CgI4TGUToJvxvu5Ou1XNp04rIhJyu0B7bmVuYO6admO2+kouVG3AMKcjQfZF3AVkripnTRaRSGD5xDgCWCpR43YK9Oc+ZPsQVfyBpb9UqKXCVbpp2dzW9vPrRTq0ytejE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764060695; c=relaxed/simple; bh=HdsckBWSG95WlvPsTD6wFTt7nUD2XM45VlgF1rj8Z2U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=W0XSiX6tiSLHa33dBOpB2/OM7L0WpShjK9BGvxe3kF6HxurYa6LBJ7vNtrKp8DkpYD0XzGnP4LaRcL61RbJJXWe4LRKpBiZuGVSFIuy7lZjAKChMCgafayRAD2b4pxidF1qs7/YM4Q+eEimfdiLm0FqUo0z7jM2l1jViwL+vS6Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=EV9Mr6b/; arc=fail smtp.client-ip=40.107.130.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="EV9Mr6b/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z/bwmZwE/TVSIw1jQzB5D+I+Nq8x5WpdhuxQQNGeryEFRGscOzrnOf2PGa5WqUygVOszU3UTmhjZfU+m79mjHDWxqpzphpByeQ+OZwfysTG+ogXCApkXFlJyr3B/+seECwig4jY+wWxTtA1smy7KtTWh2qhykFxuAy4gTDh/6jrKNQ7KlXPVhGNo59iR7E3ktgs2ce6aAZ3ME25S5wKo8oXcNIs7lmHcpixu9TxM5B+gzZNy5CTOHXIpDI1ylwor6gmnTP2VsMYKTN3V/mpI3kWXRAULumDh3725+FZIfcdf0hnLCME6dF2Vx/lvG3qP8XeLPVwzddCk8bnL8VswwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hda9IyWFyUZmh1WlGmTn8pzIuDPhrkp1AzeGFvtTXX0=; b=A2BVoYTgn0sNpzE6SlgzXugqzSlI9HHyTVO55GKv8S2k/2nKhm+3474hOEhmZHNBfK2FvxA/NOomkAAvAfLC7skhD4m++UTBKFmGoDGAYo2NsP/pw6ZNWGaiubbyg00URvN6UdfmgCOLmNoWjFMUoYTxgqjHswamSEi4nVBTo4pusCI5CXuktIGa6aTABnF3QEnlVpeCoX8K92fkiev5BWY+e+5jKzpeAQaQxucO3VnLZtEcAEDMSwIVDMJYlSf6J/IncUX/rkfRqLN+qFISfNU3ieheenRnTDUidTCxOM2388sCElMySGcmt6hHQyzaZ8vIhxC8wUe00HHpk2hZLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hda9IyWFyUZmh1WlGmTn8pzIuDPhrkp1AzeGFvtTXX0=; b=EV9Mr6b/BcMVmYz3m6iG63ipAADCKF7wtTQK2ST364xWyYYbTmjWnis/5FtHOci9XIilTY+LGgFzs8qF4xl8+mhGJ5mn0Ijv0Qf4/R5cVyh56CONspUKv5vC05kU+TetCB/uSZGwA/lF2ytejxLM3mrJu6INC9JUJ9esiGy5Dc/bwEs0Ed4GFLqRNK5JkOSOSaPVxJZECFWG5sTIdAwQv07wNri3+vnlxdTPOpjX69r0xas4+zZcN9Frf+yUCORpJwuU5qFVEfIgOkZ1AkzA0XcUkpe1ydZtTqwlPhcJJlaRzrYW+XbdcR3vWAka1e2fHHdLyCI5OaFCqoIdBt84xQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) by PA4PR04MB7533.eurprd04.prod.outlook.com (2603:10a6:102:f1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.18; Tue, 25 Nov 2025 08:51:32 +0000 Received: from PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db]) by PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db%4]) with mapi id 15.20.9366.009; Tue, 25 Nov 2025 08:51:32 +0000 From: Wei Fang To: shenwei.wang@nxp.com, xiaoning.wang@nxp.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, eric@nelint.com, richardcochran@gmail.com Cc: imx@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 1/4] net: fec: cancel perout_timer when PEROUT is disabled Date: Tue, 25 Nov 2025 16:52:07 +0800 Message-Id: <20251125085210.1094306-2-wei.fang@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251125085210.1094306-1-wei.fang@nxp.com> References: <20251125085210.1094306-1-wei.fang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2P153CA0011.APCP153.PROD.OUTLOOK.COM (2603:1096::21) To PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8510:EE_|PA4PR04MB7533:EE_ X-MS-Office365-Filtering-Correlation-Id: e43a192a-c7ea-4cf2-dfe5-08de2bffd4c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|19092799006|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+WmZ6hVYRYuWUabiI6HTnmFdYDLvQBlru6F8TudFA6PxgvN0O30Iy/yxJFcm?= =?us-ascii?Q?lQcfKy7U6FKb/dBqN0BaWLPWscnPsorJmeeDN/6d5JLT/kphY/FcuHepCUXd?= =?us-ascii?Q?XKZAJv03Wr98HQ+1lyvI+5VwwukPozXTWReUJnYTin2419w5WXx+cWaQXnze?= =?us-ascii?Q?WPRwjbGxtXvAw29aVDVUISZsQ6BdTC/gBz6EhYSqHTXfDegl8KFWcnLIlQEW?= =?us-ascii?Q?DokMxhhVaGXBTVV/DyG9eXDFFFDioTORh57jSY73pyCkFuDzy0DI1qoMdmaj?= =?us-ascii?Q?z4yP4AnhwjWF7So31DA+fwDbqVTY94Go2Y7DZddg5YRSPiD+uY2A0/RVd2Si?= =?us-ascii?Q?I1BLnJscVbfGq3U9E3RBbXKQAC/SGcfrs2NWO5wgGILmTSMfcO+Nq62a2HiB?= =?us-ascii?Q?9ifbK/nhJbO+em7VBSFPxi7c6IHHfdFCK9aiYWBTfDKyMoRghwb12ltDP/wu?= =?us-ascii?Q?lIzKFbYATMISQecTCJYxjXVwL5niBnZo4BRx/eqdduKmZvmEnmxkXoxwK3rz?= =?us-ascii?Q?Q3Kxx804JEF0JQ8qvFHIlMSrw2L3dr+HYE3Ih9wxUy2wpS07TXjNLPW7wVEx?= =?us-ascii?Q?OUWzH1snFZNalPEY+IDt1KfJTjpCpMnjdW8Yp5Kh6ql7ha4GDAFoq4HadjcT?= =?us-ascii?Q?65unhKe2hm/qfRif9X/H8/dKuDu0e0zECcpllrfZ8ypmbF5fMt0ZH9SI8gjA?= =?us-ascii?Q?oGwPEaS6TEcV3Y6BHvvXScXLyQuCljPczJm41a/CWF14tninWBkqV/rqArD2?= =?us-ascii?Q?OOm731gBzcIOvMvC2ayI8s2K0qYP4D/tPN2HU7UB3zimAJo4o1jtnn3FBV28?= =?us-ascii?Q?LATwu0N9Kkc6rjDV8Y3OlFEZ/PSfpUkfqvOmsESmLFjqqEIPrJ10UpTEuNoJ?= =?us-ascii?Q?IHJ1Du1sscB9/jfQAefJrepjRk+bGBCdvD1UhNNZiGbNgD7gTWna5W6dsSMF?= =?us-ascii?Q?VBzzhk/5JQHSVin099aY04RXz+nWXxAOhLgg+l6jz2UtqGtHuQuMYOfH/+5+?= =?us-ascii?Q?FwdZ+EQoDAwcCpWbyBlFSKE6HgenWmTkT80iZZJFtAo3chTZntf1HzSjZr+u?= =?us-ascii?Q?wknt57zhCJdYkNPlSpqwYD678tZtRmjQXHTREy4110WiBohEby8XCa8c3Smx?= =?us-ascii?Q?EME0DuVHa6CjbJ+XFY939kd26xBrRbVSRw64xHtfv+Xa4QGExj9FRY55+bCV?= =?us-ascii?Q?wN3/j6MyOwO5LBnZQKq4zL3tm1PMtR56+UXUtXrYBXZHR5Ac0KlZRqGLmdtd?= =?us-ascii?Q?LPCgph53kDg0OwWDz3JgXP0Ihy2Nf5Avu8+h4v9KfWtRJD2TfHrPQCG3x7+N?= =?us-ascii?Q?mOU66lwJYZJfgNQBqPm9leRdjbDmxiOvSWHl3DZvaIygQiTQoHJZ4BO01kFh?= =?us-ascii?Q?mZl7nA0sTsSxULCgUjH0kY9jb85tULA5MVBGNRSjaOvH6OOZnpJZCusLbBm4?= =?us-ascii?Q?Laj6T6W2H2DSOoduwNtLHozlYOyQHmywzJz4h5wFC64xpO5EmbkVXOdjUgc7?= =?us-ascii?Q?y4RhFJYqQjEcv1/e61Vg3gEca3okFCTZbiw3?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8510.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(19092799006)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qww0Hw/DG205lMKJvJjD8rOCzhRE4EpqVMAjpLsSMnQ1rZ1TGLg6mW0Y+Dlp?= =?us-ascii?Q?wO0yN9ox1vCpv9Hw62su2sdNe1fIjb7wfHQ5ZdJseUGjgKFlwAXQSADi3qU2?= =?us-ascii?Q?sKM5dJ236qoJ6K8J1lI0RIosrRO5InO8V8ytf8YQhv9ZV2anlB4OpxzOoOFu?= =?us-ascii?Q?CCl9aaO3Lczyyu7lQ8asYzIWkDPID4srn5jpa+PeZWmD11FIC+zli6suA4OL?= =?us-ascii?Q?UlMapwSA57RcNi7Zy1MktVuYdjcJVNB0Ndg5cr1PHMTQbb8ea6dK1hI2MfyP?= =?us-ascii?Q?v4H/Axc2YDp3d2DTpGFZ0XUVNv8cox0GuJ3REOJ8Cuhqk3UUwvqK8kbS13De?= =?us-ascii?Q?qhKddCqJYwLQcQ+J47FEvF91mYcRYUxoyoXZuXu48XPj1W7nj7dDQKNy/naS?= =?us-ascii?Q?MWJFp4tSGnjb0zMOCu9+r7j/1fk+qpBja8tb7RGVgaYbhTP/qanOl/GyA7EX?= =?us-ascii?Q?g5sO8hfRMdsOMn80l9ffvRXEFVbUbPjv5TedUtiMbkl9+YqP3oBRMIScOAAQ?= =?us-ascii?Q?TU/NNtyGNuOw1ZcyijPKgHknB1QKXJTzb35H+YJkEcgL5+lBESZbfpQpYgSF?= =?us-ascii?Q?wdlKOl8l6Ot6LQ5e3tAWKVd8oRzKaG5A6dmXqF3DlDt8jvfKX1DCALsnJS8B?= =?us-ascii?Q?WuUf9mLHTl1lwbZ8zHG6U/FV2f0sE5Lq3iuy+yuyoqO0xzeCi7lpoPnNcTQ0?= =?us-ascii?Q?PP2v5m3/Mxym2h0J4UPqnArng9Izqwg8pLrJZ8fkxBa9UR9ZYWuVa35ZBm6I?= =?us-ascii?Q?sNIPOOV1//sE0358/MbpnmZ+CriNRrcBDAhqGhvl6vAsIkM9q+G9EooNBWU2?= =?us-ascii?Q?SsLwg3yQmptCthFC8YRCbW3Is5OVq7Du/inWgywt7GSfPeGf8sPsacq8H2g3?= =?us-ascii?Q?WfRw3vUqmFKQ8/TB1jkfQWcoC9apvuuXWwitU+TcTzPQVls2krXYAa6QWhoK?= =?us-ascii?Q?omPn2huJeismers2VdUhN+L7G8yPsBmpiEv7q8xhG+D8ucgqBfeV1kCZmr9u?= =?us-ascii?Q?3LKWhmxbuSjnHzWSNxNEZn+2eDa25JHiH3LNfA0sF3/hHyvrBKuoUZVyE8GH?= =?us-ascii?Q?IERYzIuCqZY5a1xVJ3mLBmiJeJZz+joqFE2BSe1Zl4zjxhi5tMmvhvGSYT8z?= =?us-ascii?Q?ypKPbVDIzujN7p2o93rUKI81IEhvRRNnr6a8gqLy75Pe29eUSDweRz+6ZPE+?= =?us-ascii?Q?+xk3Hk0NULez/gaulZTboPE9y9ki1dBm17vd7A8yTIEWZR34CAe5a0/KYWUc?= =?us-ascii?Q?v4rl+RVkcnEJcnSWt+H2bgmTnSI2nTj3tFxIQ/dtPrrI0FHKlJVD9p6UUI2H?= =?us-ascii?Q?bRUfZTC8hk9dBS+LPQuxqQuUEg7gnkFgW4kr3jk7UQq35tI569AitnZC160o?= =?us-ascii?Q?q1Y5qlYE5+qHeUmpoNq3hBPIJkToMA1rwj/bJKEGeo9nithy/slwPkUm5qHf?= =?us-ascii?Q?utkxgaoA1sfQQxm+Vd4nUjJuw0Of05Mn2KWqoFRi3qFkr7BO+Ea58TS2ouHM?= =?us-ascii?Q?8cm0Kii0kezJD8v2vqrXpAUqF1x0uWvuCBhoReBN11mOL5h+q+hZ5c6eUmKS?= =?us-ascii?Q?WjjdX3iQsSFvnPXy5H9zwjUkU+IYsBv2QnX2TWrW?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e43a192a-c7ea-4cf2-dfe5-08de2bffd4c5 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8510.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2025 08:51:32.2725 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ODMjhtd6FyVj/uGGud9ERVYMwGz6BMuSxZCTl2rVSjf4C+/pYd52XARbg7oUwF3cxS5OfNtCLS0gct2XoKOGpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7533 Content-Type: text/plain; charset="utf-8" The PEROUT allows the user to set a specified future time to output the periodic signal. If the future time is far from the current time, the FEC driver will use hrtimer to configure PEROUT one second before the future time. However, the hrtimer will not be canceled if the PEROUT is disabled before the hrtimer expires. So the PEROUT will be configured when the hrtimer expires, which is not as expected. Therefore, cancel the hrtimer in fec_ptp_pps_disable() to fix this issue. Fixes: 350749b909bf ("net: fec: Add support for periodic output signal of P= PS") Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/fec_ptp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/etherne= t/freescale/fec_ptp.c index fa88b47d526c..7a5367ea9410 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -497,6 +497,8 @@ static int fec_ptp_pps_disable(struct fec_enet_private = *fep, uint channel) { unsigned long flags; =20 + hrtimer_cancel(&fep->perout_timer); + spin_lock_irqsave(&fep->tmreg_lock, flags); writel(0, fep->hwp + FEC_TCSR(channel)); spin_unlock_irqrestore(&fep->tmreg_lock, flags); --=20 2.34.1 From nobody Tue Dec 2 00:03:24 2025 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013009.outbound.protection.outlook.com [40.107.162.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B523F18EFD1; Tue, 25 Nov 2025 08:51:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.9 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764060700; cv=fail; b=oWJPOuoJNwvd87p7rFUVQ08/PXk8qnBhwvrN0ZklqxFD8t8hh1jYo5kuA5lMBCqWSYO4SvlFTjDmC2Q6XI3WGiTtxdY4KdZ1L3gmGoibVO/7iWF/90ksgVyxCTvjWuK+5rWQFs+YRVMrWx+8VN3tZA0odjFPvMRgP9Jal0x99zk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764060700; c=relaxed/simple; bh=Cdg3EZmY/x2Mq5KObR+3880Klb17Kl3cX8NW6ZYeLcI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=W/svEz3g7kCuku0ip1QybDcr9WFwk16TmVCYRLSg/Gkz/OdSiivmtu/oV+W1B8cijDXzT1NuNmbr/3H7bRej6V2vBlNYLS51Yxj3sfGJJXNdH6gnF0fWNPR4HB0ZVOm6IG42gYUk2vTV6ggFZeQUFoYU+MY/qUXHg0PocFTa3dk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Jt2YKyOp; arc=fail smtp.client-ip=40.107.162.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Jt2YKyOp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sd7WAuhg1TWwn1Fiw2Yj0GMT13eC9x3qvAi6cpbNeBWPqIYulOZxtB8vhADpXu25gno+45HSFmER5V3DqIFMEQvsKmW37ETskZdIPbSImGFk+Z9YoFIpLQ6LJcADAymqC9SjdvNe23tNbMV68sfMpr/LVN3xnSdLg80nAr9G8eypyPxvCsAjb+Szd9FvBRGtXBgIh0AAZO7ZvHO1VbM6vhMwHPthFZC/TUdn+XprM9qx4o6ILH2JVLTtqoYHlKeGDUbo9cybuyFm9Nt5NOnG6Mz2625/aRo363z+jGkMPWZBX86MGiLo3CYpRh7Rtr1HjgMHS34Kr51lF5nqVZFrxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O0aERrrEWRv2NDTpiFZAbQxH09FpUXVdUNQjXzjkYcE=; b=QUP+7aEALlJQC0hs/GHkFwY2gnU0GrEalPCHWJ+xxx+gcLq1OzVxPWuLmPejWaN7D3bY10Ke/cZlka9uNoV3rz3LTEbVnZBUNaa2fBlhSoKiCncokyjEsnra6g0FXVYxBq7572w2O+NrzE29zrvETuCFkcbPmJ2Qcq9rpkO/9KQOhPwFS+BD6e9Wg4FL1Zkd1a/rZZCBMo4BueWFRqzpNGDsaynja0B7MggLYO9uEiPZnaYb/wu2BDmAmyBKwa1a8fQ4Bsb7BTm3UeQSykIcqjBVfDbNoJZLBUIffsfNVFPfRQnQ4T1cwhNnul+32QkldLdX+2FD0ZE1ZcIzLhOkhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O0aERrrEWRv2NDTpiFZAbQxH09FpUXVdUNQjXzjkYcE=; b=Jt2YKyOp4Nd7Z4FW7va5L+PRZMalqF9v2O52vSw78ghTG+djEiofaj71+KRr/iWzFo9GV/H2WnlbRXMIex1g/3tH8etGNNLnuUUTLRSaTgNkAZ4jzYc9W5UEiJVT7lEVxbONkY0yzLebkynjaA33saySW6N1NV6q6qHL5Izo8b10zlHmZfc3Sv/pOFhqoLwUTw7ol65DXzZbJaSs4W9tNk4PY3lfC95RIQO7D8sxxQn3Cgb8AQmkifgZaLHB8/KBAPu2IfOmQiBATBN2vOLiuPnZ0nwyCyRe+use7W7cKNwHomcXi9lN4zPthaosASQ4eLQyKDhTALHHRe4d9RqeGA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) by PA4PR04MB7533.eurprd04.prod.outlook.com (2603:10a6:102:f1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.18; Tue, 25 Nov 2025 08:51:36 +0000 Received: from PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db]) by PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db%4]) with mapi id 15.20.9366.009; Tue, 25 Nov 2025 08:51:36 +0000 From: Wei Fang To: shenwei.wang@nxp.com, xiaoning.wang@nxp.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, eric@nelint.com, richardcochran@gmail.com Cc: imx@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 2/4] net: fec: do not update PEROUT if it is enabled Date: Tue, 25 Nov 2025 16:52:08 +0800 Message-Id: <20251125085210.1094306-3-wei.fang@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251125085210.1094306-1-wei.fang@nxp.com> References: <20251125085210.1094306-1-wei.fang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2P153CA0011.APCP153.PROD.OUTLOOK.COM (2603:1096::21) To PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8510:EE_|PA4PR04MB7533:EE_ X-MS-Office365-Filtering-Correlation-Id: 64e27d24-dee4-4b08-df70-08de2bffd71e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|19092799006|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?HjCTkMmyG3cgB51nTpICRuoMrc9f+DXjjhyOxHRRQ6hZxZLim/PfNg8R3N3Y?= =?us-ascii?Q?y9HcvIS6ULeEbg74i0S2B1pwgTcuOiy5z9Ppx5k8WwR+QfTyg+1x9Qr58EFv?= =?us-ascii?Q?X+L1XZ89oaeO2vSr/S94FhH0xVCZnI9BkSTfCurjNkhApg9WTJnBRTBJSaJF?= =?us-ascii?Q?E5h+ndeAI1uzg7Br38rXK4tv+ehqVUGlbJ+Y/yrFnd7b/Pn/I4wA2kD8Nx0m?= =?us-ascii?Q?qgZik+e/UmATzzsDBlonHlddG2MWl7GbDrJ+bdDq4bkIVWFQMBulxzJVGMuH?= =?us-ascii?Q?oZsTxTF5Y0ewTP+035PLuwc2NvfewtFIQgQVRn23ekv++nb2G0rx8/ERx2Jl?= =?us-ascii?Q?onxOCZk56tv6GSNcWsaqsRpCC+SUIJHZB7vzR5CB8+6xfOSHyh+G3lXFpuaE?= =?us-ascii?Q?aBz7kEivNTNVpj4FFXwkUX4TDKet2Lv6e8x/ddURhlg6creZr0qd8RldUp9Q?= =?us-ascii?Q?2mTPeGNgi8JFK9d+PCMSVSMTJdNN8SDb72kb1sK9hgcG3K/C46fdW8YSb8B+?= =?us-ascii?Q?nm2DeqATRq/VcQ0Q5Pw5PmTvizN9nYCnXhtEgOr93r/31fRPbB2VXfprPpfj?= =?us-ascii?Q?/xjiHOgVmiCU4aA31f980r9zsghUbdqlCNZ+L8zQkkTBqzrp6C0Kq6bChph5?= =?us-ascii?Q?VRpg+blzDDnfDazg51IFHH/GMC+6sdLzTOsRgylth1L0RW/Y1/CeGU4ddHnR?= =?us-ascii?Q?UQyeDMgbU+0bCJitMk2trbdbEJNU+jkCW5lAkyi4bu0qUGXm4lU+RnrK6zvn?= =?us-ascii?Q?KrmCzwVb9QnmoFN4UJMTYaTBRUw5FwNKrxzKSlPoEVvSVp1sw1RB4CPFM1Ur?= =?us-ascii?Q?lSrBzwd/zEqU29pCkaUQPU39ltBGqW8us0swI/yEgG268gz6zukRDm64s8Jp?= =?us-ascii?Q?Fk1Yqj7iHLGkbS2WyuQ9HB/3PvM6ph4yyBnwWGAn6hpWWjZ880w7NZMGR9fa?= =?us-ascii?Q?w9xgAiT5AxpDmlwbhvjjOa4bAjzAd0zbk0iBCdaxj/lN1H2AbYih4G7zhCYL?= =?us-ascii?Q?qrGGYF8P8LYM3/o5E8p/hJjs3lNY0NsHY3HsB0b10SEn5E7L6dl+gUuHU//O?= =?us-ascii?Q?9K5p8j643sTTFdYnUpYwi75Th//M0IYMWAYKh2EPCzCfxQGnJtzTdgFVTh8d?= =?us-ascii?Q?+WF7p+vK253+s3Nm68K93dqKqI5vCmIS7PJP+mOffj1P+JzzgqbX2AjIYCg/?= =?us-ascii?Q?DS8jH8vC9nNi6S28PzlvpbQs373vqiJTS399berI2BPZQznrs4Er1PdaSjRC?= =?us-ascii?Q?Mf+rcb4BBBTjrPgBYHsjxVQfScjA3O7mXpjT3l41k2wwVVrTV9ijlM6NhcfI?= =?us-ascii?Q?8q2OvIdz6RZka3Ll0pTvE5NOAUjMQoq8MKoTPYksW4Y3M64rKFtcaS/cl+Qz?= =?us-ascii?Q?eTaQ4+PJnQi0usyz35scrTxxOKJbWZ6bnhKSY+xgUAWwcJi2Eh6vhliYC6Xp?= =?us-ascii?Q?bO/lzc4rbnbOGDx2/RuUbOAQRR3Yyxe3qtpFgSfecNluMfZjGSnIlVGxmId2?= =?us-ascii?Q?Kyu1SYn9ChBR3Pr4D7tkQNDQbkA8MvA9lPeb?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8510.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(19092799006)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WNjvPvb5dCf9mhc6Hctc/W49QuzlC/l1ctfS2HZ619Px2UUm/S68O626hn23?= =?us-ascii?Q?tSrf+65BjPEY6rUp7SiAh6/8UycXZ7kzlPlfb4IsQemryP0cvWgQx4FbdiTp?= =?us-ascii?Q?wh+32Fm0EYb3Th4UjjMozPD2gxSJb66jWI3OlVA6aKjnGHDlA5h5pIXrXrWC?= =?us-ascii?Q?xMfnP1gJqxjUGTPfYFlHXK1BaxOy2klRqcau1KRK3416biYWFFldYeci/TyX?= =?us-ascii?Q?A8zlBSlSxT4N8RwOAfQM0klJ1i0koPEXCT0xa9JzOVJgdm6yLgLbm83nin+R?= =?us-ascii?Q?C9yo5mYh0aB9zG27krE5pRd++GNrkm+ZlvBquCeoYjF2kYGiHjcN+LZsQwM5?= =?us-ascii?Q?Y2JkkoPDotfeqnDZ4LFC1r38lVTL3N1jyBJ0baNAuXAOLQe4MCISbuCJZq0J?= =?us-ascii?Q?Z5YUKOzTin+VC7uaVc3UzL+3aZnY1Mltz6e8mi66/aTSTD4OVaQlQsgqMW1e?= =?us-ascii?Q?N/yD65JEGmVSX7gTXmvjV/dzMWi6IDaOxDLRB86lOfIIlUQ6QNrwixBHGTKq?= =?us-ascii?Q?YpWjoW9RPn83DO358FevaVP9j35mqHBGntYl2bH/ru81L/mk80oQ/crXc6nr?= =?us-ascii?Q?zyCg9krS147NPFuybZjwG/NShnbTOAaRgT7M0SbwjijShHBLmP8Dx3DibURm?= =?us-ascii?Q?3LUykU3s34oTFCKSE6PQ6YjbRqIcNJszfRYYyxVC7EO9PDkuQgHr+iCpjU7T?= =?us-ascii?Q?GYDWuTb0QdNIL7edjnX5DV50MN2UF9Mo8CCfkZrBhQRZH2K9/flmlRkQ+2z8?= =?us-ascii?Q?+XoDuG4sOjB15sRQTsxz/GpyC7++3S3xPfcJBBbWWM2YQDh98CnzKFhQREM4?= =?us-ascii?Q?vxknaGpreiJpvba6R5MLRWHHNS8UoqPnyeHuidwwK1nfR7p54Fh40gkovaEX?= =?us-ascii?Q?yERhJbP3gJdYXNE8CaKuL8MuM6g0JbDW3UJB4Nz0VqfjZYyXOqScqn7OzKUl?= =?us-ascii?Q?Pmxg3n8pq0g1ENfyWJZpl0wpP3SEjIrdgz8Vp4RDVSYlbTW7Ekfz2hTs1LWn?= =?us-ascii?Q?YdtUfKSXXjBL2ga/eHZjhS8qWlcbRd6ur/ujCPnEsNFYqzTwpjeqWDMmo/h5?= =?us-ascii?Q?0szXjGY1/9gjxJxVAA/hGw2OQI3HeQFxr1E6DyNdtu4Snbt3Z1BWFhVBNWgO?= =?us-ascii?Q?RebY93rHnrt++7a8tUVlayb07/U6uq4AC7pTpAu80W4IDS3dYRYJ4cxN4B29?= =?us-ascii?Q?0NF7OBR8kruZNIOa0Jk5hHGGCqGBtTw9a20l98ITDf+xingC0f0T5OsaAgma?= =?us-ascii?Q?2/Ff9yUv7jweB0v9c3EkifYZvTPR7Q1BeIPsGRm3IjfSKtve7/moHKnJvd+7?= =?us-ascii?Q?57b9yPCLOLPydDgAYaafR/EhQw4iKd7fC5bEEZY70djz+6mGtna/9+wjBC/C?= =?us-ascii?Q?HFSPX5O5dR6G2SDz9hSixP9TLQQAUJA4qzJN0nBdV/fESXh7bxogoPFdd0YS?= =?us-ascii?Q?w2+Cw9wpOwRSFTJbAnYqibVtvQEyE+3oXCDuo7UlxsBQaJ69YMC5KyQDNCx8?= =?us-ascii?Q?e0Gi+2ATA/5dS2OgshHTjh46qDQz1rcI9kUKaLXxsxMHxr56ic0jDqkO3YDs?= =?us-ascii?Q?NLc2VPaZZN528ov+1S32piGMlmOGB6TVTYwK9jDC?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64e27d24-dee4-4b08-df70-08de2bffd71e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8510.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2025 08:51:36.1344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YN0IIyrgL8yaYeqL38F+G/3JhkLPO4GZvf+Wz/j6KBD6aiy5itZcLcpdwh8SE0kg1C9BmqvKPUfh1xtYZiI3Bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7533 Content-Type: text/plain; charset="utf-8" If the previously set PEROUT is already active, updating it will cause the new PEROUT to start immediately instead of at the specified time. This is because fep->reload_period is updated whithout check whether the PEROUT is enabled, and the old PEROUT is not disabled. Therefore, the pulse period will be updated immediately in the pulse interrupt handler fec_pps_interrupt(). Currently, the driver does not support directly updating PEROUT and it will make the logic be more complicated. To fix the current issue, add a check before enabling the PEROUT, the driver will return an error if PEROUT is enabled. If users wants to update a new PEROUT, they should disable the old PEROUT first. Fixes: 350749b909bf ("net: fec: Add support for periodic output signal of P= PS") Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/fec.h | 1 + drivers/net/ethernet/freescale/fec_ptp.c | 43 ++++++++++++++++++------ 2 files changed, 34 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/fr= eescale/fec.h index 41e0d85d15da..abf1ef8e76c6 100644 --- a/drivers/net/ethernet/freescale/fec.h +++ b/drivers/net/ethernet/freescale/fec.h @@ -687,6 +687,7 @@ struct fec_enet_private { unsigned int reload_period; int pps_enable; unsigned int next_counter; + bool perout_enable; struct hrtimer perout_timer; u64 perout_stime; =20 diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/etherne= t/freescale/fec_ptp.c index 7a5367ea9410..f31b1626c12f 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -243,6 +243,7 @@ static int fec_ptp_pps_perout(struct fec_enet_private *= fep) * the FEC_TCCR register in time and missed the start time. */ if (fep->perout_stime < curr_time + 100 * NSEC_PER_MSEC) { + fep->perout_enable =3D false; dev_err(&fep->pdev->dev, "Current time is too close to the start time!\n= "); spin_unlock_irqrestore(&fep->tmreg_lock, flags); return -1; @@ -500,6 +501,7 @@ static int fec_ptp_pps_disable(struct fec_enet_private = *fep, uint channel) hrtimer_cancel(&fep->perout_timer); =20 spin_lock_irqsave(&fep->tmreg_lock, flags); + fep->perout_enable =3D false; writel(0, fep->hwp + FEC_TCSR(channel)); spin_unlock_irqrestore(&fep->tmreg_lock, flags); =20 @@ -531,6 +533,8 @@ static int fec_ptp_enable(struct ptp_clock_info *ptp, =20 return ret; } else if (rq->type =3D=3D PTP_CLK_REQ_PEROUT) { + u32 reload_period; + /* Reject requests with unsupported flags */ if (rq->perout.flags) return -EOPNOTSUPP; @@ -550,12 +554,14 @@ static int fec_ptp_enable(struct ptp_clock_info *ptp, return -EOPNOTSUPP; } =20 - fep->reload_period =3D div_u64(period_ns, 2); - if (on && fep->reload_period) { + reload_period =3D div_u64(period_ns, 2); + if (on && reload_period) { + u64 perout_stime; + /* Convert 1588 timestamp to ns*/ start_time.tv_sec =3D rq->perout.start.sec; start_time.tv_nsec =3D rq->perout.start.nsec; - fep->perout_stime =3D timespec64_to_ns(&start_time); + perout_stime =3D timespec64_to_ns(&start_time); =20 mutex_lock(&fep->ptp_clk_mutex); if (!fep->ptp_clk_on) { @@ -564,18 +570,35 @@ static int fec_ptp_enable(struct ptp_clock_info *ptp, return -EOPNOTSUPP; } spin_lock_irqsave(&fep->tmreg_lock, flags); + + if (fep->perout_enable) { + dev_err(&fep->pdev->dev, + "PEROUT has been enabled\n"); + ret =3D -EBUSY; + goto unlock; + } + /* Read current timestamp */ curr_time =3D timecounter_read(&fep->tc); - spin_unlock_irqrestore(&fep->tmreg_lock, flags); - mutex_unlock(&fep->ptp_clk_mutex); + if (perout_stime <=3D curr_time) { + dev_err(&fep->pdev->dev, + "Start time must be greater than current time\n"); + ret =3D -EINVAL; + goto unlock; + } =20 /* Calculate time difference */ - delta =3D fep->perout_stime - curr_time; + delta =3D perout_stime - curr_time; + fep->reload_period =3D reload_period; + fep->perout_stime =3D perout_stime; + fep->perout_enable =3D true; =20 - if (fep->perout_stime <=3D curr_time) { - dev_err(&fep->pdev->dev, "Start time must larger than current time!\n"= ); - return -EINVAL; - } +unlock: + spin_unlock_irqrestore(&fep->tmreg_lock, flags); + mutex_unlock(&fep->ptp_clk_mutex); + + if (ret) + return ret; =20 /* Because the timer counter of FEC only has 31-bits, correspondingly, * the time comparison register FEC_TCCR also only low 31 bits can be --=20 2.34.1 From nobody Tue Dec 2 00:03:24 2025 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013009.outbound.protection.outlook.com [40.107.162.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29C052FF663; Tue, 25 Nov 2025 08:51:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.9 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764060703; cv=fail; b=tmyRrxCty2eqC33XVdroafemKlv33Qoguj8pLvDVWyNG2wto82ac9WAf/oIEYo+OgGCK3gPqC0UK3Q5A4iYVCW/SGzPq8xCZ7R3UusGw7L1DW8mjcL10Q2bngyn43dLqKmyLFhIJSvCGgy0Q0GwAVnF7EzQmiHo3XK1ba4hCFX0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764060703; c=relaxed/simple; bh=+d7nsIWhnSl3KOIy6EXTE55IIAfxDYHicTiOsgIpyOg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=PogvVPlSn/xvAjWGCyOpm5TuKmRa+vrt31b6qWTx6JNAZcZ5g9s5MY/UknGxmlzA2dDWeRO/3xUwf7qdMZVdW/NeYIVOjePERvZbigC3kals5uauyyN94z8Wh29OO7GhHwgkS+/tSirjK4Bv151RTmEA1JmxXoW0eK6VExRRy8o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=MFjrc4W+; arc=fail smtp.client-ip=40.107.162.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="MFjrc4W+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AfvAahM0oL7RR9xIELVe2XmcW7WkGD2+zIMPR9lUoRTVlnMF55E2iehKX7kCBVt/2krYAdvVBwnmQN70U4EGLkwp1LQjXv257mExT4KfLsbPXxqW52e9/mqj7boSsj/mo/GeQEc36CG1/F4KHmDz59n6ZaEABk/4E18I3QYXcqTEapV/Ta30Ie9nUJ2ohig097MFIqHHlAMfFkX0lEwiROZyIZroxjNKZGPgMjUqNO0v1FNHGlMN2NWY9lELukFM44+IbNO1hZrVIXGHFPaX1S+BdWFNi5gwcUBpe9D6BqDS9JdNxPWUqSCynWY+KrciDuVFJT9CZumi4Z+diNi4Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qTrH9+jFzPTTNGmGAB03EiXFdNet7j53bmzzt+Ce7FY=; b=OsaHtmOep0YEfHV3Yz+rTUd2uh/9srZIdf0iAcuES5kAZ/aY/xYEpwQyamSrcnXLVtbzhioO15P3N/fOBSg+gbOOEUeTXZ1HcJStACT+f/Rtht1b5SgOq09mzcLraTRHPid3XbmsG/+kreabLrX2l7UGRYYFbcTgotHbwJ4JEYa4AW+fJP7DFmpaOJqDLqjDV9zhO/+OflZPrCgMbo3GK7NDLFTqKGTSwxfZN0X3t5cnuYRExbZGYAWL+LXuXsmDii5GTr2VlFMkUra5a7QP90Pztcdenl4pjJq4XC4TcWX5qf7cjmS+ulta4jMQVuyhueGWaJy1TWtq4PjIEzEl1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qTrH9+jFzPTTNGmGAB03EiXFdNet7j53bmzzt+Ce7FY=; b=MFjrc4W+TyK2mRCFU26ho1SqFpEdFvCKnSgK1zARLKPcRNlfMdoraSEDMQAYj5MSMF3WM1agVUnIzSw++Oz5GnCsdWtlvgyq/X6DqzUQTgLmOTWN4qoz3CU0NB1RgWP9EQyWF/K35gANWK9UEZ2iYi6U4s7RAKNgiS0DKgZIQFbEz6d3aGKazc6SITJQvoqJDvookA5WvzHOD1OF/K4sPQE1vrXbgLLgjmKusUqt4/0qz0m2pub/ZUqFiKU+M6BKKXZQJicBC8DOrFd/5FUh4kpk7g9c/owPP7I8aVNnw37/NsdsCR6IGSIbIQE3YEfcknNo5ZY+1Up1OnNk1p00Dw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) by PA4PR04MB7533.eurprd04.prod.outlook.com (2603:10a6:102:f1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.18; Tue, 25 Nov 2025 08:51:39 +0000 Received: from PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db]) by PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db%4]) with mapi id 15.20.9366.009; Tue, 25 Nov 2025 08:51:39 +0000 From: Wei Fang To: shenwei.wang@nxp.com, xiaoning.wang@nxp.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, eric@nelint.com, richardcochran@gmail.com Cc: imx@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 3/4] net: fec: do not allow enabling PPS and PEROUT simultaneously Date: Tue, 25 Nov 2025 16:52:09 +0800 Message-Id: <20251125085210.1094306-4-wei.fang@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251125085210.1094306-1-wei.fang@nxp.com> References: <20251125085210.1094306-1-wei.fang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2P153CA0011.APCP153.PROD.OUTLOOK.COM (2603:1096::21) To PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8510:EE_|PA4PR04MB7533:EE_ X-MS-Office365-Filtering-Correlation-Id: f8fb6832-baa0-451c-b994-08de2bffd941 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|19092799006|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?tiy0PYERsRPhsmpoR3Rx+O9YZHcrpB9gUZGrxBr3yQkKTViUjsvaQDwFbX/0?= =?us-ascii?Q?7diGxj4uCu9wM16s5K9P6FxjiGuCvRHhnsIKpbFloDOX+CyEqZtJ5MF1ks1h?= =?us-ascii?Q?Abpg6FVnU4Tmy/CM6CfyU+OUcw0U2mcdYbEkjpNFbP5520zZI0QlkwyVzUex?= =?us-ascii?Q?yZBZeq1brJxADgT/Xp5m4Swl/EVb4Jtp3g3naERNDXsJd+DStW9cvTYacQvw?= =?us-ascii?Q?lImqEyOG+GusBLV3vVIATobozB0kOqGl9Tk6dCcNpmW56Y+xAOdC/EOMAIZ4?= =?us-ascii?Q?5Qw6djGK2MoNKuCMTn2MD9rIfXTjd5z9TSxvOwwSaym6pN2Sf1yTpEC9t3GH?= =?us-ascii?Q?WYQGP4Y4xYbFGhRWZX5VuW1Tgk+VgrAmWMh0G5HG4vBWH8Su4/A5GrHhqFXO?= =?us-ascii?Q?tLEeI8o/qxuE3eE9ewSvCCqS/XFiNRnlMyYiIVRWFczLv6tBhSNW+VCYxfwD?= =?us-ascii?Q?mRe9Y3p6RG/dXH2xAbEECb7R+2S8dJf05ETkmA+QVdX7OcgVidYb/p5BaRUJ?= =?us-ascii?Q?l9nwgUY2P9BnRQqka6x3KoNRqzYEB0+vytzYd+NevB1KQzgZu8fVg5OwwyYI?= =?us-ascii?Q?M/ryDIIKeXb/A3XPynN+F8FSnGofc8SwvOFyLZZYXpt5URuZosTbatxKfMtr?= =?us-ascii?Q?q2/JjbLdwM962MApWw0oYRQizIV1fZUWC3xl3bqFlddc+YDbEE+mysZ+pGBX?= =?us-ascii?Q?cr7h3P37hxWrrseKCAnq2/eh6+hU5VXXktS0grKZ9Ny44mvEMvr21c95E8/Y?= =?us-ascii?Q?Wk6pyHQH36/IPyeEA6/PG7K++xq1J07/NTnvjuMoBj+UfTfUokrmdA8yCo86?= =?us-ascii?Q?ulXDInzkK4nH0R1D2By3f7T2oQDa4oL++jbUMrDeWbrbsLS9Lr45zaggz6My?= =?us-ascii?Q?xdo/ZLwtZyrRq9tAnD4+Y/vNsCt7DjUJyspxSlXQia5lWe/HAuKSYIrLWfvz?= =?us-ascii?Q?BeNdkytrMw5bFrwjJeRKOt2e27WQFZ7V+jKe1jffNMnbHpYTSZUsIqJuzXfN?= =?us-ascii?Q?Dx0QNwkzyXgOYoQ2ereSC3qmaSewYQK9mPyV0TMn987cJXrJh/J4iZ3m6yU1?= =?us-ascii?Q?Oa8Hj3MzMzH9AiBXblVuJyFbK9LCSmk98mBXAB9C3gXSgFBJW8VDNwEyHY6y?= =?us-ascii?Q?a4clrrU8EBTa3elYEWK7JgtTat5dY101uU+r1CZOu0dC7e7N9VtJGKEaEoxo?= =?us-ascii?Q?wOxE1wORejD6UplARyjIJUl8zXfYbRLuYwS8JvMRI7dmRFmrUNrEc6jS2UlM?= =?us-ascii?Q?X5E/SzAoMvZglGHWwip0Tmog2NFFC5v8kgxgMoWFh1OKwNmDjE1oc17HSui4?= =?us-ascii?Q?hYhI8gf0NcM/KD0GtmpX7ou1SH5JaidKc+WnqXeFda6T2D1vfUMacBr1/x+e?= =?us-ascii?Q?SEWSnZhh+S/1+rGwockm8g8EdD1TuLyh4Ub7VW+C8Kh69BOptQanN4YUUoVS?= =?us-ascii?Q?fIfGVnRMBTNMdXaoDs256+CLY5Pwk/fC+mWDqjhjOfNRF0GsRPLOmtZfcjG9?= =?us-ascii?Q?Sg2qcl0p1cT3yeaiJsfCJgLKktEFOSgrH0AH?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8510.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(19092799006)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?omH8Y2Kj9TwE4wWWBuM2/2xtX8OUrPEYtDUS1NXo0mZ77wmowrcXEibTOTP4?= =?us-ascii?Q?b3NxFNeQ8gKgCTPwyAMAs7cYK3+/TPYouRS8j9aoMfUZtXrNrZPAqZSqtnrV?= =?us-ascii?Q?Enbx9ikPoRAhWqjQwfERcNmXbnG5mgZVdm32JLALVKKit8N9cjp1808iMLZk?= =?us-ascii?Q?lzHORQGWRLOTZf4GWVLSh1UhicYwAY8EyHxeRRamuFCsOQ5GrnfPNjBFQprH?= =?us-ascii?Q?TagdYlpbRY3otoCVuEqK/C+B7mesmT3MK50NYnczRwYKDxDQgmX3yZufrnlI?= =?us-ascii?Q?58sRPmhVWQ1unP4zrCWKRHBgUXzIOtQOarYCTBkIrsJZPmbSqioH6ARVF2dB?= =?us-ascii?Q?eqYD1Gizo7rn3yQ2URoliKgKq5jqRbO7or4bB5oFQhBkLxi4/AN1cHZj+Hcb?= =?us-ascii?Q?XJ3q8lHVDdD3xrjs3lDMkzNuLkIrFuA8VU+ZfqIQYUAueuIWfMyuTKuKJCGc?= =?us-ascii?Q?hTEF1WwJicfZN0bx0kHqDh8w7O8t4eYTtH/pIzJGU5JyMpQqIzWXMKOFBuCk?= =?us-ascii?Q?PcqnDpIQrYwJQ0zuJCojLE4DE3WOR3b0YBY1YjpMJMhBtZfYAXYuFnSZR0Lr?= =?us-ascii?Q?T7pr3ZyubjzQQgQi1RtRuxbUcVUzixtE2/QwOGhQuv1u5L2UFfllYwvNTOLS?= =?us-ascii?Q?bnABiLE53FUHc4el4IPLMhEppDt6T1ZyBv3iZ8UuEr+tp0euFsPMtH/MTAWD?= =?us-ascii?Q?MRX0Sxb22HytQ16c7AH1oMJW6AU+v31FXUofz1rfpeE5na3ER3QWvR4RgcWm?= =?us-ascii?Q?4EVWJRxFFYoc03h/qvCNPyQn0k7aKa6zvHy4qDJm9m27GJ2+KPIXrrlZMkkq?= =?us-ascii?Q?wZSGr17IjPNx373jGEBTO/hNdk6TzkXmgJeKHVSB8LBWJQGM6w/QrRiRWCbG?= =?us-ascii?Q?FMsrFjlA+XxXOcr2Kuhqk+jVYFp+tCGOLKMPaMlmX0/7wslsiiAtopD3qr1e?= =?us-ascii?Q?tRYx2VdM+WXjVyewGfXca08nSCwy7pf5wrSc8x2m/Jj9wi/j2yKxLpDv5M13?= =?us-ascii?Q?JE1PWjDaO4HnwPQMfmWazmsVNtXlQ5P+YVX1ShtsYTiCdPyv29qTGe8Vz022?= =?us-ascii?Q?L15hV2dujQpc/p3izlOXN8fM7jDvxt+gCVlfqqCA39WMecikCk5CzBXuiSqA?= =?us-ascii?Q?NOSGlPzEsrTsLEzvESztsDLlHkqhFOZoMlQvzB2MKEd0a1QN6fDQ1fCMkNdL?= =?us-ascii?Q?yTcn+XUlJ0Mt8hmbA9SP9WXi/0IDQc46wReMhphPIAF5QcxbeTuUIrSb7SaG?= =?us-ascii?Q?msbLEVI0Grn13WqXi+sezGJTqZHVaVuEg6UH6yJDT8/BScslPK8Xu9JzOeWQ?= =?us-ascii?Q?D+1F6hBeGqjCGbNPjWlZQ8bRPYaA0S7DIU//9ZYe/Sx0wKwllLaa0uWq2Wf7?= =?us-ascii?Q?tqyiF3ow7XFQntMmXScIoEBFHXRVE7oBeC2dKrDHfH4udWsf3R/57TXcpBWT?= =?us-ascii?Q?9fpDrteypYjO5cddAYbbA83ODLLhVb2ZVJrpXcPacyShaTCWfzlPHJYpjau5?= =?us-ascii?Q?EW0hcsviNnjCnthPutYV/sFAs47xyEE7u0rG/1OHSAbg8iJX0VCSnVV0MmFi?= =?us-ascii?Q?eX+61E7DuywCRRl++Owq1byStm+IjEEfA/UPH5z8?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8fb6832-baa0-451c-b994-08de2bffd941 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8510.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2025 08:51:39.6480 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iNVwoADKPlfhTfGBXZxBtp3PKDd3r8jLsmZ0fLaMJ+rIR+Oh2m7C5ANYMXhMnrtKfG4qQa0h5EZKHjP6Lfvwuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7533 Content-Type: text/plain; charset="utf-8" In the current driver, PPS and PEROUT use the same channel to generate the events, so they cannot be enabled at the same time. Otherwise, the later configuration will overwrite the earlier configuration. Therefore, when configuring PPS, the driver will check whether PEROUT is enabled. Similarly, when configuring PEROUT, the driver will check whether PPS is enabled. Fixes: 350749b909bf ("net: fec: Add support for periodic output signal of P= PS") Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/fec_ptp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/etherne= t/freescale/fec_ptp.c index f31b1626c12f..ed5d59abeb53 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -128,6 +128,12 @@ static int fec_ptp_enable_pps(struct fec_enet_private = *fep, uint enable) =20 spin_lock_irqsave(&fep->tmreg_lock, flags); =20 + if (fep->perout_enable) { + spin_unlock_irqrestore(&fep->tmreg_lock, flags); + dev_err(&fep->pdev->dev, "PEROUT is running"); + return -EBUSY; + } + if (fep->pps_enable =3D=3D enable) { spin_unlock_irqrestore(&fep->tmreg_lock, flags); return 0; @@ -571,6 +577,12 @@ static int fec_ptp_enable(struct ptp_clock_info *ptp, } spin_lock_irqsave(&fep->tmreg_lock, flags); =20 + if (fep->pps_enable) { + dev_err(&fep->pdev->dev, "PPS is running"); + ret =3D -EBUSY; + goto unlock; + } + if (fep->perout_enable) { dev_err(&fep->pdev->dev, "PEROUT has been enabled\n"); --=20 2.34.1 From nobody Tue Dec 2 00:03:24 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010035.outbound.protection.outlook.com [52.101.69.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57B8A2FE07B; Tue, 25 Nov 2025 08:51:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764060708; cv=fail; b=m7gwFqDHa7roJoqdNT69mk5pqqQphSK2Sg+t62zyG0uxkBzEIyHeypJDV92st++rtOdkfL/HVrSx27sMIYIqo2GK64rAC9ECfSLbYX28vuUdq5O/sKqteNKogSbrxLDcURCCMhCgKEpmgSiglde3xGKDoi3AkB0KTb7axrF5RgQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764060708; c=relaxed/simple; bh=QQOha/aQTknARcVI+Gvouf3TC+Y6/Fa7tvJTaRugD/M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=SnF2LCer0JhkQ5aF6CduBKiDFB1Raoxq4hpxl6rx5XKGzITwA44IICB+eJGTBwBIZfjgyTcj8pnMKbDUuihi+p9ooNkpUcrnhux8xE4wtBQsPcnbxJt1Us68nPS8eJERSGxeKNuCaNgTkSV+9HtlhLMvEItws4tnWWw9OyWotNA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=UiAmNl9N; arc=fail smtp.client-ip=52.101.69.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="UiAmNl9N" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dVT118OhNjpeQq0/hJtH3MLuuGL4AFqFVIwOAvahZ35LjOgBmgCPhsPBRQEk8Rw3eHbjbg71VnEZdjqsNrP3SJqq1je201Io0yseFk3m7PHESV8yMkS+OEZ2U01d5Ps44aVE+p/PHNi9zIZAwlyecJClYj1llqBiOsD3bKAozbE60DZZYoneClT9keyqjq/2LHW2yRE4oSFz6O5/6hyyg6xGxg4Ljy1xAPrwv6Oi+zBabW+AvGqML4e0pr2D5L5TwBMEk4Ct3BAG1T0vcpaD55IkWOUZbd2Kd2WSsZTH4ggSGlbaKEAoXort4qJKuChvptGmqoMeVtPMSoU0pQujxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8kO7+N1xJLCXr13CVv/lykZOp+Cq8ucb51KPG4K7CvM=; b=qtGRbrhsCxLJr5I0db1XH4VpWeVCD3uacKEkREbuQV5Z/nI1n/eFyxFAKdYQFbJdGx4LOIXW8KxdjrzspwQ+5VhrI76C+BCMfPg3tJuwgt1ZvOyFTHoJtxTs1oGvrETAXrgX06i3zeS4L/lW6Khqwud4BIc5TS6PgRnPJwvn3gSUw5CHCbdY1W0xuLmqYn4tpYjBxtrvU+1a119CbMQTL6hDztZB9wh/BtTp9ar05BYYr+AiHn4XFu7qaTlA+xbl8WJlqGqMnhIx14H30/P86lFEf9AWxAZRtyIlw5WaPgDXkHSfMKR4ggKOHdeCO/HWP8elPbq6acI93QNpy9eTVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8kO7+N1xJLCXr13CVv/lykZOp+Cq8ucb51KPG4K7CvM=; b=UiAmNl9N5WxwkcAAb6CIbd/kfXxDqEzurFv+P89kvhV3vNxSzLrXbrgiF7yn4EFs1B1lfHafEDVDEuePxMYlNRX4WTtxn0wDAvYzL72q6Dhw9wUDCZ8sPNdvR7xBreebuJAnMk8ulF+OcGnkFmq67of1XW8+5Eo093G57VIm6MuD7hFXfEPtrLPhxu/oswASwEhZ6396WwJi/6UCc8ton9HaWc4bVH+ng8oWacR1yqYg7cbwIdBttjnJbwI1d5AxI6ri/87wN86y5ahVva/ktnyTkFGrLKqwgaz6q6TCSw1E0V9csU2dTASbfPw04KLCf3Z6/C7pwugi2DYLzH4wgg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) by PA4PR04MB7533.eurprd04.prod.outlook.com (2603:10a6:102:f1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.18; Tue, 25 Nov 2025 08:51:43 +0000 Received: from PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db]) by PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db%4]) with mapi id 15.20.9366.009; Tue, 25 Nov 2025 08:51:43 +0000 From: Wei Fang To: shenwei.wang@nxp.com, xiaoning.wang@nxp.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, eric@nelint.com, richardcochran@gmail.com Cc: imx@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 4/4] net: fec: do not register PPS event for PEROUT Date: Tue, 25 Nov 2025 16:52:10 +0800 Message-Id: <20251125085210.1094306-5-wei.fang@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251125085210.1094306-1-wei.fang@nxp.com> References: <20251125085210.1094306-1-wei.fang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2P153CA0011.APCP153.PROD.OUTLOOK.COM (2603:1096::21) To PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8510:EE_|PA4PR04MB7533:EE_ X-MS-Office365-Filtering-Correlation-Id: 67fe0183-8308-441e-5954-08de2bffdb5c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|19092799006|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?eeuwJaKWDzWrwE8soT8zXVq+iYcxWTBwenzd4GzBnpM30MVVqrmbodXkVc1H?= =?us-ascii?Q?wpZR321qMGkecouZaMZbpFTyLOlkdDy2TmWBIWBHYzciOdMkOZrRRjk7RE63?= =?us-ascii?Q?Y/cWcNw5KzXdHKuDxnBfosy0cfyMKLB3eg+isUvfQdi6Ttbhk1oW/j4JuBUf?= =?us-ascii?Q?X5tZxJIjqCdlDqqmKjaYVUPlooOejLHriIlIjUJS/uNV8ObbnM9oLa2a2lf8?= =?us-ascii?Q?vWjfIkvdMSPOxKuIrq+a2uCtLG9r+e1GFQKwkUCrcVIJPtnDBdWfUEUqTiwQ?= =?us-ascii?Q?btrukBw7IP3vKYY2CQ5wHvGec94iC+QPKMCmFNR9M1qVHymWoBhiYCe2whZU?= =?us-ascii?Q?2UIql74vaKg9ITDYhXDSaMMgW0JkQQFPmVLST5qCK88l+twsUqj0Kgh/rsa5?= =?us-ascii?Q?KRt/TZ1fj4MCYt8cmcRQpvJptPQhHEwHbVq2mPEaOi14UTdaA3EJlg2Cjg/m?= =?us-ascii?Q?WmI2wT3tZnABszolAhnuBygoyo/sRoQKxHGYQfmoarGUZ8BczEZkNqu+2aoQ?= =?us-ascii?Q?4CZEWUZaD/XU2e4C0j784l6xkKBHy6/ehVvQ6Vxc1YAi3+vT8VyHxoMAEHfn?= =?us-ascii?Q?YD6OEjYaDMXJcYCfT60VPuTv13GsI8iZ45K1eIpBVDzHP4dWQvcVcKXmg6FB?= =?us-ascii?Q?aVI6AIAuEbmcpugVaFUlB5EpGQPUD6Tfz/kEz3BV33+nCJAH44kzQiCMn/Qy?= =?us-ascii?Q?OX78otV0Sh1Pey7X4WiyVOHdfc/KCV0FEdaru6az4u7p5bvtLLKfApg80bFg?= =?us-ascii?Q?dYW49jLj0NBxVqxFfU70YMwdHYAdsWPEEPAN6r2n63UbZ2P2kgUc2gVsjZcl?= =?us-ascii?Q?ZILclgNa0Br8LvcYnlO3LQ0DGfuj6kzG0KCIAH6BzAWZCxsYiFdWBRImTkGb?= =?us-ascii?Q?f6qObsnHa+r/JABpBQKuddgsVq8IVckuZCEykRCEJJqCKA9D0jurReBhSm9t?= =?us-ascii?Q?oiz7p708G3lsJYPNIsRpix8XuTPAcg3YUdBUVJED9u2eIQ9dEJNJAg5e9D+z?= =?us-ascii?Q?OwRf9Go3ewGSc53eNDt8ReKaqeUGA+ynybOxApXHdYu1Ne1LT3ZJK50S8mUy?= =?us-ascii?Q?xcfRUX++2OOgakM1ClXzYRFPhP8T6mt53MOTt4lYHqZ1IsQMB818S6APAvlA?= =?us-ascii?Q?XZxfQW4IQIqRt2nkur39gcxAgY2d4Ce0CiamFlWbuHGLsYV3ETqQqsa9qShZ?= =?us-ascii?Q?XSs/s5fU85F8tibQF3pyPzfUyvp6F0fc8doOvzi7n0fmlXx2TVjN0w4DcmJC?= =?us-ascii?Q?s4ryZ16BnGVI+K8E/o8HZXW/efiZZJjuhCMbTt17yp6MIbTlxPL7GSw0i9Rg?= =?us-ascii?Q?I/h+e/2j6+D3yKll4SMzXS+15qBVVJdsVtShwTRNTpJq0VRKruEmwvyXTokk?= =?us-ascii?Q?RSwnDvl8IXw4gEpUslJBECGlmW77EC9v0bZJve8tihMPwv8U8cmGntbNEEZo?= =?us-ascii?Q?AWCxcgCzcNdVM/rTefca6nh4B7FXRvikyjUVwzjKIP4FgrqhBMXuUxbEn+WQ?= =?us-ascii?Q?u05KRslG0ThdHGXZyxqJp0TEh0rwTCnhBm8T?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8510.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(19092799006)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yTUuZsViONpig5ERZjG52kpwQgVUNQfbK/Pp+dadvQYtyC/GZh42Jo2oQJ1y?= =?us-ascii?Q?8r2EKRwAK7hMpmpPHPSdrmhz9Aue11Xz+fPdIe3rfAaTlgeyQg6cU1iVBqTd?= =?us-ascii?Q?IEyGA/6tyCXy5DaCug0tMxjEHgzgZn2w5rCaDF192rG1paJs4ZKYfbZtKnk7?= =?us-ascii?Q?PyUmp6GzAPpjXyjJI1bAWJ6Fw6YBKdww/p2Rrb1FIPjMvi+Jn/VRSkwdkRHI?= =?us-ascii?Q?6wAAyslCGofBlo7iB5ZEEc7Qu+XnULUn+eLrE367lmsoz9qHW/vXfs5Az5vv?= =?us-ascii?Q?suhT1r2qD6+k8NfjzTMKLEJun6IIdFK/MsHDENtHhdEjtmGx0mr7y8ImODb1?= =?us-ascii?Q?fb4qhIRIyqTiB6GtZvpeDcjCd9Y5AILU3eSVzDqgtOp32hqWGDyte17NTy3h?= =?us-ascii?Q?wQ1uctzQHKoG4+IYzD8aaI4zDGX3nBE+kfjfDWwM58UQW6jA0x0OpBQtheGT?= =?us-ascii?Q?oJ42r+QcmLwGPxomR+blk9Fq4s1gKsYtdEmOKG+5JVF3TaHfoE4Olu//1aEd?= =?us-ascii?Q?5vUx/bQyPosqWZo26MUgNSyYdUNnjEZZAJcZOiX5B1ETQ3WwG7RD2eE5Gkb4?= =?us-ascii?Q?gglhg7BMo4Nq43bE1ePBNzQuFNd05CMUWH3ZrbjoyYI8OCuwEdaOktYSNrFn?= =?us-ascii?Q?SHvR/iRsnxfiZOMeeZ5TzZNjMgmg/RQD4A8v/eq22gr38EdN/YRzhLyeQpbg?= =?us-ascii?Q?SIDBWMojy7c0+2LnJLVXHjV3riYxZAHvPqZ2Pf6qpFWIUutzvupuUb7PX+dl?= =?us-ascii?Q?BRwbncgmgfOjwcfKyK1F+IU5TWsgfqSpj2ni+FVfp2f2PF7nr36G9lZfz3IS?= =?us-ascii?Q?Fh5r6NK8H4gf2fvQkXuXPMdB1lXxl027XgWFRvNL9eitlyYLQ/g432ikv6rU?= =?us-ascii?Q?86iRCBdCs8J6Zd+5fSEUOxOEQAlIX8Khn7O5YvnGd92LGZkIWzdKHq403hwX?= =?us-ascii?Q?h+Mcg5XUPn/TZQzWUDB4ju9joijq5m1So2heFP28dtLoDFtETrl3ZmsF9jxv?= =?us-ascii?Q?ptE3rmP+JjBnIBobdkeN5IrSs9NeUiQvFORNyCNDyIjiZ1OBrn3yvdXrh5e9?= =?us-ascii?Q?99YtFyWIQOw/46/r5sMiduoJsuiS1Es7xjKIfFlkPG1YPWyDM71QVdKHLLHe?= =?us-ascii?Q?r8W0YAk/PHQhy8tVX5n4WmjaEG7sqwBSwl3X16i6/YdnRZQMgfwcDtKPOkPj?= =?us-ascii?Q?s54+bDbJpJZOdwr4DZnE6HHuz1d+W4Ls8ESWFcJKVwBQPMRfZ+MHUupnWCRE?= =?us-ascii?Q?UzLF8P8jtJHi6qw8r+6JinzZpwNde35PVnl5iy7aOzW69SBtylG6BYBEQV8k?= =?us-ascii?Q?/IW2Fz7VJNuLiQEOcm73azt4/EjqPABcFqn/EI8wjbETDyNQ4Y6OjGavhUxg?= =?us-ascii?Q?CffAK08l8ZhGZVGIXdHm/BOdusp1IfvngsehMcEG7tmKSPgkulPWyHbz2uVG?= =?us-ascii?Q?aQHZcYWeLWohPbO/uC3EAqLDBmbflJVbSLk+/Y05IKsU+kXr0763nJKpdSJs?= =?us-ascii?Q?eowV36baAnhT0yyj50uUFwf3qpcyyOscS+FRo+hiZSi3pFtcjp9Qtx4gahfA?= =?us-ascii?Q?C2RdvnsAEykPNDYMsCSb336Iax4WQyzMT2VQv4ki?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67fe0183-8308-441e-5954-08de2bffdb5c X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8510.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2025 08:51:43.1983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kKRF3dzyIdkh6WYCPugJiFIDgTxE/IEdaLZXbz9DbjfHhihbUcJJe3uBcEzVrP21KVdOWc/GMag9Ju+4DOyJGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7533 Content-Type: text/plain; charset="utf-8" There are currently two situations that can trigger the PTP interrupt, one is the PPS event, the other is the PEROUT event. However, the irq handler fec_pps_interrupt() does not check the irq event type and directly registers a PPS event into the system, but the event may be a PEROUT event. This is incorrect because PEROUT is an output signal, while PPS is the input of the kernel PPS system. Therefore, add a check for the event type, if pps_enable is true, it means that the current event is a PPS event, and then the PPS event is registered. Fixes: 350749b909bf ("net: fec: Add support for periodic output signal of P= PS") Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/fec_ptp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/etherne= t/freescale/fec_ptp.c index ed5d59abeb53..4b7bad9a485d 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -718,8 +718,11 @@ static irqreturn_t fec_pps_interrupt(int irq, void *de= v_id) fep->next_counter =3D (fep->next_counter + fep->reload_period) & fep->cc.mask; =20 - event.type =3D PTP_CLOCK_PPS; - ptp_clock_event(fep->ptp_clock, &event); + if (fep->pps_enable) { + event.type =3D PTP_CLOCK_PPS; + ptp_clock_event(fep->ptp_clock, &event); + } + return IRQ_HANDLED; } =20 --=20 2.34.1