From nobody Tue Dec 2 00:25:22 2025 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 100752BEFF5 for ; Tue, 25 Nov 2025 07:52:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764057126; cv=none; b=aFc2uZI4g6BreunH86Ll2XZTbLf06BaTcsSC9+20JnZi2dx+uaqGxplXb3Kv03k/M98WBm8M9/VLQc1Cus+mYR3tr+myfIwqCJqfiOK6kGdaDrcQWlUqLQvJvlLhToUscs2N5L9Ef/MlnGlIFqOiJMckCRyI1L3iJbJuI9gtbhk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764057126; c=relaxed/simple; bh=QQ9ntuYhygUsjfxWjbJZY9/FX0sWkRHe9KfAHu92J2Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n2zXhnRR7aOZFUIk8oI/sBHp1YbRF95hwKhMVvTFVOWzg45V2LW9iURDnt08QHU+vpTI6xZSTVJtQs+08rqeL+j0Dx3GvWWhkc27BXXg3CtxmTVp1tUzyu7xA52c5hObGIgIN4O5alUlpuIf/z49bQldZChx5+QBkzpM/ukvJDE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OFZMa1TM; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OFZMa1TM" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-b739b3fc2a0so95080866b.3 for ; Mon, 24 Nov 2025 23:52:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764057123; x=1764661923; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZOFFbceL7ixCdLph1FgW62yHiAksNzDjiAkR6G7AzZY=; b=OFZMa1TM/jsJMeLCNNZoQwdtJUU8d40uxMmxWMJTTDKJ4Tv+fPgkbcigT49IJ7QU/0 wnFtitz9JMa7ADHQFJCWj8qnEAHGdBUcfQTwntczCzP2wbbmruIkmzwZLQWL9MTvdyP6 QLffg+9LeO/XmLVbThjbCh/lVZNA7RAlZZVe/bUZD8pId+HtyHbLXJ2TqdS1DJPgUlOy ECxD1UW0gFbp6dPrv5h8zJT3dGpUh1y9OK7FldBlrVv6yVFlBrBNzMW1sKq9deu+8D5N iXND0be1TbclvOSIRlRGwbASRDbC9w7lH9VsrHfVPfSFxkJCl4OTShp+nua1bzdVFStF iVzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764057123; x=1764661923; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZOFFbceL7ixCdLph1FgW62yHiAksNzDjiAkR6G7AzZY=; b=pTpX/ODYlMHXdMY8DR1YtzeNeZfGGYegWxwxEcxOb03UH6Za/iPx9tG6ju0oTAbyOK KxYgVicMj3pnNhRRVl3O3ErJsF9NyDCkAlY2xt9oY3CDGICvje3OH7w1/L8DDDbix5Xv 175xfExOFGqXWWrSB+0zAkFoEvrGrOjmFI+1tIdB1wOaRyMjG9zdXuHN5ZjgUOrM1cZw /dMcVd82AxXyjLSgekeBjqjNO4IroOJFwOd4Fia7pvm0xrd78bxxwR0jshRzG+KsEpus XmzSiIaqn8bInjmJGqgjg8Bi5vFXXOra7mUCseXy48FWgPPYyWOQNvZkis3qXmm7n7/k AIdw== X-Forwarded-Encrypted: i=1; AJvYcCUewwsqNGT3iFULku+BNBpzX0bda4wmG1FbYSAx98kOzAzV66T7goVPrD3zoR5BWsHU/oe+XK/YTcQ9Ghs=@vger.kernel.org X-Gm-Message-State: AOJu0YzU+LRLZ8mIF0UA5TvZOLLGOVRKDO9u/liMb2nCUnPM571GflT5 I3vJWgs2VVHMADpTmjFjXe14gZ0/Su0COjl5LVWIWiza84KQJ7avDQIr X-Gm-Gg: ASbGnctSrazbqEv9iGk8OK46u7UpcnGdIcyLhzlJzO7MdUn1TU+TBv1z3swZhgIWZck cKyb6XymxwlQbkm6Uo4mhvcfsy9MuRsw4QCEav45GbnWRnSl3AY/P1VcOD04c5QSsN3rxtdflKA uAB1/kjF8BRLGgx3YExr4WbBrbVnxVkZLB/mgEgE0VEVorA4Oefasyk6zPfrzqBM2EMQcaq1Exd q7KyV8B4HhMf0VbSKz0CoNbpDLYgX5/TOY9NoYMu45RzbwRg/H/iDBEYeIWqmmZtqeIFw0EkCPT AHldOA1NrMZrGoX6BB3RcPCNbAUCaP1OvNagBTIhM+IFvwUQdzPrV4YPql+CoFNoWsrX7NpGj8X NidIAj9rLG1CULcAKzRz3Pfh/WG/V/WO+RMkG2SVt12Ra3HN3Qq26l5I0z03ssHTtnEXnyzjOOK NkvZWq+WvuzNbMEBmQesffDkkHRhgPR1R1o5u7Oq/T5p8GycdtHPk33N0xFPjE6CEjwDuM6NQHk Y4Cxw== X-Google-Smtp-Source: AGHT+IHPFwvqG3ONIsm/AzjrLUIRNEbm0l92p/sdhNru/P9U5+Z4BpK4CrBOtHk9NZMM7UpCONTnkw== X-Received: by 2002:a17:907:7f19:b0:b73:9b49:2dc7 with SMTP id a640c23a62f3a-b76c558f4b0mr157643366b.52.1764057123075; Mon, 24 Nov 2025 23:52:03 -0800 (PST) Received: from localhost (dslb-002-205-018-238.002.205.pools.vodafone-ip.de. [2.205.18.238]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654d7cb3bsm1536176766b.27.2025.11.24.23.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 23:52:02 -0800 (PST) From: Jonas Gorski To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/7] net: dsa: b53: fix VLAN_ID_IDX write size for BCM5325/65 Date: Tue, 25 Nov 2025 08:51:44 +0100 Message-ID: <20251125075150.13879-2-jonas.gorski@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251125075150.13879-1-jonas.gorski@gmail.com> References: <20251125075150.13879-1-jonas.gorski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since BCM5325 and BCM5365 only support up to 256 VLANs, the VLAN_ID_IDX register is only 8 bit wide, not 16 bit, so use an appropriate accessor. Fixes: c45655386e53 ("net: dsa: b53: add support for FDB operations on 5325= /5365") Signed-off-by: Jonas Gorski Reviewed-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_com= mon.c index 72c85cd34a4e..7f24d2d8f938 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1966,8 +1966,12 @@ static int b53_arl_op(struct b53_device *dev, int op= , int port, =20 /* Perform a read for the given MAC and VID */ b53_write48(dev, B53_ARLIO_PAGE, B53_MAC_ADDR_IDX, mac); - if (!is5325m(dev)) - b53_write16(dev, B53_ARLIO_PAGE, B53_VLAN_ID_IDX, vid); + if (!is5325m(dev)) { + if (is5325(dev) || is5365(dev)) + b53_write8(dev, B53_ARLIO_PAGE, B53_VLAN_ID_IDX, vid); + else + b53_write16(dev, B53_ARLIO_PAGE, B53_VLAN_ID_IDX, vid); + } =20 /* Issue a read operation for this MAC */ ret =3D b53_arl_rw_op(dev, 1); --=20 2.43.0