From nobody Tue Dec 2 00:44:40 2025 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FA9C1EB195; Tue, 25 Nov 2025 01:44:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764035076; cv=none; b=PXqARTdAt1T3I1Aood24Lek+m9K1tzVIPBomNG4SbJrErmtO87k8i6psJFiUi1U+0anrlaSovtI6ayFw+UQxAP9clO/ZKCzgT7PJ+fYkIXFk/QqLQdtf0ja/PUwgXhlc1vDk4OEapSiqKoSuOgDJhmevC1lMyZivuhWW5S4E478= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764035076; c=relaxed/simple; bh=qw8/uYRMptxs0uwQ83diseB8FzQ4VdZ+FopeAmroTv0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=NdA7T+9rXKfZUZPE+B5IPvbeMuBcGJjAPmirsJe2iQTXNW0U3z/5/5Tqnj3wTZR93GTWe8GSC/9sRxnd7l21ou74FqJ3iRRuYgSe6g2w81RFoaNKnaqvcAQ/pyjueUJN+LJ5Canr7+wBs96pasomVv6cIzN8c+49KvnO8T3N0bQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 4670a1aac9a011f0a38c85956e01ac42-20251125 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.6,REQID:67c66d7e-412e-4a53-b9c6-df7e943d76b6,IP:0,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION:r elease,TS:0 X-CID-META: VersionHash:a9d874c,CLOUDID:16152b78a9394bacbdfe02a23d67e84a,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|850|898,TC:nil,Content:0|15|50,EDM:- 3,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,A V:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 4670a1aac9a011f0a38c85956e01ac42-20251125 X-User: chenchangcheng@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 73763576; Tue, 25 Nov 2025 09:44:26 +0800 From: Chen Changcheng To: stern@rowland.harvard.edu, benjamin.tissoires@redhat.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org, Chen Changcheng Subject: [PATCH v3] usb: usb-storage: No additional quirks need to be added to the EL-R12 optical drive. Date: Tue, 25 Nov 2025 09:44:22 +0800 Message-Id: <20251125014422.12721-1-chenchangcheng@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The optical drive of EL-R12 has the same vid and pid as INIC-3069, as follows: T: Bus=3D02 Lev=3D02 Prnt=3D02 Port=3D01 Cnt=3D01 Dev#=3D 3 Spd=3D5000 Mx= Ch=3D 0 D: Ver=3D 3.00 Cls=3D00(>ifc ) Sub=3D00 Prot=3D00 MxPS=3D 9 #Cfgs=3D 1 P: Vendor=3D13fd ProdID=3D3940 Rev=3D 3.10 S: Manufacturer=3DHL-DT-ST S: Product=3D DVD+-RW GT80N S: SerialNumber=3D423349524E4E38303338323439202020 C:* #Ifs=3D 1 Cfg#=3D 1 Atr=3D80 MxPwr=3D144mA I:* If#=3D 0 Alt=3D 0 #EPs=3D 2 Cls=3D08(stor.) Sub=3D02 Prot=3D50 Driver= =3Dusb-storage E: Ad=3D83(I) Atr=3D02(Bulk) MxPS=3D1024 Ivl=3D0ms E: Ad=3D0a(O) Atr=3D02(Bulk) MxPS=3D1024 Ivl=3D0ms This will result in the optical drive device also adding the quirks of US_FL_NO_ATA_1X. When performing an erase operation, it will fail, and the reason for the failure is as follows: [ 388.967742] sr 5:0:0:0: [sr0] tag#0 Send: scmd 0x00000000d20c33a7 [ 388.967742] sr 5:0:0:0: [sr0] tag#0 CDB: ATA command pass through(12)/Bl= ank a1 11 00 00 00 00 00 00 00 00 00 00 [ 388.967773] sr 5:0:0:0: [sr0] tag#0 Done: SUCCESS Result: hostbyte=3DDID= _TARGET_FAILURE driverbyte=3DDRIVER_OK cmd_age=3D0s [ 388.967773] sr 5:0:0:0: [sr0] tag#0 CDB: ATA command pass through(12)/Bl= ank a1 11 00 00 00 00 00 00 00 00 00 00 [ 388.967803] sr 5:0:0:0: [sr0] tag#0 Sense Key : Illegal Request [current] [ 388.967803] sr 5:0:0:0: [sr0] tag#0 Add. Sense: Invalid field in cdb [ 388.967803] sr 5:0:0:0: [sr0] tag#0 scsi host busy 1 failed 0 [ 388.967803] sr 5:0:0:0: Notifying upper driver of completion (result 810= 0002) [ 388.967834] sr 5:0:0:0: [sr0] tag#0 0 sectors total, 0 bytes done. For the EL-R12 standard optical drive, all operational commands and usage scenarios were tested without adding the IGNORE_RESIDUE quirks, and no issues were encountered. It can be reasonably concluded that removing the IGNORE_RESIDUE quirks has no impact. Signed-off-by: Chen Changcheng --- drivers/usb/storage/unusual_uas.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusua= l_uas.h index 1477e31d7763..939a98c2d3f7 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -98,7 +98,7 @@ UNUSUAL_DEV(0x125f, 0xa94a, 0x0160, 0x0160, US_FL_NO_ATA_1X), =20 /* Reported-by: Benjamin Tissoires */ -UNUSUAL_DEV(0x13fd, 0x3940, 0x0000, 0x9999, +UNUSUAL_DEV(0x13fd, 0x3940, 0x0000, 0x0309, "Initio Corporation", "INIC-3069", USB_SC_DEVICE, USB_PR_DEVICE, NULL, base-commit: e9a6fb0bcdd7609be6969112f3fbfcce3b1d4a7c --=20 2.25.1