From nobody Tue Dec 2 00:04:44 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 934B232860C for ; Tue, 25 Nov 2025 15:25:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764084319; cv=none; b=Z7tMBWxSgegjtfFMy8tPASVkGg1Se+8WkL9L3+nYP7S0sOsPYS2QmOaZfGbkf3K0v3birSIoRpLRj6MbOBUa+LSoO/GS9Qc2LwTdmbvMA8bq8DOu5Yf8CMQUEX/urM6pKVzXAvbMf3Kh2vKGKWpg0eV0H9Kq7OvIHgCnLqSGxOA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764084319; c=relaxed/simple; bh=7ayFBJ7Y2AmVW7OVfEwWNzmHgzbLjTCXtOnUFO5KOBI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=W8hejHpLyokGke0Sxv5uCoRsXqlBrWqJ/aCtaSzIqFnDrRnzb8HxuqSNpCT5CDo4n+vpPFMnRZ/Zln9wO99B4VymrK54XynY/1n6aRuJWZwJ6FslR9ftVV//RFsNVLk46LAfN4iK4skL9QMszhMdqnL9ib/enVeLvpw12TieKDo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EDUE/uE+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UrzqJND7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EDUE/uE+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UrzqJND7" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AP9xLlA2650901 for ; Tue, 25 Nov 2025 15:25:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=DWiu5ksRlljwbgPGyVazaU o5FrHk5DQFqyQwrdgB+ug=; b=EDUE/uE+CNi5snlEZoYAho5XEY2RvIHIVt6gls TkygaoSNczaqM7u0Wt3laJatSiN0O+Mx9my0kUS65kzuLgCaggkjjHgq7DpY9j4Z SBEGHD2wB6F1V/NjqnYiQ0yVP3GDe08TrgUlY1/AowN6T4QDZjUeC7oFO8L7tyLn gzBxMDEadNTGTXkoyQ0rpHVkyiqY7pP1hT+rvj1wgbX+Va96ZIzH+ZQtxVHNiH9c Hae8XR3JnDRryqrBXFMdH1qh0HR+WsvAZy3+qZ1WaG9emkO0Bo8NXI+7W+aiO4Um LShTuT+EuDtlSx10e/QjjXhUMVcEGuPSDPF40FV2CT4Xt3eQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4anaabrvv0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Nov 2025 15:25:16 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-34740cc80d5so6055445a91.0 for ; Tue, 25 Nov 2025 07:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764084316; x=1764689116; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=DWiu5ksRlljwbgPGyVazaUo5FrHk5DQFqyQwrdgB+ug=; b=UrzqJND7/dk/1kWlvxStNnau9/VHRkFejQWkAqJ9gIiUzLA5n4Wh+elgSwT9+HZF1V 8NmibJfq9MNpVcfGTqcbr0twDwUBt5McMPHOo4w8lYOdBOMUIDZd272yZQIW4Imhl69w UlkJcpZEqwtzJSzG7lnRzJfwIrPkChg8kae0xUI4cAt61+y7sF/DYTzyHnnFcxXyFxpY JM1J3uZqVfdwi8s7szLqC7E2+hYizLMxTmyGGIweDlXjxnjOiDLAze/9LYLdGkRVUzrg PlFW5DFiLhkIzdJvZaHmBYVTpg8HqUk3QEuLv7GicEQVo+tHTh61HZbCTjx0zZ0NTnr6 OSKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764084316; x=1764689116; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DWiu5ksRlljwbgPGyVazaUo5FrHk5DQFqyQwrdgB+ug=; b=jgg14hEkRtYGvR4SWDX6Ll8hbu/31p48R44WX8kVB8XxrqMneRrcIPJD6YmelFBnJQ hAt7YGLNmOl5s68dwjU7kNCHr/ZLt6qD17QP2h1DjGxi++8tUaZDvDahvaOMLdj479kG Z2s7zxb4eVnQ1/7zSRb1drn1awrcrqV/9pkyjwMe0WbbmK/pOe0OW9tmb7wgOE5TirSB XgQday2VQ7Xe7xOUIqglSordYJtBo44moGWwxWMgVh9iBuxaQYYOod4MgDx1kFpjJ8Cu 0XjNaa0Idc+/VuTVUUcCaXEgPTqk/AAAPFQWhe77xPJJSBfHdgvN2jVY8qI0m4JleTkH MNMQ== X-Forwarded-Encrypted: i=1; AJvYcCVMD9kjjYlnedPEBWyRyhOkXii5l+aJocdfsqJz6lHwj2VUqul+JMYCDYwh/Xq35WSuwgF7aQRAncOj00o=@vger.kernel.org X-Gm-Message-State: AOJu0YykwVg3t+uru+x2flBh9EtHSyZYQMuRWDgs7m8dmImLdPamugEh yFK2VpfszaTtNxukCjEYdmpCI+VSePN9a733guOtqYukjtHgBwBFGlv7M+g2En7f/9XdqxvCB6C /Qd7J9quVrSF+LeM+cIcncE7/hmPU6uwLCHVDhe/jwdIUuynqBBzPrIRditpddc663LE= X-Gm-Gg: ASbGncsTxMHzlO24VS6VA/RmW7vjjsPQOO5UvNwpFrhJwWNLi4834KyTHPgYXHj1nOa XlApKIB8JfecipgcATiQurHDKLe+FXzAWy1y4V7GyzINZ3RF6zEO3xw+E/GmDwQNaMsnA3QT9V4 vK7DaXL+wPOv7hyfwUTFoMNBrU/o5SUr88birMRSxy3or4HFDyjJpF2d5Pq9TTzkbAoF6lJqTfu S/H/W3Rb6XJfmnJKYm6miGGf3O5aeWHpWix423s5D8nHkvsXDe21G34xI9C3GIpxjf3MKxnuUMF uoTsfDzIkS0ZlxDiZwgbikK6GqR17qlnJjtLQhGt1NixN//mRbpDKhRMIbb1rmH3sMf1H+AVV6x /E6RyhQOZDdNAP3/0yoQ6Cm3am+wmEgZQGE31ky0guoQ5aQ== X-Received: by 2002:a17:90b:3b86:b0:340:e521:bc73 with SMTP id 98e67ed59e1d1-34733e2d536mr13523436a91.5.1764084315922; Tue, 25 Nov 2025 07:25:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwDIciaM8fT4Sm6dek10YkSXKVgkPJBK4nqwfc7HN2+8feblvYmjydOt+c76wRPvDWkXk5CA== X-Received: by 2002:a17:90b:3b86:b0:340:e521:bc73 with SMTP id 98e67ed59e1d1-34733e2d536mr13523391a91.5.1764084315261; Tue, 25 Nov 2025 07:25:15 -0800 (PST) Received: from hu-vvalluru-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3475ff34831sm1269949a91.5.2025.11.25.07.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 07:25:14 -0800 (PST) From: Prahlad Valluru Date: Tue, 25 Nov 2025 20:55:07 +0530 Subject: [PATCH] drm/msm/dsi/phy_7nm: fix rounding error in recalc_rate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251125-msm-dsi-phy-7nm-clk-rate-v1-1-17141806e3a0@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAFLKJWkC/x3MQQqDMBBA0avIrB0wE4zSq4iLGKc62ETJlGIR7 97Q5Vv8f4FyFlZ4VBdk/ojKngpMXUFYfVoYZS4Gaqg1hlqMGnFWwWP9YpcihteG2b8ZyXVkvZ1 c7wKU/Mj8lPO/Hsb7/gFyQsTCagAAAA== X-Change-ID: 20251125-msm-dsi-phy-7nm-clk-rate-26723a3b686c To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Prahlad Valluru X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764084311; l=1586; i=venkata.valluru@oss.qualcomm.com; s=20251028; h=from:subject:message-id; bh=7ayFBJ7Y2AmVW7OVfEwWNzmHgzbLjTCXtOnUFO5KOBI=; b=/5iu8JRKBCqZ/1D+J2tdQAk946G2v3s0XzkNHK4VQkGvU75y4mVYbPct6TmJ33S1rfHthCMvO InWPd3lKk2eAHpI5svS567TmJzpLLrfTKf/LGjmhXacYOjqNqIV/JRE X-Developer-Key: i=venkata.valluru@oss.qualcomm.com; a=ed25519; pk=KEpJdy7/I8HDmNSf6B83x+sFHUNr+mjMNJ2qe4G/zXI= X-Authority-Analysis: v=2.4 cv=Vd36/Vp9 c=1 sm=1 tr=0 ts=6925ca5c cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=R1ZPujbRWijfOtoOsmYA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: 0o1Zfva7TPXlXex2QoWFVuFvy1THFm-u X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI1MDEyOCBTYWx0ZWRfX01Tr6IJU0G7L rRwdLpl3ryc9NSBo+4x15IcTe1rtdvkxPxLfddEI6PKD+bN7mBU3VAmQRrVRPgscFeHhB2UHe/q qgjOvAfshSXMI4kwmTdluBTehiW1a49t7f8xWDU4UQ2eXQlWrJ+0KwUMx/oztLcjeDS8OgSpONK rdEzRFCjRSCVW2npGecIf7B5ioJeXwJ23wush3QNsJb8sG8Uq1Lf36ZTwGrW/XfqMNgNvC9tvOU uyZrw94O4qb6FUtYDvwLULwqgtluWvCZ5UhS4baNa0IsUOxDHq3+WV3z5OpYg2O99AcEQ61jv11 Ig3it3zdGhWTKrtwJuLPKE8u4nMvOfk4cyJ2QdnlVb2CSFfTbSveRbMg00C3+kk0j9wC0VrQuw6 AHcQAbfSEZb9F7synOaYoekjVZDTnQ== X-Proofpoint-GUID: 0o1Zfva7TPXlXex2QoWFVuFvy1THFm-u X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511250128 Required vco rate is set by programming decimal and fraction from 64 bit calculation. This programmed rate is not exactly matching the requested rate and corresponding recalc_rate is having rounding error due to this delta. When setting byte_clk and byte_intf_clk from this pll, set_rate on byte_intf_clk resulting in dividers getting reprogrammed, which are already set from byte_clk. Convert this recalc_rate to KHz and back to Hz to round up this delta in calculation. Signed-off-by: Prahlad Valluru --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/ms= m/dsi/phy/dsi_phy_7nm.c index 32f06edd21a9..00f20c5a7c73 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c @@ -598,6 +598,12 @@ static unsigned long dsi_pll_7nm_vco_recalc_rate(struc= t clk_hw *hw, pll_freq +=3D div_u64(tmp64, multiplier); =20 vco_rate =3D pll_freq; + /* + * Recalculating the rate from dec and frac doesn't end up the rate + * we originally set. Convert the freq to KHz, round it up and + * convert it back to Hz. + */ + vco_rate =3D DIV_ROUND_UP_ULL(vco_rate, 1000) * 1000; pll_7nm->vco_current_rate =3D vco_rate; =20 DBG("DSI PLL%d returning vco rate =3D %lu, dec =3D %x, frac =3D %x", --- base-commit: 63c971af40365ee706c7e24f6a7900d693518f09 change-id: 20251125-msm-dsi-phy-7nm-clk-rate-26723a3b686c Best regards, --=20 Prahlad Valluru