From nobody Tue Dec 2 00:26:10 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DA6F2EA723 for ; Tue, 25 Nov 2025 09:16:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764062210; cv=none; b=jEzbxKWalkKCsNBISU8F5RWVs7yXnKkGcWGRgqR8DAF05DhJ02r1v0hHuNwbucAb2U93kWvXYNrMNmOOOBQPjmbmEgp0uj6qQRPAqwRtKSlYhDRInU0XldukeaSEQYShvIhE9hiWi6g4L59Qrcl6S2RY3vlnrxXWJoj3QmIKrxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764062210; c=relaxed/simple; bh=lhDCbIcoXm8l0+EHHUOegAZG7EHOFvzMTONdMXqjRvU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RzL4PBbS7WJjgOmKH5wilbA1+2YI0syDwaVZ3xM6ArYoeQzVLKDcsaX378o+GAR+skOT4ZLavHXue8p8qcqIatdvKZrczrWU6RlWJZklKLNUdKpvEttu3Z7sTIfXOuYiCnGaDzX5Cu8is5YEWf7c7SyWYLGDAWSrgy2cIZCwXg0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BXudTuhf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Egh1Wq8w; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BXudTuhf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Egh1Wq8w" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AP2h2rk1689503 for ; Tue, 25 Nov 2025 09:16:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xJ9D1s/yri3IgF3ATpCR8TpSZJj0ewqTKeESOhEzQPI=; b=BXudTuhfhKNp9h7M nNaizSS8bnI75ge7yy08jCICnADA+bvkjIsM42M6ykm2eFfKo9so8npWnLvbThvA inGPmoFsot/0Uxfv3U3axPYBwXgnl/Pub6qUnLJYlBLCPCrk4iBkE1hQSTwM8A9A knhZ1NncOHWU7Nfaf+/HGP/1+44bFPhYOB34O6Y5MnfkszCBM9xJ59NoOJSC57al 38fedbuZERqZJkKpP3GP5DoXUIJxU7x2i/rFgyu8z1Nr7OzuFsiPr7OkY/Dai5CA bBboV6ZptpIcGbyzlnnFHK4bgcGs/2cauZkLQUj7vf2qEINJ4xjkeSfEf0dO6f6y j1UUTw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4amrv6b1bn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Nov 2025 09:16:47 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3437f0760daso11723402a91.1 for ; Tue, 25 Nov 2025 01:16:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764062207; x=1764667007; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xJ9D1s/yri3IgF3ATpCR8TpSZJj0ewqTKeESOhEzQPI=; b=Egh1Wq8wbeFtLpLLC1TrivEJmZp3cVoVgibukHM6QNsnkyBQ9DpQ9JjNab4mY8AHk7 WuRhsE9Ou9iZrfgW8qAxrsmM8gSbk23ZjjAnGEJH4yb5P5zX/5a+cutPfDdJzOmAwEeL 2c/aLmNacBevbKOhR4r0N0AdYheTiHjCbwF6H4PvaYzgJhUuyBmeoN2ceUQUQwI9GN49 M9y9fgGFnfHUFJ5dcSlsSNjg1a+Y6P9Tx+WAWcpbPbcmDaGvDSa2fFkivVt6T0/eZg1J Y64oWtUdkZkX0Ay+S4w0dBdTzlShWS9/SKbqLbgcZWGYokzQtgFE9w2GHLMx8bsSk/2i SuGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764062207; x=1764667007; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xJ9D1s/yri3IgF3ATpCR8TpSZJj0ewqTKeESOhEzQPI=; b=hZ6GW7VM1kHlhlsDAc6lUGV/4llwUOysSR75xIopVsMCuSbIg4iIeLZsyjRdD3qWf7 hzvVy7FD9er9MvmxKdruNlxq/yASmWtoQMHW6qK5KqQR1yQSXHkH6rTr/5rGwYyW30e1 cfjK0kb6nlJvkwuso1dOwWCIsQkMcOvvRLNSs3PXXubIkqW6yP1g3JW8XPYlKei2KRkm ieVCwKkzXSxxvypS5EO58Px+/rIa/LT1ZoWacmX9oABb6cVxikJhlrovn8JMkLIZa1Qc PaOhgOW+Ln4XQhpQ8fuitmAz6llX6PSN5xAJMln6nfRZxmKYgu3/vKhPSj5tl2BWQoE9 EwnQ== X-Forwarded-Encrypted: i=1; AJvYcCW6cMEberq4I5PVSkPALrgNirVdnHCMxozn9MCEht1ZMoinqOp1uleDeIJH1NMbh+JnLJAHkQG+QJVs9kQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/lZ09mks7RbcDdxvMKbIOuCk1VQFs/bGFYA/eGdygXrgNxImS MxdnLAJlxsOMfy83zW6MtquHaJ65Gx5+BKWU+4CeV3E50ZJ5M4XO86B9z5QEK6j+409hk9SR+3w BUqDfyZc8KPv8MuUkSoZ6IusRWPI80cS/TiBkj/sYvsE9yG/MN50AQ2N8wJWoWdFo98w= X-Gm-Gg: ASbGnctLf9/ro0WfdSbcag0AT36molybdzGRv8BtfK0ZvDm1yNbRjQx4mDN19G9yyfY 9rdEwLBJ0jY9yNW6Z4RemUh8yM207c9hQJ3NJoNwYE3JzAEXds+uJYH0Vpv1bDLxitUT523H9tv XDLAqwGSdiLsBCgVZdmDFwAKfY9fkcioFGFe4+YUIUkBpkMnBMrVKV1Bh3i3u+vb7NYNQ/WL+KS Zc+EhE5UfGu98Mg2YBjoWk1eIZa9jrZEpARRVvousd2GsXCYhw5yN1PHJsthm2FFWeDp/SyGFP/ atvsO/wtaB+TThwipnRsB8OqIf3/Z3Jdj1vsnPuXMEgWyZ56oHmHw4GB4VtcVgPeUE1GKiG+Jju HTYLwOKFaLCqvQVcYNREAPEVB0OqlwC/QyUcBixGrB1HkQ7r8hpE0r+c6ZqCgHs/5Nmp2ltex9P oXpn0XS+Gk5qAAaKUYbOOnftcmfBhhkw== X-Received: by 2002:a17:90b:4f45:b0:340:b908:9665 with SMTP id 98e67ed59e1d1-34733f50e52mr16030602a91.37.1764062206786; Tue, 25 Nov 2025 01:16:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IH+4EwYC3543/amZeHdio3x2ddnK+yRFqyKCsXJN4ibOjYvrUWeKH+4wKNy6brHbXTtpTC25Q== X-Received: by 2002:a17:90b:4f45:b0:340:b908:9665 with SMTP id 98e67ed59e1d1-34733f50e52mr16030580a91.37.1764062206305; Tue, 25 Nov 2025 01:16:46 -0800 (PST) Received: from hu-pankpati-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3ecf7c29asm17288851b3a.9.2025.11.25.01.16.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 01:16:45 -0800 (PST) From: Pankaj Patil Date: Tue, 25 Nov 2025 14:46:24 +0530 Subject: [PATCH v2 3/3] soc: qcom: llcc-qcom: Add support for Glymur Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251125-glymur_llcc_enablement-v2-3-75a10be51d74@oss.qualcomm.com> References: <20251125-glymur_llcc_enablement-v2-0-75a10be51d74@oss.qualcomm.com> In-Reply-To: <20251125-glymur_llcc_enablement-v2-0-75a10be51d74@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Conor Dooley , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pankaj Patil X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764062193; l=6806; i=pankaj.patil@oss.qualcomm.com; s=20251121; h=from:subject:message-id; bh=lhDCbIcoXm8l0+EHHUOegAZG7EHOFvzMTONdMXqjRvU=; b=p6DeUpgxEMpERKP0D9/hY8LX4cssazrUj3mk0ot1Sf0jFfUOKXr0fSrRxlITuA/UBsRUtpP4b HefOWhF4EwyB4u84e1ZK4N9v51CzG+5PVoM+LLUIxrszw2UYHTT9uUJ X-Developer-Key: i=pankaj.patil@oss.qualcomm.com; a=ed25519; pk=pWpEq/tlX6TaKH1UQolvxjRD+Vdib/sEkb8bH8AL6gc= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI1MDA3NSBTYWx0ZWRfX4puDEeFU94QB VKp6c0zlUqADNquqf/z3mrxDN5yAa7FKS+fNhWzBL8v4ULgM1Vzdlx4ExE1M7846t4+rn3EpUtm dfSSpxhMDSkp+p6PLkVbkBnNFZ5YSdX6WJeCYKM4JMT7x54sAYK0FGVRIQfazq/LX7zAj+QH8G9 mtQ6wKEqUFHLdNMRPbYCAa4ujCE/kTB9Jagy5kJ+0tYRtZvuHw2A2OzUypM2I+BQAXN1/U5qv6m LWUN3PlCpt2QtHiCRW7MrOyHlWDOU4Iemmy8y0lX8tcjeDU1zS/qQ//WcKl7lxnx4tfO7rAGBtS dLfNZZrHvSM0IdyVI3nWaF4W0j1yGo74KSnczczp6rGlnKp9wnWi8g8EceicFlHQjPBaIOaCwsU SvA/VomEaiOUncm+r7d08GEfCN0R6A== X-Proofpoint-GUID: A8PBkCjU8Gsjs26KZo0s-Pdw0-DAeSt- X-Authority-Analysis: v=2.4 cv=f7BFxeyM c=1 sm=1 tr=0 ts=692573ff cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=4LaLCKXmak5nUjv6dOcA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: A8PBkCjU8Gsjs26KZo0s-Pdw0-DAeSt- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 phishscore=0 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511250075 Add system cache table(SCT) and configs for Glymur SoC Updated the list of usecase id's to enable additional clients for Glymur Signed-off-by: Pankaj Patil Reviewed-by: Konrad Dybcio --- drivers/soc/qcom/llcc-qcom.c | 207 +++++++++++++++++++++++++++++++++= ++++ include/linux/soc/qcom/llcc-qcom.h | 4 + 2 files changed, 211 insertions(+) diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c index 13e174267294..1abfda7a58f2 100644 --- a/drivers/soc/qcom/llcc-qcom.c +++ b/drivers/soc/qcom/llcc-qcom.c @@ -182,6 +182,197 @@ enum llcc_reg_offset { LLCC_TRP_WRS_CACHEABLE_EN, }; =20 +static const struct llcc_slice_config glymur_data[] =3D { + { + .usecase_id =3D LLCC_CPUSS, + .slice_id =3D 1, + .max_cap =3D 7680, + .priority =3D 1, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + .activate_on_init =3D true, + }, { + .usecase_id =3D LLCC_VIDSC0, + .slice_id =3D 2, + .max_cap =3D 512, + .priority =3D 3, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + }, { + .usecase_id =3D LLCC_AUDIO, + .slice_id =3D 6, + .max_cap =3D 1024, + .priority =3D 1, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + }, { + .usecase_id =3D LLCC_VIDSC1, + .slice_id =3D 4, + .max_cap =3D 512, + .priority =3D 3, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + }, { + .usecase_id =3D LLCC_CMPT, + .slice_id =3D 10, + .max_cap =3D 7680, + .priority =3D 1, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + }, { + .usecase_id =3D LLCC_GPUHTW, + .slice_id =3D 11, + .max_cap =3D 512, + .priority =3D 1, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + }, { + .usecase_id =3D LLCC_GPU, + .slice_id =3D 9, + .max_cap =3D 7680, + .priority =3D 1, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .write_scid_en =3D true, + .write_scid_cacheable_en =3D true, + .stale_en =3D true, + .vict_prio =3D true, + }, { + .usecase_id =3D LLCC_MMUHWT, + .slice_id =3D 18, + .max_cap =3D 768, + .priority =3D 1, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + .activate_on_init =3D true, + }, { + .usecase_id =3D LLCC_AUDHW, + .slice_id =3D 22, + .max_cap =3D 1024, + .priority =3D 1, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + }, { + .usecase_id =3D LLCC_CVP, + .slice_id =3D 8, + .max_cap =3D 64, + .priority =3D 3, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + }, { + .usecase_id =3D LLCC_WRCACHE, + .slice_id =3D 31, + .max_cap =3D 1536, + .priority =3D 1, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + .activate_on_init =3D true, + }, { + .usecase_id =3D LLCC_CMPTHCP, + .slice_id =3D 17, + .max_cap =3D 256, + .priority =3D 3, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + }, { + .usecase_id =3D LLCC_LCPDARE, + .slice_id =3D 30, + .max_cap =3D 768, + .priority =3D 3, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .alloc_oneway_en =3D true, + .vict_prio =3D true, + .activate_on_init =3D true, + }, { + .usecase_id =3D LLCC_AENPU, + .slice_id =3D 3, + .max_cap =3D 3072, + .priority =3D 1, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .cache_mode =3D 2, + .vict_prio =3D true, + }, { + .usecase_id =3D LLCC_ISLAND1, + .slice_id =3D 12, + .max_cap =3D 5632, + .priority =3D 7, + .fixed_size =3D true, + .bonus_ways =3D 0x0, + .res_ways =3D 0x7FF, + .vict_prio =3D true, + }, { + .usecase_id =3D LLCC_VIDVSP, + .slice_id =3D 28, + .max_cap =3D 256, + .priority =3D 3, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + }, { + .usecase_id =3D LLCC_OOBM_NS, + .slice_id =3D 5, + .max_cap =3D 512, + .priority =3D 1, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + }, { + .usecase_id =3D LLCC_CPUSS_OPP, + .slice_id =3D 32, + .max_cap =3D 0, + .fixed_size =3D true, + .bonus_ways =3D 0x0, + .res_ways =3D 0x0, + .vict_prio =3D true, + .activate_on_init =3D true, + }, { + .usecase_id =3D LLCC_PCIE_TCU, + .slice_id =3D 19, + .max_cap =3D 256, + .priority =3D 1, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + .activate_on_init =3D true, + }, { + .usecase_id =3D LLCC_VIDSC_VSP1, + .slice_id =3D 29, + .max_cap =3D 256, + .priority =3D 3, + .fixed_size =3D true, + .bonus_ways =3D 0xFFF, + .res_ways =3D 0x0, + .vict_prio =3D true, + } +}; + static const struct llcc_slice_config ipq5424_data[] =3D { { .usecase_id =3D LLCC_CPUSS, @@ -3872,6 +4063,16 @@ static const struct qcom_llcc_config kaanapali_cfg[]= =3D { }, }; =20 +static const struct qcom_llcc_config glymur_cfg[] =3D { + { + .sct_data =3D glymur_data, + .size =3D ARRAY_SIZE(glymur_data), + .reg_offset =3D llcc_v6_reg_offset, + .edac_reg_offset =3D &llcc_v2_1_edac_reg_offset, + .no_edac =3D true, + }, +}; + static const struct qcom_llcc_config qcs615_cfg[] =3D { { .sct_data =3D qcs615_data, @@ -4103,6 +4304,11 @@ static const struct qcom_sct_config kaanapali_cfgs = =3D { .num_config =3D ARRAY_SIZE(kaanapali_cfg), }; =20 +static const struct qcom_sct_config glymur_cfgs =3D { + .llcc_config =3D glymur_cfg, + .num_config =3D ARRAY_SIZE(glymur_cfg), +}; + static const struct qcom_sct_config qcs615_cfgs =3D { .llcc_config =3D qcs615_cfg, .num_config =3D ARRAY_SIZE(qcs615_cfg), @@ -4941,6 +5147,7 @@ static int qcom_llcc_probe(struct platform_device *pd= ev) } =20 static const struct of_device_id qcom_llcc_of_match[] =3D { + { .compatible =3D "qcom,glymur-llcc", .data =3D &glymur_cfgs }, { .compatible =3D "qcom,ipq5424-llcc", .data =3D &ipq5424_cfgs}, { .compatible =3D "qcom,kaanapali-llcc", .data =3D &kaanapali_cfgs}, { .compatible =3D "qcom,qcs615-llcc", .data =3D &qcs615_cfgs}, diff --git a/include/linux/soc/qcom/llcc-qcom.h b/include/linux/soc/qcom/ll= cc-qcom.h index c52464262ab3..30b436d0140a 100644 --- a/include/linux/soc/qcom/llcc-qcom.h +++ b/include/linux/soc/qcom/llcc-qcom.h @@ -74,13 +74,17 @@ #define LLCC_CAMSRTIP 73 #define LLCC_CAMRTRF 74 #define LLCC_CAMSRTRF 75 +#define LLCC_OOBM_NS 81 +#define LLCC_OOBM_S 82 #define LLCC_VIDEO_APV 83 #define LLCC_COMPUTE1 87 #define LLCC_CPUSS_OPP 88 #define LLCC_CPUSSMPAM 89 +#define LLCC_VIDSC_VSP1 91 #define LLCC_CAM_IPE_STROV 92 #define LLCC_CAM_OFE_STROV 93 #define LLCC_CPUSS_HEU 94 +#define LLCC_PCIE_TCU 97 #define LLCC_MDM_PNG_FIXED 100 =20 /** --=20 2.34.1