From nobody Tue Dec 2 00:46:08 2025 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DF052FD1D9 for ; Mon, 24 Nov 2025 23:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764028108; cv=none; b=JddNEec7NZN0wCdOwrVho76FlQz2M4BfyIHX+P1WC6kf4M02LJnwOnMX3n7KDiwC25X2MO6Ms7rC+8fULo4s3UxqmHUAGacndg/WHyMDgEGBvBkVaBJHxfGascX4CAzhyX+atjJ4uxEdM66pyDnjgZ8IzxOzFaREXD2m6OhywLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764028108; c=relaxed/simple; bh=LiJgbQPzVCy/nNKtdgxFtiNJpUa7IyMaSDSo31f8t5g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WbHyln55CEqw3dksK1oMLNNsgC+qsCRAqEGbTUA2oXoC9sqO6d9yV5v/18GVVCXSAuI137Blru1nsWv2fF/DaFH6t7CgGbl8ijpLr7zCG8GIN8+ieG+MKVZ2hnNyTRxCyPYvhFsAYIcyU6+9iuP3ES2I0K1Vlx7DF1CtsWOuznU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QWk8Up6s; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QWk8Up6s" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-297e982506fso66618795ad.2 for ; Mon, 24 Nov 2025 15:48:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764028105; x=1764632905; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x5IpKKGvYwA44MA2SdIRqzoysh0eqDWrauHh/IuigN8=; b=QWk8Up6sn3lYBV/iB9lZxGmffbRvzawOFw5BgJ2PYx9NHD+dLKfyI3JTqNp513mBEV vrxwKhuZvodq3ta/8e4Xw5HFvIU3H7v0KYCuuUctkaSPfrE0kSCNUQgtQ+u9zI4mJNlR 9JXIbL7tPP5otS/iH/1e1KJW/G0Fae76007IVjPvsLWohUyZ/1bqGEzeiRa5Sr5fu9S1 6c2+gnEtNhBQpacrDuwF0WcYEIRDiSmoF3icXb3ZZUFcoh31hsAyvty0UVz/c3gHwQQh UpRwTviaUPAqYFlZrZd5CHzBVfcGHREOtF3zC0bY4WYeylVTQn3LlTzZSOnjHYrK0m0T TsjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764028105; x=1764632905; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=x5IpKKGvYwA44MA2SdIRqzoysh0eqDWrauHh/IuigN8=; b=dMkQsICil8Msk1S/Q2EHGwwwfOp6M1jzepXXinRYd7TblmKXSb6/YvXlLiXyQLANh4 /Z5RzXcq5Z5Cubaldz9jRtWaJEIKP7+JszMRf34IJKWSwu3Ez5Db6tBdnLm9MmIapf+f MjMxa0JPPM5oTC8mmbUHXnPxOdyYJ2MR83QLyZrlVCOb6qwnivLBa4M/qbVoAsQzc5Mf SkdCjvE8Nw69R8YuZ+0C6DWjbdHVp+gZn4vi41rtjK28BQleUNhzScuvryjR6AcmP7oS ktgf0yTW5ZFwZpWNv5hl6bk9fc9mL3hODVchX0WED5uE+gOMacuP3Nia3jl+aaiQhbZq jzGQ== X-Forwarded-Encrypted: i=1; AJvYcCWaWBNTHOr4YDHXGnNd4q0x/pWLvxUlZg8Zmpq8zxZcL1sJk4qVJe6NjtbYLIylDASUpdh5X5NfL/ndTmg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzg+yO9pKvhJxZazsm7WeynnqnuJ+6yWal7s6AUXF8CalrjFEg/ +qpTT6mbldPZOkQtj1Ris+rNohI/oyM0dr/6m5q2n8kxoJGPEEYfRy/K X-Gm-Gg: ASbGncvpuEWZQTXTFtpa8swyXd0XV9OktsaXLMpX1Ht8r37R2QjEBIOgP2iNNcq2r26 wcKNljztc8OTkAB4kf9H/74ER4L1LLsI5MT2kbHRirArlvcYdoCHSAds4x9h7VmGIb5QO7JKXmh t8E1Zj6MTV7Wj/b2jIJVGop2siJA9Yc7X5c8Y38o6U2G3lmFTgXOpWPY1GUkiZ4hn0ZqyKLgGzF KnGvfbUQ/dX13duz03eaFlMdW18lp7iL8zxXGPsrm81us690KziPcJKFx565qNvY8DmllakRqPm bxnbygF6dHM2uda86zW0O2BwkUmegD2sXLY+8+r438D99r71PKbOZcVoRlM6EIp7KOaQbUmAFZU NQR+aUGIY2Vw8UbiouiE0wYxlPV2VnNKnKywj5+aafsBxVB6F/UiAO3uAteU6UquSINHSeqJ4Ga Q195PGfkxgFVKjG3mLGIzxqAxV9YiuinvlNacDqpukVM3+BKqg+vTqXWyTag== X-Google-Smtp-Source: AGHT+IGUjnYuQU4uZ65RexnKMVsIkRo4SljblPDkF73f7cjoVp9uAJMvqcbsbNcZ8FiTC+XwEcc2Xg== X-Received: by 2002:a05:7022:6610:b0:11b:9386:a37b with SMTP id a92af1059eb24-11c9d870ef7mr10566206c88.42.1764028105314; Mon, 24 Nov 2025 15:48:25 -0800 (PST) Received: from localhost (ip70-175-132-216.oc.oc.cox.net. [70.175.132.216]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11c93de6d5csm50934572c88.4.2025.11.24.15.48.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 15:48:25 -0800 (PST) From: Chaitanya Kulkarni To: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com, song@kernel.org, yukuai@fnnas.com, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, jaegeuk@kernel.org, chao@kernel.org, cem@kernel.org Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, Chaitanya Kulkarni , "Martin K . Petersen" , Johannes Thumshirn Subject: [PATCH V3 3/6] dm: ignore discard return value Date: Mon, 24 Nov 2025 15:48:03 -0800 Message-Id: <20251124234806.75216-4-ckulkarnilinux@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20251124234806.75216-1-ckulkarnilinux@gmail.com> References: <20251124234806.75216-1-ckulkarnilinux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" __blkdev_issue_discard() always returns 0, making all error checking at call sites dead code. For dm-thin change issue_discard() return type to void, in passdown_double_checking_shared_status() remove the r assignment from return value of the issue_discard(), for end_discard() hardcode value of=20 r to 0 that matches only value returned from __blkdev_issue_discard(). Reviewed-by: Martin K. Petersen Reviewed-by: Johannes Thumshirn Reviewed-by: Christoph Hellwig Signed-off-by: Chaitanya Kulkarni --- drivers/md/dm-thin.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index c84149ba4e38..77c76f75c85f 100644 --- a/drivers/md/dm-thin.c +++ b/drivers/md/dm-thin.c @@ -395,13 +395,13 @@ static void begin_discard(struct discard_op *op, stru= ct thin_c *tc, struct bio * op->bio =3D NULL; } =20 -static int issue_discard(struct discard_op *op, dm_block_t data_b, dm_bloc= k_t data_e) +static void issue_discard(struct discard_op *op, dm_block_t data_b, dm_blo= ck_t data_e) { struct thin_c *tc =3D op->tc; sector_t s =3D block_to_sectors(tc->pool, data_b); sector_t len =3D block_to_sectors(tc->pool, data_e - data_b); =20 - return __blkdev_issue_discard(tc->pool_dev->bdev, s, len, GFP_NOIO, &op->= bio); + __blkdev_issue_discard(tc->pool_dev->bdev, s, len, GFP_NOIO, &op->bio); } =20 static void end_discard(struct discard_op *op, int r) @@ -1113,9 +1113,7 @@ static void passdown_double_checking_shared_status(st= ruct dm_thin_new_mapping *m break; } =20 - r =3D issue_discard(&op, b, e); - if (r) - goto out; + issue_discard(&op, b, e); =20 b =3D e; } @@ -1188,8 +1186,8 @@ static void process_prepared_discard_passdown_pt1(str= uct dm_thin_new_mapping *m) struct discard_op op; =20 begin_discard(&op, tc, discard_parent); - r =3D issue_discard(&op, m->data_block, data_end); - end_discard(&op, r); + issue_discard(&op, m->data_block, data_end); + end_discard(&op, 0); } } =20 --=20 2.40.0