From nobody Tue Dec 2 00:46:08 2025 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0E962D5950 for ; Mon, 24 Nov 2025 23:48:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764028105; cv=none; b=kzijEmu0lGoBHjBRCmkYb4oj33C97Ky5/epFEEM6Kx+BC+01JXY3NRK4CcFj6yWodpWCsOH02f6CK/Hs+Ams2WMGAh0zyqYLfBotW3+YV1OWS4Byk4Pp+6RqvFiIvNVqX/sqjhpgJj4m6mEXRyiQj2fhZqjoH9BpkBGj1eGVJxM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764028105; c=relaxed/simple; bh=O/JUDf1xQdyUKKqPMxOm/ySwho1/juV+ixb/yhr4OcA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PDboGCFA8WNoq4/K/fXZIZEUcHLP4J7T521TRshimn8F+YiIeahwSEcF8UB6bBopkjT1oNTRGYTnY9rzW2ypO7DNcNXJ6ogHXXRPvR7ysybY8nQYAqHhAuDF0lPlM3j9MffvNjnevpQhD8L4cqitX+biFL8mqbris4tcOHZaaMc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fyRvwB0P; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fyRvwB0P" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7b86e0d9615so5846198b3a.0 for ; Mon, 24 Nov 2025 15:48:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764028103; x=1764632903; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YcqbQ5S4JXXbau3fgh6ZbMU20qGzRcIfkGSPAKTqhkc=; b=fyRvwB0PwJyRFVMmj9BwngRdyh1FxB+k80U4l3kSgDZisjLtKwedeBZ3WsHlXzv4LW smguUguTqO4ye5EUVlnlvpwehhBTfYAqQ/x5sNJHqkipIoz1rFFOO/xvS/2DbnpZKGWU NT7VSCuaOqINYCuFj77EXlZa539ZIvO0qNkghSekpJ5G0ksAQiFu5ykpDGTAVN31tJfk 64rRkgLXr7NPb8V3l2WHWDXRrJhsD4fRRbJez9GqQhUbppDygfJEiz8/8/j6tRnC4bcU 2SvXeNYZLlS+Zu8IJeuLKXeJkDs+fSU0LrJknD6fbkf69ZraKuFmm52FKSe5bUPXEgYv Qv0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764028103; x=1764632903; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YcqbQ5S4JXXbau3fgh6ZbMU20qGzRcIfkGSPAKTqhkc=; b=I8mUHLlJpMgk9sD5OEqZcxDQb+g6W8R8cVC2ZIoh14yp1FOeXmeI/FKe/Bg1AZPkqj ImKsMSPjHwnAuC7QPzhGdF+vWwnVPggY0eDLfTcAmo562QeoIFEW4RVn2t3opxzlBY8X r8NmqKLuzmWPTFJbavVUMsXbccK1GEtS84PU70Ej+hkpEkIU1UfFcYGF96wjdIl9nZlt d3bf2TuY7/Kxzxttu8bgnLPvQQCfGbrs6TENzfz3Nwneg44iO3Q2jUrKd1dZnNRCAiKV D1RJS+pPCzQuZszOwlVmGqN4yZHGifeLICLxvxrfL4T+9Xq3IU/naWYy5kb9iWMmna+U F9PA== X-Forwarded-Encrypted: i=1; AJvYcCUIX3CkgEdSgRJbyZncQ8KLPdm7LhYCgauf6OqKt1uFEJp4ZdWlx1snPqiCZAdljNzoVk76rWOEaDsDpCk=@vger.kernel.org X-Gm-Message-State: AOJu0YxMBrfQ78/fI+1WvITZM23ISTq4NAw5P6ks9u9qhr8jZxts+BMi YtMmxJfd97j8yWUSDAybqoftEznKPDnMkoK0IQhUlbGvCIUY2c8Ws/Nf X-Gm-Gg: ASbGncuLLeK8ZMQ4FLr923yL3yDdiGr8aMFZLzJtICG1pHtvIOnq3c4wrg+q81GZncX qNfuKlBFGpjtaVIsFt9KTC5piV0dJcG20gUse5EoHTbFlqVDFMw74ISM2HuRGPAZjGW+YceKui0 uZe58GkTCvmE9hidZMj2NtInBaH71wWNl16SSRt5rJfF5TZzh6l9envGuQQYiNTGhwAUnZNIsTD NV/G+J8ZByRw5/O3MCYHo3lLZbqK+4fzC7f17MQOFzheU/PiSNBmK0H1Tb3AXPUaf7wEPxNySht F74xeShHAHT9GJvGHxMrrKRYq0KJgZ1RX111CbJdkhBRsRJHr+ChMYgxHy+RAjwtroBOY6QF6ib Kl53QBjrcqhXiuclhdxwewhsluSOMzkk9YXblqkS8P4oHVKhVLFNomrO9+wlCfC21/0lP2wfly+ CePChlJwmJq4Q4viQ2XeHixHqNuFUDnRxjHrxYSu2ePQsfOWY= X-Google-Smtp-Source: AGHT+IH9F80PvdpBpbojg7Y02KngkDHXsfXBdGLUzofDSvSvFO71NKJ3uHp3bN/w9c26If04NsQEQQ== X-Received: by 2002:a05:7022:d45:b0:11b:c1ab:bdd0 with SMTP id a92af1059eb24-11c9d863a0amr6183635c88.35.1764028102624; Mon, 24 Nov 2025 15:48:22 -0800 (PST) Received: from localhost (ip70-175-132-216.oc.oc.cox.net. [70.175.132.216]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11c93cd457dsm72215056c88.0.2025.11.24.15.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 15:48:22 -0800 (PST) From: Chaitanya Kulkarni To: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com, song@kernel.org, yukuai@fnnas.com, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, jaegeuk@kernel.org, chao@kernel.org, cem@kernel.org Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, Chaitanya Kulkarni , Johannes Thumshirn , "Martin K . Petersen" Subject: [PATCH V3 1/6] block: ignore discard return value Date: Mon, 24 Nov 2025 15:48:01 -0800 Message-Id: <20251124234806.75216-2-ckulkarnilinux@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20251124234806.75216-1-ckulkarnilinux@gmail.com> References: <20251124234806.75216-1-ckulkarnilinux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" __blkdev_issue_discard() always returns 0, making the error check in blkdev_issue_discard() dead code. In function blkdev_issue_discard() initialize ret =3D 0, remove ret assignment from __blkdev_issue_discard(), rely on bio =3D=3D NULL check to call submit_bio_wait(), preserve submit_bio_wait() error handling, and preserve -EOPNOTSUPP to 0 mapping. Reviewed-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn Reviewed-by: Martin K. Petersen Signed-off-by: Chaitanya Kulkarni --- block/blk-lib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/blk-lib.c b/block/blk-lib.c index 3030a772d3aa..19e0203cc18a 100644 --- a/block/blk-lib.c +++ b/block/blk-lib.c @@ -87,11 +87,11 @@ int blkdev_issue_discard(struct block_device *bdev, sec= tor_t sector, { struct bio *bio =3D NULL; struct blk_plug plug; - int ret; + int ret =3D 0; =20 blk_start_plug(&plug); - ret =3D __blkdev_issue_discard(bdev, sector, nr_sects, gfp_mask, &bio); - if (!ret && bio) { + __blkdev_issue_discard(bdev, sector, nr_sects, gfp_mask, &bio); + if (bio) { ret =3D submit_bio_wait(bio); if (ret =3D=3D -EOPNOTSUPP) ret =3D 0; --=20 2.40.0