From nobody Tue Dec 2 00:26:10 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E03403128B5 for ; Mon, 24 Nov 2025 16:06:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764000394; cv=none; b=ssqaZjAGxSX8duLt8F3tP6Yaxr4EzQmalmVns63q0AdpxhPF1eQwsekuxO0mXdbdmMhSPRb+iHe1yDDcdU5sIEUAmQwiycvWpdN2pzMT8TN+UvllwjRv9ojiMN6wtWk2KLH7zEwyt/6mg6pGqcIbEunCDySzEj6H/Xnih6owDzg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764000394; c=relaxed/simple; bh=pfjXagXhcSRJcg6DITZ2xdHDDpJqTTa7Ccj+mt0pkaA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=eEk9w3oUgGP6YHS+4V4t95lpRItxZxnLnOAjROwF9nN/FabaHgYF5jIGnDaIBHIT1vduRadmFEw9FBn8G/nyH/isa/4Mri8jrkoyA/4rJW2IfWQd8cI1eyb5I0IBUINQd9b/e5a/iDrG+MxoLtl6UOHl6126OHiYn1pibPtScdQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=asu.edu; spf=pass smtp.mailfrom=asu.edu; dkim=pass (2048-bit key) header.d=asu.edu header.i=@asu.edu header.b=U0TO4xSY; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=asu.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=asu.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=asu.edu header.i=@asu.edu header.b="U0TO4xSY" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-297f35be2ffso67645795ad.2 for ; Mon, 24 Nov 2025 08:06:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu.edu; s=google; t=1764000392; x=1764605192; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KTI/AniVvO9tBc5YU1ZIeGzn1xQ7IIEnHW/pxxneqLw=; b=U0TO4xSYMja3BLK380fEs4YbZZ9lVBYKime71SnkY1RzhlzH9IuHeyATRn4RHFFh2c mKY/xqXiiCKmCRxDKM/aw+sXKY/HfIAVBeTQwOPXwcaJiXkoRx4V+hyZrpSqYXr8ApCa a0vBMuzJqX3ZHIQMaJmMBhxOwCUkGL6K3Fkbh+aiHmUnRnfVGq8wdD7Xz9H0leXG9+Js 5bCv/nAA+e2BO54+ruHt1qZTI+5+SIvQr7BF8iNWBmQEYCpSAKFPP6Zg2ruSZa1iw1PN +w8TFSsgdRVFrMBAoicVK8zdLz+9sooe/TFboU+y89sVY/qmPiIkiLCGy4bcBFJBEiLt Z8XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764000392; x=1764605192; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KTI/AniVvO9tBc5YU1ZIeGzn1xQ7IIEnHW/pxxneqLw=; b=Go+ZHdSmnvMTj5kkv5uFC7BFwMCFyyP4+uLh1TYB+fj8MrYgihDUKMaBanhfmOdbGq 30OBD/Ounk7FC23Lna1qtCDVbtjMjZhiBazSeRHo4uq/UeAuOYMxSzpG2+Epk+abRzg7 KUhjmKJQAausw7QmSXHdkcPZZ+DeWzSrJHJay3mkNkIQIaMMIRbWxepGJLC5Dne6qjns 21MdUKBB09YuEucu2RW3eN3yHyOqyPsDio3tKZXJjFAwmtfUoCP0YFAL5yJPc9lKakHX xvkUeOmE5U0p/Bfzh9joHLBHnkPj269W+GxmhkDUxVmwSwPWxJHyZtyD821GvzGoAByP LPWA== X-Forwarded-Encrypted: i=1; AJvYcCUtZdO8SeZ1Pfoopd0Qh6eCoZ9twOYhjf9n/behw1iIO6JAf4Ti43XXdOkqPM1FQnl9lsT2wIwl77KlOWk=@vger.kernel.org X-Gm-Message-State: AOJu0YyV17+xpQWTPMaWdxnGj37TquuQaVvqIYVGyso6Z9o3y6pzbYUn PKQt2TAHB8dSuYLwZr5uOfJKXcgYlNp2FBP947OklhcUuI27Hzxlxh5JGWhq7d4Gfw== X-Gm-Gg: ASbGncuUMLVq1UVx2/iCus3kfjDyq7wqPIt7Zl6zmQfCgYwKo5rPJmuqUE/5xe+rt8C 7U/9iEuQIDaFUAB56GDSM9q3laT/vyONERBPMRH9oTZAvMnBNWVr2fWAc38Fj1md2lMxjc6Rijo tYfB0KWrS76HQBUNwJkAmX80Fvevie0h3s/uw6DVAG6zCZ+nCAUwZhMg/H8bjuUXntZD6Uxvwsh kVvxpVVFGjUSrvk48Ce4AfVj7Jg31HkgYfXm8mCpI6Q9rMPIXHqcO0iFejPnQ3BkJZ1Mu47rAjy e3LGZkA8l/uEDzaGBr0P6/tln7v2xclscbbxrkgZgQ+gFM5ya3NA97rub6BzZ2oo9IZGPDppMMf FCI48uMPOEDsAMpt3gNVq5+FmVSn8IF6nh6D6zVEwfLjS6Um6P9WtcLWmUtPdjQRmZgHHqU/Pyp 3ki3KtfGIgIDS67IIXcJA= X-Google-Smtp-Source: AGHT+IEOriGJSXzP8uk63KZq7yrBQvaNewacPk0o895QGNdqEk9zrIELHI4r4IbVV5MrZ+48PH4WXg== X-Received: by 2002:a17:903:2ec8:b0:24e:3cf2:2453 with SMTP id d9443c01a7336-29b6c6f1d7dmr129608895ad.61.1764000392087; Mon, 24 Nov 2025 08:06:32 -0800 (PST) Received: from will-mint.dhcp.asu.edu ([94.156.149.24]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-29b5b25e0f0sm136710385ad.46.2025.11.24.08.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 08:06:31 -0800 (PST) From: Will Rosenberg To: Cc: Will Rosenberg , Oliver Rosenberg , Greg Kroah-Hartman , Tejun Heo , linux-kernel@vger.kernel.org Subject: [PATCH v2] kernfs: fix memory leak of kernfs_iattrs in __kernfs_new_node Date: Mon, 24 Nov 2025 09:02:26 -0700 Message-Id: <20251124160226.1921258-1-whrosenb@asu.edu> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There exists a memory leak of kernfs_iattrs contained as an element of kernfs_node allocated in __kernfs_new_node(). __kernfs_setattr() allocates kernfs_iattrs as a sub-object, and the LSM security check incorrectly errors out and does not free the kernfs_iattrs sub-object. Make an additional error out case that properly frees kernfs_iattrs if security_kernfs_init_security() fails. Fixes: f72dae20891d7bcc43e9263ab206960b6ae5209f ("Merge tag 'selinux-pr-201= 90507' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux") Co-developed-by: Oliver Rosenberg Signed-off-by: Oliver Rosenberg Signed-off-by: Will Rosenberg --- fs/kernfs/dir.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c index a670ba3e565e..5a40bfee7055 100644 --- a/fs/kernfs/dir.c +++ b/fs/kernfs/dir.c @@ -675,11 +675,13 @@ static struct kernfs_node *__kernfs_new_node(struct k= ernfs_root *root, if (parent) { ret =3D security_kernfs_init_security(parent, kn); if (ret) - goto err_out3; + goto err_out4; } =20 return kn; =20 + err_out4: + kfree(kn->iattr); err_out3: spin_lock(&root->kernfs_idr_lock); idr_remove(&root->ino_idr, (u32)kernfs_ino(kn)); base-commit: dcb6fa37fd7bc9c3d2b066329b0d27dedf8becaa --=20 2.34.1