From nobody Tue Dec 2 00:46:29 2025 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26D023002DE for ; Mon, 24 Nov 2025 12:46:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763988410; cv=none; b=ejsAGEscP+O+zFBrxmdTzMtcqAQzV6HS02Vc4wPYrHm5VNDaLOYci/B99Z50t733Lht4MXlRDn4VaJTBJBuch9clAFzEn6zWYRNZoKiFuc5TztdRt29HYR1gRIXfeXj0+fto5sSpJS0+fyQu/OuzZlUVmwcEsC1EYEEczwr0Vfw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763988410; c=relaxed/simple; bh=fxEbaz6w0uMCGJivWLfG+scyIrw8SEt71KrJ1bqrzW8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qw5YGZE1Tw6ndjOmBfdGrf5ZRNbcoYaQV5HWoCNfAqKNGYnoKS25cB/cRtHrVY0KAW+eJu3uAsqtIAia4PNyKC/iZ2rHtM8uzRVjr+pQJdrgXm3VEi64f9w6Bj8kFU0D/XANNIYeFI6VGH65aiXnE6ffJDp4GawEFBVbM/cplNo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=jCewDmK6; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jCewDmK6" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b7291af7190so620780366b.3 for ; Mon, 24 Nov 2025 04:46:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1763988406; x=1764593206; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MnwvCDgrr4841IDmxQlulqzHQNtUVlEwFIhs0bIly3A=; b=jCewDmK6wy7OcmPCyDr7gUfwKzJMuOgt3+V/t3CKBZGA61adXuCCv+/BB7akbNqY8t FogPSceo0Cs2FXXEvK5rRtAPPCznPTFt+yCifJVVJd19tYIy8irsrvhjzDS791anbOM0 4sbunm4yQL35SAPmm2Qzquen7QpT0oMAmeung= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763988406; x=1764593206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MnwvCDgrr4841IDmxQlulqzHQNtUVlEwFIhs0bIly3A=; b=krn0vXbDpXQAiriuuro2aJgxcDTqm4WKrzpzaOtK6lhoeOWwRdb3jTKt1WAl4KrH5H RcAa/55uxYQHMpew45nRT8JlxtyX27A61RyP+1PG2D91y8HZJbAKXUA9Ls6nUXTHJ0/3 ENur4ZKpjdnf2wMMO+qWmeXDJ21S/sxHVhZF3XaIl3MELfRUwsvdBDZ4Z7RCO/1ysyzA XsOCNRk0eQbK/WVT3HX8G2ToQbWGQWBzeIc5zMQ+B5Zdn1e9zw6M/3mdhhlzMo4uOI3u dDB5+6NnaykJFv0dGZtF2zk1LkXWX9NWb2aLIFTDh16Vix8raFw+612V2h2RT0tpSyVO ANkQ== X-Forwarded-Encrypted: i=1; AJvYcCVzDnNjVvEAuXrmIR/9t+UzcTFqpxTPWuKyK3kBF/uDF9DRBT1h+OoXvqZljpzLhh9ObvEqeXCpmWAScMg=@vger.kernel.org X-Gm-Message-State: AOJu0YzIBxQ70TxS/Llp9Ar+To7rKddW04F99pjZU5wpOpLZqIwffxeE uxynfy7HAdjGA3eRJSrokIKUaL3tuGYsaKPEkMKr186itjo/Tifd28hN1cvS298mYA== X-Gm-Gg: ASbGnctr4+6v8MJc5WdeZFjKPiJpzRXVVt9B12p7xGri6j+jc7o0sW2p0oqsnTI4BcT HUjVpIttMh6XKdLrSjQoBN6sdM/d3ff6cFVGCPauqab09TBx9tIOB4dQ00lf+MxMD8e8hKgfNUQ NNAZywUzqmU7L07FYaI64YdFt7luwpkY84aEPYx43Hs1YJIT4IipGZMVjDznjt56G7btZGRQouG 3+rsXJLFrSCVbmRzDWho0LlVRfU9mk1MMXuc/JT7ONQ3Vuk5c3aA+c8VEDp9RLcedhlu63edNaV bIy0k0LRJ+zWXsYJLtCF1wRXhPtVVMaE5euYoiLrgPMKZt5DRclYqdIzqcFjecBoSBaPIk8OI3b fs8e06GLIqBXhRbgQr/Z8MuvllnjPFK6UksVZ1Z8bd0usfFeaRfGkr86cp8ar647t2BAPeLLcyF Gik+xvBhG/UB6fjAKf4Pt4w1EhJqSaQDLA7PL4u0JXVI5YCOKWBwVEMIf8xNOI7QoX/bBfDvdlO oHMM/8sXp8= X-Google-Smtp-Source: AGHT+IEBkgh8AVlO5hu3L84i66IimEV3HBFW93RnnCjQGKAdtwiKbIMtcj0XYTbEpogMfTr251MMCA== X-Received: by 2002:a17:907:3cc5:b0:b71:51b:bd4c with SMTP id a640c23a62f3a-b767170c7dbmr1109856466b.50.1763988406487; Mon, 24 Nov 2025 04:46:46 -0800 (PST) Received: from akuchynski.c.googlers.com.com (224.138.204.35.bc.googleusercontent.com. [35.204.138.224]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64536460ea9sm13342599a12.35.2025.11.24.04.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 04:46:45 -0800 (PST) From: Andrei Kuchynski To: Heikki Krogerus , Abhishek Pandit-Subedi , Benson Leung , Jameson Thies , Tzung-Bi Shih , linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev Cc: Guenter Roeck , Greg Kroah-Hartman , Dmitry Baryshkov , "Christian A. Ehrhardt" , Abel Vesa , Pooja Katiyar , Venkat Jayaraman , linux-kernel@vger.kernel.org, Andrei Kuchynski Subject: [PATCH v5 1/4] usb: typec: Add mode_control field to port property Date: Mon, 24 Nov 2025 12:46:36 +0000 Message-ID: <20251124124639.1101335-2-akuchynski@chromium.org> X-Mailer: git-send-email 2.52.0.rc2.455.g230fcf2819-goog In-Reply-To: <20251124124639.1101335-1-akuchynski@chromium.org> References: <20251124124639.1101335-1-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This new field in the port properties dictates whether the Platform Policy Manager (PPM) allows the OS Policy Manager (OPM) to change the currently active, negotiated alternate mode. Signed-off-by: Andrei Kuchynski Reviewed-by: Heikki Krogerus Reviewed-by: Benson Leung --- drivers/usb/typec/class.c | 9 ++++++--- drivers/usb/typec/class.h | 1 + include/linux/usb/typec.h | 2 ++ 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c index 9b2647cb199b..a5327e444265 100644 --- a/drivers/usb/typec/class.c +++ b/drivers/usb/typec/class.c @@ -457,11 +457,13 @@ static umode_t typec_altmode_attr_is_visible(struct k= object *kobj, struct attribute *attr, int n) { struct typec_altmode *adev =3D to_typec_altmode(kobj_to_dev(kobj)); + struct typec_port *port =3D typec_altmode2port(adev); =20 if (attr =3D=3D &dev_attr_active.attr) - if (!is_typec_port(adev->dev.parent) && - (!adev->ops || !adev->ops->activate)) - return 0444; + if (!is_typec_port(adev->dev.parent)) { + if (!port->mode_control || !adev->ops || !adev->ops->activate) + return 0444; + } =20 return attr->mode; } @@ -2694,6 +2696,7 @@ struct typec_port *typec_register_port(struct device = *parent, } =20 port->pd =3D cap->pd; + port->mode_control =3D !cap->no_mode_control; =20 ret =3D device_add(&port->dev); if (ret) { diff --git a/drivers/usb/typec/class.h b/drivers/usb/typec/class.h index db2fe96c48ff..2e89a83c2eb7 100644 --- a/drivers/usb/typec/class.h +++ b/drivers/usb/typec/class.h @@ -62,6 +62,7 @@ struct typec_port { struct mutex partner_link_lock; =20 enum typec_orientation orientation; + bool mode_control; struct typec_switch *sw; struct typec_mux *mux; struct typec_retimer *retimer; diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h index 309251572e2e..59d5fd7e4ff4 100644 --- a/include/linux/usb/typec.h +++ b/include/linux/usb/typec.h @@ -287,6 +287,7 @@ enum usb_pd_svdm_ver { * @prefer_role: Initial role preference (DRP ports). * @accessory: Supported Accessory Modes * @usb_capability: Supported USB Modes + * @no_mode_control: Ability to manage Alternate Modes * @fwnode: Optional fwnode of the port * @driver_data: Private pointer for driver specific info * @pd: Optional USB Power Delivery Support @@ -304,6 +305,7 @@ struct typec_capability { enum typec_accessory accessory[TYPEC_MAX_ACCESSORY]; unsigned int orientation_aware:1; u8 usb_capability; + bool no_mode_control; =20 struct fwnode_handle *fwnode; void *driver_data; --=20 2.52.0.rc2.455.g230fcf2819-goog