From nobody Tue Dec 2 01:06:33 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2264E2FE577; Mon, 24 Nov 2025 12:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986341; cv=none; b=O9z2Yt9lX9hwWlKnKBhOpiUXzSSFdpjaNehDuBpujQvvX5VbHmwEpsd5lQgH8c42Zdvh2ntPK+iDd4iGZJuEtjAW9QRXQJLYpr2t3v1FvRZ0qXKNHCNSKCBEfGuw+oHO5ooVDb8WYcm60bN208r01os2m3D4RB5F7HxJRN06jdM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986341; c=relaxed/simple; bh=1Su3S1OYlS3Av5yiXyt302P5FfhwZUhZFXIJtWLZ5yY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lXI71fS+AYxDB8IYDW5Q5+8jBNaaWzgFTDn//vE1hz3fdfkbxinGt83UnxXkS5GppKorpd5zWpDDrZv1oZR2OhlS6rN3tCh3t/aFeySs/treM5NSgywH4h/ZBGKcc99K3G/SqCdKYYM0lNtKXY7uHAUntj5tV4yywx8YPBitSuk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ITwnht9m; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ITwnht9m" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986337; x=1795522337; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1Su3S1OYlS3Av5yiXyt302P5FfhwZUhZFXIJtWLZ5yY=; b=ITwnht9mQsM8Gt2NDgXQR23eK/I5n9LER1WpbZRr4Ap+beu4nmM1r0yT lN6ivEr6aEaQD1ZYH9VoCcR8iBet7hsYyLwZCu67YpI0uqPL5FKvO5ue1 UiaSv18MKPlup9sgYlPYAmnHL+fUJwT2KS6gSDecxhs2pSuElprUx14lx x6tK+/EnU2FLIi155Cf5xrC9fQJKxqPQ3B7x70QzdTl7RvI9unUwBWe27 fQa7e403SmDtXJWyn6v8hfQtNb8xf2T4zu82SA7nK3mI8rIZgIi1UznoO kR7DKDAO7ckXVMq328yWsmfQC+B+gGRKsDUi9NrgaT64blnGg5vxVKdGC Q==; X-CSE-ConnectionGUID: RcluZXpsRdO5SUiN7NoO2w== X-CSE-MsgGUID: XwHKqIsoTAKqrEGBQSbBAg== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="91467944" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="91467944" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:09 -0800 X-CSE-ConnectionGUID: nCKfT6NBTvG88CwjFB0MBg== X-CSE-MsgGUID: 6Dk4WXZfS/+KdrHlY06iSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="192559538" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa008.fm.intel.com with ESMTP; 24 Nov 2025 04:12:04 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 56D2CA4; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 04/13] dmaengine: bcm2835-dma: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:22 +0100 Message-ID: <20251124121202.424072-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/bcm2835-dma.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c index 0117bb2e8591..802b23be2fd8 100644 --- a/drivers/dma/bcm2835-dma.c +++ b/drivers/dma/bcm2835-dma.c @@ -260,23 +260,6 @@ static void bcm2835_dma_create_cb_set_length( control_block->info |=3D finalextrainfo; } =20 -static inline size_t bcm2835_dma_count_frames_for_sg( - struct bcm2835_chan *c, - struct scatterlist *sgl, - unsigned int sg_len) -{ - size_t frames =3D 0; - struct scatterlist *sgent; - unsigned int i; - size_t plength =3D bcm2835_dma_max_frame_length(c); - - for_each_sg(sgl, sgent, sg_len, i) - frames +=3D bcm2835_dma_frames_for_length( - sg_dma_len(sgent), plength); - - return frames; -} - /** * bcm2835_dma_create_cb_chain - create a control block and fills data in * @@ -672,7 +655,7 @@ static struct dma_async_tx_descriptor *bcm2835_dma_prep= _slave_sg( } =20 /* count frames in sg list */ - frames =3D bcm2835_dma_count_frames_for_sg(c, sgl, sg_len); + frames =3D sg_nents_for_dma(sgl, sg_len, bcm2835_dma_max_frame_length(c)); =20 /* allocate the CB chain */ d =3D bcm2835_dma_create_cb_chain(chan, direction, false, --=20 2.50.1