From nobody Tue Dec 2 01:06:31 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1CF23009DE; Mon, 24 Nov 2025 12:12:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986345; cv=none; b=D8eZ5V6ryAOqwxqeKhjVSDGNNjh/W5GsRqsPAFza0yfE+IjwrlOPIGhVFs5EWPtGKuRMd8UxhSKR/UtPao6nHk42DIlb26JiG5ofWD0YDfptBEYOVD1k26LBzG3k83AYDXfkOVDxrYOnTSzLZRDd6LrPzdgmfwgzRwy450GFYLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986345; c=relaxed/simple; bh=akryAXafWhZQlfplABSdwgarfhhYIf26xngrUAauxhA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B9PUHlm132C7+J6pRwMRnkMB/CKqn1cVOeT9qP8p2Ou9VGzSRzB69ijktVzgblUi3TJmyhROkvZ3sQ19mnN1nNRMZTqRbrJKrdZbp8J9Onv+YyozRlNwBUuVUvJycSluERv6aLh2xDiGRCGq3f4FkVjdCl5auLcbXgis1m2aqAE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GzfNSGJ2; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GzfNSGJ2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986342; x=1795522342; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=akryAXafWhZQlfplABSdwgarfhhYIf26xngrUAauxhA=; b=GzfNSGJ2E1pQxiu4EP2P8LI+5Oz0o34CO2vRKu3w0MCGr11VmxTR/hkS a4u1Sj0DKtAL5A9cKZQeJiacR847MRvAIAHHLRs3NJyvmrJw2xgDDNHnw CtbtMvupJ4W6FQfi96nkbiM+DaL5fLwQL5N6auPtbP4+bAijoQW1jEuOL vOaVAMbTzzP5IhgOhmGxMqx/QZfeVcfAfYyAEa+f1sZgOl7KFSoD8AXPj HjWhmqFiSPPb/qGphMpb9CJWESxVGCYgNuWNV75YfhEoZ4GYGwX68ta/Y JDXjg+UYXteV4zMlhxYkGzs0VJ41UMJDzIHxbPdJPosfH0Q3Cog7qJG1f Q==; X-CSE-ConnectionGUID: TinSauuCTAyfyRgDOysJHg== X-CSE-MsgGUID: 3/8d3062St+tRrBVtjGGwQ== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="69847617" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="69847617" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:16 -0800 X-CSE-ConnectionGUID: DwbDk/0CSIK5hVBMlgSbzQ== X-CSE-MsgGUID: 60dj4sW0Rx6N2jQllImwvg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="222970346" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa002.jf.intel.com with ESMTP; 24 Nov 2025 04:12:10 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 73EFAAA; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 10/13] dmaengine: qcom: bam_dma: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:28 +0100 Message-ID: <20251124121202.424072-11-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/qcom/bam_dma.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c index 2cf060174795..62b3921f0d11 100644 --- a/drivers/dma/qcom/bam_dma.c +++ b/drivers/dma/qcom/bam_dma.c @@ -655,22 +655,17 @@ static struct dma_async_tx_descriptor *bam_prep_slave= _sg(struct dma_chan *chan, struct scatterlist *sg; u32 i; struct bam_desc_hw *desc; - unsigned int num_alloc =3D 0; - + unsigned int num_alloc; =20 if (!is_slave_direction(direction)) { dev_err(bdev->dev, "invalid dma direction\n"); return NULL; } =20 - /* calculate number of required entries */ - for_each_sg(sgl, sg, sg_len, i) - num_alloc +=3D DIV_ROUND_UP(sg_dma_len(sg), BAM_FIFO_SIZE); - /* allocate enough room to accommodate the number of entries */ + num_alloc =3D sg_nents_for_dma(sgl, sg_len, BAM_FIFO_SIZE); async_desc =3D kzalloc(struct_size(async_desc, desc, num_alloc), GFP_NOWAIT); - if (!async_desc) return NULL; =20 --=20 2.50.1