From nobody Tue Dec 2 00:25:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E119D2FF656; Mon, 24 Nov 2025 12:12:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986334; cv=none; b=EAMTMSxHXelaf0/fN9TYhLvPcJPIxw+lbDaNvaePJVsaq4ZxK0iMq9fdd4wsDsMdJ2jrt6mWrVm8R7gPHpAqFOHf9kWRirnhom/UjMFunXD41nNF25h+LudvAQmjHjJWcb8VYD+RK5BUfap4mo9hco6IW6S9Z+/sg4khbXDo8D4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986334; c=relaxed/simple; bh=/cxJU6vGAsQflUr/+ZE9vbpP5RWmAFwZncC3phpHqKM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aZiqj2gjoF6vQiJaduil7pMCC1rCU8qH34f6FklE4AQ6CyqcfJz46EU3urUoIL/RSuVzyEVOwZugjk7X1xUWyImebyNIMLhIzxiNztOmm54FpyoG35LeTunzD3m64rDVme9vg8cYji94yafcIG9LPQGw1cbKJ2f2z7c00tSP1T8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GIpA9SWH; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GIpA9SWH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986332; x=1795522332; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/cxJU6vGAsQflUr/+ZE9vbpP5RWmAFwZncC3phpHqKM=; b=GIpA9SWHHV48B2VylH5MZ4RiQbAydwuhNLs+RSDDBSqN1BUqwPZgTVEZ FedBw+S2C4ShnDBf9AQBZp2Ixi0cH7YjljsmySc4bDakQXbP6uBXrmZl9 SrMted+9vQH5s15l73dPkttX9PoWPm3qJ0tVE+AkhF7rMt9DlQ5UGjjqQ tLJv5IJO1KKjCuo9O6tVaJfAxzSJF4Ug8BAS84eA/+69+7bpnWxgI758b 6/I1xyI7DlQVyNSlLlE8bkFScoaTBaGINU97HFzV8iHYOG8csdk3bEp6A cFloLkYdwmEn5vMuXXT8lmD744LKClNZWT4uRirZ6AydzS2hABESu7FNa Q==; X-CSE-ConnectionGUID: O982OkL6TSSfbo37HpCuVg== X-CSE-MsgGUID: J5aRCAAyTkGlSP+V3N/TZQ== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="91467912" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="91467912" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:09 -0800 X-CSE-ConnectionGUID: fh/9F8B6QSyvv2FZin4FtQ== X-CSE-MsgGUID: v9ZK9M8yQI6oey+Xgb50lQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="192559536" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa008.fm.intel.com with ESMTP; 24 Nov 2025 04:12:04 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 4975DA1; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 01/13] scatterlist: introduce sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:19 +0100 Message-ID: <20251124121202.424072-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Sometimes the user needs to split each entry on the mapped scatter list due to DMA length constrains. This helper returns a number of entities assuming that each of them is not bigger than supplied maximum length. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- include/linux/scatterlist.h | 2 ++ lib/scatterlist.c | 26 ++++++++++++++++++++++++++ 2 files changed, 28 insertions(+) diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h index 29f6ceb98d74..6de1a2434299 100644 --- a/include/linux/scatterlist.h +++ b/include/linux/scatterlist.h @@ -441,6 +441,8 @@ static inline void sg_init_marker(struct scatterlist *s= gl, =20 int sg_nents(struct scatterlist *sg); int sg_nents_for_len(struct scatterlist *sg, u64 len); +int sg_nents_for_dma(struct scatterlist *sgl, unsigned int sglen, size_t l= en); + struct scatterlist *sg_last(struct scatterlist *s, unsigned int); void sg_init_table(struct scatterlist *, unsigned int); void sg_init_one(struct scatterlist *, const void *, unsigned int); diff --git a/lib/scatterlist.c b/lib/scatterlist.c index 4af1c8b0775a..21bc9c1f7c06 100644 --- a/lib/scatterlist.c +++ b/lib/scatterlist.c @@ -64,6 +64,32 @@ int sg_nents_for_len(struct scatterlist *sg, u64 len) } EXPORT_SYMBOL(sg_nents_for_len); =20 +/** + * sg_nents_for_dma - return the count of DMA-capable entries in scatterli= st + * @sgl: The scatterlist + * @sglen: The current number of entries + * @len: The maximum length of DMA-capable block + * + * Description: + * Determines the number of entries in @sgl which would be permitted in + * DMA-capable transfer if list had been split accordingly, taking into + * account chaining as well. + * + * Returns: + * the number of sgl entries needed + * + **/ +int sg_nents_for_dma(struct scatterlist *sgl, unsigned int sglen, size_t l= en) +{ + struct scatterlist *sg; + int i, nents =3D 0; + + for_each_sg(sgl, sg, sglen, i) + nents +=3D DIV_ROUND_UP(sg_dma_len(sg), len); + return nents; +} +EXPORT_SYMBOL(sg_nents_for_dma); + /** * sg_last - return the last scatterlist entry in a list * @sgl: First entry in the scatterlist --=20 2.50.1 From nobody Tue Dec 2 00:25:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E5052FFDE4; Mon, 24 Nov 2025 12:12:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986339; cv=none; b=Lq+1/Si2BIa16iuU0hJlNDfl8ieXgw8vsUfs6KUh+fueK798E9NpxbtKqwaAHn+9FSt0Lm1hyDIdvMenC8V4CT0Lm0fZV8y75viWC/zF9YqFZFgAlI+6r1ApyKxgQYXVLImKiuG7PcqC+/MbIvsva+Tc2eXn6gmGAJ77Eg6rcnI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986339; c=relaxed/simple; bh=trxP5p0DPdBeRi5vhwLDZx5PvWwqNzPStkGF5be32MQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q7f22JnmmgppaAfszxScAHNmx3V8xNdqzJnk+HbhjVoaQwtWbSuyBvla7xjpyQy78h3zw4r3K553HaDe+4TU73FsEsei64Nxvg2AZTekiMrTKx+7nKIA/gQrvAVeiI6MTqSz6OCdYNaBlIJ6I7htJ6bG2ryuEErGnJ3mhrqOD/o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ezzUEZRF; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ezzUEZRF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986336; x=1795522336; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=trxP5p0DPdBeRi5vhwLDZx5PvWwqNzPStkGF5be32MQ=; b=ezzUEZRFRHaaq9BHbLBBgpzraAvF9dt2GM0gCgmn4Ixsr7lvocWqstKM OV2d2g+f7imzExV9Jqzcu04YDvvjQHvWrYfEggfU9VFSc8QiaRFf1q3Zq nMVGavM8HKS19C34e0vZRR1gDgiODuQAn+ivL7NDWGzlgtnU6yCWxY/Ex w1ILXrq+5XxYpZh+PE37XYtCeTyq6YG3bI+3jGAGXjO0E5eIvjbN489Yz isEQktppA3kF61q1GCmhnehtJ3q0J+DNmrRomZdpQQ7+fqlVmI9v1EvmB UxpYJNbBWZ9VJlRQ3sQR+i4y042+9BAdaRkL/F0EC4lkWXVTNA2DI/Ohh A==; X-CSE-ConnectionGUID: yXohF6B2TTexW3cksiZIgw== X-CSE-MsgGUID: +3uMCVgoSWGXV5z/alzzCg== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="91467930" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="91467930" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:09 -0800 X-CSE-ConnectionGUID: 3opyCmUeRgyXZLeN0a8A3A== X-CSE-MsgGUID: ZpvOF1xUTt2GcGUO71jbBg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="192559539" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa008.fm.intel.com with ESMTP; 24 Nov 2025 04:12:04 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 4E189A2; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 02/13] dmaengine: altera-msgdma: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:20 +0100 Message-ID: <20251124121202.424072-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/altera-msgdma.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c index a203fdd84950..48d2a0e638bb 100644 --- a/drivers/dma/altera-msgdma.c +++ b/drivers/dma/altera-msgdma.c @@ -396,13 +396,12 @@ msgdma_prep_slave_sg(struct dma_chan *dchan, struct s= catterlist *sgl, void *desc =3D NULL; size_t len, avail; dma_addr_t dma_dst, dma_src; - u32 desc_cnt =3D 0, i; struct scatterlist *sg; + u32 desc_cnt; u32 stride; unsigned long irqflags; =20 - for_each_sg(sgl, sg, sg_len, i) - desc_cnt +=3D DIV_ROUND_UP(sg_dma_len(sg), MSGDMA_MAX_TRANS_LEN); + desc_cnt =3D sg_nents_for_dma(sgl, sg_len, MSGDMA_MAX_TRANS_LEN); =20 spin_lock_irqsave(&mdev->lock, irqflags); if (desc_cnt > mdev->desc_free_cnt) { --=20 2.50.1 From nobody Tue Dec 2 00:25:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B87562FF648; Mon, 24 Nov 2025 12:12:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986338; cv=none; b=cwQH6kIIN8yQwxrX8CWQbcycDb+DWWkCYWniMuEZXdRblSuF/kxxzvXoUmnY593GjVJ6E5rcmFU39IXQc/Y3raAPfTS+njzs+ToCYW27Z4Sx8f82IfrkOoacbPJJDhxPUznG5+PJUFatvRINEcM0v7z3HTJG57vwjAj8p+N+W6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986338; c=relaxed/simple; bh=nUvI1SoM4FGg3QQHNwgNidRdOH1tF5MQSJvXCQ4IzUg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eOwf3Xvho5l5u/YoA0wQRzZcrtt991c58jzhtSqo0q1tpXr9BqvL5l8Zfk70w809m/vmTk9LjD5VTWScplP/XRV8KKKfiGqh4zH+v6Jk/ia2sm6KTwX5N3noCIs27Jrn8sodQ/eZ8xZLytlGf1LdVS6ICEik4C0A+DD84Mrg6nQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=I0aUlDNY; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="I0aUlDNY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986335; x=1795522335; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nUvI1SoM4FGg3QQHNwgNidRdOH1tF5MQSJvXCQ4IzUg=; b=I0aUlDNY2aIpM+umdNDufbnPL1iURVaaruF48vzTMtwLn1kyofLk8Aln XZg6KJJxpL5TzhLzqWmEJtZ9Yum5eA2q1acjOLoNqOihHT7EFBVPYakBS fNnkthMK7tpltkGLIvQiEmDaVFsOFuVkJPNsP70S/n+qFuVtxML5WWPyA lQV3/Dq+VrZ2/J9ciFnVHqu+n9Wq0SFwJutBvvAu9Cc2kJDoPizlEiUsd uv4s2yMUDwaJs2NoRbVPkCfFYmfMz8NcJjdpVPAAdtzojI+EIBsgPqbJX SYG/khArt9/aCvjvdOSu6vL2pmeCNG2aE2OGkprqeLiBCSpD9TlhdvzAI A==; X-CSE-ConnectionGUID: n9SYMItvQFKk7icAQm3eVg== X-CSE-MsgGUID: c/t07u4oQl+xOZD9GkS8Xg== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="69847547" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="69847547" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:10 -0800 X-CSE-ConnectionGUID: O5zO3YrlQIGH3jGTtG1/RQ== X-CSE-MsgGUID: FlLlvMcMQWWorE6BXZ13rw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="222970324" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa002.jf.intel.com with ESMTP; 24 Nov 2025 04:12:04 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 52C24A3; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 03/13] dmaengine: axi-dmac: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:21 +0100 Message-ID: <20251124121202.424072-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/dma-axi-dmac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index 5b06b0dc67ee..5d4436e7d2ee 100644 --- a/drivers/dma/dma-axi-dmac.c +++ b/drivers/dma/dma-axi-dmac.c @@ -674,10 +674,7 @@ static struct dma_async_tx_descriptor *axi_dmac_prep_s= lave_sg( if (direction !=3D chan->direction) return NULL; =20 - num_sgs =3D 0; - for_each_sg(sgl, sg, sg_len, i) - num_sgs +=3D DIV_ROUND_UP(sg_dma_len(sg), chan->max_length); - + num_sgs =3D sg_nents_for_dma(sgl, sg_len, chan->max_length); desc =3D axi_dmac_alloc_desc(chan, num_sgs); if (!desc) return NULL; --=20 2.50.1 From nobody Tue Dec 2 00:25:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2264E2FE577; Mon, 24 Nov 2025 12:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986341; cv=none; b=O9z2Yt9lX9hwWlKnKBhOpiUXzSSFdpjaNehDuBpujQvvX5VbHmwEpsd5lQgH8c42Zdvh2ntPK+iDd4iGZJuEtjAW9QRXQJLYpr2t3v1FvRZ0qXKNHCNSKCBEfGuw+oHO5ooVDb8WYcm60bN208r01os2m3D4RB5F7HxJRN06jdM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986341; c=relaxed/simple; bh=1Su3S1OYlS3Av5yiXyt302P5FfhwZUhZFXIJtWLZ5yY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lXI71fS+AYxDB8IYDW5Q5+8jBNaaWzgFTDn//vE1hz3fdfkbxinGt83UnxXkS5GppKorpd5zWpDDrZv1oZR2OhlS6rN3tCh3t/aFeySs/treM5NSgywH4h/ZBGKcc99K3G/SqCdKYYM0lNtKXY7uHAUntj5tV4yywx8YPBitSuk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ITwnht9m; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ITwnht9m" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986337; x=1795522337; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1Su3S1OYlS3Av5yiXyt302P5FfhwZUhZFXIJtWLZ5yY=; b=ITwnht9mQsM8Gt2NDgXQR23eK/I5n9LER1WpbZRr4Ap+beu4nmM1r0yT lN6ivEr6aEaQD1ZYH9VoCcR8iBet7hsYyLwZCu67YpI0uqPL5FKvO5ue1 UiaSv18MKPlup9sgYlPYAmnHL+fUJwT2KS6gSDecxhs2pSuElprUx14lx x6tK+/EnU2FLIi155Cf5xrC9fQJKxqPQ3B7x70QzdTl7RvI9unUwBWe27 fQa7e403SmDtXJWyn6v8hfQtNb8xf2T4zu82SA7nK3mI8rIZgIi1UznoO kR7DKDAO7ckXVMq328yWsmfQC+B+gGRKsDUi9NrgaT64blnGg5vxVKdGC Q==; X-CSE-ConnectionGUID: RcluZXpsRdO5SUiN7NoO2w== X-CSE-MsgGUID: XwHKqIsoTAKqrEGBQSbBAg== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="91467944" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="91467944" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:09 -0800 X-CSE-ConnectionGUID: nCKfT6NBTvG88CwjFB0MBg== X-CSE-MsgGUID: 6Dk4WXZfS/+KdrHlY06iSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="192559538" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa008.fm.intel.com with ESMTP; 24 Nov 2025 04:12:04 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 56D2CA4; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 04/13] dmaengine: bcm2835-dma: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:22 +0100 Message-ID: <20251124121202.424072-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/bcm2835-dma.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c index 0117bb2e8591..802b23be2fd8 100644 --- a/drivers/dma/bcm2835-dma.c +++ b/drivers/dma/bcm2835-dma.c @@ -260,23 +260,6 @@ static void bcm2835_dma_create_cb_set_length( control_block->info |=3D finalextrainfo; } =20 -static inline size_t bcm2835_dma_count_frames_for_sg( - struct bcm2835_chan *c, - struct scatterlist *sgl, - unsigned int sg_len) -{ - size_t frames =3D 0; - struct scatterlist *sgent; - unsigned int i; - size_t plength =3D bcm2835_dma_max_frame_length(c); - - for_each_sg(sgl, sgent, sg_len, i) - frames +=3D bcm2835_dma_frames_for_length( - sg_dma_len(sgent), plength); - - return frames; -} - /** * bcm2835_dma_create_cb_chain - create a control block and fills data in * @@ -672,7 +655,7 @@ static struct dma_async_tx_descriptor *bcm2835_dma_prep= _slave_sg( } =20 /* count frames in sg list */ - frames =3D bcm2835_dma_count_frames_for_sg(c, sgl, sg_len); + frames =3D sg_nents_for_dma(sgl, sg_len, bcm2835_dma_max_frame_length(c)); =20 /* allocate the CB chain */ d =3D bcm2835_dma_create_cb_chain(chan, direction, false, --=20 2.50.1 From nobody Tue Dec 2 00:25:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9C202FF660; Mon, 24 Nov 2025 12:12:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986341; cv=none; b=fFnXv9CvlYPb3riTemun+A/uy3YZJ/rM2eE3c1kZfMcOCzPoIPYdb/RVGCdrhr4qMhSAvX8wjqxok1Efvatu+ADysLUhHpVowRNVjLG48hewQxuedRltb+PyxjrrK/yQv0/FohA6vfRiMNteo+cVYqWqxL/I5BWF0XBL6XGug4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986341; c=relaxed/simple; bh=AVsEaLmI7GtsoKPxvWrWR94lD6aGbAJMgKiJV4Biyag=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Yn50AJZNNVl1HOM8AKi6pqx/uMG6pz0B+7hhDjkOBcRh5ndDGbijWC5yI0eEnzzAl413bqLcTpXJGOwjnX04kjyBqLb4TxWXnxUu5NrkT3Eih8ZqFiZn5lrRSHMSuzTCcpGR4RcDEJIdvccKAyt8rX9HHSbi7ShOQGxTO9RmuBU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nDgU5l2S; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nDgU5l2S" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986338; x=1795522338; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AVsEaLmI7GtsoKPxvWrWR94lD6aGbAJMgKiJV4Biyag=; b=nDgU5l2SPHX2F15B4BeVwXbf05GYKbZWr4pLLftejBtWiAgcLDUaWoi1 WRnnaHffdckquhkaBAZwO7vbUUoZqO4U0bdEIudyyKPHblMRpoevpG4Rq xy4+Bd2rMYSBshPHi91kmU/YJ3Q9M9nUJGu0ZjLquxVZheYbAGFVFiMca G9QA9oFokch6MrzlcUlgiwUHmcU0aJmTOdas52xG8NGHukvVW8TBTTPE1 D1ri41ipDrp2erWw8AgKbvxLPrT41J56kMX9l69q4139F4p+1ienP9f/O /yuYN3Ftkko8locMJVxwu1fKUWjPQEhkuboWydiCeqjhXdJr6d2/WdSyb w==; X-CSE-ConnectionGUID: 66gGZhDJQe6R6tWQi15obw== X-CSE-MsgGUID: kh4UF9GKTu6fcqw0mlh9kg== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="69847569" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="69847569" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:15 -0800 X-CSE-ConnectionGUID: spmCwM9MRQqA5SvF0Vzuuw== X-CSE-MsgGUID: TZzaWKrJQOSEKD51KOqVAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="222970343" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa002.jf.intel.com with ESMTP; 24 Nov 2025 04:12:10 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 5B4BCA5; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 05/13] dmaengine: dw-axi-dmac: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:23 +0100 Message-ID: <20251124121202.424072-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/d= w-axi-dmac/dw-axi-dmac-platform.c index b23536645ff7..493c2a32b0fe 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -850,7 +850,7 @@ dw_axi_dma_chan_prep_slave_sg(struct dma_chan *dchan, s= truct scatterlist *sgl, unsigned int loop =3D 0; struct scatterlist *sg; size_t axi_block_len; - u32 len, num_sgs =3D 0; + u32 len, num_sgs; unsigned int i; dma_addr_t mem; int status; @@ -867,9 +867,7 @@ dw_axi_dma_chan_prep_slave_sg(struct dma_chan *dchan, s= truct scatterlist *sgl, if (axi_block_len =3D=3D 0) return NULL; =20 - for_each_sg(sgl, sg, sg_len, i) - num_sgs +=3D DIV_ROUND_UP(sg_dma_len(sg), axi_block_len); - + num_sgs =3D sg_nents_for_dma(sgl, sg_len, axi_block_len); desc =3D axi_desc_alloc(num_sgs); if (unlikely(!desc)) goto err_desc_get; --=20 2.50.1 From nobody Tue Dec 2 00:25:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F25A42FF663; Mon, 24 Nov 2025 12:12:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986342; cv=none; b=q4EuDv8+VMHOtI77mUm5B2TBRNyS4Dv7zBGCxurbyOpzcgx38LM0SMi2R0KpDLGmNmglh3I8yzngvUGHBdqNZW7Ruv3jEru9B2M4EboA6EG+OvpGm5pgQDsT1TgUbceWW3FtW/YulKMnIBAlXGh7BcjaRrYb5S/oz0rvVpdKsS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986342; c=relaxed/simple; bh=yN+ecYcYKcZKT4gWNmRCDsdhTOBiye6jHzywdjrd5sk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j9JAdMGd5Sv89Haqb/Eq+oxUGt/GN1jA5aFygS2MlhsHSx2VQn/6+fqzzsb4+/qVzHogzbIwGJqV/sCOtnPS9v9GTC7tH/XNifgAjAq0oK/uCzSItLY0pv8G9+U7YsVy5cKnSTjr+eT6B8/TXr7rvKWdzDxPtfbBEVvvq6obS3c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VCrZL4kk; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VCrZL4kk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986339; x=1795522339; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yN+ecYcYKcZKT4gWNmRCDsdhTOBiye6jHzywdjrd5sk=; b=VCrZL4kkP/55orkgEchC+T9PDYTOIoiptM37kOSs41Fswlqy9I6WC3If d3lqgnyQ5WQ5jtwJLCqz4kTgIcGcEDtEGtnkdoORrquIwWGW/+/RE1OHs 0SNI/1Uzb+1L86fWmR5iObKWyJn/NuHPmNIlnL93q2SZPpTa6WwjcOxPl 1xQle2T8kjMj9Va9PhcWEv2iM38fzAJzqD7JMQKpt7YdSufJ1KcJhdGUY gpJ21IgGStljGtPZi/CIjBDnaBOtG8gHd7JMjauoYzOaEtjhU7LwKc6YE sT7MgEYnrLC8iNPi4cl916lseckgNVUwgGKKmm/n2LJRq2ThxSRUwbtxl Q==; X-CSE-ConnectionGUID: lEracMilTJC7itXDr1WuGQ== X-CSE-MsgGUID: K3PJ6//LSu+K/qeK0ifuOw== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="91467960" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="91467960" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:15 -0800 X-CSE-ConnectionGUID: J8Apy+NdRdG8m6rJd8K6Ig== X-CSE-MsgGUID: jcpL5DqWTwKaU8kaKNBkiQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="192559570" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa008.fm.intel.com with ESMTP; 24 Nov 2025 04:12:10 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 6077AA6; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 06/13] dmaengine: k3dma: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:24 +0100 Message-ID: <20251124121202.424072-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/k3dma.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c index acc2983e28e0..88f9a2952edc 100644 --- a/drivers/dma/k3dma.c +++ b/drivers/dma/k3dma.c @@ -536,19 +536,14 @@ static struct dma_async_tx_descriptor *k3_dma_prep_sl= ave_sg( size_t len, avail, total =3D 0; struct scatterlist *sg; dma_addr_t addr, src =3D 0, dst =3D 0; - int num =3D sglen, i; + int num, i; =20 if (sgl =3D=3D NULL) return NULL; =20 c->cyclic =3D 0; =20 - for_each_sg(sgl, sg, sglen, i) { - avail =3D sg_dma_len(sg); - if (avail > DMA_MAX_SIZE) - num +=3D DIV_ROUND_UP(avail, DMA_MAX_SIZE) - 1; - } - + num =3D sg_nents_for_dma(sgl, sglen, DMA_MAX_SIZE); ds =3D k3_dma_alloc_desc_resource(num, chan); if (!ds) return NULL; --=20 2.50.1 From nobody Tue Dec 2 00:25:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 539E62FFF80; Mon, 24 Nov 2025 12:12:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986343; cv=none; b=lZVj2DOJp8R83ZhOKuLn03rPg4ZyEKuax8NKyiqeWp5mmQxfTrKCAP8ZNDn8RcGULaclgYgVSzfEBQ/hCpjH/IAft8hRJ2KCHJqhln0nDGirEiAW/YQpxvH7dSBpuyg/hXgl2lzWyhhQJRMwhE8jGYTsFa13waqyuu3JYFtDI3M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986343; c=relaxed/simple; bh=Z4cy+2HbiLCLWtcSsLcUwBV59DreBfM5HrektthG6GQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gNNj9SmJ6NgHJTbseFSd2rEbepaqU/3xQK9CzGLb0Pjjfyd4ruC8cJgKrIT86HQvrpnEnVNVoIY66T1wddkr7N0lbN/C1GxITyVxWVDeacAMjTwxYQa1MtDzx8vtSQHe1yKBvSrONW4ZHEp1Z/HlLwTNB1DmiCHqhf0/Ol31o4M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=TCkiUMio; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="TCkiUMio" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986339; x=1795522339; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Z4cy+2HbiLCLWtcSsLcUwBV59DreBfM5HrektthG6GQ=; b=TCkiUMiowQuCOQ3zBlrCxPwT4dEAA8TFmVLTpdDxMuNM8qg9CPotyMUf Y47G5B4T+L6kepVAwtesr87Wn1+DCMojVjn6jeWKFFBYcpC3d2dv8TgOI Jr5L1717wLVAlJ0IpdTrLa795UAm+Izy+LHxxRnbpl9RpWEV+qx6SWNo/ FJ53Z2r4fhoqbQ1AIzHcTf6km1oXvBz3JUFG1shmpfC79K4/RkBulEMbH 9+D+jkMJSTKjkGQAZYoGVjSutRyKHl5hp/XVtGztPbBqqFI69t0vgenR4 TAKuRWngNlhNVop766q+gXWwscXVU6JghgPBDWuesBBw+9X97hBJWW/W/ Q==; X-CSE-ConnectionGUID: F+2DNrXjR+a7DTykIgwWfw== X-CSE-MsgGUID: hHzEaE7lRAqiK33kNvPiNQ== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="69847587" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="69847587" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:15 -0800 X-CSE-ConnectionGUID: u8eTMZfQRgaZ40Qo2k195g== X-CSE-MsgGUID: 39ttMucESuq1ncwuVM0izw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="222970344" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa002.jf.intel.com with ESMTP; 24 Nov 2025 04:12:10 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 6560CA7; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 07/13] dmaengine: lgm: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:25 +0100 Message-ID: <20251124121202.424072-8-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/lgm/lgm-dma.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/dma/lgm/lgm-dma.c b/drivers/dma/lgm/lgm-dma.c index 8173c3f1075a..a7b9cf30f6ad 100644 --- a/drivers/dma/lgm/lgm-dma.c +++ b/drivers/dma/lgm/lgm-dma.c @@ -1164,8 +1164,8 @@ ldma_prep_slave_sg(struct dma_chan *chan, struct scat= terlist *sgl, struct dw2_desc *hw_ds; struct dw2_desc_sw *ds; struct scatterlist *sg; - int num =3D sglen, i; dma_addr_t addr; + int num, i; =20 if (!sgl) return NULL; @@ -1173,12 +1173,7 @@ ldma_prep_slave_sg(struct dma_chan *chan, struct sca= tterlist *sgl, if (d->ver > DMA_VER22) return ldma_chan_desc_cfg(chan, sgl->dma_address, sglen); =20 - for_each_sg(sgl, sg, sglen, i) { - avail =3D sg_dma_len(sg); - if (avail > DMA_MAX_SIZE) - num +=3D DIV_ROUND_UP(avail, DMA_MAX_SIZE) - 1; - } - + num =3D sg_nents_for_dma(sgl, sglen, DMA_MAX_SIZE); ds =3D dma_alloc_desc_resource(num, c); if (!ds) return NULL; --=20 2.50.1 From nobody Tue Dec 2 00:25:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C69B2F90E0; Mon, 24 Nov 2025 12:12:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986343; cv=none; b=r5sct2fEfkbmsnMtOaquy/A7yFtFPxnyhbQGSOgwRnYBS73tvkEno1pj6s3PQI1u7GxXOt9cA9ZG9EfISCusZmDXkOHWQugUj69+PU2Lc/AHnplyHUNmEtBrR0mXgDipKQddUvf33ej+xXX60/8WQs7frRcrIUJhjTgx7zxLfFg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986343; c=relaxed/simple; bh=aIZKpp2i1U4bYPp+lJpBExBX9TU2DJpWjDWAz41Iejk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bMJyZ60Fkx4B5MIdgaJqd0PlKvkuNHaBuBqSyPALXXmJgo0N5fBBXK8bEfNkpX9NEFjPyF5CmpCOAOCBmUU3IshcM9wlSPe1y0msS5X+P5NTtL+CkKb08dfuuaCwKkYjbl0Ok0r8ubGS9R1aqNH+RM2S+nqGGsBOCzYreBDAnME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OQiT1l95; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OQiT1l95" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986340; x=1795522340; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aIZKpp2i1U4bYPp+lJpBExBX9TU2DJpWjDWAz41Iejk=; b=OQiT1l952fOPwDpWxoKbFKjPmgAJiGOjoKoYWdiZ+hasgLeebb1RAb+k j1Dr4tWBbLyc1s/MG7aVum3EzT7xoCo9O3fLzQn5CGh/CW/fSlf6nuFxL hgr6Hv4lpHOtIGf5LrlecLNLonGFt5u1kT89zYo1T/Rio/ZUi9+79daaA N8NdwNJOZc9ApdG1rpFuOx0zblf0hBg7dmwDQiZ54ZYgPC0kRwHz+S8QN 2ukKtJA+m4WGqzeJc7RBocLbwM78ehxu07uUrx+kaZo0Q6JXFXo5DMY0Q ICLXeTHnOaSixqXYN4T4H78so6p10cecAKbPr5oN236TdV+Lc7jLiVm02 Q==; X-CSE-ConnectionGUID: DhjwRODJRpm2BXPiildRgQ== X-CSE-MsgGUID: +qu2eCoXRAqwVhuWdPupFQ== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="91467977" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="91467977" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:15 -0800 X-CSE-ConnectionGUID: TTvZDXbhSCi3GwHPuB08gg== X-CSE-MsgGUID: IzSkpYm7TIGtqQIBH5iKGQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="192559571" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa008.fm.intel.com with ESMTP; 24 Nov 2025 04:12:10 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 6A35BA8; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 08/13] dmaengine: pxa-dma: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:26 +0100 Message-ID: <20251124121202.424072-9-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/pxa_dma.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index 249296389771..b639c8b51e87 100644 --- a/drivers/dma/pxa_dma.c +++ b/drivers/dma/pxa_dma.c @@ -970,7 +970,7 @@ pxad_prep_slave_sg(struct dma_chan *dchan, struct scatt= erlist *sgl, struct scatterlist *sg; dma_addr_t dma; u32 dcmd, dsadr =3D 0, dtadr =3D 0; - unsigned int nb_desc =3D 0, i, j =3D 0; + unsigned int nb_desc, i, j =3D 0; =20 if ((sgl =3D=3D NULL) || (sg_len =3D=3D 0)) return NULL; @@ -979,8 +979,7 @@ pxad_prep_slave_sg(struct dma_chan *dchan, struct scatt= erlist *sgl, dev_dbg(&chan->vc.chan.dev->device, "%s(): dir=3D%d flags=3D%lx\n", __func__, dir, flags); =20 - for_each_sg(sgl, sg, sg_len, i) - nb_desc +=3D DIV_ROUND_UP(sg_dma_len(sg), PDMA_MAX_DESC_BYTES); + nb_desc =3D sg_nents_for_dma(sgl, sg_len, PDMA_MAX_DESC_BYTES); sw_desc =3D pxad_alloc_desc(chan, nb_desc + 1); if (!sw_desc) return NULL; --=20 2.50.1 From nobody Tue Dec 2 00:25:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9E682FFDD6; Mon, 24 Nov 2025 12:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986344; cv=none; b=eQr0H0hnUIPA6WLwbbaU73ia8EWRUpB9c0hF50Hg1YzSMnWLmDjOIVl+Ts5j6YLkmWQeRJOKaejH0zKaC9fLMpQu7SpC4Xf00wM6bk9YEhMNkDjqK+eDZ+m7ySMOmyLzijJ7pL5QYhR5WAKPp10jLKUhMsiCd2VGBEs05oKxrVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986344; c=relaxed/simple; bh=noDJxCmlGW2l/RNKrw+Y3WhNwmbPyJ6mAjM7+Omfh0g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EHF6u1HL/NphVMCSvpgD0Zmf9OCTQ5DRJaL6OEhPF5QxKqldh+hVthANtdhlIZb6YPHKBrIaFpZ8e1XleA9wt2eR4kEW3rgL3Mq5Dx2pRqQqJcL3bqzj5P+syPe8oBmoZmBQX+rH++L1HLUcuWXTiuUpnpLOPl+5Uj6vLzV0EyY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=a8CuPq7n; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="a8CuPq7n" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986341; x=1795522341; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=noDJxCmlGW2l/RNKrw+Y3WhNwmbPyJ6mAjM7+Omfh0g=; b=a8CuPq7nwnmL/ykXOaeg8J0CdV7saios3JLVlXRKfTtsqA/h8zRobH8N rDGoljOdw6hVQl1wZGhHSCdoG6kwImGinOrvQr7uVRHzOIaPANd63VyZt vzejbSlSGgH3WNDafgRw2nkYig8u4dK40mqCg/g+nVWEib0Tcd+7d5ymN 116yQxJft0/1cIeFsNGa/ZcPrHbFlm5BeHyeLQ/zQgkgpKkF95mE94EyY HwDpoABgX4k1h4QgRjweDkr9VDWSIJvX0sOmJl2Z3Ybzi4MTphIvuL+p3 XuoAvHCUMlcOQsQ/ZnWmFPoiKbd7W44HCTwLk6DbFpKpeGrQ4ScWVwUtF Q==; X-CSE-ConnectionGUID: o90D4kf/Qf2H8ZLCD0yTDg== X-CSE-MsgGUID: UTLaULJESh2ULfKJ6PN66w== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="69847604" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="69847604" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:16 -0800 X-CSE-ConnectionGUID: ul+nTSsMTxuky5teU59mmA== X-CSE-MsgGUID: Lw/TYoX5SQSD+IXZODL5KQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="222970345" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa002.jf.intel.com with ESMTP; 24 Nov 2025 04:12:10 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 6F30AA9; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 09/13] dmaengine: qcom: adm: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:27 +0100 Message-ID: <20251124121202.424072-10-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/qcom/qcom_adm.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/dma/qcom/qcom_adm.c b/drivers/dma/qcom/qcom_adm.c index e0f0c6f42c1f..aeb01b7087e2 100644 --- a/drivers/dma/qcom/qcom_adm.c +++ b/drivers/dma/qcom/qcom_adm.c @@ -390,16 +390,15 @@ static struct dma_async_tx_descriptor *adm_prep_slave= _sg(struct dma_chan *chan, } =20 /* iterate through sgs and compute allocation size of structures */ - for_each_sg(sgl, sg, sg_len, i) { - if (achan->slave.device_fc) { + if (achan->slave.device_fc) { + for_each_sg(sgl, sg, sg_len, i) { box_count +=3D DIV_ROUND_UP(sg_dma_len(sg) / burst, ADM_MAX_ROWS); if (sg_dma_len(sg) % burst) single_count++; - } else { - single_count +=3D DIV_ROUND_UP(sg_dma_len(sg), - ADM_MAX_XFER); } + } else { + single_count =3D sg_nents_for_dma(sgl, sg_len, ADM_MAX_XFER); } =20 async_desc =3D kzalloc(sizeof(*async_desc), GFP_NOWAIT); --=20 2.50.1 From nobody Tue Dec 2 00:25:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1CF23009DE; Mon, 24 Nov 2025 12:12:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986345; cv=none; b=D8eZ5V6ryAOqwxqeKhjVSDGNNjh/W5GsRqsPAFza0yfE+IjwrlOPIGhVFs5EWPtGKuRMd8UxhSKR/UtPao6nHk42DIlb26JiG5ofWD0YDfptBEYOVD1k26LBzG3k83AYDXfkOVDxrYOnTSzLZRDd6LrPzdgmfwgzRwy450GFYLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986345; c=relaxed/simple; bh=akryAXafWhZQlfplABSdwgarfhhYIf26xngrUAauxhA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B9PUHlm132C7+J6pRwMRnkMB/CKqn1cVOeT9qP8p2Ou9VGzSRzB69ijktVzgblUi3TJmyhROkvZ3sQ19mnN1nNRMZTqRbrJKrdZbp8J9Onv+YyozRlNwBUuVUvJycSluERv6aLh2xDiGRCGq3f4FkVjdCl5auLcbXgis1m2aqAE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GzfNSGJ2; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GzfNSGJ2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986342; x=1795522342; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=akryAXafWhZQlfplABSdwgarfhhYIf26xngrUAauxhA=; b=GzfNSGJ2E1pQxiu4EP2P8LI+5Oz0o34CO2vRKu3w0MCGr11VmxTR/hkS a4u1Sj0DKtAL5A9cKZQeJiacR847MRvAIAHHLRs3NJyvmrJw2xgDDNHnw CtbtMvupJ4W6FQfi96nkbiM+DaL5fLwQL5N6auPtbP4+bAijoQW1jEuOL vOaVAMbTzzP5IhgOhmGxMqx/QZfeVcfAfYyAEa+f1sZgOl7KFSoD8AXPj HjWhmqFiSPPb/qGphMpb9CJWESxVGCYgNuWNV75YfhEoZ4GYGwX68ta/Y JDXjg+UYXteV4zMlhxYkGzs0VJ41UMJDzIHxbPdJPosfH0Q3Cog7qJG1f Q==; X-CSE-ConnectionGUID: TinSauuCTAyfyRgDOysJHg== X-CSE-MsgGUID: 3/8d3062St+tRrBVtjGGwQ== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="69847617" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="69847617" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:16 -0800 X-CSE-ConnectionGUID: DwbDk/0CSIK5hVBMlgSbzQ== X-CSE-MsgGUID: 60dj4sW0Rx6N2jQllImwvg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="222970346" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa002.jf.intel.com with ESMTP; 24 Nov 2025 04:12:10 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 73EFAAA; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 10/13] dmaengine: qcom: bam_dma: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:28 +0100 Message-ID: <20251124121202.424072-11-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/qcom/bam_dma.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c index 2cf060174795..62b3921f0d11 100644 --- a/drivers/dma/qcom/bam_dma.c +++ b/drivers/dma/qcom/bam_dma.c @@ -655,22 +655,17 @@ static struct dma_async_tx_descriptor *bam_prep_slave= _sg(struct dma_chan *chan, struct scatterlist *sg; u32 i; struct bam_desc_hw *desc; - unsigned int num_alloc =3D 0; - + unsigned int num_alloc; =20 if (!is_slave_direction(direction)) { dev_err(bdev->dev, "invalid dma direction\n"); return NULL; } =20 - /* calculate number of required entries */ - for_each_sg(sgl, sg, sg_len, i) - num_alloc +=3D DIV_ROUND_UP(sg_dma_len(sg), BAM_FIFO_SIZE); - /* allocate enough room to accommodate the number of entries */ + num_alloc =3D sg_nents_for_dma(sgl, sg_len, BAM_FIFO_SIZE); async_desc =3D kzalloc(struct_size(async_desc, desc, num_alloc), GFP_NOWAIT); - if (!async_desc) return NULL; =20 --=20 2.50.1 From nobody Tue Dec 2 00:25:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1C1E3009D9; Mon, 24 Nov 2025 12:12:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986345; cv=none; b=VKD5dxbhe3oyRK8riJRPvJxrfYX9+4FsNl/KUfGvSq8cdpofLh3K115bsq4zAckUbnOFjQD0srXxiwI64YBFD++hIf1aUBSZWuYqn3c7W4IJTAaDdVj0aHBfMZRSbRXICLKdjMd/jEVdaC4OmkPQZVFl1XwVsXRDiiAkARoZYp4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986345; c=relaxed/simple; bh=G7V9+SrifDGfqxju25Hp/oyxgo/fWf9zfXipYvZQzAU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hNsDcKSaOiZcasJ+wgISDQTsoFx5mTeN7+nGp+MehYVoGc/9/swx39vpG6yAjZOYYvLWTfZecEb8WCFEjjwAnu4rnWmWzHuRUXwhdAEBCbTqPSFNUil1Pc+glFVxsKph2gWVW5b0+7fAF8ADraSvdJXAZg5+cbZZZhz30mqBVkM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ObM8xmXR; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ObM8xmXR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986342; x=1795522342; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=G7V9+SrifDGfqxju25Hp/oyxgo/fWf9zfXipYvZQzAU=; b=ObM8xmXRYJZXoGByNHV+VHnw99j7kWwJBlFxNsR1ZKOFG414AzyhNhHj wRQHi3AFx11eUp5kVtytDbbXNSuFf/mJL+V40h6e11Xg04MumW3ahLciw T6B3Xjdn3tbV0q0jIsr+AN5YpjAg/8a8FUexJLT/A9yL+xUbIyTFnmIx7 IPwwm2252mosP/2/qkBdFUBccylAJ+qsVOz3Ix/fkmXXkaBHhRgs/Jd8g S6/N5qsJY1lYXkw230luIYtUQrJXcVshsUo0YCOgafuamByRy9Sritau8 7uJmS7Y4IR94/Oad6zREoAMd0YX8ffwiXOrCXsvNXju22APk0XKe+uLTf Q==; X-CSE-ConnectionGUID: UUYBMMjzQ/20RZxOB0sIfg== X-CSE-MsgGUID: Rp1o0W/SRNaj/ntoZhndPw== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="91467987" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="91467987" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:15 -0800 X-CSE-ConnectionGUID: lJ4Ysb5USrGqJ9huUsuiUg== X-CSE-MsgGUID: 0wSONVK7THiwWxrHksVtVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="192559575" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa008.fm.intel.com with ESMTP; 24 Nov 2025 04:12:10 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 78832AB; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 11/13] dmaengine: sa11x0: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:29 +0100 Message-ID: <20251124121202.424072-12-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/sa11x0-dma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/dma/sa11x0-dma.c b/drivers/dma/sa11x0-dma.c index dc1a9a05252e..86f1d7461f56 100644 --- a/drivers/dma/sa11x0-dma.c +++ b/drivers/dma/sa11x0-dma.c @@ -526,7 +526,7 @@ static struct dma_async_tx_descriptor *sa11x0_dma_prep_= slave_sg( struct sa11x0_dma_chan *c =3D to_sa11x0_dma_chan(chan); struct sa11x0_dma_desc *txd; struct scatterlist *sgent; - unsigned i, j =3D sglen; + unsigned int i, j; size_t size =3D 0; =20 /* SA11x0 channels can only operate in their native direction */ @@ -542,10 +542,7 @@ static struct dma_async_tx_descriptor *sa11x0_dma_prep= _slave_sg( =20 for_each_sg(sg, sgent, sglen, i) { dma_addr_t addr =3D sg_dma_address(sgent); - unsigned int len =3D sg_dma_len(sgent); =20 - if (len > DMA_MAX_SIZE) - j +=3D DIV_ROUND_UP(len, DMA_MAX_SIZE & ~DMA_ALIGN) - 1; if (addr & DMA_ALIGN) { dev_dbg(chan->device->dev, "vchan %p: bad buffer alignment: %pad\n", &c->vc, &addr); @@ -553,6 +550,7 @@ static struct dma_async_tx_descriptor *sa11x0_dma_prep_= slave_sg( } } =20 + j =3D sg_nents_for_dma(sg, sglen, DMA_MAX_SIZE & ~DMA_ALIGN); txd =3D kzalloc(struct_size(txd, sg, j), GFP_ATOMIC); if (!txd) { dev_dbg(chan->device->dev, "vchan %p: kzalloc failed\n", &c->vc); --=20 2.50.1 From nobody Tue Dec 2 00:25:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4427301461; Mon, 24 Nov 2025 12:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986347; cv=none; b=js8NP1ploLKdrVvBcNxMsTuZMQGy1UsOtm02/DnSh9/ySSWCcuqGdAusIYIcd2RQ3z06UUVSQ2qp3NGCuFSbHzVisoPCLeTuNLFqlv+bZyZ2SCSUjIkQZYAPmWDPKRMVdx6i/IYldzwbDD4K82kPsC9XJ2UEN61/3fiuBgiMTAs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986347; c=relaxed/simple; bh=3FTR/BGUP+Jif1zotbkvzWhNiBsBN/SOnlvS3OB5AC0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fEwQDBfLVefyBJLahY4V8RrZropYNR4sG0XcKkXtE8UuTNb6KvWXwSYI6k0m3IlDMFK3OELnSusBI/9b4Q/+Z2T34brU4SDKwW8VZKl1hPxPPf8FPbcRcP//36j0Xqw0tZVFHZ71oMy1EWq3VoTZFqANdOgEMPwYSUAT4/FaQRk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=eR5geAez; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="eR5geAez" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986344; x=1795522344; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3FTR/BGUP+Jif1zotbkvzWhNiBsBN/SOnlvS3OB5AC0=; b=eR5geAeziyW5kk+zUmueGfGCDrPnXPLxn96kWRkJ+rtHs2RtyKDHuR6P ZCUyLNhNNfcqNWv2YVx6DHTh21e3fu1Qnvv0A8oidSZeYt1iCoKIr4j40 XxZEWyz1uxyPrnfVx1tV4Cq/NaQJrkRyKmx9mHIVuH9WMLpZjPWoJdPQE HdV+8yaEt81xm7JkqeHqaz65NPhWWA1EnwULBwtBTgaxek5FsKa1+QmkU +ZxBqyJa4xLX4p22zix06RZADi9MWaBq4ZtK70DMe0cL0gdA9ADP3jiEp RuHzv7a+n8f+ugursT1chWsjVMtKKg/EGE57AoirhtEtrYZ108chfW7NP w==; X-CSE-ConnectionGUID: IdqESwU2TyeOJ0J6Ge13OQ== X-CSE-MsgGUID: tNhWYUcDT0KrQuzOs92xrg== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="69847624" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="69847624" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:16 -0800 X-CSE-ConnectionGUID: wKDEV3l3QqGEpZZVjkvI1A== X-CSE-MsgGUID: 1/09amQaRCCXpqw5buivZA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="222970347" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa002.jf.intel.com with ESMTP; 24 Nov 2025 04:12:11 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 7D9A2AC; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 12/13] dmaengine: sh: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:30 +0100 Message-ID: <20251124121202.424072-13-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/sh/shdma-base.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c index 834741adadaa..1e1b65e46668 100644 --- a/drivers/dma/sh/shdma-base.c +++ b/drivers/dma/sh/shdma-base.c @@ -577,12 +577,11 @@ static struct dma_async_tx_descriptor *shdma_prep_sg(= struct shdma_chan *schan, struct scatterlist *sg; struct shdma_desc *first =3D NULL, *new =3D NULL /* compiler... */; LIST_HEAD(tx_list); - int chunks =3D 0; + int chunks; unsigned long irq_flags; int i; =20 - for_each_sg(sgl, sg, sg_len, i) - chunks +=3D DIV_ROUND_UP(sg_dma_len(sg), schan->max_xfer_len); + chunks =3D sg_nents_for_dma(sgl, sg_len, schan->max_xfer_len); =20 /* Have to lock the whole loop to protect against concurrent release */ spin_lock_irqsave(&schan->chan_lock, irq_flags); --=20 2.50.1 From nobody Tue Dec 2 00:25:22 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C764274B44; Mon, 24 Nov 2025 12:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986347; cv=none; b=UaCUu0Mr/6rlyvgCD/bZdbZCMopjraabV7UI8clx8+ktl3DPms9Hxrxp5lrfd0VHaqwaB+OLOfuDe+zWfeya+RjWaK8v/o4NDyOTjhvC0K08IZgJknNLDZJvxCg3TNKpop7N78ZN61H+ypFfiusXSmb/yyEf5k0ArDSySlR2/4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763986347; c=relaxed/simple; bh=rUyODX56g/0PVw4q9uoPm3QtJgx5W1kE7M9udwy7iHM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b3J/dxBjXKudqj2F0BJQ5r/ScQv13Muje/ZSE2ZsmtspaWEPOxCZxkXWzFWhC2QQqLzWWDi+cNp5ya8PlqXBLLxd8tBiuSOd2ERRXlnabZhVgXJBXnb4tfqSb2iAVne/wR7pks57QernPYLaJ0F7h763pl7PvO1KP6EqAUMlWiQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=galhEHDn; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="galhEHDn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986344; x=1795522344; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rUyODX56g/0PVw4q9uoPm3QtJgx5W1kE7M9udwy7iHM=; b=galhEHDnjfXG40zzvZRcs2D3MScSiPhCEpdqa7syjorB4CpGkCOKFaBC YTWaAYCga/iQ3PvXR9gPWO+oYKyJ8GQg6Xc2UInY4xyHUJsfPgMIlFWML poNeQcPm2w0kTqtYf0WRbZef1v4heo9ZeYtvNhMS1uW7RMC6HRAv8f3v2 RxmSK3AdmmmdmPFHlBRP4oQ5XhAn3MzVejiUIujIOEuA+AhSOECOQo7Ig RecUsTifwUFS205AemPXR73z8xu9ZraWfyGhaU4ZSEQE3UyuERZSzv1LB I1lujMMxODieoxL/XRIBPV1iMHZJcHtCzitM4F33WWCKB+MduY8o2fSmy g==; X-CSE-ConnectionGUID: /YQ7W60fSlKwg1Hw5rBduA== X-CSE-MsgGUID: dk5SjVEQSQa+L4/aQKlWWg== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="91468005" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="91468005" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:15 -0800 X-CSE-ConnectionGUID: nnXj4wckTvi9keb5yZ3x/g== X-CSE-MsgGUID: 7CI4VqycQDKBM7yw1yp7Tw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="192559576" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa008.fm.intel.com with ESMTP; 24 Nov 2025 04:12:10 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 823E6AD; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 13/13] dmaengine: xilinx: xdma: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:31 +0100 Message-ID: <20251124121202.424072-14-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/xilinx/xdma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c index 5ecf8223c112..118199a04902 100644 --- a/drivers/dma/xilinx/xdma.c +++ b/drivers/dma/xilinx/xdma.c @@ -605,13 +605,11 @@ xdma_prep_device_sg(struct dma_chan *chan, struct sca= tterlist *sgl, struct xdma_chan *xdma_chan =3D to_xdma_chan(chan); struct dma_async_tx_descriptor *tx_desc; struct xdma_desc *sw_desc; - u32 desc_num =3D 0, i; u64 addr, dev_addr, *src, *dst; + u32 desc_num, i; struct scatterlist *sg; =20 - for_each_sg(sgl, sg, sg_len, i) - desc_num +=3D DIV_ROUND_UP(sg_dma_len(sg), XDMA_DESC_BLEN_MAX); - + desc_num =3D sg_nents_for_dma(sgl, sg_len, XDMA_DESC_BLEN_MAX); sw_desc =3D xdma_alloc_desc(xdma_chan, desc_num, false); if (!sw_desc) return NULL; --=20 2.50.1