From nobody Tue Dec 2 00:26:33 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 667682F1FF4 for ; Mon, 24 Nov 2025 11:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763983253; cv=none; b=QrlN5O+rv1zCuleQT+6L4f2ZeuvqLoVUeRy7SNGxfx3qhnsAWJWqnCEeX6HzqfjQwVJBHiXpnD5ervowt69dYhzuxBgqC6v87qFDam6/mfKq6FkL4szYPZVFxGgJPbPvS/k26/5nquL2FU1niYsacPZJZitZ+7CEiOqkl4K6LVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763983253; c=relaxed/simple; bh=ovMJMXjdfvLuRO1hcVMqtSMGA0xweX57QtqswNr2sGA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=A4Tutkh2n/niKxl0kzMPe7bSrKUKSbd6cvpH1KLEaDQykdntVMCs9di7cXd5dndzn9XMDOLzfs0ld25kvKEJ+va+GvOdok2LkP3oiVGH9Jq+F0EWbeava5q6JiZEHx/hRIL/UhvJWlN1RNksgUTbFdkJqBT8W39U67HZ8GMoqas= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0DE12497; Mon, 24 Nov 2025 03:20:42 -0800 (PST) Received: from e122027.arm.com (unknown [10.57.74.238]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5B0473F73B; Mon, 24 Nov 2025 03:20:47 -0800 (PST) From: Steven Price To: David Airlie , Maarten Lankhorst , Maxime Ripard , Simona Vetter , Thomas Zimmermann Cc: Steven Price , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Andr=C3=A9=20Almeida?= , Tvrtko Ursulin Subject: [PATCH] drm/gem: Correct error condition in drm_gem_objects_lookup Date: Mon, 24 Nov 2025 11:20:38 +0000 Message-ID: <20251124112039.117748-1-steven.price@arm.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When vmemdup_array_user() fails, 'handles' is set to a negative error code and no memory is allocated. So the call to kvfree() should not happen. Instead just return early with the error code. Fixes: cb77b79abf5f ("drm/gem: Use vmemdup_array_user in drm_gem_objects_lo= okup") Signed-off-by: Steven Price Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_gem.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 68168d58a7c8..efc79bbf3c73 100644 --- a/drivers/gpu/drm/drm_gem.c +++ b/drivers/gpu/drm/drm_gem.c @@ -798,13 +798,10 @@ int drm_gem_objects_lookup(struct drm_file *filp, voi= d __user *bo_handles, *objs_out =3D objs; =20 handles =3D vmemdup_array_user(bo_handles, count, sizeof(u32)); - if (IS_ERR(handles)) { - ret =3D PTR_ERR(handles); - goto out; - } + if (IS_ERR(handles)) + return PTR_ERR(handles); =20 ret =3D objects_lookup(filp, handles, count, objs); -out: kvfree(handles); return ret; =20 --=20 2.43.0