From nobody Tue Dec 2 01:07:42 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 688452FAC14 for ; Mon, 24 Nov 2025 10:28:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763980130; cv=none; b=GwU7mlqSfkGjbrttdTPrHNK9WXStrN2zieGOaOxDaogCAX5uJ6ZhFu97Mx9cZzRB5i2jXUzxmZfAf5/ImDxQet17G35PxaX0O5xHrTJnbMEkrh0Be3Lyk1a5hnogbm6g6EaJOrEUM+0Xagg5jpB6X0ib/SGYfDPSW24kYD9AJU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763980130; c=relaxed/simple; bh=rPyNl3IXKetzOLBOyKPO8g0EGzeg1E0yIt+StmCCebY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bgR14SA57hoc5JTwNEMBurwaC/ku8jeunVGr39Y+P92TVH1uVzk2gDZO37aZYbby/d5HAPfJWfqC/b7MFaqkq3YZhiS5XmHHBOn3e4cTrDz9Cr94mfc6bnu8MgECQOZK3UhP6g+GsBA2GKCuI0EZheoXBtkdpG2egvkC/5ztQ4s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cVh2Exk0; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cVh2Exk0" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-477a1c28778so45525565e9.3 for ; Mon, 24 Nov 2025 02:28:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763980125; x=1764584925; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WgtID0nFX3nGFRlE1VlQTXM54bzqiyChn12CU60+xHU=; b=cVh2Exk0kdpfHBpQzoRTAAoqyObCeHVYdZEaR0HVcowQPhVc97J5zLWVx5EYn8sVwS JBs9LVSyd2bDukM5lIKj+ciA/Dw6TBlmD0u+AEPWT1YmDlRguKHrg7G0sNj5nZ6+R6UZ k7ToFbUaZQD5BHbyOXjMRAmI+rL6Y8AWVfsC1l1/+6WlqXc/lfxHfrcDxb8WgHgQnoDC XJSk6aKTYNnpS2FSHGaGvgzMSe8hWYH2NV5atjHbfp/iGLWrbxAqMCC3BwLKaCivxsQ6 7VBjWB5v22GMT9gzYYJJ8TZCPqPB/eNWNH2YM9TEa+MQkggrvdbnxLoFyShKXCVRl5XU YMug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763980125; x=1764584925; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WgtID0nFX3nGFRlE1VlQTXM54bzqiyChn12CU60+xHU=; b=UNUXKQumxxKWB9FKV17Htg/cJjrNKT1ZnF2NUp+RnC7jyvxzqIPth4vcbWgaCKB6/A W1PfLJA4qLY+AyHlerqpJecKcQYmA0ierc4DWX96k7T2fPnnamh5w65J5P2z9KIObCIG R7eN+a5EjW9SKKwhLlXNJ3OwjIZUNVo+QNofStYA7M/wjRk3laQcq1l2fgZpR2QAbDxU fX4V62SBUs45UAGFRNWbcHgffseeCIFGHXbVpBQIj39AsZlyFWABhtogSxKdhxtw5Rtb GOiF5HjSXewONQiB0txfQbIzeor6phexzqFU/uqhkxVJwXTFDrcGqcFLfBKArixsUCUT 1O0w== X-Forwarded-Encrypted: i=1; AJvYcCUxwQ9uiKzgxpXiUfoTJ3oXxUUu6ws9aax/xpecpmQrsn/2AETue8EGp4X5lC/9zLsEF+jyCDiTVcm0Mrs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywf5NGY+n9bTHJNJn1K75/HgjohCMUtEF00HXuksIPv2y2Nf0BX h3BeXnWY7YDLdeT0cK4Wk0Tl5kkHBxNM7s+y/+8t+Q3nHDP932MP9rHq X-Gm-Gg: ASbGnctNE1x720jTo9tHwKFGYLQhDGk7YP3eIs+dvI/FjZcGex9KpY3rLG8MFFje8cU LGmAvwV0j1M9V0dm396KIuGp7fm+nBYiq8a3rLllECL1D4k0gB7WD4zJyJmiPVu+gB05l72fdgM M8IorUlQ9p1CPXdyWD1TCKDbc/DERlGpkUQUV2uOVB8rEJ+W3CdBj4lL7/dO03nsuvjRAa13dQ9 VZqRCwTAgFIjcKVp2wFuEk7EY2esN2a8sG/R3st6DTU8zIAK59iaEt+N6tz/aGooFJj+DZz81WR spZGyAaTBYPSQkQetMIiMZSUSEtNUA8Xv/9WMi5LaPW+XWjHiv8PshNoCsRAZWNqXWsGOC1NlTs nE99YmltMfr0rQH7UPDLVXhy8ZsG1SUlYVVthZGfa51hvfp63JDPtUnX19qH5oFdiOWy4TBTZqH Hyeq+M+d8YY5MGqb62ALkGqpfgDym8JwGKJa+8M7JTcTeXOZnYrPIixwo8uMeiz9lFeDcfMUKyE m7dtjTr+yMsnjB6 X-Google-Smtp-Source: AGHT+IGyTyi4ltNsVDvmhl+/roG3AiodjJTRXbT98h+eS1FAwZ4STCcD5g+TawJPyCHRDRFgKtjvvg== X-Received: by 2002:a05:600c:1c0c:b0:46e:7e22:ff6a with SMTP id 5b1f17b1804b1-477c018a099mr148973035e9.15.1763980124606; Mon, 24 Nov 2025 02:28:44 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf1df334sm186753945e9.3.2025.11.24.02.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 02:28:44 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Marc Kleine-Budde , Vincent Mailhol , Geert Uytterhoeven , Magnus Damm , Philipp Zabel Cc: Biju Das , linux-can@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar Mahadev Lad , Biju Das Subject: [PATCH v3 7/7] can: rcar_canfd: Add suspend/resume support Date: Mon, 24 Nov 2025 10:28:32 +0000 Message-ID: <20251124102837.106973-8-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251124102837.106973-1-biju.das.jz@bp.renesas.com> References: <20251124102837.106973-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geert Uytterhoeven On R-Car Gen3 using PSCI, s2ram powers down the SoC. After resume, the CAN-FD interface no longer works. Trying to bring it up again fails: # ip link set can0 up RTNETLINK answers: Connection timed out # dmesg ... channel 0 communication state failed Fix this by populating the (currently empty) suspend and resume callbacks, to stop/start the individual CAN-FD channels, and (de)initialize the CAN-FD controller. Signed-off-by: Geert Uytterhoeven Tested-by: Biju Das Signed-off-by: Biju Das --- v2->v3: * No change. v1->v2: * Collected tag * Fixed the typo in error path of rcar_canfd_resume(). --- drivers/net/can/rcar/rcar_canfd.c | 53 +++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_= canfd.c index 5a555b01ffbb..4a653d8978ba 100644 --- a/drivers/net/can/rcar/rcar_canfd.c +++ b/drivers/net/can/rcar/rcar_canfd.c @@ -2278,11 +2278,64 @@ static void rcar_canfd_remove(struct platform_devic= e *pdev) =20 static int rcar_canfd_suspend(struct device *dev) { + struct rcar_canfd_global *gpriv =3D dev_get_drvdata(dev); + int err; + u32 ch; + + for_each_set_bit(ch, &gpriv->channels_mask, gpriv->info->max_channels) { + struct rcar_canfd_channel *priv =3D gpriv->ch[ch]; + struct net_device *ndev =3D priv->ndev; + + if (!netif_running(ndev)) + continue; + + netif_device_detach(ndev); + + err =3D rcar_canfd_close(ndev); + if (err) { + netdev_err(ndev, "rcar_canfd_close() failed %pe\n", + ERR_PTR(err)); + return err; + } + + priv->can.state =3D CAN_STATE_SLEEPING; + } + + /* TODO Skip if wake-up (which is not yet supported) is enabled */ + rcar_canfd_global_deinit(gpriv, false); + return 0; } =20 static int rcar_canfd_resume(struct device *dev) { + struct rcar_canfd_global *gpriv =3D dev_get_drvdata(dev); + int err; + u32 ch; + + err =3D rcar_canfd_global_init(gpriv); + if (err) { + dev_err(dev, "rcar_canfd_global_init() failed %pe\n", ERR_PTR(err)); + return err; + } + + for_each_set_bit(ch, &gpriv->channels_mask, gpriv->info->max_channels) { + struct rcar_canfd_channel *priv =3D gpriv->ch[ch]; + struct net_device *ndev =3D priv->ndev; + + if (!netif_running(ndev)) + continue; + + err =3D rcar_canfd_open(ndev); + if (err) { + netdev_err(ndev, "rcar_canfd_open() failed %pe\n", + ERR_PTR(err)); + return err; + } + + netif_device_attach(ndev); + } + return 0; } =20 --=20 2.43.0