From nobody Tue Dec 2 01:07:41 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F1F62F9C3D for ; Mon, 24 Nov 2025 10:28:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763980129; cv=none; b=D46F6sIKvq4ccvHjdcoz2rULZ/jD6SUbYGy7IdS3Yr/r+42NY+65VSl4TqFXez7Nksqu/IKzSYbvoBTH+AZckK+92A9G2bNK5rQIAjnuWf6+2kUfCooDJDBdX0yjIDqqUPKaMQMo/KMHt2mmfKsP3advBN80v/zJdBW0oenMr4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763980129; c=relaxed/simple; bh=25AN4XiGc6CZ1SMIZ0IBj9ec9hPtrhDC/hZ+f8Nm1lw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LX7oAHfhrqU2FeRcv95RiOwxVmot7+9jr/jLxzsik92D82exSX8hthSizkI8njVLMFvQB6ZCO9cxZGpAn/Z4YBcgeQ3K1LK8SRtXN5vBTYxLC9bpZjH4imZ0qOtEil7DNnm19uL72hXlPrEi5P5y1ZNEJFoYGqqlMsyDnaeUKnQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nYAPVDiS; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nYAPVDiS" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-47755de027eso21513305e9.0 for ; Mon, 24 Nov 2025 02:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763980123; x=1764584923; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5VPGo5U/iXGFhSlRJsPXDRX32fruUCYMsM5nvll/4Kw=; b=nYAPVDiSTAIK+quKuIvU/mHI4U3/TKAogrZ3Upc+SzJSgIrHZNg5s1Q42FA/tovaDQ bQvpzZeszYW/Qrky3+43PaMtBaW/TfTAezz5DtsuYTTP/s4ajrnhbVr4EAFcgCc4OTFN lanpazHKpRh+8+5zj1Vl4it2GnsAj0OARnyFBdDpteWMLkXIKkWvegZTpd68wbg/A6vI DAg8DDjzJXaoafwxPbRBxUD5ttBNN0s9xIcl+V+dzQjX4LiEcE6RTyOGmIduytqXF1/S zhNaNrGSYifFAyGKDceCR1HvtVRNDc94g9KCelyeAvNcd0MybM8UhTl86ylYHbvPOZrB Aoyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763980123; x=1764584923; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5VPGo5U/iXGFhSlRJsPXDRX32fruUCYMsM5nvll/4Kw=; b=PZ8A96620I8SnrMeduTyTI4FGmXg43Ev7cK4rTAVFnIcEWzTSerXgNVtF91ondQG/j QRAlGIQWFaHAKqc5+1l3euw0jlRPaOlFRzBhRS6wxQJuStoQ4x1RlQAt7JzOlUq5jMgX QUQ4wav/IOuT965c56zWjz6FnnZiXmwhtER/NPJPmcNJh8r4foKQ7zjH5XhsWtoMo4Tc xlNxtsjqRXykvru73KeLrmiG37XvryPP+NQ4VdgxHqIjAqR75A/1ym7yOrf+Ne61J1/I o3pDd1ozoNmzMcSf9QyHTsRfuqWCxRcJbiRUro3mm8NO/0ZeTolCT0UghzGT8AdhToFl l+Tg== X-Forwarded-Encrypted: i=1; AJvYcCW48N2hLXOtJ9kVciozGdNyKDejl0C4I03TImHXdFLjZbUdTe32DUPjX5zHnI7fj60IB+TQQ//SLywz8Dc=@vger.kernel.org X-Gm-Message-State: AOJu0YyZsidIF2AWQ0VHnyOBgklR87ndTbYaSN7erWBK0m1Oq9QAGyjX vAlPa7PjhVX+x6dArOTQUvJgRx+7z7IDclMFZtgRyACpP7tryFXHxlBI X-Gm-Gg: ASbGncuT9FgfK6HsLjyxEc8IYulGPtop4T7tD8+A7MJcX/r3Fm+JjRtWd6Y20e7PDaP 3ZzWXPI3fGxzZEgRZP2agFBNHn+Bgv7SyGkXQENaJvlTyykNl0oCEBt8n8WTt+orv+hIIMuxS4j Y5465b4yTdP+w/OJWZximfGfksarNd1PWl99H7NgYMB1HCYV520h1SnQxLg3Ux0+LYr/V3tS6T/ qPUaee6QRfnyJLUCObkradBLz56KJOLbY9UFbQlEmlI/2x7OOAF+27vi2u/NNZ2lDHF4y3yM25w UjofDk/0QcNZ8I1qR8yS5SymNbNvqw6SiJ9Ym5PpIL12mTnraq1oQPVBMRnAk2MlO+UphzwtJNc p/rH/unmrFcjQnntk6DgIxYt7+lK3gfnZKzJOnc1LUm4eQ7Qbff2OD1Ciej+mBhHNCQHcfUJNd6 O8GmUgV0AOX5ANul1jNQsN8b/EJlyRkLCfVUPDHw1NjwPWlDFf+vZp4z/zWGb9mPwHD6nqUAx5M mwemI1OPJwc/Cuq X-Google-Smtp-Source: AGHT+IGPyNSAkUnNNLh90REio7RQidDo1QlxOrR1JlpAc2ox428h/ljqAzuZmEq2S0sQiaTFD1UHMA== X-Received: by 2002:a05:600c:1c24:b0:477:76bf:e1fb with SMTP id 5b1f17b1804b1-477c01be2b2mr148615015e9.16.1763980123429; Mon, 24 Nov 2025 02:28:43 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf1df334sm186753945e9.3.2025.11.24.02.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 02:28:43 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Marc Kleine-Budde , Vincent Mailhol , Geert Uytterhoeven , Magnus Damm , Philipp Zabel Cc: Biju Das , linux-can@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar Mahadev Lad , Biju Das Subject: [PATCH v3 5/7] can: rcar_canfd: Invert CAN clock and close_candev() order Date: Mon, 24 Nov 2025 10:28:30 +0000 Message-ID: <20251124102837.106973-6-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251124102837.106973-1-biju.das.jz@bp.renesas.com> References: <20251124102837.106973-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geert Uytterhoeven The CAN clock is enabled before calling open_candev(), and disabled before calling close_candev(). Invert the order of the latter, to restore symmetry. Signed-off-by: Geert Uytterhoeven Reviewed-by: Biju Das Signed-off-by: Biju Das --- v2->v3: * No change. v1->v2: * Collected tag --- drivers/net/can/rcar/rcar_canfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_= canfd.c index d77d28d0ca6b..2f9fc0da2d1b 100644 --- a/drivers/net/can/rcar/rcar_canfd.c +++ b/drivers/net/can/rcar/rcar_canfd.c @@ -1588,8 +1588,8 @@ static int rcar_canfd_close(struct net_device *ndev) netif_stop_queue(ndev); rcar_canfd_stop(ndev); napi_disable(&priv->napi); - clk_disable_unprepare(gpriv->can_clk); close_candev(ndev); + clk_disable_unprepare(gpriv->can_clk); phy_power_off(priv->transceiver); return 0; } --=20 2.43.0