From nobody Tue Dec 2 01:07:42 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EB482F3609 for ; Mon, 24 Nov 2025 10:28:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763980126; cv=none; b=dRho/9g3lfoWhtzVtxgiQ/hE62mBiLwSSpN5pSAt10AnhxThzKrNiyOFPX3A+ZdrGI//IeiHIgx5U5XNU7B9xPKAxZYmefF0EoR47n3G/64AMIoDUnGyx3ETXRLtlCFuh4GQXRc2nBrcoOmMBPEjmgApGINuCXk8/D9tdlSDPMs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763980126; c=relaxed/simple; bh=E/A8VrtH51z0lvb8lkMZcyZT4EdZZmFfF1gv521yMRM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e5TFFb3IBcNQ6dKTuKJefSn+C9S1NXd6CsU64WK7MAs6wtqF4LYc9OThVhA0guhj4VCns7IjNv6Z4dpsW7yg4VQDK9K7eRcNfpccZLsWLVaRz5qn0tINIucMvXzpFnxgiPUzPHeKZmUPIBrz85vDH/pYHllrGHNJ8/vrlIYZj0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YvXfwvqj; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YvXfwvqj" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-477a219db05so24460835e9.2 for ; Mon, 24 Nov 2025 02:28:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763980122; x=1764584922; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P3EGBpm7Z4624Ma2B0L7glleYByz0KLJbb7xFZAvoyY=; b=YvXfwvqjP/+/OCgDTLh4SvzDBHzl0JW86ZFdJ14cOcLyYl+EBZmzJSh1mr3GnLWkDK T0DSRIMESVYClMy+On5LN+3ifBuyGQQN9dIFBtaHhuU5WBoPThxQrSIAzBwJ7cBIM44G f7fJSTpoGAqlDXhYy0PxYY/XHScpatkOC4iSS2InGi4XOFQFuyPatABWMIrwV9pHTF0d dmFQhN45+tHFX/4pn5v2CxC1RY60ai2E2nOwJ96eUpCUmPKanlMMc3SY43zb5FTdDHQm z1IHjUQMIKikgMFR0JtU+r+qrWYPVfycNDYB2LUArzXg2EI4VaQrG33YZZhxkGFpDtYr 35dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763980122; x=1764584922; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=P3EGBpm7Z4624Ma2B0L7glleYByz0KLJbb7xFZAvoyY=; b=NYLgpnqMUIobVrnuk9caCTwF1hvbhow+Pqvef+mlwqPjMCowXmJ5H7JpMe5wvxEwLi KGWOe8Yc17lECdvhAXMdfV4HYbtrKJR+kw3UJfzBcx3s/KRMS8u3okaElOqQUGAs++Qd vw01Aov1BxMHrbarOe3swOX5vMrN8Se1zqxUDwr+v6NRfOsN0H6LvDzfbGMCIwojBjtS 2nl2oPmNg7/jGXvILdYUov4ez6R2ovqk1IlY3G7DiuvJnLuBQ4GxWLGPFwcwtvqD6OdZ ABNNMnjav0CMJviwZrWcGsTfgKzpO4zTU3PnTseMapcuaDXIFeQQjhTp+9cD9Gs8lDoD yXAw== X-Forwarded-Encrypted: i=1; AJvYcCXhZmWRMIejomwhgUoxa7w+v7SACdkjCPtz5WQxngxuOxozSDxWHwR4Q2VyeMLR6kE1pMtk0oMgK4Hf7pM=@vger.kernel.org X-Gm-Message-State: AOJu0YxYPeUV44a+88H4EbXnYJx1SRjY/m11ztlZPOFeiN2R4GtqTMqm zZ1NjKuiwcvZVvie5MZp51G6E42ZI8jcqVLBKzmn2wye5b9iFtXr3z6p X-Gm-Gg: ASbGncuocWFrI5sgY2WJ9+Bl/0pNFrqTK3Er52/VCQEKOoa9AEIgHZJD+FuqfYQ/UDD kIQTGQZLZoK4dPoxAqg8wp2fhmKc0FodidmtcZC1TmmfYd9NC2RIZLgXNM6+wid54vL0NvG2+dF 5AheU9Li7PBofduuBBKGQdqRTKAetN75dE1mA6WoR12bn93Mz3uNPzAbkP832FjMFf7QGBFeQ7D JN9IrmNRL4Mqrag4vfajHizYyN0eGGI2f/Fm+0+pxBVNYL4Cvr06FJY8ojNbbgi0dUZWptnpy7V sCgvl5py7ESKIs3DlO+REQ6/kaUDMOf3b0a5Iu0E5HHWE1IcBvQmgYkoR2AAH1iTNn0pGSwLqL5 T/D95F3ZomFZdYdhKlxsgBoEdVhRzWx7Rlf8/+frCbNQQUzJRxXQv1XS2UGm/m1vjG6cqlvICVM CxED0aZN9hL0mSZ5c1KAR5eyLHKEwA/YCr0OS1Q+3JTzmJmOzV8R+QkDCOEfub91uN7iBTfYnre HNtNlRQuwWo6R1ASrSrHCzFKTA= X-Google-Smtp-Source: AGHT+IFpGKBj0WQRrF358OhLtccWrXcXV0btkWFGpcKOuCTzthrxs/C2CByHNJsGuuLvUcAyiaXsyQ== X-Received: by 2002:a05:600c:310f:b0:475:de14:db1e with SMTP id 5b1f17b1804b1-477c1125568mr131901425e9.24.1763980122229; Mon, 24 Nov 2025 02:28:42 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf1df334sm186753945e9.3.2025.11.24.02.28.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 02:28:41 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Marc Kleine-Budde , Vincent Mailhol , Geert Uytterhoeven , Magnus Damm , Philipp Zabel Cc: Biju Das , linux-can@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar Mahadev Lad , Biju Das Subject: [PATCH v3 3/7] can: rcar_canfd: Use devm_clk_get_optional() for RAM clk Date: Mon, 24 Nov 2025 10:28:28 +0000 Message-ID: <20251124102837.106973-4-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251124102837.106973-1-biju.das.jz@bp.renesas.com> References: <20251124102837.106973-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Replace devm_clk_get_optional_enabled()->devm_clk_get_optional() as the RAM clk needs to be enabled in resume for proper operation in STR mode for RZ/G3E SoC. Signed-off-by: Biju Das Reviewed-by: Geert Uytterhoeven --- v2->v3: * Collected tag * Updated commit header and description. v2: * New patch. --- drivers/net/can/rcar/rcar_canfd.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_= canfd.c index c03e8dff6a20..a127c0845a3b 100644 --- a/drivers/net/can/rcar/rcar_canfd.c +++ b/drivers/net/can/rcar/rcar_canfd.c @@ -468,6 +468,7 @@ struct rcar_canfd_global { struct platform_device *pdev; /* Respective platform device */ struct clk *clkp; /* Peripheral clock */ struct clk *can_clk; /* fCAN clock */ + struct clk *clk_ram; /* Clock RAM */ unsigned long channels_mask; /* Enabled channels mask */ bool extclk; /* CANFD or Ext clock */ bool fdmode; /* CAN FD or Classical CAN only mode */ @@ -1993,7 +1994,6 @@ static int rcar_canfd_probe(struct platform_device *p= dev) u32 rule_entry =3D 0; bool fdmode =3D true; /* CAN FD only mode - default */ char name[9] =3D "channelX"; - struct clk *clk_ram; int i; =20 info =3D of_device_get_match_data(dev); @@ -2086,10 +2086,10 @@ static int rcar_canfd_probe(struct platform_device = *pdev) gpriv->extclk =3D gpriv->info->external_clk; } =20 - clk_ram =3D devm_clk_get_optional_enabled(dev, "ram_clk"); - if (IS_ERR(clk_ram)) - return dev_err_probe(dev, PTR_ERR(clk_ram), - "cannot get enabled ram clock\n"); + gpriv->clk_ram =3D devm_clk_get_optional(dev, "ram_clk"); + if (IS_ERR(gpriv->clk_ram)) + return dev_err_probe(dev, PTR_ERR(gpriv->clk_ram), + "cannot get ram clock\n"); =20 addr =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(addr)) { @@ -2155,10 +2155,18 @@ static int rcar_canfd_probe(struct platform_device = *pdev) goto fail_reset; } =20 + /* Enable RAM clock */ + err =3D clk_prepare_enable(gpriv->clk_ram); + if (err) { + dev_err(dev, "failed to enable RAM clock: %pe\n", + ERR_PTR(err)); + goto fail_clk; + } + err =3D rcar_canfd_reset_controller(gpriv); if (err) { dev_err(dev, "reset controller failed: %pe\n", ERR_PTR(err)); - goto fail_clk; + goto fail_ram_clk; } =20 /* Controller in Global reset & Channel reset mode */ @@ -2210,6 +2218,8 @@ static int rcar_canfd_probe(struct platform_device *p= dev) rcar_canfd_channel_remove(gpriv, ch); fail_mode: rcar_canfd_disable_global_interrupts(gpriv); +fail_ram_clk: + clk_disable_unprepare(gpriv->clk_ram); fail_clk: clk_disable_unprepare(gpriv->clkp); fail_reset: @@ -2234,6 +2244,7 @@ static void rcar_canfd_remove(struct platform_device = *pdev) =20 /* Enter global sleep mode */ rcar_canfd_set_bit(gpriv->base, RCANFD_GCTR, RCANFD_GCTR_GSLPR); + clk_disable_unprepare(gpriv->clk_ram); clk_disable_unprepare(gpriv->clkp); reset_control_assert(gpriv->rstc2); reset_control_assert(gpriv->rstc1); --=20 2.43.0