From nobody Tue Dec 2 01:07:42 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1C21270ED9 for ; Mon, 24 Nov 2025 10:28:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763980126; cv=none; b=YF9o0WH5hp6Z6uQrnHMi3idRuQBf5dRk0kt64vAnPEG8al8+7hYgcfzpWvygYg6NeHrdAVkGpXMIH9m+cu28dwaqUuwK/7nO5K3shM1+25STSwJqoxu7FsyikVL/ZDXL9MnZfx3NUwoN7XWIwDAqJYVHG0FlrEq28h1e/erA7a8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763980126; c=relaxed/simple; bh=3+nnF588T378GBA+9QQgUACjWK+jYS7zewBllPyBRO8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DDRvOcyvHwc9xoSLcxJw/II3OUIMpmpiCdNBClmLiMHssijPUswgP0yU9pfyZphoatjSkWiE//1eISXTWDqn+CIVXA4L/6fiqPSL/BG+OkK6BvsOds+YHW+B5WS3jxI0GgPuaNBByrHvLfyRUkQda2YI7e1X6qVSV2qlOmTHPAg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EC+gxzE7; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EC+gxzE7" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-477ba2c1ca2so42573095e9.2 for ; Mon, 24 Nov 2025 02:28:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763980122; x=1764584922; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E5oBZG16/wN6GG9AM2JpUrMbboYKvUgGXIP4x48mO+I=; b=EC+gxzE7haF0S9RkQtrNX6HqYjPMR1G02Ts1FT7iyQ+S/mwxsk+ZCAYouuoWDmCgzA csP2hDwyZ0G5ri1+9MRJYnNYC56SSGbZObvP6iSO2KZrY2sP+6GcyIT0uwd1omY1RvHw y2C4aHx+AK+k8hKR6oyDO4lPVmCqqfTQfreWndATg3gbzmZjOlzvf9RxyTkJ7QHVUtgS CaRjDUqesHlIKWC4EHPUlLrsDavSpw9uPUkhnC/kHO0T4sknFQR9mGRjAQGdNnnzF6VM gR53s3PWM7R4fnScWOkKDZKN+n3t2BDLMEkpdz9C5s5n8PfSA+a5C+rrjyDVWPCp70aK nOmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763980122; x=1764584922; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=E5oBZG16/wN6GG9AM2JpUrMbboYKvUgGXIP4x48mO+I=; b=pRHSbH4VBZaSb1XNYth/eussKiz/5oYvYEA1o4VJhHS0lqqjHyAHV7wJrnx5Nt9Qzm TUn5Qksk96fdzaujxuXxHQBlOEhHDyoVDqAkSZapTgrtikBNPw28TX+PQxXV1ICyhePs xTQ8cALC9O7RcCkZB+9rK1KwTPZpiwTRi51ss0V0R8aT8i6QtDAh2bcocq+nDbYHPFgu 57S0YHkGDhg5PhtuihhmRsZIeKQWn+qDcIr1Y/2zMOwjlFMENOno9nFI1EdsxTi+U+0o pc6bE9909Z1Sj49h+dtWpUgqpduMuzNweQobp7AoN0wiVJJ2r6UvpykP8bxycEVFOIki MAwA== X-Forwarded-Encrypted: i=1; AJvYcCVBCkqRaTWsV6woTiaa9GSbOK4LYBb1ba+cv5FbWVGiBlZWL5rgCowvPPTh4G7/MPPwbwpBJ2PbyyqzqyM=@vger.kernel.org X-Gm-Message-State: AOJu0YxoscN2OW3SSPPhvKA+sPrzAcG+gTKr+2O/5ErWqwgb5iZG1BiE ad8YrL0NEUs6+NgmfsKz2KUmmNCQirbx9ly6CejQ+KfuBnO0vH29ux64 X-Gm-Gg: ASbGncsOEVcT8/Ty6T166FUNADen2ZfZwqZEQokD09kpBa1avFaYZkP7ykqJMq8Mh5P kWAfIlTKfDv4ZmuVS3PwJIt1zZeE6W80yzCVTSIlkGDJjv5MEan+cFAuFNqGumWho+hFlyPF7Wd +gQHI1396OO60EIBwlS2l4U293Y9iMboFZxJUWzQ6AIKgFY4nHdxqiwjrfPMcH2He/vaMI/e0vn G3dmGgCAaNbW4HBz/P7LYclJIdyJtLAcjLKIlwF8OQVsbcMcGhok2yA+GGGyZaaewx3wmRxRoqq bM9Kkn5xEczVPpsZ+yKIN9Q7K3I7nSiJSZDNDY04p+/E9y4KZn+/uA3qYdIU5XuZ13Mo9Egkhna Dj082zEozGNzZVVX3koIgppctq1JmFfGDu7bzEzyNnZbJYX3qWg8PWn5jd7oE04aPOPxudryO2Q wWcd8iimj6XmtBtr+AE5s9533LHNkL5+LBEb0WYwV1UJfjJfGFWu25ttLCLjCq9oeH9xgl2nRID IZH7Yjb0RGUZn/t X-Google-Smtp-Source: AGHT+IGo1CVZwZ/FAWJme7Zy+9NRmnO4ycz8303KaODH2VEd772twsOxKeh/e9ysRmPRF1JNLoWrmg== X-Received: by 2002:a05:600c:1381:b0:477:7a95:b971 with SMTP id 5b1f17b1804b1-477c01f55damr116622105e9.31.1763980121578; Mon, 24 Nov 2025 02:28:41 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf1df334sm186753945e9.3.2025.11.24.02.28.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 02:28:41 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Marc Kleine-Budde , Vincent Mailhol , Geert Uytterhoeven , Magnus Damm , Philipp Zabel Cc: Biju Das , linux-can@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar Mahadev Lad , Biju Das Subject: [PATCH v3 2/7] can: rcar_canfd: Invert global vs. channel teardown Date: Mon, 24 Nov 2025 10:28:27 +0000 Message-ID: <20251124102837.106973-3-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251124102837.106973-1-biju.das.jz@bp.renesas.com> References: <20251124102837.106973-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geert Uytterhoeven Global state is initialized and torn down before per-channel state. Invert the order to restore symmetry. Signed-off-by: Geert Uytterhoeven Reviewed-by: Vincent Mailhol Reviewed-by: Biju Das Signed-off-by: Biju Das --- v2->v3: * No Change. v1->v2: * Collected tags. --- drivers/net/can/rcar/rcar_canfd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_= canfd.c index 6098a3eebc43..c03e8dff6a20 100644 --- a/drivers/net/can/rcar/rcar_canfd.c +++ b/drivers/net/can/rcar/rcar_canfd.c @@ -2224,14 +2224,14 @@ static void rcar_canfd_remove(struct platform_devic= e *pdev) struct rcar_canfd_global *gpriv =3D platform_get_drvdata(pdev); u32 ch; =20 - rcar_canfd_reset_controller(gpriv); - rcar_canfd_disable_global_interrupts(gpriv); - for_each_set_bit(ch, &gpriv->channels_mask, gpriv->info->max_channels) { rcar_canfd_disable_channel_interrupts(gpriv->ch[ch]); rcar_canfd_channel_remove(gpriv, ch); } =20 + rcar_canfd_disable_global_interrupts(gpriv); + rcar_canfd_reset_controller(gpriv); + /* Enter global sleep mode */ rcar_canfd_set_bit(gpriv->base, RCANFD_GCTR, RCANFD_GCTR_GSLPR); clk_disable_unprepare(gpriv->clkp); --=20 2.43.0