From nobody Tue Dec 2 01:07:42 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7BBA272E42 for ; Mon, 24 Nov 2025 10:28:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763980125; cv=none; b=VXLERt+QkybenbFKW/7rh2V6qmDtoPU4tLEQFeUQKtd/pcGfNxpmOUHFBeame+l9IPKUuXOp9yfHDkz5Ul5fe9Vu0eRYNSGqZtd96KZm+RdjTuQ3tol/Rounfl/8/TarHEwvdQFUmUgapPha2WnEo0Fz/sTtIdor1mXl9+6MEAA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763980125; c=relaxed/simple; bh=Gv1p1qFtgqVq/hlWSzsyiuvBbNBS6q1HICEEW1Sy8N8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZaSlTecxhqpgyXTKGezu4QKy2FhUI7cEPSzcZ5q6drP9OZ8wQ1dx5vGFgwDSY9/iqF2KPN9td8jCiAtI0yysWj7qlqjyyE9n9L6u8Q0aUN7suUL6w7z6IOQ8F9dxOUP8RegtBGOoCZX/Dx0SvSxE3pqLHERMyoK+Elux2qxwe+k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CD9x6lvU; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CD9x6lvU" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-47790b080e4so21463225e9.3 for ; Mon, 24 Nov 2025 02:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763980121; x=1764584921; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v/lCM7b3NP2vHVQh7B6VQTEtsXsCikhEIHSatdbk53Y=; b=CD9x6lvUw8kaqIDKsdL2KzZKgmvzxjQ7UGqmqjh8/RxmR924iF+A1+bVxPd3KMsfyU 513uTCqCQuyH63UTx1rW914FRxMXmmZzL54AMFk6vy6NDk5zOvQw0DGniTn0xV+y6R4P acC+fAzv72vPEiEIXwyN/bR6ftHtShj4wiWpkSyURKuAgLw3voMbxMlHE3njlUE3FnMG dBxPBZIB+5Ax8iegaOoJXDMDNFA002deW/L8k1+Y2Xx7cPF+v+k6FVY1ERYt35oHZl3k gUj+JWxKMycGnLtxAO0ngCKK25/lvEd1qpUmFvjb68LOqHSq/wGIJA7mLqakwtd7Jlzx Upyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763980121; x=1764584921; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=v/lCM7b3NP2vHVQh7B6VQTEtsXsCikhEIHSatdbk53Y=; b=nw8zX+2cf3q5MKMGTtNFxoPS8cD9qXVr7qSzpIGSSF+l/3+EuNLY8N02pTVh0OM+B4 avVpPqWBSo+pjMd7WBtuahy4B0Gs3jvbuga9ZBuVZ+o+SjQ9VmqX3zCJn+UbHmm+fqs+ MRWIQMrGN9U7BH0UtU/8wphmeoMzce75gyE1CFKvFO9mIynNgEvXYoKBFFL5q6bXxea6 lV+1eITWMgaK3Tq2MzmWrmSuYSbuv5PWDCiXuVEK3+AtITfkaHksKj7LImtIr4RfoF9h 96gsq+K9vBf/L1xUSJ9fKAMu8oXDbiiUz0dIkhhgFfFUmxZ87wTTCE5hTKYTjyc71jFg Y3/w== X-Forwarded-Encrypted: i=1; AJvYcCU5pP4pdbljQn38udyXbMJp1mZVm1a4zwcom8/gYFC/uAlCdYumNTMh/ndgJTg/aNyBgZTvb53rCOhrH54=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/UQr1soMzAXT77wyKSAD6V2w4JSPMlDVTuBMT3bX5cbUwWGsa yJ8TRojJN0t+Z+JtzMVvXeuIQaotBQJkHb5aRlDjGwWbXO/NR9y6UBll X-Gm-Gg: ASbGncstlDv/INg2986I/0KLEbMIPiQ61NekkVzul7L7tKVFF4SAOO24yOCf4IrkcOs pa/VXdo5RoEnd9G4Z99G3UqsOooPrUwUW4H6nBLRI7GLUuWgfgxs3Cjs/wus8ui285N0VsMC/R1 KQqyLFZQ3bxAUFKUHPdh6pTnxxeTjCLQHSYw6hPlFxL0n2bPKIeHuqOYEupfXyJDH4KOMvk/1uJ Xx0LG2G97taVl5xJQRHWZjlAWMCURaX8f3R5MRcL/hBm/chdBoX+tqZ/Argx8BO87tSiKKGgujd Ol5LFMAFOs83GWiChWAJf+6x9W7PEEwD+P+oiReyTrZfd/soKG4Sl37BOghVMBRkU09AXgZrLXM Ysh41iSNrFyqNcPAh4cl3TTmtJH6Bbc3Bdl5S+gA+L8xQudMvPAgVKbwpjcmXQbOL2Q6IT0Hw+w Jz7GQe9QCwQg+xIvBTchd0YqHEenP5NLaqYvPh4YZuW9QyHEsOIrSBh/Rofkjm72evQmkFp7vPv lQe3YWJzw7+y7mw X-Google-Smtp-Source: AGHT+IE1Wu4cnnS2yubMRh/9JOsB11KmbzSedpxoYaakH7zmTVKVbY5LsdGtqPUlk4li0q4DKBmVVQ== X-Received: by 2002:a05:600c:3511:b0:476:d494:41d2 with SMTP id 5b1f17b1804b1-477c112f7b1mr104835185e9.29.1763980120947; Mon, 24 Nov 2025 02:28:40 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf1df334sm186753945e9.3.2025.11.24.02.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 02:28:40 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Marc Kleine-Budde , Vincent Mailhol , Geert Uytterhoeven , Magnus Damm , Philipp Zabel Cc: Biju Das , linux-can@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar Mahadev Lad , Biju Das Subject: [PATCH v3 1/7] can: rcar_canfd: Invert reset assert order Date: Mon, 24 Nov 2025 10:28:26 +0000 Message-ID: <20251124102837.106973-2-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251124102837.106973-1-biju.das.jz@bp.renesas.com> References: <20251124102837.106973-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geert Uytterhoeven The two resets are asserted during cleanup in the same order as they were deasserted during probe. Invert the order to restore symmetry. Signed-off-by: Geert Uytterhoeven Reviewed-by: Vincent Mailhol Reviewed-by: Biju Das Signed-off-by: Biju Das --- v2->v3: * No change. v1->v2: * Collected tags. --- drivers/net/can/rcar/rcar_canfd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_= canfd.c index 00c3462fc975..6098a3eebc43 100644 --- a/drivers/net/can/rcar/rcar_canfd.c +++ b/drivers/net/can/rcar/rcar_canfd.c @@ -2213,8 +2213,8 @@ static int rcar_canfd_probe(struct platform_device *p= dev) fail_clk: clk_disable_unprepare(gpriv->clkp); fail_reset: - reset_control_assert(gpriv->rstc1); reset_control_assert(gpriv->rstc2); + reset_control_assert(gpriv->rstc1); fail_dev: return err; } @@ -2235,8 +2235,8 @@ static void rcar_canfd_remove(struct platform_device = *pdev) /* Enter global sleep mode */ rcar_canfd_set_bit(gpriv->base, RCANFD_GCTR, RCANFD_GCTR_GSLPR); clk_disable_unprepare(gpriv->clkp); - reset_control_assert(gpriv->rstc1); reset_control_assert(gpriv->rstc2); + reset_control_assert(gpriv->rstc1); } =20 static int __maybe_unused rcar_canfd_suspend(struct device *dev) --=20 2.43.0