From nobody Tue Dec 2 00:46:01 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD8BC2F0681; Mon, 24 Nov 2025 08:48:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763974108; cv=none; b=dTxs9ubpUOAxwd/I27ZH+DcV/VpONAkWjw1AFR9fXS92CMJyIcVsQhX6LS7enaPUfjT7AQhlg1D8STn539xk9wuKmSUVEwWZybLv9S1yAGmQeAOBu2/4vUEDbbZt+/ErUqwnyT054rRRyPalP1WbKpaANTXictzvdpKciJ5fJwM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763974108; c=relaxed/simple; bh=drmNgq3OAGtr22eH9B0jg8N/Ugx9X2lzloI3SoRn0Dw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=olwQzsP6F2746QtxTcFD6x0XQmdyzb6dp+ZmEQc5rj+zTcaro3PsDbWCQHJ36LR4nDyde4acIzmh6AGFkR/4otz5hBD1J+1ab3EZSnRfzJAwyyrqaOCK011psOUmML1NYmOxD7PmiYhwxKH83QmDO7ZEtwHUPBNWCp9mIPeoN7U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=aUzSIz5W; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="aUzSIz5W" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763974107; x=1795510107; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=drmNgq3OAGtr22eH9B0jg8N/Ugx9X2lzloI3SoRn0Dw=; b=aUzSIz5WDuOFRXX/Y1853Dzw0QYa2gf1go38wTXA65AJIs86jV2XjzEh jjpDzfWiJ5/vElvE2i/wEIDkVR7nlyJbh/1FYh5YlSCW6D2nkthopzJKR Kbmd433luGob9zH1/qWDouUoeM36aF5pGOkkzDpC1lmA3zuSLCWmktZ7M wDM5EASiGSn7Pp2LfM3/BG+aQ4MCstA9CjaOiFJFmBcFEx1WdZ3IjkYBi IrYc6mKeLtWUyERh69y93T6zOvdMVZvY63XQk+oBpm2e4QJOAycN2kMWx filFaXYayYKyz+HO1wMvK4HfIrzo4F3Rm0sd7/avtUmiXaF/XQe1/qp2o Q==; X-CSE-ConnectionGUID: lZsp2iy+RnCgrKwzKRkhSA== X-CSE-MsgGUID: W0sNFhEhTkmT26KCjIUvfw== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="65918432" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="65918432" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 00:48:21 -0800 X-CSE-ConnectionGUID: 4LoD1nTcRReLCoF8wOs8dA== X-CSE-MsgGUID: JfnEDHqbS/K0DBASRKRCUw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="196729228" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa004.jf.intel.com with ESMTP; 24 Nov 2025 00:48:19 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id D007F98; Mon, 24 Nov 2025 09:48:17 +0100 (CET) From: Andy Shevchenko To: Vadim Fedorenko , Andy Shevchenko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Lemon , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH net-next v2 1/4] ptp: ocp: Refactor signal_show() and fix %ptT misuse Date: Mon, 24 Nov 2025 09:45:45 +0100 Message-ID: <20251124084816.205035-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124084816.205035-1-andriy.shevchenko@linux.intel.com> References: <20251124084816.205035-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Refactor signal_show() to avoid sequential calls to sysfs_emit*() and use the same pattern to get the index of a signal as it's done in signal_store(). While at it, fix wrong use of %ptT against struct timespec64. It's kinda lucky that it worked just because the first member there 64-bit and it's of time64_t type. Now with %ptS it may be used correctly. Reviewed-by: Vadim Fedorenko Signed-off-by: Andy Shevchenko --- drivers/ptp/ptp_ocp.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c index 21a8109fae34..49bad0f83779 100644 --- a/drivers/ptp/ptp_ocp.c +++ b/drivers/ptp/ptp_ocp.c @@ -3250,20 +3250,16 @@ signal_show(struct device *dev, struct device_attri= bute *attr, char *buf) struct dev_ext_attribute *ea =3D to_ext_attr(attr); struct ptp_ocp *bp =3D dev_get_drvdata(dev); struct ptp_ocp_signal *signal; + int gen =3D (uintptr_t)ea->var; struct timespec64 ts; - ssize_t count; - int i; =20 - i =3D (uintptr_t)ea->var; - signal =3D &bp->signal[i]; - - count =3D sysfs_emit(buf, "%llu %d %llu %d", signal->period, - signal->duty, signal->phase, signal->polarity); + signal =3D &bp->signal[gen]; =20 ts =3D ktime_to_timespec64(signal->start); - count +=3D sysfs_emit_at(buf, count, " %ptT TAI\n", &ts); =20 - return count; + return sysfs_emit(buf, "%llu %d %llu %d %ptT TAI\n", + signal->period, signal->duty, signal->phase, signal->polarity, + &ts.tv_sec); } static EXT_ATTR_RW(signal, signal, 0); static EXT_ATTR_RW(signal, signal, 1); --=20 2.50.1 From nobody Tue Dec 2 00:46:01 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72CF52EF665; Mon, 24 Nov 2025 08:48:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763974104; cv=none; b=gahKkik9rApGwP6iaTcL7zyIRwiwv6TRNZCRAnuh3/74T1u5ExOLXUYWRReeDxMsy/KNEwKnJ76obyGGkPVSSqKSDHnLr9qAY5HCaNSZF55QzhGM4JrEYp5oJIkZ4k8DUGLOOw3hIfbNMR244IbVkZrXj+buc2auBS8EFMawP44= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763974104; c=relaxed/simple; bh=o3MmZCf8pomvHEJmGGf6fQQ2DxNe6T0aBzettfVtUa4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a847OKsEd2VWA+jTH+GiuADdZb32aUosbI5TaFiX9CfC9KarK07fzmqKD31+VkhNzbQRXAPPMWkCHNpd14zX980HiSmYEyRq6+9blnn/Zh0HWUrwEZjSTk6V7o5JYQYyaPos74JvEoXVo7Dxcl8fVZpaTEoznjXbu2ZGblpnX+E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HPAWQDMD; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HPAWQDMD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763974102; x=1795510102; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=o3MmZCf8pomvHEJmGGf6fQQ2DxNe6T0aBzettfVtUa4=; b=HPAWQDMD1u5+Il+cqDYkfoFHZRoj9uuSee9PGYEwlvQYOy5nZxQVjgzW ZozHqj2x85Yuql6yf2t+i8cZV9VrKyawEBiqAAISLtJJbE0/yso78F+xN Oq37vQ0d0jKo89Me3PJ7HCSUq5+tYYIC90bQVHhtY7MtOd9EiCyjS9WGI q5yhBcUo//mL+Pnhj3tpff9yOntrNtwgOdePPETmMwtbKmR7WvCHNMA5f G5zVzJcIoD2+k8ecGUd8lAirF+8iwVORVid6Ukb2kjdFYHDDPN0W1RZAl XpX1RBYoqvcusXs9nSlh6R0X+xDCkbq5zF3BweE9RC84zQgrunZx4tjTk Q==; X-CSE-ConnectionGUID: FwvQVo+DS6qOtM1ReiqXfQ== X-CSE-MsgGUID: tS/wi7/6SrezSPpMRqZcpQ== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="83583713" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="83583713" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 00:48:21 -0800 X-CSE-ConnectionGUID: FOszCJjtQki2rcWTDOqiPQ== X-CSE-MsgGUID: sKUZjwG+S0uNS73TtzT7OA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="192068187" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa009.jf.intel.com with ESMTP; 24 Nov 2025 00:48:19 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id D498D99; Mon, 24 Nov 2025 09:48:17 +0100 (CET) From: Andy Shevchenko To: Vadim Fedorenko , Andy Shevchenko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Lemon , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH net-next v2 2/4] ptp: ocp: Make ptp_ocp_unregister_ext() NULL-aware Date: Mon, 24 Nov 2025 09:45:46 +0100 Message-ID: <20251124084816.205035-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124084816.205035-1-andriy.shevchenko@linux.intel.com> References: <20251124084816.205035-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It's a common practice to make resource release functions be NULL-aware. Make ptp_ocp_unregister_ext() NULL-aware. Reviewed-by: Vadim Fedorenko Signed-off-by: Andy Shevchenko --- drivers/ptp/ptp_ocp.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c index 49bad0f83779..1fd2243e0f9f 100644 --- a/drivers/ptp/ptp_ocp.c +++ b/drivers/ptp/ptp_ocp.c @@ -2225,6 +2225,9 @@ ptp_ocp_ts_enable(void *priv, u32 req, bool enable) static void ptp_ocp_unregister_ext(struct ptp_ocp_ext_src *ext) { + if (!ext) + return; + ext->info->enable(ext, ~0, false); pci_free_irq(ext->bp->pdev, ext->irq_vec, ext); kfree(ext); @@ -4555,21 +4558,14 @@ ptp_ocp_detach(struct ptp_ocp *bp) ptp_ocp_detach_sysfs(bp); ptp_ocp_attr_group_del(bp); timer_delete_sync(&bp->watchdog); - if (bp->ts0) - ptp_ocp_unregister_ext(bp->ts0); - if (bp->ts1) - ptp_ocp_unregister_ext(bp->ts1); - if (bp->ts2) - ptp_ocp_unregister_ext(bp->ts2); - if (bp->ts3) - ptp_ocp_unregister_ext(bp->ts3); - if (bp->ts4) - ptp_ocp_unregister_ext(bp->ts4); - if (bp->pps) - ptp_ocp_unregister_ext(bp->pps); + ptp_ocp_unregister_ext(bp->ts0); + ptp_ocp_unregister_ext(bp->ts1); + ptp_ocp_unregister_ext(bp->ts2); + ptp_ocp_unregister_ext(bp->ts3); + ptp_ocp_unregister_ext(bp->ts4); + ptp_ocp_unregister_ext(bp->pps); for (i =3D 0; i < 4; i++) - if (bp->signal_out[i]) - ptp_ocp_unregister_ext(bp->signal_out[i]); + ptp_ocp_unregister_ext(bp->signal_out[i]); for (i =3D 0; i < __PORT_COUNT; i++) if (bp->port[i].line !=3D -1) serial8250_unregister_port(bp->port[i].line); --=20 2.50.1 From nobody Tue Dec 2 00:46:01 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3E522F12BD; Mon, 24 Nov 2025 08:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763974109; cv=none; b=JKvg8c5NDLp8S/X0E3p8WxZejgo42hLjCSDS9fsCYFCiyLe//2bWOMdMGaHRRXBTzR17gVQVkVEs0/dF/AKbU+vUqPAptH2Pl5wf3GdJY2cm3jt07lC0u1Zi/VF1Tzhsr3j32709fJ18i6sjEcIFayieqHw1drycftvwCkZcZjA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763974109; c=relaxed/simple; bh=16jY6OH6luP8crDYCxHQBYhqJL6CLIweYFPaai388f8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Eg3bgIoJP8SEdFPLE/1u7RuD4tB9f02YqGSzoYsB8uUmHb8mGxEVcN5oToEGsi29PwmQJ6d4bdYWs5tseScYnk8aAjXEVUv+I06k89oc4Iy7dqZrlz5drSJOrx+D0e9lWvp3DmsgWCg13iQqcKY3ezwvRT6+dKARLqLi3M2SDA8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=UYuDI4Ag; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="UYuDI4Ag" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763974107; x=1795510107; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=16jY6OH6luP8crDYCxHQBYhqJL6CLIweYFPaai388f8=; b=UYuDI4Agge+Zu+MwEITRCD8fD+IqAYT+TJ2ZiRDx/NYEydfl5udm8wKE v0g8m8armeLiU1E729DRykaHJgiN230zeCtSn03uqmyZmLXOD9aBq84VI qD5ofmY70T0n5TrEoaLg5FFeiPhFVcB8aqnZH3KNPgW0p+BavuLC39UKL Ka6VdbzhBgmacXt5Mesqbc5H3KOHb58fOOKUzG9ezLPGhpult112ViBRj ImIjq/SHKGJqQ8u6hmYt6CnD59QMrxwPsusvnx0/3ZxWgudrC4mugomjh I177MBrxhQmUbkb1IqLSh8EZqTIH/9T95jfIDLZGKRZ6Av4Nx9oP9lSDq A==; X-CSE-ConnectionGUID: ZstoqgkyRSKdSiiOlprwgw== X-CSE-MsgGUID: X4Da5icGQ0+pBh0eNDkcBA== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="65918449" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="65918449" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 00:48:21 -0800 X-CSE-ConnectionGUID: QN3BxsBXQ46vjVZcZaW1iw== X-CSE-MsgGUID: ELISTBZhRdy6cWL7ioSUhQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="196729229" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa004.jf.intel.com with ESMTP; 24 Nov 2025 00:48:19 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id D91289A; Mon, 24 Nov 2025 09:48:17 +0100 (CET) From: Andy Shevchenko To: Vadim Fedorenko , Andy Shevchenko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Lemon , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH net-next v2 3/4] ptp: ocp: Apply standard pattern for cleaning up loop Date: Mon, 24 Nov 2025 09:45:47 +0100 Message-ID: <20251124084816.205035-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124084816.205035-1-andriy.shevchenko@linux.intel.com> References: <20251124084816.205035-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The while (i--) is a standard pattern for the cleaning up loops. Apply this pattern where it makes sense in the driver. Reviewed-by: Vadim Fedorenko Signed-off-by: Andy Shevchenko --- drivers/ptp/ptp_ocp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c index 1fd2243e0f9f..63c73a5909f2 100644 --- a/drivers/ptp/ptp_ocp.c +++ b/drivers/ptp/ptp_ocp.c @@ -4818,8 +4818,7 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_= device_id *id) =20 return 0; out_dpll: - while (i) { - --i; + while (i--) { dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, &bp->= sma[i]); dpll_pin_put(bp->sma[i].dpll_pin); } --=20 2.50.1 From nobody Tue Dec 2 00:46:01 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3A482EFDBF; Mon, 24 Nov 2025 08:48:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763974107; cv=none; b=LcSz7D8BZ15A3b9xI9GdPNwp623b7rsfPoo3MaSmdoeh6hBZwJr7DZ3L+k4WyXw5XOpSFC9QDyPrldTdUxXqep9CiLyuMrJKo8LM6abxb2KDg0o7/+Lvt4sSXfZ0K32dscws0Vtu36yWIcIHO7hGBxQ05xnGA3totKEoOMealuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763974107; c=relaxed/simple; bh=MZ9Xkt07I8vhrJpfDzWnGEgNkwbTf/2C68251v3ZzsM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a7e36bCkDaaLR8q/5RHZpeR3CLN5jLl3pCRTLMv58Ezy6Izh5M4UZ0WL1u9g0Uv95M8GzrjOWILmioUhWE/h6OQ5rngywSpsIDg7VZv753DpcuPt0IA8sPTMgC3zfz0sPkgWWTdqauJAstDAw2wKobmT7Qt00Ef3sCVvJI9wKoM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ngOTgT0b; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ngOTgT0b" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763974105; x=1795510105; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MZ9Xkt07I8vhrJpfDzWnGEgNkwbTf/2C68251v3ZzsM=; b=ngOTgT0bUxJG4z9fTRqpTEDH6Og5287EiwsteJ18qbAw0ErEWru5dUeK 9ISbtvEL8WW+w0npdGkcXnr/OXTBXjuSTt20pnHfjRT0TN/YMzR7DjNZk x7CSV3TaJRUNvloV128fdYp+xyJKfNV/lv7MYD/C+EQHkSSkL4d8h+Sh+ t+e2NKDHPhPZCg3MDR+cQw4avmY+UC4xQKE1wqOjcI6wbaXIuREQNW6ha 3EVctz5cCbhA/rleMz8pAVHNsaoo7Z06OThV9SRBy7AQ6S60NE/FNk701 jL421prTydzLxGKUPR4JQxp/cN1cqDenyO20697K9AOQw6Zm8KR8mtcW6 w==; X-CSE-ConnectionGUID: bIjvclWoRVWtU6mcVeLlGg== X-CSE-MsgGUID: Yloa1Bk/R3CrP/SEUd0ZSg== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="83583717" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="83583717" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 00:48:22 -0800 X-CSE-ConnectionGUID: 2eM2GYBZQY6D9xGpIega0A== X-CSE-MsgGUID: qjbD/GX4TNGr2JFQ8fhIMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="192068188" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa009.jf.intel.com with ESMTP; 24 Nov 2025 00:48:19 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id DD0F39B; Mon, 24 Nov 2025 09:48:17 +0100 (CET) From: Andy Shevchenko To: Vadim Fedorenko , Andy Shevchenko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Lemon , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH net-next v2 4/4] ptp: ocp: Reuse META's PCI vendor ID Date: Mon, 24 Nov 2025 09:45:48 +0100 Message-ID: <20251124084816.205035-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124084816.205035-1-andriy.shevchenko@linux.intel.com> References: <20251124084816.205035-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The META's PCI vendor ID is listed already in the pci_ids.h. Reuse it here. Reviewed-by: Vadim Fedorenko Signed-off-by: Andy Shevchenko --- drivers/ptp/ptp_ocp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c index 63c73a5909f2..65fe05cac8c4 100644 --- a/drivers/ptp/ptp_ocp.c +++ b/drivers/ptp/ptp_ocp.c @@ -25,8 +25,7 @@ #include #include =20 -#define PCI_VENDOR_ID_FACEBOOK 0x1d9b -#define PCI_DEVICE_ID_FACEBOOK_TIMECARD 0x0400 +#define PCI_DEVICE_ID_META_TIMECARD 0x0400 =20 #define PCI_VENDOR_ID_CELESTICA 0x18d4 #define PCI_DEVICE_ID_CELESTICA_TIMECARD 0x1008 @@ -1030,7 +1029,7 @@ static struct ocp_resource ocp_adva_resource[] =3D { }; =20 static const struct pci_device_id ptp_ocp_pcidev_id[] =3D { - { PCI_DEVICE_DATA(FACEBOOK, TIMECARD, &ocp_fb_resource) }, + { PCI_DEVICE_DATA(META, TIMECARD, &ocp_fb_resource) }, { PCI_DEVICE_DATA(CELESTICA, TIMECARD, &ocp_fb_resource) }, { PCI_DEVICE_DATA(OROLIA, ARTCARD, &ocp_art_resource) }, { PCI_DEVICE_DATA(ADVA, TIMECARD, &ocp_adva_resource) }, --=20 2.50.1